< bitcoin-git> [bitcoin] Gnappuraz opened pull request #13568: Trivial: Remove double semicolon from wallet.cpp (master...typo_double_semicolon) https://github.com/bitcoin/bitcoin/pull/13568
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/b330f3fdd56b...90990d274185
< bitcoin-git> bitcoin/master 2fca656 fanquake: depends: Update Qt download url
< bitcoin-git> bitcoin/master 90990d2 Wladimir J. van der Laan: Merge #13544: depends: Update Qt download url...
< bitcoin-git> [bitcoin] laanwj closed pull request #13544: depends: Update Qt download url (master...qt-been-archived) https://github.com/bitcoin/bitcoin/pull/13544
< promag> wumpus: how about #12151
< gribble> https://github.com/bitcoin/bitcoin/issues/12151 | rpc: Remove cs_main lock from blockToJSON and blockheaderToJSON by promag · Pull Request #12151 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/90990d274185...f3c9c40aeb12
< bitcoin-git> bitcoin/master c6fd0df practicalswift: Fix incorrect tests
< bitcoin-git> bitcoin/master 962d8ee practicalswift: Remove boost dependency (boost/assign/std/vector.hpp)
< bitcoin-git> bitcoin/master f3c9c40 MarcoFalke: Merge #13545: tests: Fix test case streams_serializedata_xor. Remove Boost dependency....
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #13545: tests: Fix test case streams_serializedata_xor. Remove Boost dependency. (master...fix-test-and-de-boost) https://github.com/bitcoin/bitcoin/pull/13545
< jnewbery> promag: what are you asking wumpus for on 12151?
< bitcoin-git> [bitcoin] aqwark opened pull request #13569: Need help! wallet.dat corrupt (master...master) https://github.com/bitcoin/bitcoin/pull/13569
< bitcoin-git> [bitcoin] domob1812 opened pull request #13570: RPC: Add new "getzmqnotifications" method (master...zmq) https://github.com/bitcoin/bitcoin/pull/13570
< bitcoin-git> [bitcoin] jonasschnelli closed pull request #13569: Need help! wallet.dat corrupt (master...master) https://github.com/bitcoin/bitcoin/pull/13569
< promag> jnewbery: asking if it's merge ready
< jnewbery> doesn't look like it to me. There are no ACKs since your last change and rebase
< jnewbery> you'll find more success seeking review than asking a maintainer to merge an unreviewed PR :)
< jonasschnelli> Core-memchart: Wallets(1000 keys) versus memory consumption: https://bitcointools.jonasschnelli.ch/mem-graph.png
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/f3c9c40aeb12...a6ed99a1e6fa
< bitcoin-git> bitcoin/master fa87da2 MarcoFalke: qa: Avoid start/stop of the network thread mid-test
< bitcoin-git> bitcoin/master a6ed99a Wladimir J. van der Laan: Merge #13517: qa: Remove need to handle the network thread in tests...
< bitcoin-git> [bitcoin] laanwj closed pull request #13517: qa: Remove need to handle the network thread in tests (master...Mf1806-qaAsyncIo) https://github.com/bitcoin/bitcoin/pull/13517
< jonasschnelli> A wallet with 1000keys (keypool 1000) and no transaction requires roughly 6.8MB of ram
< satwo> Hello all. When running bitcoind with printtoconsole=1 in bitcoin.conf, I am still getting output written to debug.log (in addition to stdout, which is what I want). Am I missing something? FWIW I am using a patched version of Bitcoin Core that simply adds a couple LogPrint statements in Validation.cpp, but I doubt that would have anything to do with this behavior.
< sipa> satwo: what changed or what do you expect to see differently? (in case i'm missing some context)
< satwo> sipa: Well, I'm expecting the trace/debug info to stop going to debug.log altogether based on the docs ("Send trace/debug info to console instead of debug.log file"). The problem is I'm running this node on a small VM with limited storage so an ever-growing debug.log is not desired
< satwo> BTW "Send trace/debug info to console instead of debug.log file" is from -printtoconsole under bitcoind -h
< satwo> It seems that this is the expected behavior based on InitLogging() in init.cpp. The m_print_to_file flag does not take into consideration "-printtoconsole"
< sipa> satwo: sounds like a bug to me
< sipa> was this changed recently?
< satwo> Not that I'm aware of. Only had a need for this functionality recently
< satwo> I'd be happy to submit a fix/PR. I guess the question is, should there be two separate flags for -printtoconsole and -printtofile so that they're not mututally exclusive? The latter would just default to 1
< sipa> satwo: that sounds ideal; but if the behaviour unintentionally changed in a recent commit, that is a bug, and should be fixed independently from improving the functionality
< satwo> sipa: looking over the history now. there were some relatively recent changes in April which are related to this stuff
< achow101> satwo: sipa this was changed recently for the default printtoconsole when not using -daemon change that happened a few months ago
< gmaxwell> why was that changed?
< achow101> see #13004
< gribble> https://github.com/bitcoin/bitcoin/issues/13004 | Print to console by default when not run with -daemon by practicalswift · Pull Request #13004 · bitcoin/bitcoin · GitHub
< sipa> oh
< achow101> and #12689
< gribble> https://github.com/bitcoin/bitcoin/issues/12689 | Smarter default behavior for -printtoconsole by eklitzke · Pull Request #12689 · bitcoin/bitcoin · GitHub
< gmaxwell> so ... how do you turn off logging to a file?
< achow101> USE -nodebuglogfile
< achow101> or -debuglogfile=0
< achow101> i think
< gmaxwell> It makes sense that non-daemon operation prints to the console by default, I guess.
< gmaxwell> OK
< gmaxwell> satwo: there you go.
< gmaxwell> has someone written a release note for that? :P
< sipa> The command line help for -printtoconsole is wrong though
< achow101> indeed
< sipa> It should probably explain the full behaviour, including a reference to -debuglogfile
< gmaxwell> PR description also doesn't describe this change in behavior.
< gmaxwell> It's burried in a comment in the original pr. :P
< satwo> Thanks all. I'd be happy to make a go at modifying the command line help.
< bitcoin-git> [bitcoin] practicalswift closed pull request #12611: interpreter: Use safer casting in IsValidSignatureEncoding(...) (master...safer-casting-in-IsValidSignatureEncoding) https://github.com/bitcoin/bitcoin/pull/12611