< promag> I'll take a stab at #16341
< gribble> https://github.com/bitcoin/bitcoin/issues/16341 | Introduce ScriptPubKeyMan interface and use it for key and script management (aka wallet boxes) by achow101 . Pull Request #16341 . bitcoin/bitcoin . GitHub
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/eb292af309aa...4cfb6738e81b
< bitcoin-git> bitcoin/master a0daea4 Sjors Provoost: [build] depends macOS: point --sysroot to SDK
< bitcoin-git> bitcoin/master 4cfb673 Wladimir J. van der Laan: Merge #17118: build: depends macOS: point --sysroot to SDK
< bitcoin-git> [bitcoin] laanwj merged pull request #17118: build: depends macOS: point --sysroot to SDK (master...2019/10/macos-sysroot) https://github.com/bitcoin/bitcoin/pull/17118
< bitcoin-git> [bitcoin] carnhofdaki opened pull request #17158: tests: Fix fs_tests for unknown locales (0.19...cdk/0.19-fix_fs_tests) https://github.com/bitcoin/bitcoin/pull/17158
< bitcoin-git> [bitcoin] carnhofdaki opened pull request #17159: doc: Add a note about backporting (master...cdk/doc-backports) https://github.com/bitcoin/bitcoin/pull/17159
< bitcoin-git> [bitcoin] theStack opened pull request #17160: net: subnet lookup: use single-result LookupHost() (master...20191016-net-simplify_function_lookupsubnet) https://github.com/bitcoin/bitcoin/pull/17160
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/4cfb6738e81b...1f6638630ef8
< bitcoin-git> bitcoin/master 58d67f1 practicalswift: tests: Add fuzzing harness for descriptor Span-parsing helpers
< bitcoin-git> bitcoin/master 1f66386 MarcoFalke: Merge #17113: tests: Add fuzzing harness for descriptor Span-parsing helpe...
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #17113: tests: Add fuzzing harness for descriptor Span-parsing helpers (master...fuzzers-spanparsing) https://github.com/bitcoin/bitcoin/pull/17113
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to 0.19: https://github.com/bitcoin/bitcoin/compare/3a7b2a15e3dd...3834d3d12196
< bitcoin-git> bitcoin/0.19 bd9d40d Daki Carnhof: tests: Fix fs_tests for unknown locales
< bitcoin-git> bitcoin/0.19 3834d3d Wladimir J. van der Laan: Merge #17158: tests: Fix fs_tests for unknown locales
< bitcoin-git> [bitcoin] laanwj merged pull request #17158: tests: Fix fs_tests for unknown locales (0.19...cdk/0.19-fix_fs_tests) https://github.com/bitcoin/bitcoin/pull/17158
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/1f6638630ef8...5a3dd9359455
< bitcoin-git> bitcoin/master b3b26e1 Fabian Jahr: rpc: fix -rpcclienttimeout 0 option
< bitcoin-git> bitcoin/master 5a3dd93 Wladimir J. van der Laan: Merge #17131: rpc: fix -rpcclienttimeout 0 option
< bitcoin-git> [bitcoin] laanwj merged pull request #17131: rpc: fix -rpcclienttimeout 0 option (master...rpcclienttimeout) https://github.com/bitcoin/bitcoin/pull/17131
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/5a3dd9359455...c34b88620dc8
< bitcoin-git> bitcoin/master d7820a1 Wladimir J. van der Laan: util: Filter control characters out of log messages
< bitcoin-git> bitcoin/master c34b886 Wladimir J. van der Laan: Merge #17095: util: Filter control characters out of log messages
< bitcoin-git> [bitcoin] laanwj merged pull request #17095: util: Filter control characters out of log messages (master...2019_10_log_control_chars) https://github.com/bitcoin/bitcoin/pull/17095
< gleb> Do we allocate full memory for a bloom filter in the constructor? There is no dynamic allocation as in vectors, right?
< sipa> CBloomFilter and CRollingBloomFilter store their data in a vector
< sipa> so there is dynamic allocation, but it does happen in the constructor
< sipa> i think what you're asking is whether they're statically allocated, and that's not possible as that would require a compile-time known constant size
< sipa> i guess that is actually possible, but would require a bunch of templating
< gleb> I'm just wondering whether there is a point in not constructing them where they won't be used.
< gleb> E.g., suhas added those block_relay_only peers which never relay addresses, so addrKnown filter for those peers is not used.
< sipa> iirc we don't construct the filter in that case?
< gleb> It seems to me we do.
< sipa> oh, i see
< sipa> yeah, we could avoid that
< luke-jr> is there a reason we have a dedicated legacyWhitelisted bool instead of just leaving PF_ISIMPLICIT in place and checking that?
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #17162: chain: Remove CBlockIndex::SetNull helper, add RaiseValidity lock annotation (master...1910-docChainLocks) https://github.com/bitcoin/bitcoin/pull/17162
< bitcoin-git> [bitcoin] naumenkogs opened pull request #17163: p2p: Address relay optimization (master...addr_relay_optimization) https://github.com/bitcoin/bitcoin/pull/17163
< bitcoin-git> [bitcoin] naumenkogs opened pull request #17164: p2p: Avoid allocating memory for addrKnown where we don't need it (master...addr_relay_optimization_4) https://github.com/bitcoin/bitcoin/pull/17164
< moneyball> #proposedmeetingtopic taproot proposal next steps; possible review sessions
< jonatack> moneyball: good idea
< moneyball> for those interested in this discussion, please have a quick read here for discussion in tomorrow's meeting. thanks to aj and others for putting this process proposal together. https://docs.google.com/document/d/1G48-yhZMLLMZW68Bq59h_FBi__pwFKoWKF1D385I38Y/edit#
< bitcoin-git> [bitcoin] fanquake opened pull request #17165: [WIP] Remove BIP70 support (master...remove_bip70) https://github.com/bitcoin/bitcoin/pull/17165
< bitcoin-git> [bitcoin] sandakersmann opened pull request #17166: Changed http:// to https:// on one link in build-unix.md (master...patch-1) https://github.com/bitcoin/bitcoin/pull/17166
< bitcoin-git> [bitcoin] luke-jr opened pull request #17167: Allow whitelisting outgoing connections (master...whitelist_outgoing) https://github.com/bitcoin/bitcoin/pull/17167
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/c34b88620dc8...46d6930f8c7b
< bitcoin-git> bitcoin/master 084e17c practicalswift: Remove unused includes
< bitcoin-git> bitcoin/master 46d6930 MarcoFalke: Merge #16659: refactoring: Remove unused includes
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #16659: refactoring: Remove unused includes (master...unused-includes) https://github.com/bitcoin/bitcoin/pull/16659
< bitcoin-git> [bitcoin] PrinceKK300188 opened pull request #17168: build: use full version string in setup (master...master) https://github.com/bitcoin/bitcoin/pull/17168
< bitcoin-git> [bitcoin] fanquake closed pull request #17168: build: use full version string in setup (master...master) https://github.com/bitcoin/bitcoin/pull/17168