00:09 < luke-jr> what's up with DrahtBot on #17213 ? looks totally broken

00:09 < gribble> https://github.com/bitcoin/bitcoin/issues/17213 | gui: Add Windows taskbar progress by luke-jr . Pull Request #17213 . bitcoin/bitcoin . GitHub

00:17 < luke-jr> MarcoFalke: was it your bot?

00:37 < meshcollider> (I'm guessing Marco is testing something since he added the label multiple times to that pr)

06:13 < luke-jr> hm, -prune no longer works - didn't it used to imply -prune=1 ?

06:21 < sipa> luke-jr: i think -prune means manual pruning

06:22 < luke-jr> sipa: that's what I would expect, but apparently it does nothing, and for manual we need -prune=1

06:23 < sipa> hmm

06:24 < luke-jr> not sure if this is a new regression or older behaviour though

07:17 < aj> luke-jr: are you running in the gui, or command line? could be related to SetPrune from #16714 if it's just the gui

07:17 < gribble> https://github.com/bitcoin/bitcoin/issues/16714 | gui: add prune to intro screen with smart default by Sjors . Pull Request #16714 . bitcoin/bitcoin . GitHub

10:28 < bitcoin-git> [bitcoin] hebasto opened pull request #17297: refactor: Remove addrdb.h dependency from node.h (master...20191029-refactor-addrdb) https://github.com/bitcoin/bitcoin/pull/17297

12:22 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #17260: Split some CWallet functions into new LegacyScriptPubKeyMan (master...wallet-box-pr-1) https://github.com/bitcoin/bitcoin/pull/17260

13:11 < provoostenator> ^ yes!

14:11 < bitcoin-git> [bitcoin] theStack opened pull request #17299: test: add reason checks for non-standard txs in test_IsStandard (master...20191029-test-also_check_reason_for_nonstd_txs) https://github.com/bitcoin/bitcoin/pull/17299

14:12 < achow101> \o/ (I think? seems a bit premature, but ok)

14:13 < luke-jr> aj: I noticed it testing clean HOMEs ;)

14:29 < achow101> Can someone add #17261 to hi prio?

14:29 < gribble> https://github.com/bitcoin/bitcoin/issues/17261 | Make ScriptPubKeyMan an actual interface and the wallet to have multiple by achow101 . Pull Request #17261 . bitcoin/bitcoin . GitHub

16:39 < bitcoin-git> [bitcoin] ryanofsky opened pull request #17300: LegacyScriptPubKeyMan code cleanups (master...pr/keyman-cleanup) https://github.com/bitcoin/bitcoin/pull/17300

18:12 < bitcoin-git> [bitcoin] Sjors opened pull request #17301: [gui] enable RPC server by default (master...2019/10/gui-server) https://github.com/bitcoin/bitcoin/pull/17301

18:17 < bitcoin-git> [bitcoin] sdaftuar reopened pull request #15505: [p2p] Request NOTFOUND transactions immediately from other outbound peers, when possible (master...2019-02-notfound-requests) https://github.com/bitcoin/bitcoin/pull/15505

18:39 < bitcoin-git> [bitcoin] laanwj opened pull request #17302: cli: Add "headers" and "verifcationprogress" to -getinfo (master...2019_10_getinfo) https://github.com/bitcoin/bitcoin/pull/17302

18:49 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #17303: p2p: Stop relaying non-mempool txs (master...1910-p2pNoRemovedTxs) https://github.com/bitcoin/bitcoin/pull/17303

19:01 < MarcoFalke> [20:17] <luke-jr> MarcoFalke: was it your bot?

19:01 < MarcoFalke> The gitian builds crash about 10% of the time, so those results are missing then (empty comment by DrahtBot)

19:03 < MarcoFalke> The bot doesn't have a hardcoded list of all targets, so it can't detect the case where a target is missing

19:03 < MarcoFalke> It should be trivial for a human to detect the missing target

19:03 < bitcoin-git> [bitcoin] achow101 opened pull request #17304: refactor: Move many functions into LegacyScriptPubKeyMan and further separate it from CWallet (master...wallet-box-pr-3) https://github.com/bitcoin/bitcoin/pull/17304

19:05 < cfields> gitian builders: detached sigs for v0.19.0rc3 are up.

19:13 < MarcoFalke> [10:12] <achow101> \o/ (I think? seems a bit premature, but ok)

19:17 < bitcoin-git> [bitcoin] birtony opened pull request #17305: doc: Updated -blocksonly documentation (master...issue#17294) https://github.com/bitcoin/bitcoin/pull/17305

19:20 < MarcoFalke> I think it is easier to move the fixups into a 30 LOC cleanup pr than having to re-ACK a 2000LOC move-only pr

19:24 < achow101> I was just expecting it to have a few more ACKs before it being merged

19:32 < bitcoin-git> [bitcoin] jtimon opened pull request #17306: Use name constants in chainparams initialization (master...b20-chain-constants) https://github.com/bitcoin/bitcoin/pull/17306

19:33 < wumpus> cfields: thanks!

20:26 < dongcarl> elichai2: You should take a look at https://github.com/bitcoin/bitcoin/pull/17060#issuecomment-547611741

20:49 < bitcoin-git> [bitcoin] dongcarl opened pull request #17308: nsis: Write to correct filename in first place (master...2019-10-simplify-nsis-exe-rename) https://github.com/bitcoin/bitcoin/pull/17308

21:05 < elichai2> dongcarl: +1

21:05 < elichai2> thanks

21:37 < bitcoin-git> [bitcoin] fanquake opened pull request #17309: doc: update MSVC instructions to remove Qt OpenSSL linking (master...windows_notes_update) https://github.com/bitcoin/bitcoin/pull/17309

23:55 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/6a97e8a060f7...ecad0a8019fb

23:55 < bitcoin-git> bitcoin/master c1c6c41 Sebastian Falbesoner: test: add reason checks for non-standard txs in test_IsStandard

23:55 < bitcoin-git> bitcoin/master ecad0a8 MarcoFalke: Merge #17299: test: add reason checks for non-standard txs in test_IsStand...

23:56 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #17299: test: add reason checks for non-standard txs in test_IsStandard (master...20191029-test-also_check_reason_for_nonstd_txs) https://github.com/bitcoin/bitcoin/pull/17299