< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/be50469217bd...9ae468a6d525
< bitcoin-git> bitcoin/master faeb666 MarcoFalke: util: Add CHECK_NONFATAL and use it in src/rpc
< bitcoin-git> bitcoin/master 9ae468a Wladimir J. van der Laan: Merge #17192: util: Add CHECK_NONFATAL and use it in src/rpc
< bitcoin-git> [bitcoin] laanwj merged pull request #17192: util: Add CHECK_NONFATAL and use it in src/rpc (master...1910-utilCHECK_NONFATAL) https://github.com/bitcoin/bitcoin/pull/17192
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/9ae468a6d525...a25945318fdc
< bitcoin-git> bitcoin/master fa39809 MarcoFalke: Avoid unused call to GuessVerificationProgress in NotifyHeaderTip
< bitcoin-git> bitcoin/master a259453 Wladimir J. van der Laan: Merge #17250: Avoid unused call to GuessVerificationProgress in NotifyHead...
< bitcoin-git> [bitcoin] laanwj merged pull request #17250: Avoid unused call to GuessVerificationProgress in NotifyHeaderTip (master...1910-NoWrongGuess) https://github.com/bitcoin/bitcoin/pull/17250
< bitcoin-git> [bitcoin] laanwj opened pull request #17279: refactor: Remove redundant c_str() calls in formatting (master...2019_10_redundant_c_str) https://github.com/bitcoin/bitcoin/pull/17279
< elichai2> Apparently ParseISO8601DateTime/DecodeDumpTime is fine accepting overflows in the time. i.e. "2019-13-01T00:00:00Z"
< bitcoin-git> [bitcoin] laanwj opened pull request #17280: Fix occurences of c_str() used with size() to data() (master...2019_10_c_str_size) https://github.com/bitcoin/bitcoin/pull/17280
< elichai2> sorry, just overflow in the time, not date. the date it catches correctly
< elichai2> i.e. `2019-02-01T75:12:00Z` or `2019-02-01T11:92:12Z`
< wumpus> elichai2: ok, maybe fix that in a later PR, please don't combine it with the rename
< bitcoin-git> [bitcoin] laanwj opened pull request #17281: doc: Add developer note on c_str() (master...2019_10_c_str_note) https://github.com/bitcoin/bitcoin/pull/17281
< elichai2> wumpus: sure. Just wanted to add more "rainy day" tests :)
< elichai2> (as practicalswift asked)
< elichai2> But I guess it's better to leave the ACKs as is and maybe in a later PR try to fix both
< fanquake> wumpus: going on a bit of a c_str() witch hunt this morning
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/a25945318fdc...f8cc2b967b95
< bitcoin-git> bitcoin/master 3bb0a46 nijynot: bench: Fix negative values and zero for -evals flag
< bitcoin-git> bitcoin/master f8cc2b9 Wladimir J. van der Laan: Merge #17267: bench: Fix negative values and zero for -evals flag
< bitcoin-git> [bitcoin] laanwj merged pull request #17267: bench: Fix negative values and zero for -evals flag (master...fix/eval) https://github.com/bitcoin/bitcoin/pull/17267
< bitcoin-git> [bitcoin] fanquake pushed 8 commits to master: https://github.com/bitcoin/bitcoin/compare/f8cc2b967b95...badca85e2c0b
< bitcoin-git> bitcoin/master 6294ecd Jonas Schnelli: Refactor: split network transport deserializing from message container
< bitcoin-git> bitcoin/master 1a5c656 Jonas Schnelli: Remove transport protocol knowhow from CNetMessage / net processing
< bitcoin-git> bitcoin/master efecb74 Jonas Schnelli: Use adapter pattern for the network deserializer
< bitcoin-git> [bitcoin] fanquake merged pull request #16202: p2p: Refactor network message deserialization (master...2019/06/net_refactor_1) https://github.com/bitcoin/bitcoin/pull/16202
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/badca85e2c0b...1ab6c1267e34
< bitcoin-git> bitcoin/master 7aad3b6 Jon Layton: doc: Doxygen-friendly CuckooCache comments
< bitcoin-git> bitcoin/master 1ab6c12 fanquake: Merge #16986: doc: Doxygen-friendly CuckooCache comments
< bitcoin-git> [bitcoin] fanquake merged pull request #16986: doc: Doxygen-friendly CuckooCache comments (master...doc/cuckoocache) https://github.com/bitcoin/bitcoin/pull/16986
< wumpus> fanquake: about time, it has been about 5 years ago since I did the last one :)
< wumpus> elichai2: well I fully agree the function should ideally detect all those kind of invalid input
< wumpus> just, I'm trying to get the rename merged, extending the scope will not help with that
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/1ab6c1267e34...cfec3e01b4d6
< bitcoin-git> bitcoin/master 9e2c623 Elichai Turkel: Rename DecodeDumpTime to ParseISO8601DateTime and move to time.cpp
< bitcoin-git> bitcoin/master e7b02b5 Elichai Turkel: Add roundtrip and more tests to ParseISO8601DateTime and FormatISO8601Date...
< bitcoin-git> bitcoin/master cfec3e0 MarcoFalke: Merge #17266: util: Rename DecodeDumpTime to ParseISO8601DateTime
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #17266: util: Rename DecodeDumpTime to ParseISO8601DateTime (master...2019-10-FormatISO8601DateTime) https://github.com/bitcoin/bitcoin/pull/17266
< jonatack> Oops, was re-reviewing 16202, you look up and it's merged :)
< fanquake> jonatack feel free to continue and post your review anyways. There's some followup changes that'll be picked up later.
< jonatack> fanquake: ok
< justinmoon> Can the python test framework use my globally installed `bitcoind` somehow?
< jarthur> justinmoon: I believe you can by setting the BITCOIND and BITCOINCLI env vars to those two executables in your global install.
< wumpus> justinmoon: yes, what jarthur says
< justinmoon> thanks
< bitcoin-git> [bitcoin] fanquake opened pull request #17282: contrib: remove accounts from bash completion (master...update_bash_completion) https://github.com/bitcoin/bitcoin/pull/17282
< luke-jr> hmm, somehow I thought our bash completion was autogenerated from RPC help
< wumpus> hah
< * luke-jr> grumbles about MSVC/Appveyor demanding independent rewriting of changes to the normal build system
< * luke-jr> wishes we had kept just not supporting MSVC <.<
< luke-jr> seems like a high-maintenance very-low-userbase thing
< Bullit> seems not so usefull to parse old records and call it a bash
< luke-jr> wat
< bitcoin-git> [bitcoin] jonatack opened pull request #17283: rpc: improve getaddressinfo test coverage, help, code docs (master...rpc-getaddressinfo-labels) https://github.com/bitcoin/bitcoin/pull/17283
< bitcoin-git> [bitcoin] RandyMcMillan closed pull request #17273: build: proper fix for the kerning issue in macOS build fixes #16836 (master...fix-background-svg) https://github.com/bitcoin/bitcoin/pull/17273
< bitcoin-git> [bitcoin] RandyMcMillan reopened pull request #17273: build: proper fix for the kerning issue in macOS build fixes #16836 (master...fix-background-svg) https://github.com/bitcoin/bitcoin/pull/17273
< jonasschnelli> I pushed the 0.19.0rc3 osx detached signature (waiting for win now, cfields)
< bitcoin-git> [bitcoin] RandyMcMillan opened pull request #17284: build: update retry to current version (master...retry) https://github.com/bitcoin/bitcoin/pull/17284
< wumpus> jonasschnelli: thanks!
< bitcoin-git> [bitcoin] fjahr opened pull request #17285: doc: Bip70 removal follow-up (master...bip70_followup) https://github.com/bitcoin/bitcoin/pull/17285
< bitcoin-git> [bitcoin] ariard opened pull request #17286: doc: Add/extend comments for user-tunable values in validation.h (master...2019-10-comment-validation) https://github.com/bitcoin/bitcoin/pull/17286
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/cfec3e01b4d6...4c1090c882ea
< bitcoin-git> bitcoin/master c72906d Wladimir J. van der Laan: refactor: Remove redundant c_str() calls in formatting
< bitcoin-git> bitcoin/master 4c1090c MarcoFalke: Merge #17279: refactor: Remove redundant c_str() calls in formatting
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #17279: refactor: Remove redundant c_str() calls in formatting (master...2019_10_redundant_c_str) https://github.com/bitcoin/bitcoin/pull/17279
< bitcoin-git> [bitcoin] jachiang opened pull request #17288: Added TestWrapper class for interactive Python environments. (master...2019-10-testwrapper) https://github.com/bitcoin/bitcoin/pull/17288
< jeremyrubin> oops not sure what happened there
< jeremyrubin> I'm uncertain if anyone else could see that or just my machine, so if you didn't see anything please ignore :)
< gwillen> jeremyrubin: all I see from you is:12:46:43 -!- jeremyrubin [~jr@c-67-180-60-249.hsd1.ca.comcast.net] has quit [Quit: Konversation terminated!]
< gwillen> 13:24:54 -!- jeremyrubin [~jr@c-67-180-60-249.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
< gwillen> 13:26:12 < jeremyrubin> oops not sure what happened there
< jeremyrubin> Ok cool, all good then :p
< bitcoin-git> [bitcoin] achow101 opened pull request #17290: Enable BnB coin selection for preset inputs and subtract fee from outputs (master...all-bnb) https://github.com/bitcoin/bitcoin/pull/17290
< bitcoin-git> [bitcoin] practicalswift opened pull request #17291: tests: Add fuzzing harness for ISO-8601 related functions (master...fuzzers-parse_iso8601) https://github.com/bitcoin/bitcoin/pull/17291
< bitcoin-git> [bitcoin] JeremyRubin opened pull request #17292: Add new mempool benchmarks for a complex pool (master...bench_mempool) https://github.com/bitcoin/bitcoin/pull/17292
< bitcoin-git> [bitcoin] JeremyRubin opened pull request #17293: Add assertion to randrange that input is not 0 (master...assert-randrange) https://github.com/bitcoin/bitcoin/pull/17293