00:35 < bitcoin-git> [bitcoin] meshcollider opened pull request #18700: Fix locking on WSL using flock instead of fcntl (master...202004_file_lock_windows) https://github.com/bitcoin/bitcoin/pull/18700

02:57 < bitcoin-git> [bitcoin] fanquake opened pull request #18702: build: fix ASLR for bitcoin-cli on Windows (master...fix_pe_cli_aslr) https://github.com/bitcoin/bitcoin/pull/18702

03:53 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/6ae99aab5d97...d65631171cf8

03:53 < bitcoin-git> bitcoin/master 27abd1a Hennadii Stepanov: test: Replace boost::mutex with std::mutex

03:53 < bitcoin-git> bitcoin/master d656311 fanquake: Merge #18695: test: Replace boost::mutex with std::mutex

03:54 < bitcoin-git> [bitcoin] fanquake merged pull request #18695: test: Replace boost::mutex with std::mutex (master...200417-boost-mu) https://github.com/bitcoin/bitcoin/pull/18695

10:12 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/d65631171cf8...b690b24eb213

10:12 < bitcoin-git> bitcoin/master fa03713 MarcoFalke: test: Properly raise FailedToStartError when rpc shutdown before warmup fi...

10:12 < bitcoin-git> bitcoin/master b690b24 MarcoFalke: Merge #18633: test: Properly raise FailedToStartError when rpc shutdown be...

10:12 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #18633: test: Properly raise FailedToStartError when rpc shutdown before warmup finished (take 2) (master...2004-qaResetTake2) https://github.com/bitcoin/bitcoin/pull/18633

10:20 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b690b24eb213...a998c5185bc7

10:20 < bitcoin-git> bitcoin/master 3718ae2 John Newbery: [tests] Don't initialize PrecomputedTransactionData in txvalidationcache t...

10:20 < bitcoin-git> bitcoin/master a998c51 MarcoFalke: Merge #18675: tests: Don't initialize PrecomputedTransactionData in txvali...

10:20 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #18675: tests: Don't initialize PrecomputedTransactionData in txvalidationcache tests (master...2020-04-precomputedtransactiondata-txvalidationcache) https://github.com/bitcoin/bitcoin/pull/18675

11:09 < bitcoin-git> [bitcoin] MarcoFalke pushed 7 commits to master: https://github.com/bitcoin/bitcoin/compare/a998c5185bc7...b470c758470f

11:09 < bitcoin-git> bitcoin/master 9c16b17 Andrew Chow: Move wallet upgrading to its own function

11:09 < bitcoin-git> bitcoin/master 1833237 Andrew Chow: Only run UpgradeWallet if the wallet needs to be upgraded

11:09 < bitcoin-git> bitcoin/master c988f27 Andrew Chow: Have UpgradeWallet take the version to upgrade to and an error message out...

11:10 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #15761: Replace -upgradewallet startup option with upgradewallet RPC (master...upgradewallet-rpc) https://github.com/bitcoin/bitcoin/pull/15761

11:22 < darosior> MarcoFalke: re #15761, thought I might give a functional test a shot for upgrading an encrypted pre-HD wallet. However I'm not sure how to get the outdated wallet in the first place, I could create it locally and push it along with the test but..

11:22 < gribble> https://github.com/bitcoin/bitcoin/issues/15761 | Replace -upgradewallet startup option with upgradewallet RPC by achow101 · Pull Request #15761 · bitcoin/bitcoin · GitHub

11:23 < MarcoFalke> darosior: You can `cp ./test/functional/feature_backwards_compatibility.py ./test/functional/wallet_updgrade.py`

11:23 < MarcoFalke> And then have one olde node create the wallet for you

11:23 < MarcoFalke> s/olde/old/

12:03 < darosior> Great, thanks

12:40 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #18704: test: Increase debugging to hunt down mempool_reorg intermittent failure (master...2004-testMempoolReorgIntermittentFailureHuntDownIncreaseDebugLogStatements) https://github.com/bitcoin/bitcoin/pull/18704

12:53 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #18705: ci: Remove xenial tsan workaround (master...2004-ciXenialTsan) https://github.com/bitcoin/bitcoin/pull/18705

13:20 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b470c758470f...d2882a012bee

13:20 < bitcoin-git> bitcoin/master 9df32e8 Sebastian Falbesoner: scripted-diff: test: replace command with msgtype

13:20 < bitcoin-git> bitcoin/master d2882a0 MarcoFalke: Merge #18610: scripted-diff: test: replace command with msgtype (naming)

13:21 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #18610: scripted-diff: test: replace command with msgtype (naming) (master...20200410-scripted-diff-test-rename-command-to-msgtype) https://github.com/bitcoin/bitcoin/pull/18610

13:47 < provoostenator> Has anyone successfully built the macOS gitian build for 0.20.0rc1, using MacOSX10.14.sdk.tar.gz produced with macOS?

13:49 < provoostenator> I noticed #18589 tweaks the SDK instructions for linux based systems, but on macOS there's a different workflow.

13:49 < gribble> https://github.com/bitcoin/bitcoin/issues/18589 | Fix naming of macOS SDK and clarify version by achow101 · Pull Request #18589 · bitcoin/bitcoin · GitHub

13:50 < provoostenator> Lots of "fatal error: 'unistd.h' file not found" suggests it's not picking up the SDK.

14:10 < provoostenator> Unless I'm the only one with this problem, maybe #18674 could be tagged 0.20?

14:10 < gribble> https://github.com/bitcoin/bitcoin/issues/18674 | build: Use Xcode .xip as Gitian input · Issue #18674 · bitcoin/bitcoin · GitHub

14:34 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/d2882a012bee...f8102d90889a

14:34 < bitcoin-git> bitcoin/master fc289b7 João Barbosa: wallet: Refactor WalletRescanReserver to use wallet reference

14:34 < bitcoin-git> bitcoin/master f8102d9 MarcoFalke: Merge #18601: wallet: Refactor WalletRescanReserver to use wallet referenc...

14:35 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #18601: wallet: Refactor WalletRescanReserver to use wallet reference (master...2020-04-walletrescanreserver) https://github.com/bitcoin/bitcoin/pull/18601

17:09 < achow101> provoostenator: you probably have to do something similar what was changed by #18589 to get the correct naming of the directory inside the tarball

17:09 < gribble> https://github.com/bitcoin/bitcoin/issues/18589 | Fix naming of macOS SDK and clarify version by achow101 · Pull Request #18589 · bitcoin/bitcoin · GitHub

17:10 < achow101> i don't have a mac so I can't test it out myself, but the invocation is probably very close

17:10 < achow101> if you extract the sdk tarball, it proably has MacOSX.sdk instead of MacOSX.10.14.sdk

18:26 < provoostenator> achow101: that's probably it...

19:05 < provoostenator> It worked!

21:23 < achow101> provoostenator: are you using docker for gitian?