< bitcoin-git> [bitcoin] LarryRuane opened pull request #19690: util: improve FindByte() performance (master...FindByte-speedup) https://github.com/bitcoin/bitcoin/pull/19690
< fanquake> wumpus sipa: can you block yufi1213
< sipa> fanquake: he seems to have stopped
< fanquake> sipa: up to you. This is the second instance
< luke-jr> fanquake: this seems to be a language barrier?
< fanquake> luke-jr: possibly. Although looking at the GH profile they've been opening nonsense PRs and leaving random reviews all over the place.
< bitcoin-git> [bitcoin] fanquake closed pull request #19108: qt, refactor: Drop unneeded Q_DECLARE_METATYPE (master...200529-metatype) https://github.com/bitcoin/bitcoin/pull/19108
< zndtoshi> Hello. Can someone kidnly explain what does this part of the code from Core does? https://github.com/bitcoin/bitcoin/blob/be11f94e957dc59792de35c9000fba0ba7d57a50/src/validation.cpp#L1339
< wumpus> fanquake sipa yes it's a bit of a grey area, i don't think it's malicious but they're overexpressing themselves by spamming the issue with things like "i'm tired" is kind of annoying and still a good reason to block if it goes on
< wumpus> i mean, every post in that issue creates a mail to many people
< wumpus> zndtoshi: it's a warning system for detecting large forks (e.g. which reorganise a lot of blocks)
< wumpus> or which have a lot more work than our previously best chain
< zndtoshi> ok thank you.
< fanquake> wumpus: yea; 3500 people don't need those emails.
< fanquake> Kinda similar to people posting comments, and then deleting and re-posting rather than editing them. heh
< wumpus> it's kind of more of a social behavior barrier than a language barrier "github is not a chat", in any case if we have their mail we can try to send them a mail to explain first
< wumpus> should we disabble the s390 build in travis?
< wumpus> looks like the runs don't even start anymore
< jonatack> finally got the s390 job to pass after 4 kicks (ISTM the secp256k1 repo is removing it for the same reason)
< jonatack> ah, libsecp is giving it another chance as it started working again https://github.com/bitcoin-core/secp256k1/pull/794
< wumpus> sure getting it to work again would be even better
< bitcoin-git> [bitcoin] darosior closed pull request #19630: Cleanup fee estimation code (master...20/07/refactor_feeest_code) https://github.com/bitcoin/bitcoin/pull/19630
< bitcoin-git> [bitcoin] darosior reopened pull request #19630: Cleanup fee estimation code (master...20/07/refactor_feeest_code) https://github.com/bitcoin/bitcoin/pull/19630
< wumpus> i've decided to block yufi1213, looked at their profile a bit it's two days old and it's full of empty repositories that contain a funding.yml, as well as randomly copied README.md from other projects, it just seems too fishy to me
< wumpus> I've seen more accounts like that, it appears more like an attempt to game some system than a honest open source contributor
< fanquake> wumpus: 👍
< bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/be11f94e957d...f306384f5a90
< bitcoin-git> bitcoin/master 9505168 Hennadii Stepanov: build: Drop old hack which is unneeded now
< bitcoin-git> bitcoin/master 33a84e8 Hennadii Stepanov: build: Update and sort package list in gitian-linux.yml
< bitcoin-git> bitcoin/master f306384 fanquake: Merge #19622: build: Drop ancient hack in gitian-linux descriptor
< bitcoin-git> [bitcoin] fanquake merged pull request #19622: build: Drop ancient hack in gitian-linux descriptor (master...200729-multilib) https://github.com/bitcoin/bitcoin/pull/19622
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/f306384f5a90...04a0676b3fbf
< bitcoin-git> bitcoin/master ca2e474 Vasil Dimov: Fix a compiler warning: unused GetDevURandom()
< bitcoin-git> bitcoin/master 04a0676 fanquake: Merge #17563: lib: fix a compiler warning: unused GetDevURandom()
< bitcoin-git> [bitcoin] fanquake merged pull request #17563: lib: fix a compiler warning: unused GetDevURandom() (master...unused-GetDevURandom) https://github.com/bitcoin/bitcoin/pull/17563
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/04a0676b3fbf...6d5a9fec2d57
< bitcoin-git> bitcoin/master 01cd24c fanquake: doc: set CC_FOR_BUILD when building on OpenBSD
< bitcoin-git> bitcoin/master 6d5a9fe fanquake: Merge #19605: doc: set CC_FOR_BUILD when building on OpenBSD
< bitcoin-git> [bitcoin] fanquake merged pull request #19605: doc: set CC_FOR_BUILD when building on OpenBSD (master...openbsd_cc_for_build) https://github.com/bitcoin/bitcoin/pull/19605
< wumpus> I should really upgrade my OpenBSD VM
< sdaftuar> does anyone regularly use the -seednode argument to bitcoind? i am doing some testing and noticed a few interesting behaviors
< sdaftuar> the most interesting is that when trying to use -seednode, i managed to make a connection and my peer advertised itself to me, which i took as its getaddr response and disconnected
< sdaftuar> before getting a full reply
< sdaftuar> my other question, if anyone knows-- is there supposed to be a way to disable the fixed seeds?
< sdaftuar> (other than -connect=0)
< bitcoin-git> [bitcoin] instagibbs closed pull request #19269: CKey::Sign : switch test arg to explicit additional entropy argument (master...sign_entropy) https://github.com/bitcoin/bitcoin/pull/19269
< bitcoin-git> [bitcoin] instagibbs closed pull request #18245: Test some transaction creation with non-empty fee estimator (master...test_est_txn) https://github.com/bitcoin/bitcoin/pull/18245
< bitcoin-git> [bitcoin] achow101 closed pull request #16910: wallet: reduce loading time by using unordered maps (master...reduce-wallet-load) https://github.com/bitcoin/bitcoin/pull/16910
< wumpus> I've never used the -seednode argument fwiw
< sipa> i added it, and i also think i've never used it
< sdaftuar> lol
< sdaftuar> i assume matt has used it, i think he was the person who explained its purpose to me at some point
< wumpus> i've never had to use it, i do use bitcoind over tor, but i've always had peers
< wumpus> I understand why the option exists though
< sdaftuar> btw wumpus if you're in a merging state of mind, i think #19596 has been sufficiently reviewed at this point
< gribble> https://github.com/bitcoin/bitcoin/issues/19596 | Deduplicate parent txid loop of requested transactions and missing parents of orphan transactions by sdaftuar · Pull Request #19596 · bitcoin/bitcoin · GitHub
< wumpus> sdaftuar: thanks, will take a look
< jonatack> I've begun using -seednode and -addnode only very recently to try to find onion connections more quickly and keep them
< bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/6d5a9fec2d57...85fa648c857f
< bitcoin-git> bitcoin/master 8196176 Suhas Daftuar: Rewrite parent txid loop of requested transactions
< bitcoin-git> bitcoin/master 4c0731f Suhas Daftuar: Deduplicate missing parents of orphan transactions
< bitcoin-git> bitcoin/master 85fa648 Wladimir J. van der Laan: Merge #19596: Deduplicate parent txid loop of requested transactions and m...
< bitcoin-git> [bitcoin] laanwj merged pull request #19596: Deduplicate parent txid loop of requested transactions and missing parents of orphan transactions (master...2020-07-dedup-inputs) https://github.com/bitcoin/bitcoin/pull/19596
< sdaftuar> wumpus: thanks!
< bitcoin-git> [bitcoin] sipa opened pull request #19695: [do not merge] Test impact of secp256k1 endianness detection change (master...202008_test_appveyer_secp256k1) https://github.com/bitcoin/bitcoin/pull/19695
< bitcoin-git> [bitcoin] fjahr opened pull request #19696: rpc: Fix addnode remove command error (master...rpc_net_tests) https://github.com/bitcoin/bitcoin/pull/19696