< bitcoin-git> [bitcoin] fanquake closed pull request #18153: doc/release-process: Restore and update PPA note (master...doc_ppa_202002) https://github.com/bitcoin/bitcoin/pull/18153
< bitcoin-git> [bitcoin] fanquake closed pull request #17311: build: macOS fix background.svg (master...fix-background-svg) https://github.com/bitcoin/bitcoin/pull/17311
< bitcoin-git> [bitcoin] fanquake closed pull request #18133: Fix various edge case bugs in QValidatedLineEdit (master...bugfix_qvalidlineedit) https://github.com/bitcoin/bitcoin/pull/18133
< bitcoin-git> [bitcoin] fanquake closed pull request #17877: qt, refactor: Make BitcoinUnits::Unit a scoped enum (master...20200105-scoped-enums) https://github.com/bitcoin/bitcoin/pull/17877
< bitcoin-git> [bitcoin] fanquake closed pull request #17659: qt: Do not block GUI thread in RPCConsole (master...20191203-nonblocking-rpcconsole) https://github.com/bitcoin/bitcoin/pull/17659
< fanquake> Does anyone actually use the gitian-build.py script with the --pull option? If so, can you take a look at #18336.
< gribble> https://github.com/bitcoin/bitcoin/issues/18336 | script: Fix gitian-build.py --pull option by hebasto · Pull Request #18336 · bitcoin/bitcoin · GitHub
< fanquake> I don't think I've ever used that script.
< hebasto> fanquake: it's an easy and convenient way to make gitian build to test someone's pr
< hebasto> if --pull option is not used by other developers, it should me removed rather keeping in broken state
< fanquake> hebasto: thanks. I'm aware of what it does. Just want someone that actually uses it to look over your changes.
< fanquake> When I gitian build I generally just call gbuild directly. i.e: https://github.com/fanquake/core-review/tree/master/gitian-building#once-off-builds
< hebasto> this feature was introduced in #13765
< gribble> https://github.com/bitcoin/bitcoin/issues/13765 | contrib: add gitian build support for github pull request by ken2812221 · Pull Request #13765 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/609ce2d0da49...31760bb7c9f3
< bitcoin-git> bitcoin/master fa459bd MarcoFalke: rpc: Treat all args after a hidden arg as hidden as well
< bitcoin-git> bitcoin/master fa89ca9 MarcoFalke: refactor: Use C++11 range based for loops to simplify rpc code
< bitcoin-git> bitcoin/master fa50bdc MarcoFalke: rpc: Limit echo to 10 args
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #19528: rpc: Assert that RPCArg names are equal to CRPCCommand ones (misc) (master...2007-rpcMiscAssert) https://github.com/bitcoin/bitcoin/pull/19528
< bitcoin-git> [bitcoin] fanquake opened pull request #19716: build: Qt 5.15.x (master...qt_5_15_x) https://github.com/bitcoin/bitcoin/pull/19716
< jonatack> mini-nudge: #17204 has 3 acks
< gribble> https://github.com/bitcoin/bitcoin/issues/17204 | wallet: Do not turn OP_1NEGATE in scriptSig into 0x0181 in signing code (sipa) by meshcollider · Pull Request #17204 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/31760bb7c9f3...c0b170696432
< bitcoin-git> bitcoin/master e7448d6 Fabian Jahr: wallet: Don't override signing errors
< bitcoin-git> bitcoin/master c0b1706 fanquake: Merge #19568: Wallet should not override signing errors
< bitcoin-git> [bitcoin] fanquake merged pull request #19568: Wallet should not override signing errors (master...err_override) https://github.com/bitcoin/bitcoin/pull/19568
< jonatack> #19455 has 3 acks as well
< gribble> https://github.com/bitcoin/bitcoin/issues/19455 | rpc generate: print useful help and error message by jonatack · Pull Request #19455 · bitcoin/bitcoin · GitHub
< wumpus> jonasschnelli: thanks will take a look
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #19717: rpc: Assert that RPCArg names are equal to CRPCCommand ones (mining,zmq,rpcdump) (master...2008-rpcMisc) https://github.com/bitcoin/bitcoin/pull/19717
< bitcoin-git> [bitcoin] laanwj pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/c0b170696432...dabab06a1a1a
< bitcoin-git> bitcoin/master 8d32d20 Jon Atack: test: consider generate covered in _get_uncovered_rpc_commands()
< bitcoin-git> bitcoin/master 92d94ff Jon Atack: rpc: print useful help and error message for generate
< bitcoin-git> bitcoin/master f0aa8ae Jon Atack: test: add rpc_generate functional test
< bitcoin-git> [bitcoin] laanwj merged pull request #19455: rpc generate: print useful help and error message (master...rpc-generate-helpful-error_message) https://github.com/bitcoin/bitcoin/pull/19455
< bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/dabab06a1a1a...4d4bd5ed7474
< bitcoin-git> bitcoin/master e629d07 Pieter Wuille: Do not turn OP_1NEGATE in scriptSig into 0x0181 in signing code
< bitcoin-git> bitcoin/master dca2863 Jon Atack: test: ensure OP_1NEGATE satisfies BIP62 minimal push rule
< bitcoin-git> bitcoin/master 4d4bd5e Wladimir J. van der Laan: Merge #17204: wallet: Do not turn OP_1NEGATE in scriptSig into 0x0181 in s...
< bitcoin-git> [bitcoin] laanwj merged pull request #17204: wallet: Do not turn OP_1NEGATE in scriptSig into 0x0181 in signing code (sipa) (master...201910_1negate_rebase) https://github.com/bitcoin/bitcoin/pull/17204
< wumpus> fanquake: no, I've never used that option, from what I remember, let's see
< wumpus> oh gitian-build not github-merge, no, I must shamefully admit have used that script one or twice for testing, I still have my own age-old gitian build script
< hebasto> it seems everyone uses its own self-crafted gitian build script :D
< wumpus> it has always been "oh it will work for now, no need to switch around scripts, this release we're going to switch to something else than gitian, right 😳
< jonatack> i've basically been using fanquake's guide, slightly adapted for linux
< hebasto> how to conditionally skip a benchmark in nanobench framework?
< wumpus> maybe something with -filter=<regex> ?
< wumpus> it seems more suitable for running a subset than excluding a benchmark but still, depending on the regex subset supported it should be possible
< wumpus> ok
< wumpus> apparently I misinterpeted your questino in exactly the same way
< hebasto> sorry for misleading
< wumpus> I'm happy that Martinus still sticks around to provide support
< hebasto> very kind of him
< bitcoin-git> [bitcoin] hebasto opened pull request #19718: build, test: Add missed gcov files to 'make clean' (master...200814-gcno) https://github.com/bitcoin/bitcoin/pull/19718
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/4d4bd5ed7474...1a43cd3f747f
< bitcoin-git> bitcoin/master 35cd2da Hennadii Stepanov: test: Fix 'make cov' with clang
< bitcoin-git> bitcoin/master 1a43cd3 MarcoFalke: Merge #19709: test: Fix 'make cov' with clang
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #19709: test: Fix 'make cov' with clang (master...200813-lcov) https://github.com/bitcoin/bitcoin/pull/19709
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #19719: build: Add Werror=range-loop-analysis (master...2008-buildLoopErr) https://github.com/bitcoin/bitcoin/pull/19719
< bitcoin-git> [bitcoin] jonatack opened pull request #19720: test: bip157 p2p_blockfilters configuration options (master...bip157-blockfilters-tests) https://github.com/bitcoin/bitcoin/pull/19720
< bitcoin-git> [bitcoin] adamjonas opened pull request #19721: doc: comment out unused MSG_FILTERED_WITNESS_BLOCK (master...2020_8_MSG_FILTERED_WITNESS_BLOCK_comment) https://github.com/bitcoin/bitcoin/pull/19721
< jonatack> perhaps ban "Jssdr" for this spammy comment: https://github.com/bitcoin/bitcoin/issues/2086#issuecomment-674142837
< luke-jr> a shame that we're finally getting real progress toward splitting out the GUI, and now univalue is being pulled into it :x
< bitcoin-git> [bitcoin] torhte opened pull request #19722: [test] Add test for getblockheader verboseness (master...test-gbh) https://github.com/bitcoin/bitcoin/pull/19722
< meshcollider> #startmeeting
< lightningbot> Meeting started Fri Aug 14 19:00:14 2020 UTC. The chair is meshcollider. Information about MeetBot at http://wiki.debian.org/MeetBot.
< lightningbot> Useful Commands: #action #agreed #help #info #idea #link #topic.
< achow101> hi
< meshcollider> #bitcoin-core-dev Wallet Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb moneyball ariard digi_james amiti fjahr
< meshcollider> jeremyrubin emilengler jonatack hebasto jb55
< fjahr> hi
< meshcollider> Any topics this week?
< achow101> any wallet PRs in need of review?
< achow101> that are reasonably close to being merged?
< kanzure> hi
< fjahr> I think #14582 is interesting but long forgotten
< gribble> https://github.com/bitcoin/bitcoin/issues/14582 | wallet: always do avoid partial spends if fees are within a specified range by kallewoof · Pull Request #14582 · bitcoin/bitcoin · GitHub
< instagibbs> hi
< fjahr> enough concept ACK now I think and a tested ACK from me so not super close but still
< meshcollider> achow101: time to review-beg for your coin selection PRs?
< jonatack> hi
< achow101> meshcollider: yep
< achow101> if sqlite is too big/scary to review, how about coin selection, almost as scary!
< achow101> #17458 is close to being merged. 3 ACKs
< gribble> https://github.com/bitcoin/bitcoin/issues/17458 | Refactor OutputGroup effective value calculations and filtering to occur within the struct by achow101 · Pull Request #17458 · bitcoin/bitcoin · GitHub
< achow101> #17331 is next up in that stack
< gribble> https://github.com/bitcoin/bitcoin/issues/17331 | Use effective values throughout coin selection by achow101 · Pull Request #17331 · bitcoin/bitcoin · GitHub
< meshcollider> #16841 is also nearly rtm
< gribble> https://github.com/bitcoin/bitcoin/issues/16841 | Replace GetScriptForWitness with GetScriptForDestination by meshcollider · Pull Request #16841 · bitcoin/bitcoin · GitHub
< achow101> yes, getting that in would be nice
< meshcollider> Anything else anyone wants to discuss? Perhaps #19700 vs #19671 ?
< gribble> https://github.com/bitcoin/bitcoin/issues/19671 | wallet: Remove -zapwallettxes by achow101 · Pull Request #19671 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/19700 | wallet: Replace -zapwallettxes with wallet tool command by achow101 · Pull Request #19700 · bitcoin/bitcoin · GitHub
< achow101> 19700 feels way too involved for something that is barely used
< achow101> i prefer removing -zapwallettxes outright
< meshcollider> But jonasschnelli just reviewed it, does that mean he prefers it?
< achow101> good question
< meshcollider> people need to say "I prefer this one or this one"
< meshcollider> Well I don't think there is enough people online to discuss it much
< achow101> I think it's also reasonable to reintroduce it in the wallettool if people complain about it being gone
< meshcollider> Yes it doesn't need to be immediate if it's moving to the tool anyway
< meshcollider> #action Please take a look at those two PRs and comment your preference ^
< meshcollider> I guess that's all for this week
< meshcollider> #endmeeting
< lightningbot> Meeting ended Fri Aug 14 19:16:07 2020 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)
< jonasschnelli> Meshcollider: as for zaptx. I slightly prefer to keep the functionality (in an expert CLI tool). But no strong opinion.
< jonasschnelli> I remember some situation where this „sledge hammer“ rescued some stuck (non rbf) transactions.
< achow101> jonasschnelli: abandontransaction does that now
< jonasschnelli> abandontx may help... but it’s more complicated
< achow101> and removeprunedfunds as a slightly smaller sledgehammer
< jonasschnelli> I agree. I see it more as a function we could drag along for a while.
< jonasschnelli> Shouldn’t hurt
< achow101> I'd agree if we didn't have to drag along the metadata keeping part
< jonasschnelli> Yeah... that’s a point.
< bitcoin-git> [bitcoin] sdaftuar opened pull request #19723: Ignore unknown messages before VERACK (master...2020-08-feature-negotiation) https://github.com/bitcoin/bitcoin/pull/19723
< jonasschnelli> As said. No strong opinion.
< achow101> #16841 RTM?
< gribble> https://github.com/bitcoin/bitcoin/issues/16841 | Replace GetScriptForWitness with GetScriptForDestination by meshcollider · Pull Request #16841 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] amitiuttarwar opened pull request #19724: [net] Cleanup connection type- followups (master...2020-08-conn-refactor-followups) https://github.com/bitcoin/bitcoin/pull/19724
< fanquake> achow101: 👍
< bitcoin-git> [bitcoin] meshcollider pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/30dd562fd2c5...f269165edc03
< bitcoin-git> bitcoin/master 7d07e86 Andrew Chow: Use real value when calculating OutputGroup value
< bitcoin-git> bitcoin/master 9adc2f8 Andrew Chow: Refactor OutputGroups to handle effective values, fees, and filtering
< bitcoin-git> bitcoin/master f269165 Samuel Dobson: Merge #17458: Refactor OutputGroup effective value calculations and filter...
< bitcoin-git> [bitcoin] meshcollider merged pull request #17458: Refactor OutputGroup effective value calculations and filtering to occur within the struct (master...cleanup-outputgroups) https://github.com/bitcoin/bitcoin/pull/17458