< shesek> achow101, "the seed is a valid key that we can receive coins at!" w00t, what was the original rational behind this?
< shesek> (from #19602)
< gribble> https://github.com/bitcoin/bitcoin/issues/19602 | wallet: Migrate legacy wallets to descriptor wallets by achow101 · Pull Request #19602 · bitcoin/bitcoin · GitHub
< achow101> shesek: probably because a CKey is an easy container, and mapKeys is an easy place to put it
< shesek> I see, so just a side-effect of how this was convenient to implement
< bitcoin-git> [bitcoin] adamjonas closed pull request #17232: Sanity assert GetAncestor() != nullptr where appropriate (master...assert_get_ancestor) https://github.com/bitcoin/bitcoin/pull/17232
< achow101> I believe so
< shesek> achow101, one unintended side-effect is that spending from that address reveals that you're using bitcoin core. but that can only be an issue if someone learns your xpub, which should not really happen normally anyway
< achow101> It never gets given out, so it's unlikely anyone had every received at their seed before
< shesek> is it really necessary to preserve this feature/bug when upgrading to descriptor wallets?
< sipa> hell no
< sipa> oh, you mean when upgrading an existing wallet... perhaps that exact part not, but it's easier to reason about if it exactly maps things
< sipa> a newly created descriptor wallet shouldn't have such silliness though!
< bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/3ab2582c7fe7...a57af897ec16
< bitcoin-git> bitcoin/master 6d94192 Sebastian Falbesoner: test: add logging for p2p_feefilter.py
< bitcoin-git> bitcoin/master fe3f0cc Sebastian Falbesoner: test: use wait_until for invs matching in p2p_feefilter.py
< bitcoin-git> bitcoin/master 9e78943 Sebastian Falbesoner: test: speedup p2p_feefilter.py by whitelisting peers (immediate tx relay)
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #19564: test: p2p_feefilter improvements (logging, refactoring, speedup) (master...20200722-test-p2p_feefilter_improvements) https://github.com/bitcoin/bitcoin/pull/19564
< bitcoin-git> [bitcoin] hebasto opened pull request #19735: Fix -Wtautological-constant-out-of-range-compare warnings on 32-bit systems (master...200816-size) https://github.com/bitcoin/bitcoin/pull/19735
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/a57af897ec16...ffad34816722
< bitcoin-git> bitcoin/master 767073f Vasil Dimov: Shrink CAddress from 48 to 40 bytes on x64
< bitcoin-git> bitcoin/master ffad348 Wladimir J. van der Laan: Merge #19705: Shrink CAddress from 48 to 40 bytes on x64
< bitcoin-git> [bitcoin] laanwj merged pull request #19705: Shrink CAddress from 48 to 40 bytes on x64 (master...shrink_caddress) https://github.com/bitcoin/bitcoin/pull/19705
< luke-jr> should signrawtransactionwithwallet sign non-wallet inputs? 0.20 didn't, but master apparently does..
< bitcoin-git> [bitcoin] promag opened pull request #19738: wallet: Avoid multiple BerkeleyBatch in DelAddressBook (master...2020-08-deladdressbook) https://github.com/bitcoin/bitcoin/pull/19738