< bitcoin-git> [bitcoin] TheRook opened pull request #19665: Floating-Point Nakamoto Consensus (master...master) https://github.com/bitcoin/bitcoin/pull/19665
< bitcoin-git> [bitcoin] fanquake closed pull request #19665: Floating-Point Nakamoto Consensus (master...master) https://github.com/bitcoin/bitcoin/pull/19665
< bitcoin-git> [bitcoin] fanquake opened pull request #19667: build: set minimum required Boost to 1.58.0 (master...boost_1_58_0) https://github.com/bitcoin/bitcoin/pull/19667
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #19661: suggest a convention for python string quoting (master...doc-python-quoting) https://github.com/bitcoin/bitcoin/pull/19661
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/0f16212c5931...65e4ecabd5b4
< bitcoin-git> bitcoin/master 7235178 Fabian Jahr: lint: Remove travis env var from commit linter
< bitcoin-git> bitcoin/master 65e4eca MarcoFalke: Merge #19654: lint: Don't use TRAVIS_COMMIT_RANGE in commit message linter...
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #19654: lint: Don't use TRAVIS_COMMIT_RANGE in commit message linter (master...commit-lint) https://github.com/bitcoin/bitcoin/pull/19654
< darosior> MarcoFalke: what is the minimum supported Python version ?
< darosior> Wondering if i should drop the fstring
< fanquake> darosior: it's 3.5
< fanquake> you'll have to drop the fstring
< darosior> Arf, thanks!
< fanquake> 3.6 soon: #19504
< gribble> https://github.com/bitcoin/bitcoin/issues/19504 | Bump minimum python version to 3.6 by ajtowns · Pull Request #19504 · bitcoin/bitcoin · GitHub
< wumpus> python went through a few different kinds of 'recommended' formatting in quick succession, i hope they settle with fstrings now
< wumpus> not that much fun to keep learning new ways to do the same :-)
< bitcoin-git> [bitcoin] meshcollider pushed 8 commits to master: https://github.com/bitcoin/bitcoin/compare/65e4ecabd5b4...e4df534c60e1
< bitcoin-git> bitcoin/master 8314c23 Sjors Provoost: [depends] boost: patch unused variable in boost_process
< bitcoin-git> bitcoin/master 929cda5 Sjors Provoost: configure: add ax_boost_process
< bitcoin-git> bitcoin/master c47e4bb Sjors Provoost: [build] make boost-process opt-in
< bitcoin-git> [bitcoin] meshcollider merged pull request #15382: util: add RunCommandParseJSON (master...2019/02/runCommandParseJSON) https://github.com/bitcoin/bitcoin/pull/15382
< wumpus> achow101: re #19653, I sometimes wonder why this functionality is not part of the bitcoin-wallet tool instead
< gribble> https://github.com/bitcoin/bitcoin/issues/19653 | wallet: Replace -zapwallettxes with zapwallettxes RPC by achow101 · Pull Request #19653 · bitcoin/bitcoin · GitHub
< wumpus> achow101: (in any case, clearly, having it as RPC is better than a command line argument)
< wumpus> but it's really a maintenance/recovery command
< bitcoin-git> [bitcoin] hebasto opened pull request #19668: Do not hide compile-time thread safety warnings (master...200805-assert) https://github.com/bitcoin/bitcoin/pull/19668
< MarcoFalke> Hi, I won't be around tomorrow, but I'd like to add #19629 to high prio. Can I add it today or should I store it in a meeting topic?
< gribble> https://github.com/bitcoin/bitcoin/issues/19629 | Pass mempool pointer to chainstate constructor by MarcoFalke · Pull Request #19629 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e4df534c60e1...4644b13b4499
< bitcoin-git> bitcoin/master 82fc401 Ben Woosley: test: Catch decimal.InvalidOperation from TestNodeCLI#send_cli
< bitcoin-git> bitcoin/master 4644b13 Wladimir J. van der Laan: Merge #19632: test: Catch decimal.InvalidOperation from TestNodeCLI#send_c...
< bitcoin-git> [bitcoin] laanwj merged pull request #19632: test: Catch decimal.InvalidOperation from TestNodeCLI#send_cli (master...2020-07-send_cli-invalid-op) https://github.com/bitcoin/bitcoin/pull/19632
< MarcoFalke> #proposedmeetingtopic add #19629 to high prio, discuss whether to remove the pulls that need rebase from high prio. (MarcoFalke, but won't be around)
< gribble> https://github.com/bitcoin/bitcoin/issues/19629 | Pass mempool pointer to chainstate constructor by MarcoFalke · Pull Request #19629 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #19669: contrib: Fixup valgrind suppressions file (master...2008-valSupp) https://github.com/bitcoin/bitcoin/pull/19669
< wumpus> MarcoFalke: sure, let's just add it, I prefer doing high prio list changes only during the meeting but also understand not everyone can be there at that time
< wumpus> added
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/4644b13b4499...e3272ff2907c
< bitcoin-git> bitcoin/master 1d8338d fanquake: util: use HAVE_FDATASYNC to determine fdatasync() use
< bitcoin-git> bitcoin/master e3272ff Wladimir J. van der Laan: Merge #19614: util: use HAVE_FDATASYNC to determine fdatasync() use
< bitcoin-git> [bitcoin] laanwj merged pull request #19614: util: use HAVE_FDATASYNC to determine fdatasync() use (master...use_have_fdatasync) https://github.com/bitcoin/bitcoin/pull/19614
< achow101> wumpus: it's actually not clear to me whether we should even keep zapwallettxes since we have abandontransaction
< instagibbs> can someone remind me where a test reads off logs looking for a string
< instagibbs> ah tiny grepfu got it nvm
< instagibbs> what's the maximum time a node is supposed to wait before getdata'ing an tx it gets an inv for?
< instagibbs> Just encountered a 50 second gap on regtest, that seems a bit extreme, wondering if I'm missing something
< sipa> instagibbs: there is no limit, really
< instagibbs> hmm ok, because im modifying a test that claims the getdata won't happen(because of outstanding getdata request to other peer)
< sipa> but if you have N peers announcing, and the first N-1 ones don't respond, it'll take N-1 minutes
< instagibbs> ah!
< instagibbs> that lines up basically perfectly, thanks
< instagibbs> is that some timer based logic? Can I get a pointer?
< sipa> g_already_asked_for
< sipa> coordinates what gets requested from whom wheb
< bitcoin-git> [bitcoin] promag closed pull request #19640: refactor: Improve GetWitnessCommitmentIndex (master...2020-08-getwitnesscommitmentindex) https://github.com/bitcoin/bitcoin/pull/19640
< instagibbs> yeah ok found the block, perfect
< sipa> #19184 rewrites all of that
< gribble> https://github.com/bitcoin/bitcoin/issues/19184 | Overhaul transaction request logic by sipa · Pull Request #19184 · bitcoin/bitcoin · GitHub
< wumpus> achow101: yes, that's another point
< achow101> #proposedmeetingtopic: what to do about zapwallettxes
< wumpus> achow101: I think zapwallettx was introduced for the same reason as abandontransaction
< achow101> wumpus: it seems like that's been the only use for it
< wumpus> I'm not sure people are actually ever using it
< wumpus> right
< achow101> and both don't work with -persistmempool
< wumpus> I think abandontransaction, to be able to abandon specific conflicted or stuck transaction, is superior in every case
< wumpus> but I'm not sure, it might be zapwallettx is more of a sledge hammer that can be useful in some cases
< sipa> i think zapwallettxes was also intended as a way to.recover from very corrupted wallet files
< sipa> or is that savagewallet
< wumpus> that ^^
< achow101> there was a test case MarcoFalke made recently that did savagewallet and zapwallettxes would fix the problem
< wumpus> salvagewallet already has multiple settings IIRC
< wumpus> I guess zapwallettxes could be another salvagewallet level
< achow101> it was something like savagewallet ended up adding a tx to the wallet multiple times, so zapwallettxs could fix that with dumping all the txs
< wumpus> salvagewallet is ugly and unreliable as it goes over the raw database file data, so it sometimes misinterprets things
< wumpus> so it can create spurious records
< wumpus> the private key entries have a hash now so should be protected from this, buttransactions have not
< achow101> transactions have txid, for the things covered by that..
< wumpus> maybe salvage shouldn't salvage transactions at all
< wumpus> just the keys
< achow101> but a tx record contains a bunch of other crap
< wumpus> ohh
< wumpus> (and scripts!)
< bitcoin-git> [bitcoin] sdaftuar opened pull request #19670: Protect localhost and block-relay-only peers from eviction (master...2020-08-improved-eviction) https://github.com/bitcoin/bitcoin/pull/19670
< bitcoin-git> [bitcoin] achow101 opened pull request #19671: wallet: Remove -zapwallettxes (master...rm-zapwallettxes) https://github.com/bitcoin/bitcoin/pull/19671