< achow101> luke-jr: it didn't?
< achow101> I thought signrawtransaction* always signed stuff if it had the necessary info, however it was provided
< bitcoin-git> [bitcoin] theStack opened pull request #19739: refactor: remove c-string interfaces for DecodeBase58{Check} (master...20200811-util-remove-cstring-decodebase58) https://github.com/bitcoin/bitcoin/pull/19739
< bitcoin-git> [bitcoin] promag closed pull request #15204: gui: Add Open External Wallet action (master...2019-01-openexternalwallet) https://github.com/bitcoin/bitcoin/pull/15204
< luke-jr> achow101: well, if I backport #17204, the test fails apparently because of this
< gribble> https://github.com/bitcoin/bitcoin/issues/17204 | wallet: Do not turn OP_1NEGATE in scriptSig into 0x0181 in signing code (sipa) by meshcollider · Pull Request #17204 · bitcoin/bitcoin · GitHub
< achow101> luke-jr: interesting, I'll have a look
< achow101> luke-jr: my expectation is that 0.20 and earlier would attempt to sign non-wallet inputs and fail silently. Now what's happening is that it's attempting to sign but failing loudly
< achow101> erm got that backwards
< luke-jr> achow101: master is succeeding..
< achow101> this is looking more like a bug in 0.20 to me rather than a bug in master
< achow101> luke-jr: the test passes on 0.19
< luke-jr> XD
< sipa> it was my expectectation too that that should work
< sipa> if yiu agree to signing a tx, there is no reason why you wouldn't sign it for all inputs/keys that you can
< luke-jr> achow101: did you bisect it already?
< achow101> luke-jr: no, but I don't need to
< achow101> I already know what introduced the bug
< luke-jr> ?
< achow101> #18115
< gribble> https://github.com/bitcoin/bitcoin/issues/18115 | wallet: Pass in transactions and messages for signing instead of exporting the private keys by achow101 · Pull Request #18115 · bitcoin/bitcoin · GitHub
< sipa> so, is there a simple backport we could use in 0.20.2 ?
< achow101> pretty sure no
< sipa> a less than simple one? that doesn't involve all of descriptor wallets...?
< achow101> I don't think there's a commit we can directly backport
< achow101> but it shouldn't be hard to write a fix
< sipa> ok
< sipa> i don't think this is all that worrisome, though it's good practice to fix discovered issues
< luke-jr> especially while 0.20 is our latest
< instagibbs> it's conceivable you'd want to not necessarily sign all inputs in a tx(payjoin is an example) but you'd want a specific api to exclude inputs
< instagibbs> not important to discussion per se, just saying
< sipa> instagibbs: yes, agree, though that's a much more specialized situation
< instagibbs> agreed!
< luke-jr> probably just a PSBT use case though?
< instagibbs> anyways, not really something pertaining to this issue
< luke-jr> achow101: if it's trivial to fix correctly, I'd like to include it in Knots 0.20.1 if possible
< bitcoin-git> [bitcoin] achow101 opened pull request #19740: [0.20] wallet: Simplify and fix CWallet::SignTransaction (0.20...backport-17204-fix) https://github.com/bitcoin/bitcoin/pull/19740
< achow101> luke-jr: ^ Turns out copy and paste from master works
< luke-jr> XD
< luke-jr> achow101: is it really safe to drop all the error checking there?
< achow101> I think so. See #19568. The errors should already be coming from the called functions
< gribble> https://github.com/bitcoin/bitcoin/issues/19568 | Wallet should not override signing errors by fjahr · Pull Request #19568 · bitcoin/bitcoin · GitHub
< achow101> Don't think that has changed in master
< luke-jr> oh, right, I remember that PR
< bitcoin-git> [bitcoin] meshcollider pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/ffad34816722...c831e105c567
< bitcoin-git> bitcoin/master b82067b Karl-Johan Alm: wallet: try -avoidpartialspends mode and use its result if fees are below ...
< bitcoin-git> bitcoin/master 7f13dfb Karl-Johan Alm: test: test the implicit avoid partial spends functionality
< bitcoin-git> bitcoin/master c831e10 Samuel Dobson: Merge #14582: wallet: always do avoid partial spends if fees are within a ...
< bitcoin-git> [bitcoin] meshcollider merged pull request #14582: wallet: always do avoid partial spends if fees are within a specified range (master...181026-try-avoidpartialspends) https://github.com/bitcoin/bitcoin/pull/14582
< bitcoin-git> [bitcoin] kallewoof opened pull request #19743: -maxapsfee follow-up (master...20200817-maxapsfee-followup) https://github.com/bitcoin/bitcoin/pull/19743
< bitcoin-git> [bitcoin] hebasto opened pull request #19745: build: Drop back compatibility code for 32-bit x86 Linux binaries (master...200817-i686) https://github.com/bitcoin/bitcoin/pull/19745
< bitcoin-git> [bitcoin] hebasto closed pull request #19745: build: Drop back compatibility code for 32-bit x86 Linux binaries (master...200817-i686) https://github.com/bitcoin/bitcoin/pull/19745
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #19746: ci: Move valgrind fuzzer to cirrus (master...2008-ciValgrind) https://github.com/bitcoin/bitcoin/pull/19746
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/c831e105c567...1bc8e8eae2dc
< bitcoin-git> bitcoin/master 7668db3 Marcin Jachymiak: Move only: Move CDiskTxPos to its own file
< bitcoin-git> bitcoin/master 1bc8e8e MarcoFalke: Merge #19734: Move CDiskTxPos to its own file
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #19734: Move CDiskTxPos to its own file (master...move-disktxpos) https://github.com/bitcoin/bitcoin/pull/19734
< bitcoin-git> [bitcoin] S3RK closed pull request #19384: test: speed up functional tests (master...test_speed_up) https://github.com/bitcoin/bitcoin/pull/19384
< bitcoin-git> [bitcoin] S3RK opened pull request #19747: wallet: restore condition for HD chain split upgrade (master...wallet_upgrade_fix) https://github.com/bitcoin/bitcoin/pull/19747
< bitcoin-git> [bitcoin] theStack opened pull request #19750: refactor: remove unused c-string variant of atoi64() (master...20200817-util-remove-unused_cstr_atoi64) https://github.com/bitcoin/bitcoin/pull/19750
< * luke-jr> wonders if he needs to pivot PPC64 support to Knots-only :/
< sipa> why?
< luke-jr> sipa: nobody's reviewing it, and as it stands, I'm having to build Qt separately for Core and Knots since PPC64 requires upstream libpng :/
< luke-jr> (it needs rebase yet again, but it didn't get any activity after the last rebase either)
< sipa> who else here has power9 hardware?
< sipa> there are a few at least, afaik
< luke-jr> not sure
< luke-jr> gmaxwell I think did, but isn't here these days :x
< sipa> bluematt, sdaftuar, ...
< * luke-jr> ponders if splitting up the libpng change would be more reviewable for now
< sipa> maybe midnight ?
< * luke-jr> rebases it again for now
< bitcoin-git> [bitcoin] luke-jr opened pull request #19751: depends: Split libpng out of Qt (master...depends_libpng) https://github.com/bitcoin/bitcoin/pull/19751
< amiti> just want to highlight for anyone who might not have seen yet- as of #19316 "oneshots" have been renamed to "addr fetch" connections
< gribble> https://github.com/bitcoin/bitcoin/issues/19316 | [net] Cleanup logic around connection types by amitiuttarwar · Pull Request #19316 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] slmtpz opened pull request #19752: test: Update wait_until usage in tests not to use the one from utils (master...master) https://github.com/bitcoin/bitcoin/pull/19752
< achow101> Why are there both RemoveWallet and UnloadWallet? It seems like unloadwallet calls both, but the GUI only calls RemoveWallet?
< achow101> Can these be consolidated?
< bitcoin-git> [bitcoin] troygiorshev opened pull request #19753: p2p: fix recentRejects filling bug (master...2020-08-clean-tx-processing) https://github.com/bitcoin/bitcoin/pull/19753
< bitcoin-git> [bitcoin] achow101 opened pull request #19754: wallet: Move UpdateWalletSetting to wallet module and use from GUI interface (master...load-on-start-gui) https://github.com/bitcoin/bitcoin/pull/19754
< ryanofsky> difference between gui and rpc unloading sequences is that gui sequence is nonblocking while rpc blocks, but that code is a mess
< ryanofsky> i started changes to clean it up https://github.com/ryanofsky/bitcoin/commits/pr/path.1, #19619 came out of that
< gribble> https://github.com/bitcoin/bitcoin/issues/19619 | Remove wallet.dat path handling from wallet.cpp, rpcwallet.cpp by ryanofsky · Pull Request #19619 · bitcoin/bitcoin · GitHub
< sipa> achow101: any idea how i can resolve this bdb error?
< sipa> BDB0552 Page 0: last_pgno is not correct: 272 != 287
< sipa> wallet.dat: BDB0090 DB_VERIFY_BAD: Database verification failed
< sipa> when starting bitcoind?
< achow101> Sounds like part of the database is missing
< sipa> all my wallet files have this
< sipa> if i stop loading one, the next one gives that error
< achow101> Huh.
< achow101> Same mismatching last_pgno or different numbers?
< sipa> i just ran db_dump | db_load on all of them
< sipa> now it works
< achow101> were these copied from another system?
< sipa> nope
< achow101> just randomly happened today?
< sipa> yes, they worked 3 days ago
< sipa> i may have recompiled in between
< sipa> i know this isn't a useful bug report, as i don't know what commit exactly i was using before
< sipa> it may also have been an unclean shutdown
< sipa> actually, pretty sure it was an unclean shutdown, i'm also getting "Rolling forward" messages now
< achow101> So that particular error is that the metadata says there are 287 pages, but the actual number of pages was 272
< achow101> if you had an unclean shutdown, then it seems reasonable that the metadata could have been updated but not the file itself
< achow101> *metadata meaning the metadata page of the file
< * sipa> is scared of bdb...