< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/6eb97fb82382...f89b4f895fc6
< bitcoin-git> bitcoin/master fa1fc53 MarcoFalke: test: Add tsan supp for leveldb::DBImpl::DeleteObsoleteFiles
< bitcoin-git> bitcoin/master f89b4f8 fanquake: Merge #19830: test: Add tsan supp for leveldb::DBImpl::DeleteObsoleteFiles...
< bitcoin-git> [bitcoin] fanquake merged pull request #19830: test: Add tsan supp for leveldb::DBImpl::DeleteObsoleteFiles (master...2008-testTsan) https://github.com/bitcoin/bitcoin/pull/19830
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/f89b4f895fc6...21eda43cdea8
< bitcoin-git> bitcoin/master b35e74b João Barbosa: wallet, refactor: Remove duplicate map lookups in GetAddressBalances
< bitcoin-git> bitcoin/master 21eda43 fanquake: Merge #19828: wallet, refactor: Remove duplicate map lookups in GetAddress...
< bitcoin-git> [bitcoin] fanquake merged pull request #19828: wallet, refactor: Remove duplicate map lookups in GetAddressBalances (master...2020-08-getaddressbalances) https://github.com/bitcoin/bitcoin/pull/19828
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/0adb80fe630c...5c910a6b7aca
< bitcoin-git> bitcoin/master fa0572d MarcoFalke: Pass mempool reference to chainstate constructor
< bitcoin-git> bitcoin/master 5c910a6 MarcoFalke: Merge #19826: Pass mempool reference to chainstate constructor
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #19826: Pass mempool reference to chainstate constructor (master...2008-valMemRef) https://github.com/bitcoin/bitcoin/pull/19826
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/5c910a6b7aca...afffbb1bc640
< bitcoin-git> bitcoin/master ce3e6a7 Hennadii Stepanov: bench: Allow skip benchmark
< bitcoin-git> bitcoin/master 3edc4e3 Hennadii Stepanov: bench: Prevent thread oversubscription
< bitcoin-git> bitcoin/master afffbb1 MarcoFalke: Merge #19710: bench: Prevent thread oversubscription and decreases the var...
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #19710: bench: Prevent thread oversubscription and decreases the variance of result values (master...200813-var) https://github.com/bitcoin/bitcoin/pull/19710
< bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/afffbb1bc640...269a7ccb2784
< bitcoin-git> bitcoin/master b266b3e Russell Yanofsky: refactor: Create interfaces earlier during initialization
< bitcoin-git> bitcoin/master e4f4350 Russell Yanofsky: refactor: Move wallet methods out of chain.h and node.h
< bitcoin-git> bitcoin/master 24bf176 Russell Yanofsky: gui refactor: Inline SplashScreen::ConnectWallet
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #19099: refactor: Move wallet methods out of chain.h and node.h (master...pr/wclient) https://github.com/bitcoin/bitcoin/pull/19099
< bitcoin-git> [bitcoin] sipsorcery opened pull request #19842: Update the vcpkg checkout commit ID in appveyor config (master...appveyor-vcpkg-update) https://github.com/bitcoin/bitcoin/pull/19842
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/269a7ccb2784...61b8c04d78fb
< bitcoin-git> bitcoin/master b667a90 practicalswift: tests: Add fuzzing harness for SigHasLowR(...) and ecdsa_signature_parse_d...
< bitcoin-git> bitcoin/master 46fcac1 practicalswift: tests: Add fuzzing harness for ec_seckey_import_der(...) and ec_seckey_exp...
< bitcoin-git> bitcoin/master 61b8c04 MarcoFalke: Merge #19379: tests: Add fuzzing harness for SigHasLowR(...) and ecdsa_sig...
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #19379: tests: Add fuzzing harness for SigHasLowR(...) and ecdsa_signature_parse_der_lax(...) (master...fuzzers-SigHashLowR) https://github.com/bitcoin/bitcoin/pull/19379
< gmaxwell> Does anyone have an actual stock 0.16.x node (or older) running?
< bitcoin-git> [bitcoin] meshcollider pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/61b8c04d78fb...7721b318099e
< bitcoin-git> bitcoin/master 819f10f João Barbosa: wallet, refactor: Immutable CWalletTx::pwallet
< bitcoin-git> bitcoin/master 772ea48 João Barbosa: wallet: Avoid recursive lock in IsTrusted
< bitcoin-git> bitcoin/master 7721b31 Samuel Dobson: Merge #19773: wallet: Avoid recursive lock in IsTrusted
< bitcoin-git> [bitcoin] meshcollider merged pull request #19773: wallet: Avoid recursive lock in IsTrusted (master...2020-08-wallet-istrusted) https://github.com/bitcoin/bitcoin/pull/19773
< bitcoin-git> [bitcoin] meshcollider pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/7721b318099e...f98872f1279e
< bitcoin-git> bitcoin/master 6d1f513 Sjors Provoost: [rpc] fundrawtransaction, walletcreatefundedpsbt lock manually selected co...
< bitcoin-git> bitcoin/master f98872f Samuel Dobson: Merge #18244: rpc: fundrawtransaction and walletcreatefundedpsbt also lock...
< bitcoin-git> [bitcoin] meshcollider merged pull request #18244: rpc: fundrawtransaction and walletcreatefundedpsbt also lock manually selected coins (master...2020/03/rpc_coin_locks) https://github.com/bitcoin/bitcoin/pull/18244
< bitcoin-git> [bitcoin] fanquake opened pull request #19844: remove usage of boost::bind (master...sneak_boost_bind) https://github.com/bitcoin/bitcoin/pull/19844
< hebasto> MarcoFalke: fanquake: mind labeling #19838 ?
< gribble> https://github.com/bitcoin/bitcoin/issues/19838 | Good first issue: Improve thread safety annotation coverage · Issue #19838 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] vasild opened pull request #19845: net: CNetAddr: add support to (un)serialize as ADDRv2 (master...ser_addrv2_cnetaddr) https://github.com/bitcoin/bitcoin/pull/19845
< vasild> I added a new file, but travis complains that the file is missing: https://travis-ci.org/github/bitcoin/bitcoin/jobs/722729138#L3366. I have no idea what's going on. I ran this via my "private" travis and it complained the same. I sneaked a "find ./ ..." in travis scripts and the file is not present indeed. But the file is present when I do a fresh git clone locally.
< vasild> I also tried clearing travis casche on my travis instance (https://travis-ci.org/github/vasild/bitcoin) and it did not fix it
< vasild> cache
< instagibbs> who is actively contributing that knows the fee estimation guts the best?
< aj> instagibbs: got a particular question?
< instagibbs> if a user manually set their min mempool feerate to X, the estimator shouldn't be attempting to give estimates below those rates, yes? Excluding previously generated historical data
< instagibbs> which should decay over time IIRC
< aj> not sure it couldn't get results slightly below that due to bucketing (couldn't make it bug that way when i tried, but didn't try that hard), otherwise i think so
< instagibbs> user was getting 10x "upcharges" between estimated fee calls and wallet calls, seemingly over weeks, was curious how that persisted
< instagibbs> due to them setting a higher min relay fee*
< bitcoin-git> [bitcoin] Zero-1729 opened pull request #19846: build: enable unused member function diagnostic (master...enable-unused-member-function-diagnostic) https://github.com/bitcoin/bitcoin/pull/19846
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/f98872f1279e...c1e0c2ad3b6c
< bitcoin-git> bitcoin/master bd897ce Hennadii Stepanov: scripted-diff: Move previous_release.py to test/get_previous_releases.py
< bitcoin-git> bitcoin/master 0374e82 Hennadii Stepanov: util: Hard code previous release tarball checksums
< bitcoin-git> bitcoin/master c1e0c2a MarcoFalke: Merge #19813: util, ci: Hard code previous release tarball checksums
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #19813: util, ci: Hard code previous release tarball checksums (master...200826-gpg) https://github.com/bitcoin/bitcoin/pull/19813
< aj> instagibbs: probably takes a while for old data to go away; if it was getting the estimate from the long_decay estimator, could be ~100 days for the old data to stop being worth considering?
< aj> instagibbs: maybe two weeks for medium estimator
< aj> instagibbs: (or maybe my maths is wrong; suhas/morcos/jnewbery might have a better idea)
< hebasto> aj: mind looking into #19668 ?
< instagibbs> aj, right i only know roughly when it'll give estimates, not when it stops
< instagibbs> users probably should be taking max(estimatesmartfee, minrelay) when doing their calculations but that's a bit unexpected
< aj> instagibbs: probably the fee estimator should be ignoring anything below minrelayfee, since that's guaranteed to be unusable and baded on old data at best?
< luke-jr> aj: or new data
< luke-jr> aj: or perhaps your minrelayfee just isn't what others are using
< aj> luke-jr: the fee estimator won't see any transactions below your min relay fee, whatever others are using
< luke-jr> hm, true
< instagibbs> (in case anyone wants to take that on)
< bitcoin-git> [bitcoin] promag opened pull request #19847: test: gettxoutproof duplicate txid (master...2020-08-gettxoutproof) https://github.com/bitcoin/bitcoin/pull/19847
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #19848: Remove mempool global from interfaces (master...2008-nomemint) https://github.com/bitcoin/bitcoin/pull/19848
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/c1e0c2ad3b6c...068bc211881c
< bitcoin-git> bitcoin/master a104cae Aaron Clauson: Update the vcpkg checkout commit ID in appveyor config.
< bitcoin-git> bitcoin/master 068bc21 MarcoFalke: Merge #19842: Update the vcpkg checkout commit ID in appveyor config
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #19842: Update the vcpkg checkout commit ID in appveyor config (master...appveyor-vcpkg-update) https://github.com/bitcoin/bitcoin/pull/19842
< sdaftuar> gleb: i've modified the sync-tips-with-feelers idea some, i have two approaches that i implemented
< sdaftuar> gleb: one problem i saw with the sync-tips-with-feelers idea was that feelers are chosen from the new table exclusively, in order to move things to the tried table
< sdaftuar> for ensuring that your tip isn't behind, i think you want to try peers in general, including from the tried table
< sdaftuar> so my first approach was to create a new kind of connection -- i think i called it "chain-sync" in my code, though maybe not a great name -- that is similar to feelers (in that we try every few minutes, on average, and when successfully connected to one we stay connected for about a minute to give headers-sync a chance to happen, and then we always disconnect
< sdaftuar> my alternate approach is a bit different: rather than create a new peer-type, just make a new block-relay-only connection (like feelers, try this once every few minutes), and again give the peer a chance to sync tips by waiting about a minute so that headers sync can occur
< sdaftuar> then, in choosing which block-relay peer to evict, evict either the new connection if it didn't teach you any new blocks, OR if it did, evict your next youngest block-relay peer
< sdaftuar> so this ends up being a block-relay-peer rotation algorithm, in the event that you're learning things from these connections
< sdaftuar> (credit to gmaxwell for suggesting that second approach btw)
< sdaftuar> i think the second approach is probably better, because it lets us actually escape a scenario where we've been partitioned off the honest network
< sdaftuar> the main concern i had was whether we might skew the network graph as a whole to encourage block-relay connections to the fastest (eg mining) nodes, which will be more likely at random to occasionally give us a new block first even when we're not under attack
< sdaftuar> but i've been running that patch for a couple weeks now and haven't yet triggered a scenario where i've evicted an older block-relay peer, so this might be fine
< bitcoin-git> [bitcoin] MarcoFalke pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/068bc211881c...89a8299a14af
< bitcoin-git> bitcoin/master fa93bc1 MarcoFalke: rpc: Remove unused return type from appendCommand
< bitcoin-git> bitcoin/master faaa46d MarcoFalke: rpc: Assert that RPCArg names are equal to CRPCCommand ones (mining)
< bitcoin-git> bitcoin/master fa32c1d MarcoFalke: rpc: Assert that RPCArg names are equal to CRPCCommand ones (zmq)
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #19717: rpc: Assert that RPCArg names are equal to CRPCCommand ones (mining,zmq,rpcdump) (master...2008-rpcMisc) https://github.com/bitcoin/bitcoin/pull/19717
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #19849: Assert that RPCArg names are equal to CRPCCommand ones (blockchain,rawtransaction) (master...2008-rpcAssertNames) https://github.com/bitcoin/bitcoin/pull/19849
< hebasto> aj: thanks for your attention!
< pinheadmz> does the bitcoind wallet ever spend coins that are `untrusted_pending` ?
< achow101> pinheadmz: no
< bitcoin-git> [bitcoin] promag opened pull request #19851: refactor: Extract ParseOpCode from ParseScript (master...2020-08-parseopcode) https://github.com/bitcoin/bitcoin/pull/19851
< bitcoin-git> [bitcoin] laanwj pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/89a8299a14af...e796fdd4cb8e
< bitcoin-git> bitcoin/master e70512a Gregory Sanders: Make ordering of zmq consumption irrelevant to functional test
< bitcoin-git> bitcoin/master 2399a06 Gregory Sanders: Add test case for mempool->block zmq notification
< bitcoin-git> bitcoin/master a0f4f9c Gregory Sanders: Add zmq test for transaction pub during reorg
< bitcoin-git> [bitcoin] laanwj merged pull request #19507: Expand functional zmq transaction tests (master...zmq_testing) https://github.com/bitcoin/bitcoin/pull/19507
< vasild> sipa: MakeUCharSpan() produces a different checksum, I guess because it includes the terminating \0
< sipa> vasild: oh, indeed
< vasild> no need to check?
< sipa> MakeUCharSpan(str).first(15) would work, but is a bit less nice
< vasild> I added -1 somewhere there in the MakeSpanWhatever(~!@) code but it did not compile, anyway the terminating \0 _must_ be the reason :)
< sipa> or you can write: static constexpr unsigned char ONION_PREFIX[15] = "..."; hasher.Write(ONION_PREFIX);
< vasild> let me try first(15)...
< vasild> "error: initializer-string for char array is too long"
< vasild> .first(15) compiles and produces the correct result, and is better than the reinterpret_cast
< vasild> another possibility: static constexpr unsigned char ONION_PREFIX[15]{'.', 'o', 'n', 'i', 'o', 'n', ' ', 'c', 'h', 'e', 'c', 'k', 's', 'u', 'm'};
< vasild> ;-)
< sipa> ugh :)
< sipa> i guess that works, and doesn't even need the 15
< vasild> I rebased the code on top of #19841 and removed the sha3-256 I imported
< gribble> https://github.com/bitcoin/bitcoin/issues/19841 | Implement Keccak and SHA3_256 by sipa · Pull Request #19841 · bitcoin/bitcoin · GitHub
< fjahr> Has anyone investigated/reported the latest annoying Travis Arm64 failures? Examples: https://travis-ci.org/github/bitcoin/bitcoin/builds/722800233 https://travis-ci.org/github/bitcoin/bitcoin/builds/721669033 https://travis-ci.org/github/bitcoin/bitcoin/builds/721637124. Errors after ~ 1h 15min without any failure message I could find. Restarts seemed to solve it but I have restarted #19055 at least 5 times
< fjahr> now. I see other complaints from the past that Arm64 has been slow but at least they have seen some error messages.
< gribble> https://github.com/bitcoin/bitcoin/issues/19055 | Add MuHash3072 implementation by fjahr · Pull Request #19055 · bitcoin/bitcoin · GitHub
< sdaftuar> fjahr: i have notied that as well but don't know what to do about it
< sdaftuar> it had failed on one of my PRs, but restarting fixed it. i just restarted that same job on #19724 for the second time, trying to get a passing run
< gribble> https://github.com/bitcoin/bitcoin/issues/19724 | [net] Cleanup connection types- followups by amitiuttarwar · Pull Request #19724 · bitcoin/bitcoin · GitHub
< sdaftuar> if it is failing on a widespread basis we should probably remove the job until we come up with a way for it to be more robust.
< fjahr> sdaftuar: thanks, I agree. Not sure how widespread the persistent failures are though. I made a report on the community page but I don't have high hopes something is going to come out of it in the short term: https://travis-ci.community/t/arm64-failing-without-message/9775
< sdaftuar> thanks for trying that!
< bitcoin-git> [bitcoin] promag opened pull request #19852: refactor: Avoid duplicate map lookup in ScriptToAsmStr (master...2020-08-scripttoasmstr) https://github.com/bitcoin/bitcoin/pull/19852
< gmaxwell> https://github.com/bitcoin-core/secp256k1/pull/558 looks ready-ish to merge, so if anyone wanted to review ack this updated version that reflects the latest BIP340 changes (even R), it's time!