< ja> very weird, i had a segfault on psbt_updater_test on ubuntu 20.04
< ja> now i wanna report the bug, which configure flags should i use?
< ja> i think i'll just go with --enable-debug
< ja> ah it was a conflict between libdb's
< ja> i guess it is not really worth reporting since the libdb4.8 is third-party (from luke-jr)
< bitcoin-git> [bitcoin] dscotese opened pull request #20951: APS explanation clarified (master...patch-1) https://github.com/bitcoin/bitcoin/pull/20951
< ja> luke-jr: ok, i verified it now. if you have libdb5.3 installed, and libdb4.8 from your ppa, and you build, it will build with no error, but crash on runtime, linked to the wrong libdb
< wumpus> right, if the headers linked against mismatch the implementation version of the library, you'll get an ABI conflict and crashes at best and corruption at worst
< wumpus> if bdb has a version const in the header and a (run time) call to request the version from the library you could potentially add a ssanity check to detect this
< aj> wumpus: seems to, DB_VERSION_{MAJOR,MINOR,PATCH} and db_version(major,minor,patch)
< Talkless> I'm a bit confused about bitcoin/bitcoin and bitcoin-core/gui . So all work goes into gui, and then it's regurarly merged into bitcoin/bicoin ?
< prusnak> Talkless: only GUI work goes into gui
< wumpus> gui PRs and issues should be opened on the GUI repository; it's purely for github metadata, the tree is kept synchronized between both (the merge script pushes to both, for every merge)
< wumpus> aj: that's great
< Talkless> wumpus: iteresting, thansk.
< Talkless> Now I'm struggling on how to setup QtCreator with autotools project...
< wumpus> does anyone still use qt creator?
< wumpus> there's a pro file if you just care about editing the forms: contrib/bitcoin-qt.pro
< hebasto> using Qt Designer for form files only.
< wumpus> yes
< wumpus> or use the stand-alone qt designe
< wumpus> is there *any* entry point in Init where a BDB version sanity check could be called? I guess it could be done on loading the first BDB wallet, but it would be nicer (I think) to quit on startup when such an inconsistency is detected
< wumpus> but I can't find any global 'wallet init' function anymore
< wumpus> WalletInit::ParameterInteraction() maybe
< wumpus> that seems early enough in the startup
< Talkless> wumpus: I use QtCreator daily, probably historically, as I work mostly with Qt
< bitcoin-git> [bitcoin] laanwj opened pull request #20952: wallet: Add BerkeleyDB version sanity check at init time (master...2021-01-berkeleydb-sanity-check) https://github.com/bitcoin/bitcoin/pull/20952
< wumpus> Talkless: oh! I used it last in 2012 or so, in any case, no idea how it works nowadays
< Talkless> wumpus: I'd say it's rather good. Has clang-tidy integration, static analysis on the fly, idunno, pretty neat IDE.
< Talkless> Some refactoring tool, powerfull search, etc.
< wumpus> neat!
< bitcoin-git> [bitcoin] theStack opened pull request #20953: test: dedup zmq test setup code (node restart, topics subscription) (master...2021-zmq_dedup_test_setup_code) https://github.com/bitcoin/bitcoin/pull/20953
< wumpus> the last "real" IDE i've played around with is vscode, it has smome nice fatures and its C++ cross-referencing is pretty good, though day-to-day i mostly stick with vim, out of habit :-)
< sipa> i used eclipse a long time ago, and even used eclipse-cdt for C code... but later reverted back to just text editors
< sipa> editing the actual code.is rarely.the bottleneck
< Talkless> wumpus: I use vim only for single-file quick edits, it's to.. hardcore for me.. :/ . I don't have motivation to configure IDE on it by mysef...
< dongcarl> We should try to get #20939 merged ASAP... All gitian/guix builds are failing because of it right now
< gribble> https://github.com/bitcoin/bitcoin/issues/20939 | build: fix RELOC_SECTION security check for bitcoin-util by fanquake · Pull Request #20939 · bitcoin/bitcoin · GitHub
< dongcarl> I wish there were an IDE that has a built-in UI for doing clang-tidy-powered refactorings... Would be so powerful for things like adding a parameter to a function that's widely used...
< wumpus> dongcarl: will do
< dongcarl> wumpus: thanks!
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/30e664dcce1a...7acda55c4fa6
< bitcoin-git> bitcoin/master c061800 fanquake: build: fix RELOC_SECTION security check for bitcoin-util
< bitcoin-git> bitcoin/master 7acda55 Wladimir J. van der Laan: Merge #20939: build: fix RELOC_SECTION security check for bitcoin-util
< bitcoin-git> [bitcoin] laanwj merged pull request #20939: build: fix RELOC_SECTION security check for bitcoin-util (master...fix_bitcoin_util_reloc_section) https://github.com/bitcoin/bitcoin/pull/20939
< Talkless> dongcarl: qtcreator can scan for various coding guidelines (Cpp Core Guidelines, Google, whatever) and some of them do provide fixes.
< Talkless> dongcarl: but yeah, you are talking about much more powerfull stuff
< wumpus> what i find nice in IDEs is being able to see the documentation and method signatures on mouse over, and variable definitions/types, having an outline, and things like that, though it's mostly useful for unfamiliar codebases
< wumpus> clang-tidy refactoring looks interesting
< dongcarl> Good talk on clang-tidy, why it's great, and why you should only use it judiciously: https://youtu.be/JPnN2c2odNY
< Talkless> wumpus: you mean popup like this: https://i.imgur.com/fBIYpnX.png
< Talkless> but it seems it parses Autotools info wrong, and it's code model does not find any of bitcoin core headers
< Talkless> it's OK with qmake, cmake projects
< bitcoin-git> [bitcoin] kiminuo opened pull request #20954: test: Declare `nodes` type in test_framework.py. (master...feature/202101-test_framework-types) https://github.com/bitcoin/bitcoin/pull/20954
< bitcoin-git> [bitcoin] theStack closed pull request #20523: zmq: deduplicate 'sequence' publisher message creation/sending (master...20201128-zmq-refactor-dedup_sequence_msg_sending) https://github.com/bitcoin/bitcoin/pull/20523