< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #21003: test: Move MakeNoLogFileContext to common libtest_util, and use it in bench (master...2101-benchNoLog) https://github.com/bitcoin/bitcoin/pull/21003
< setpill>
Apologies if this is not the right place to ask, but has any research been done into gitian building of bitcoin core in docker rather than a VM?
< darosior>
setpill: it is supported (pass USE_DOCKER=1 to gitian-builder, see the python script in contrib/)
< wumpus>
setpill: AFAIK it's possible to use docker already... yea what darosior says
< bitcoin-git>
[bitcoin] MarcoFalke closed pull request #21003: test: Move MakeNoLogFileContext to libtest_util, and use it in bench (master...2101-benchNoLog) https://github.com/bitcoin/bitcoin/pull/21003
< stevenroose>
How much is the ECKey impl in the functional test framework tested?
< stevenroose>
I tried to add a method `set_wif` and I verified it's using the correct secret bytes to call `ECKey.set` but it still calculates an unexpected public key.
< stevenroose>
The method is basically this: def set_wif(self, wif): (b, _) = base58_to_bytes(wif); self.set(b[1:33], len(b) == 34)
< wumpus>
i wouldn't assume anything in the test framework itself is tested heavily except for the specific test cases it's used in
< stevenroose>
Eh, had a byte offset because I assumed base58_to_bytes took the version byte off (wif keys can be length 32 and 33 or 33 and 34 depending on the version byte to e there and mine was 33 :D)
< luke-jr>
how well-tested are the tests for the tests for the functional test framework? :P
< bitcoin-git>
[bitcoin] martinus opened pull request #21006: rpc: reduce LOCK(cs_min) scope in rest_block: ~5 times as many requests per second (master...2021-01-reduce-cs_main-lock-in-rest_block) https://github.com/bitcoin/bitcoin/pull/21006
< bitcoin-git>
[bitcoin] MarcoFalke reopened pull request #21003: test: Move MakeNoLogFileContext to libtest_util, and use it in bench (master...2101-benchNoLog) https://github.com/bitcoin/bitcoin/pull/21003