< bitcoin-git> [bitcoin] Jetro-Costa closed pull request #20968: Add simple steps to build BerkeleyDB in debian (master...patch-1) https://github.com/bitcoin/bitcoin/pull/20968
< bitcoin-git> [bitcoin] meshcollider pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/977bec1d93a5...80486e7e2d8c
< bitcoin-git> bitcoin/master ad57fb7 Wladimir J. van der Laan: wallet: Add BerkeleyDB version sanity check at init time
< bitcoin-git> bitcoin/master 80486e7 Samuel Dobson: Merge #20952: wallet: Add BerkeleyDB version sanity check at init time
< bitcoin-git> [bitcoin] meshcollider merged pull request #20952: wallet: Add BerkeleyDB version sanity check at init time (master...2021-01-berkeleydb-sanity-check) https://github.com/bitcoin/bitcoin/pull/20952
< bitcoin-git> [bitcoin] fujicoin opened pull request #20970: Fix a bug that personal signet can not be created. (master...fix-personal-signet) https://github.com/bitcoin/bitcoin/pull/20970
< prayank> Looking for people to review one line added in "Confirm fee bump" pop-up in GUI: https://github.com/bitcoin-core/gui/pull/186
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #20970: Fix a bug that personal signet can not be created. (master...fix-personal-signet) https://github.com/bitcoin/bitcoin/pull/20970
< hebasto> prayank: fyi, also ##bitcoin-core-gui exists
< prayank> Thanks
< vasild> jonatack: https://github.com/bitcoin/bitcoin/pull/20685#issuecomment-763501409 what is that "addnode remove issue"?
< jonatack> vasild: iirc it's one of the issues we discussed while testing together, and another tester from twitter managed to follow the testing setup steps i gave here https://twitter.com/jonatack/status/1351136998854176777?s=20 and reported it too
< vasild> is it the one where the rpc "addnode ... remove" does not disconnect the peer immediately?
< jonatack> it surprises people that addnode onetry doesn't count for addnode remove
< vasild> this behavior is not specific to I2P, same applies to IPv4 addresses on master
< jonatack> "Node could not be removed. It has not been added previously."
< jonatack> right, not specific to i2p
< jonatack> maybe the error message could be clearer
< vasild> two "surprises": 1. "addnode foo onetry" followed by "addnode foo remove" produces an error and 2. "addnode foo add" connects to the node, but then "addnode foo remove" does not disconnect from foo
< vasild> both made sense to me once I understood how it works :) maybe some docs/error messages improvement is warranted indeed
< jonatack> yes. disconnectnode works, addnode remove was either slow or no effect, i don't recall
< vasild> "addnode foo remove" removes foo from the list of "keep connections to these nodes". After being removed from that list foo becomes a normally connected peer, subject to eivction and we will likely not connect to foo after restart. But definitely we will not disconnect from foo immediately due to "addnode foo remove"
< jonatack> oh right, i hadn't looked at the addnode help in a while, and looking at it now, it seems ok as-is but a bit more explanation might not hurt
< vasild> jonatack: https://bpa.st/LTDBA I connected two times to your bitcoin node via i2p on different ports
< vasild> probably now you see two incoming connections from me
< vasild> that is something that needs to be addressed
< jonatack> vasild: yes, saw double conns a couple of days ago, same peer, two peer ids, lasting for a short time https://imgur.com/a/IaFfjCx
< vasild> your port is not listed in that image, may be the same thing or may be different
< jonatack> right now i don't see your inbound i2p peers because i have today's review club PR #20546 built, will reload #20764 after the meeting
< gribble> https://github.com/bitcoin/bitcoin/issues/20546 | policy, wallet, refactor: check for non-representable CFeeRates by jonatack · Pull Request #20546 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/20764 | cli -netinfo peer connections dashboard updates 🎄 ✨ by jonatack · Pull Request #20764 · bitcoin/bitcoin · GitHub
< vasild> jonatack: you can run bitcoin-cli getpeerinfo |jq 'map(select(.network == "i2p")) |map({inbound: .inbound, addr: .addr, addrbind: .addrbind, addrlocal: .addrlocal, network: .network, subver: .subver})'
< jonatack> i see you twice, medea twice, and a third i2p peer once
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #20971: test: Work around libFuzzer deadlock (master...2101-fuzzDeadlock) https://github.com/bitcoin/bitcoin/pull/20971
< jonatack> all 5 inbound
< vasild> yeah, an you probably see the port is different - 1000 and 2000 in my case
< vasild> is medea's port different too?
< vasild> that should be in addrbind
< wumpus> is the proposed change to the release notes in #20951 actually an improvement?
< gribble> https://github.com/bitcoin/bitcoin/issues/20951 | doc: APS explanation clarified in 0.21.0 release notes by dscotese · Pull Request #20951 · bitcoin/bitcoin · GitHub
< jonatack> vasild: they are all 8333
< vasild> hmm, so it must be different thing then - I managed to connect to you twice by using a different port, but medea connected to you twice because...?
< wumpus> jonatack: agree wrt 20951 (for context, the person who opened that PR first mailed me personally about the suggestion, i told them to open a PR instead)
< wumpus> it... doesn't seem like a big improvement of the text, at most a very subtle difference, not sure it warrants a post-hoc release notes change
< wumpus> but it's up to kallewoof
< benthecarman> #proposedmeetingtopic Thoughts on a future IRC meeting discussing taproot activation?
< Talkless> Building bitcoind on Debian Sid with boost 1.74 is kinda annoying with boost warnings: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=980497
< hebasto> ^ the same was with Homebrew's boost 1.74 on macOS; now its version is 1.75 with fixed warnings
< luke-jr> warnings are for developers
< luke-jr> if you're not developing, ignore them or turn them off
< luke-jr> (and devs should know when to ignore deprecation warnings ;)
< Talkless> hebasto: and Debian entered freeze, so.. :/
< luke-jr> not sure what you would expect Debian to change
< luke-jr> they look correct?
< Talkless> hebasto: I really hope patch will be applied to Debian, or users will have to get annoyed for a long time
< luke-jr> ah, I see, it's a boost bug that it even gets there
< Talkless> yes
< luke-jr> still not really a Bitcoin dev issue IMO
< Talkless> yes...
< Talkless> just wantend to "share", now if someone posts github issue agaist Bitcoin, you will know what's up.
< hebasto> Talkless: you could configure with `--enable-suppress-external-warnings`
< Talkless> cool, thanks hebasto
< bitcoin-git> [gui] RandyMcMillan opened pull request #192: fix for #191 (master...191) https://github.com/bitcoin-core/gui/pull/192
< luke-jr> hebasto: re GUI#186, I suspect the ideal solution would be to instead re-open the send in the Send tab editor-style
< gribble> https://github.com/bitcoin/bitcoin/issues/186 | Remove unnecessary line which creates a dependency on wxs png library. by TheBlueMatt · Pull Request #186 · bitcoin/bitcoin · GitHub
< luke-jr> hebasto: then coin control users can select/deselect inputs (with a warning if they try to deselect all common inputs to replaced transactions)
< luke-jr> step 1 might be to start saving a flag in the wallet with CC options
< hebasto> luke-jr: sounds good as a more general solution
< pinheadmz> is BIP125 (RBF) accurate with the implementation? Specifically, is it the absolute fees that are compared between replaces and replacing tx? or the fee rate?
< pinheadmz> absolute fee ^
< pinheadmz> fee rate ^
< pinheadmz> er, the absolute fee is the sum of everything evicted I suppose
< pinheadmz> but does the bip mention the fee RATE of the direct replacement?
< bitcoin-git> [bitcoin] dongcarl opened pull request #20972: locks: Annotate CTxMemPool::check to require cs_main (master...2021-01-CTxMemPool-spendheight-lock-inversion) https://github.com/bitcoin/bitcoin/pull/20972
< viraltaco_> Hi
< viraltaco_> Is there a way to download blocks via torrent or something? The closer to the current block I get the slower it gets 😕
< luke-jr> viraltaco_: #bitcoin
< bitcoin-git> [gui] RandyMcMillan closed pull request #192: fix for #191 (master...191) https://github.com/bitcoin-core/gui/pull/192