< bitcoin-git>
[bitcoin] jnewbery opened pull request #20986: [RFC] docs: update developer notes to discourage very long lines (master...2021-01-no-long-lines) https://github.com/bitcoin/bitcoin/pull/20986
< vasild>
In "High-priority for review" PRs (https://github.com/bitcoin/bitcoin/projects/8) #19203 is listed, but #20788 is not. I think that #20788 would help both #19203 and #20685 - the same (or very similar) Sock class is defined in all 3 PRs. So maybe add #20788 to hi-prio for review?
< wumpus>
the idea behind 'blockers' is exactly that you'd list the root PR if multiple things depend on it
< wumpus>
something i've always liked to have would be a way to link PRs and issues together in a tree (X depends on Y), and visualize that, it would be more helpful sometimes than manaually having to figure this out
< wumpus>
in any case added it
< vasild>
in the GitHub UI there is "Linked issues"
< vasild>
"Successfully merging this pull request may close these issues."
< vasild>
I wonder if we can link PR to PR :)
< wumpus>
yeah, there is some rudimentary support for it
< wumpus>
but i think the only relationship supported is 'fixes X' and 'closes X' ,which is not really always what we're trying to describe here
< wumpus>
[ot] i've installed OTR for encrypted private messaging on IRC, i was surprised how easy it was, at least for weechat, just a matter of loading a python plugin (https://github.com/mmb/weechat-otr)
< wumpus>
vasild: nice!!!
< wumpus>
where does it get the info from?
< vasild>
wumpus: I wrote the graph spec manually
< wumpus>
vasild: oh, right, that works too
< vasild>
manually could be too cumbersome...
< vasild>
otoh anybody can edit the wiki easily
< luke-jr>
wumpus: not everyone uses weechat tho :p
< luke-jr>
personally, I found a half-working unmaintained OTR plugin for ZNC a year or two ago, and patched it to behave as I wanted..
< luke-jr>
(ZNC is a bouncer/proxy, so you can use any client in front of it)
< jonatack>
wumpus: thanks for weechat, installed
< jonatack>
*weechat-otr
< wumpus>
vasild: well it's a good first step, maybe ideally it'd collect the information through the github API out of the open PRs itself, but it's nice to see how easy generating the actual graph is
< wumpus>
luke-jr: for some programs it might be more difficult, but i'd always assumed it still was, having to dig around to find some old unmaintained patch and build the code from scratch... but years have passed since and encryption is much more popular now it makes sense that it's easier now
< luke-jr>
wumpus: sadly, it seems Konversation devs are more interested in adding Matrix garbage
< luke-jr>
why would sendtoaddress with an explicit fee_rate success producing a transaction with a feerate much more than the fee_rate?
< jonatack>
luke-jr: ?
< luke-jr>
jonatack: I'm trying to add tests to wallet_basic, but now suddenly self.log.info("Test sendtoaddress with fee_rate param (explicit fee rate in sat/vB)") breaks
< jonatack>
luke-jr: can you send me a branch to look at?
< luke-jr>
jonatack: I could probably just fork the whole test since this is a one-off compatibility thing, but it's kind of alarming so I wonder if something more subtle is broken