< bitcoin-git> [bitcoin] glozow closed pull request #20895: p2p: mildly discourage peers that violate feefilter (master...p2p-feefilter-violations) https://github.com/bitcoin/bitcoin/pull/20895
< sipa> sdaftuar_: also added a mention of BIP339 in the release notes
< luke-jr> bips.md?
< luke-jr> oh already there too ☺
< HelloShitty> Hello
< HelloShitty> I was suggested to come here to ask for help with an error I am getting while trying to broadcast a raw transaction to the network
< HelloShitty> I have 2 nodes. One is online and the other one is offline (only to create addresses and sign transactions)
< sipa> HelloShitty: ok
< sipa> so far so good
< HelloShitty> So, I create a raw transaction in my online node
< HelloShitty> copy the hex string to the offline node
< HelloShitty> Then sign it with 'signrawtransactionwithkey'
< HelloShitty> copy back the transaction hex to the online node
< HelloShitty> and I try to broacast it to the network, but I get this error:
< HelloShitty> non-mandatory-script-verify-flag (Signature must be zero for failed CHECK(MULTI)SIG operation)
< sipa> this means your signature is invalid, most likely
< sipa> is it a segwit transaction? (spending segwit outputs)?
< HelloShitty> ok, and how can the signature fail?
< HelloShitty> yes, all bc1 addresses
< sipa> is it possible you didn't tell signrawtransactionwithkey what the input amounts were?
< sipa> that goes into the signature, so if it doesn't have that information, the signature will likely be invalid
< sipa> i suggest you use the PSBT RPCs instead; they pass all that information along
< HelloShitty> hum
< HelloShitty> Let me check
< sipa> see doc/psbt.md for more information
< HelloShitty> The amount in the 3rd argument needs to be the input amount?
< HelloShitty> I guess I might have failed there
< HelloShitty> I think I used the amount I wanted to send to the destination address
< sipa> it's an array of the UTXOs being spent
< sipa> the amounts are the amounts of those UTXOs
< HelloShitty> So, if I have 2 outputs, destiniy address and change address, I have to give those two outputs to the signrawtransactionwithkey command?
< sipa> no
< sipa> you have to provide information about the outputs being *spent*
< sipa> not the ones being created; those are already in the raw transaction
< sipa> really, use the PSBT commands
< HelloShitty> meaning that it's actually the utxo from the origin address
< sipa> they do all of this automatically
< sipa> raw transactions are a pain
< HelloShitty> I like to try to do them because they "force" us to know a bit better how things go under the hood
< HelloShitty> I'll try once more, if I fail again, I'll try what you suggested
< sipa> well, for PSBT there is a decodepsbt command that'll tell you exactly what's being passed around
< sipa> but that's a fair point
< sipa> the 3rd argument to signrawtransactionwithkey is ~the output from listunspent on the online machine
< sipa> for the UTXOs being spent
< HelloShitty> yes
< HelloShitty> The sendrawtransaction in now complaining from another thing
< HelloShitty> so the signature is now correct, apparently
< sipa> what error do you get now?
< HelloShitty> min relay fee not met, 0 < 141
< HelloShitty> I set a fee of 28 sats per byte
< HelloShitty> the transaction is 141 bytes
< HelloShitty> vBytes I should say
< sipa> seems you didn't
< HelloShitty> that would be 3948 sats
< HelloShitty> but I used 4000
< HelloShitty> I can show you the decoded transaction
< HelloShitty> woul you take a look at it?
< sipa> maybe the transaction was 141 before you signed it, but now it's larger?
< phantomcircuit> 0 < 141 implies that the fee is actually 0
< HelloShitty> ok, so let me try to clear this once more
< HelloShitty> about the sign command
< HelloShitty> I have this address with lets say 0.05 BTC. I want to send to a new address 0.01 and the change back to the same original address
< HelloShitty> the value I must use in "amount" field of signrawtransactionwithkey is 0.05?
< sipa> addresses are irrelevant
< sipa> what matters is the value of the UTXOs you're spending
< sipa> use PSBT :)
< HelloShitty> ok, but in my case, the original address has only 1 utxo
< HelloShitty> this utxo has 0.05 BTC
< sipa> ok, yes
< HelloShitty> So, this is the value (0.05) I must use in that "amount" field, right?
< sipa> this is getting a bit too long for this channel; i suggest posting on bitcoin.stackexchange.com for help if it still doesn't work
< sipa> yes
< HelloShitty> ok, thank you and I'm sorry
< HelloShitty> sipa:
< HelloShitty> I'm happy, I made it (not with psbt though)
< HelloShitty> but can't tell you what was wrong because I can't tell it myself
< bitcoin-git> [bitcoin] GyanPrakash2483 opened pull request #20897: Update coincontrol.cpp (master...patch-1) https://github.com/bitcoin/bitcoin/pull/20897
< bitcoin-git> [bitcoin] GyanPrakash2483 closed pull request #20897: Update coincontrol.cpp (master...patch-1) https://github.com/bitcoin/bitcoin/pull/20897
< bitcoin-git> [bitcoin] GyanPrakash2483 reopened pull request #20897: Update coincontrol.cpp (master...patch-1) https://github.com/bitcoin/bitcoin/pull/20897
< bitcoin-git> [bitcoin] GyanPrakash2483 closed pull request #20897: Update coincontrol.cpp (master...patch-1) https://github.com/bitcoin/bitcoin/pull/20897
< aj> oh yay, `--enable-suppress-external-warnings` stops clang complaining about qt headers leacking override so i can drop my "stoopid qt" patch. would it make sense to have that on by default with `--enable-werror`?
< bitcoin-git> [bitcoin] fanquake closed pull request #20875: [*.cc,*.cpp] Reduce push_back (master...push-back) https://github.com/bitcoin/bitcoin/pull/20875
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/5574e489631b...708ef4424a65
< bitcoin-git> bitcoin/master 3e61b8c Hennadii Stepanov: doc: Add explicit macdeployqtplus dependencies install step
< bitcoin-git> bitcoin/master 708ef44 fanquake: Merge #20890: doc: Add explicit macdeployqtplus dependencies install step
< bitcoin-git> [bitcoin] fanquake merged pull request #20890: doc: Add explicit macdeployqtplus dependencies install step (master...210108-deploy) https://github.com/bitcoin/bitcoin/pull/20890
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/708ef4424a65...555fc0789d21
< bitcoin-git> bitcoin/master fad327c MarcoFalke: fuzz: net permission flags in net processing
< bitcoin-git> bitcoin/master 555fc07 MarcoFalke: Merge #20881: fuzz: net permission flags in net processing
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #20881: fuzz: net permission flags in net processing (master...2101-fuzzNet) https://github.com/bitcoin/bitcoin/pull/20881
< bitcoin-git> [bitcoin] MarcoFalke pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/555fc0789d21...094402430925
< bitcoin-git> bitcoin/master 7e2beab Jon Atack: gui: create GUIUtil::ConnectionTypeToQString utility function
< bitcoin-git> bitcoin/master 2c19ba2 Jon Atack: gui: replace Direction with Connection Type in peer details
< bitcoin-git> bitcoin/master c95fe6e Hennadii Stepanov: gui: improve connection type tooltip
< bitcoin-git> [gui] MarcoFalke merged pull request #163: Peer details: replace Direction with Connection Type (master...display-peer-conn-types) https://github.com/bitcoin-core/gui/pull/163
< bitcoin-git> [bitcoin] gruve-p closed pull request #20665: Build: update clang patch to use heredoc (master...master) https://github.com/bitcoin/bitcoin/pull/20665
< bitcoin-git> [bitcoin] gruve-p opened pull request #20898: Build: update clang patch to use heredoc (master...heredoc-patch) https://github.com/bitcoin/bitcoin/pull/20898
< bitcoin-git> [bitcoin] gruve-p reopened pull request #20665: Build: update clang patch to use heredoc (master...master) https://github.com/bitcoin/bitcoin/pull/20665
< bitcoin-git> [bitcoin] gruve-p closed pull request #20898: Build: update clang patch to use heredoc (master...heredoc-patch) https://github.com/bitcoin/bitcoin/pull/20898
< elichai2> sipa: fjahr: is `Num3072::limbs` used as LE or BE?
< elichai2> looks like LE :)
< fjahr> elichai2: We are using LE but I think there is no code in Num3072 itself enforcing that.
< fjahr> ah, you found it :)
< fjahr> gave me a good idea for a small refactor I think :)
< bitcoin-git> [gui] jonatack opened pull request #180: Peer details: connection type follow-ups (master...peer-details-connection-type-followups) https://github.com/bitcoin-core/gui/pull/180
< jonatack> if anyone isn't aware: "All v3 Onion Addresses Down After Attack On The Tor Network" https://darknetdaily.com/?p=1030
< luke-jr> broken page
< luke-jr> maybe they shouldn't retire v2 just yet
< jonatack> luke-jr: hm. the page is working for me.
< jonatack> authority nodes ddosed, can’t communicate between themselves to vote and make a consensus
< luke-jr> jonatack: without JS?
< jonatack> luke-jr: no. i use noscript, and temporarily enabled darknetdaily.com and wp.com (but not the google ones) in order to read it
< jnewbery> PRs open for all the board docs (except Jan 2021 board meeting minutes)
< jnewbery> oops