<bitcoin-git>
bitcoin/master 5559cf1 Hennadii Stepanov: doc: Add packages that provide Qt Wayland plugin for Linux
<bitcoin-git>
bitcoin/master 77e77e8 fanquake: Merge bitcoin/bitcoin#22631: doc: Add packages that provide Qt Wayland plu...
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] fanquake merged pull request #22631: doc: Add packages that provide Qt Wayland plugin for Linux (master...210805-wayland) https://github.com/bitcoin/bitcoin/pull/22631
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
<meshcollider>
fanquake: I have to manually adjust it every time now hah
cmirror has quit [Remote host closed the connection]
cmirror has joined #bitcoin-core-dev
<Bullit>
3KWmEuAXy8HauiZRhUJLVdn4eFKvoGCtap restore my balance
gnaf has quit [Ping timeout: 244 seconds]
Yihen has joined #bitcoin-core-dev
homura has joined #bitcoin-core-dev
jarthur has quit [Quit: jarthur]
AaronvanW has quit [Remote host closed the connection]
jarthur has joined #bitcoin-core-dev
homura has quit [Changing host]
homura has joined #bitcoin-core-dev
vysn has quit [Ping timeout: 245 seconds]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] fanquake opened pull request #22859: Replace uses of boost::trim* with locale-independent alternatives (#18130 rebased) (master...18130_rebased) https://github.com/bitcoin/bitcoin/pull/22859
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] fanquake closed pull request #18130: Replace uses of boost::trim* with locale-independent alternatives (master...2020-02-boost-trim) https://github.com/bitcoin/bitcoin/pull/18130
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
jarthur has quit [Quit: jarthur]
goatpig has quit [Quit: Konversation terminated!]
sipsorcery has joined #bitcoin-core-dev
Yihen has quit [Remote host closed the connection]
<bitcoin-git>
bitcoin/master fa2e9de MarcoFalke: test: Check that non-signaling BIP125 tx can be replaced via parent
<bitcoin-git>
bitcoin/master b997dd2 fanquake: Merge bitcoin/bitcoin#22809: test: Check that non-signaling BIP125 tx can ...
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] fanquake merged pull request #22809: test: Check that non-signaling BIP125 tx can be replaced via parent (master...2108-testTxReplace) https://github.com/bitcoin/bitcoin/pull/22809
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
jonatack has joined #bitcoin-core-dev
fch has joined #bitcoin-core-dev
Alina-malina has quit [Ping timeout: 252 seconds]
Alina-malina has joined #bitcoin-core-dev
gnaf has quit [Ping timeout: 252 seconds]
vysn has joined #bitcoin-core-dev
yanmaani has joined #bitcoin-core-dev
yanmaani has quit [Ping timeout: 276 seconds]
yanmaani has joined #bitcoin-core-dev
jespada has quit [Ping timeout: 252 seconds]
jespada has joined #bitcoin-core-dev
fch has quit [Ping timeout: 244 seconds]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] darosior opened pull request #22863: policy: document dust threshold for Taproot outputs (master...dust_threshold_doc) https://github.com/bitcoin/bitcoin/pull/22863
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] darosior closed pull request #22779: policy: correct (lower) the dust threshold for Taproot outputs (master...taproot_dust_limit) https://github.com/bitcoin/bitcoin/pull/22779
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
bitdex has quit [Quit: = ""]
sugarpuff_ has quit []
sugarpuff_ has joined #bitcoin-core-dev
vasild has quit [Remote host closed the connection]
vasild has joined #bitcoin-core-dev
vasild has quit [Remote host closed the connection]
vasild has joined #bitcoin-core-dev
<jonatack>
On the topic of addr monitoring... #22501 has 5 ACKs (and 5 re-ACKs or so after updating it for addr_rate_limited, too) if anyone is in the mood to merge it in...been running it since mid-July
<gribble>
https://github.com/bitcoin/bitcoin/issues/22501 | netinfo: display addr_{processed, rate_limited, relay_enabled} and relaytxes data by jonatack · Pull Request #22501 · bitcoin/bitcoin · GitHub
<jonatack>
after updating it for *addr_relay_enabled
vasild has quit [Remote host closed the connection]
vasild has joined #bitcoin-core-dev
vasild has quit [Ping timeout: 276 seconds]
AaronvanW has joined #bitcoin-core-dev
vasild has joined #bitcoin-core-dev
goatpig has quit [Quit: Konversation terminated!]
goatpig has joined #bitcoin-core-dev
<michaelfolkson>
jonatack: Does seem ready to merge. Happy to test it and add another ACK if needed.
<michaelfolkson>
What was the response to sipa's point? "I'm really not convinced these numbers are sufficiently important to turn into a new field, unless the expectation is that many more things will be added to it."
<michaelfolkson>
Oh I think you ditched those numbers
schmidty has quit []
schmidty has joined #bitcoin-core-dev
Guyver2 has joined #bitcoin-core-dev
hugohn has quit []
hugohn has joined #bitcoin-core-dev
<laanwj>
jonatack: looking at it
homura has left #bitcoin-core-dev [#bitcoin-core-dev]
<jonatack>
michaelfolkson: i read that comment as referring to adding an additional developer-oriented details level, which i agree with, but since i'm close to it from always having a terminal buffer open with it, i'm used to all the detail and wasn't sure if it was becoming hard to grok :)
vnogueira has quit [Remote host closed the connection]
<jonatack>
laanwj: thanks!
vnogueira has joined #bitcoin-core-dev
<jonatack>
michaelfolkson: *i agree with (sipa's comment)
<michaelfolkson>
jonatack: Cool. Always hard to gauge the granularity of fields that people would use/appreciate :)
<gribble>
https://github.com/bitcoin/bitcoin/issues/17526 | Use Single Random Draw In addition to knapsack as coin selection fallback by achow101 · Pull Request #17526 · bitcoin/bitcoin · GitHub
<laanwj>
achow101: added
<laanwj>
anything else to add/remove or that is (almost) ready for merge?
<gene>
been thinking about adding support for cbor RPC, should that idea be floated on the mailing list before starting work?
<hebasto>
provoostenator: 22.0 draft release notes about added nat-pmp support matches a191e23b8e7f0e19fc0359825eb7ca0d47966fa9 commit
<hebasto>
not sure how to mention it in the GUI section nicely
<sipa>
gene: i'd suggest opening an issue, where you describe the advantages, what kind of changes would be required, etc...
<sipa>
the ML would be inappropriate I think, as it's not a protocol issue
<gene>
sipa: thanks, will work on a write-up, and open an issue
<laanwj>
yes, it's not a ML issue, the RPC is specific to the bitcoin core implementation
<gene>
laanwj: that makes sense, just wasn't sure since it would have implications for clients interacting with the core implementation
<laanwj>
i personally don't see much chance that JSON will be replaced
<gene>
right, not a replacement, an addition
saranshsharma has joined #bitcoin-core-dev
<gene>
basically mirroring current RPC on another port that accepts CBOR instead of JSON
hendi has quit []
hendi has joined #bitcoin-core-dev
Talkless has quit [Quit: Konversation terminated!]
<gene>
mainly thinking of it as an advantage for mobile clients, and anyone developing IoT clients
<cfields>
why not just put a proxy translator in the middle?
saranshsharma has quit [Ping timeout: 252 seconds]
<gene>
cfields: thought about doing that, too. writing a small rust program that takes in CBOR, translates to JSON, then passes to current RPC
<gene>
will make sure to include that as an alternative in the issue write-up
<gene>
the proxy has a number of advantages, like not adding more code (and thus attack surface, maintenance cost) to bitcoin core
<gene>
disadvantages would be users would need to install an additional program along with bitcoin core
<gene>
plus the translation overhead, rather than calling into the RPC backend directly from deserialized CBOR
<glozow>
laanwj: thank you for adding!
sipsorcery has joined #bitcoin-core-dev
<laanwj>
gene: what i think you need to specfically elaborate on is that, in the hypothetical case we'd add another interface in parallel to JSON, why CBOR specifically? why is it suited to software like this. e.g. it seems JSON is very well supported in mobile, almost everything uses some javascript kind of thing nowadays.
<gene>
laanwj: ok, will make sure to cover those topics. briefly, CBOR has an RFC, and is becoming the de-facto protocol for data constrained devices. because of the smaller data footprint, it would save mobile/IoT users money on their data plans
<laanwj>
also if it's meant for communication with *remote* clients, it must be tunneled over something else already, so the extra overhead of a proxy isn't that much i'd expect
<cfields>
I dunno about cbor, but json can be deserialized from a stream in realtime. Assuming cbor has the same property, you could potentially multiplex the decode/encode for minimal latency.
<gene>
right, the overhead saving would mostly be for remote clients
<laanwj>
compressing JSON already helps a lot btw
<sipa>
it appears CBOR actually has native support for 64-bit integers
<laanwj>
before you do a lot of work-i fell into that trap once, coming up with some specific binary format for something, compressed JSON actually did slightly better :-)
<sipa>
while JSON only has a rather abstractly defined "number" type
Chris_Stewart_5 has quit [Ping timeout: 245 seconds]
Chris_Stewart_5 has joined #bitcoin-core-dev
<gene>
laanwj: absolutely, that's why I wanted to float the idea before diving in too much deeper
<cfields>
sipa: I've been struggling with this lately. Playing around with rewriting UniValue as a std::variant. The JSON number/string constraints are annoyingly vague.
<gene>
sipa: CBOR also encodes binary data without the need for Base64 encoding, so passing around public keys and other binary data would be much more compact
<laanwj>
sipa: that's a good thing at least, no longer the 'how do we represent monetary amounts' question
<cfields>
s/vague/non-existent/, I guess.
<laanwj>
that said, everything is adapted to how bitcoin core does things now
<laanwj>
it was slightly different in 2012
<sipa>
gene: yes, i assumed that'd be the main objective
<laanwj>
compressing base64 gets pretty close to the original binary size
<jonatack>
laanwj: thanks for adding the node allocator pull to hi-prio. WRT the release notes, the addr rate-limiting and some PRs seem to be missing, will re-check tomorrow morning. In terms of v22.0, there's a (maybe...or maybe not important) edge case I plan to check out tomorrow.
<gene>
laanwj: can do a small implementation of a few RPC calls (trying to get a representative sample), and compare sizes between compressed CBOR and JSON encodings
<laanwj>
gene: okay!
saranshsharma has joined #bitcoin-core-dev
saranshsharma has quit [Ping timeout: 245 seconds]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] martinus closed pull request #22702: Add allocator for node based containers (master...2019-08-bulkpoolallocator) https://github.com/bitcoin/bitcoin/pull/22702
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] martinus reopened pull request #22702: Add allocator for node based containers (master...2019-08-bulkpoolallocator) https://github.com/bitcoin/bitcoin/pull/22702
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
bitdex has joined #bitcoin-core-dev
vysn has joined #bitcoin-core-dev
AaronvanW has quit [Remote host closed the connection]
common has quit [Read error: Connection reset by peer]
common has joined #bitcoin-core-dev
AaronvanW has joined #bitcoin-core-dev
AaronvanW has quit [Ping timeout: 252 seconds]
AaronvanW has joined #bitcoin-core-dev
gene has quit [Quit: gene]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] mjdietzx opened pull request #22867: Extend test coverage of BIP125 and document confusing/inconsistent behavior (master...test_bip125_edge_cases) https://github.com/bitcoin/bitcoin/pull/22867
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
Guyver2 has quit [Quit: Going offline, see ya! (www.adiirc.com)]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] promag opened pull request #22868: wallet: Call load handlers without cs_wallet locked (master...2021-09-wallet-load-lock) https://github.com/bitcoin/bitcoin/pull/22868
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]