AaronvanW has quit [Remote host closed the connection]
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
<achow101>
meshcollider: on second thought, ignore that comment. regenerating keypool only for the upgrade to HD is fine. I mistakenly thought it would have an effect on the HD -> HD_SPLIT upgrade
<achow101>
also, legacy wallet, so who cares
<meshcollider>
achow101: +1 :)
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
Henrik has quit [Read error: Connection reset by peer]
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] meshcollider opened pull request #23097: Run specified functional tests with all matching flags (master...202109_tests_matchall) https://github.com/bitcoin/bitcoin/pull/23097
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
<bitcoin-git>
[bitcoin] Shubhankar-Gambhir closed pull request #23052: test: use miniwallet in test_rpc function in feature_rbf.py (master...master) https://github.com/bitcoin/bitcoin/pull/23052
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
promag has quit [Ping timeout: 265 seconds]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] Shubhankar-Gambhir reopened pull request #23052: test: use miniwallet in test_rpc function in feature_rbf.py (master...master) https://github.com/bitcoin/bitcoin/pull/23052
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
promag has joined #bitcoin-core-dev
saranshsharma has quit [Remote host closed the connection]
nathanael has quit [Quit: connection reset by purr]
nathanael has joined #bitcoin-core-dev
earnestly has joined #bitcoin-core-dev
sipsorcery has quit [Ping timeout: 252 seconds]
Talkless has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
<shiza>
meshcollider: I didn't mean concept ACK, but how your PR is helping me understand functional testing better. Of course I don't have any reason to NACK either.
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
saranshsharma has joined #bitcoin-core-dev
kexkey has quit [Ping timeout: 252 seconds]
kexkey has joined #bitcoin-core-dev
rdbell has joined #bitcoin-core-dev
saranshsharma has quit [Ping timeout: 252 seconds]
<laanwj>
meshcollider: thanks, will take a look
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
rdbell has quit [Ping timeout: 252 seconds]
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
<laanwj>
to be clear i'm not opposed to a behavior change (at some point) with regard to persistence of utxo locks, but, i just think it's not good to do this in one go with introducing the functionality
<laanwj>
it would make the PR needlessly controversial
<bitcoin-git>
bitcoin/master c527893 Samuel Dobson: Allow locked UTXOs to be store in the wallet database
<bitcoin-git>
bitcoin/master f13fc16 Samuel Dobson: Allow lockunspent to store the lock in the wallet DB
<bitcoin-git>
bitcoin/master 719ae92 Samuel Dobson: Update lockunspent tests for lock persistence
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] laanwj merged pull request #23065: Allow UTXO locks to be written to wallet DB (master...202109_lockunspent_persistence) https://github.com/bitcoin/bitcoin/pull/23065
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
Guest33 has joined #bitcoin-core-dev
<shiza>
Functional tests started to cascade erroring once my 2G /tmp/ got completely filled.
<shiza>
I'm taking that as "Bitcoin doesn't support running all of the functional tests suite on temporary directories so small".
<shiza>
And I won't pursue a fix for that. But if I'm doing something wrong, I'll be all eyes.
Guest33 has quit [Quit: Client closed]
Guest95 has joined #bitcoin-core-dev
Guest95 has quit [Client Quit]
<meshcollider>
laanwj: Thanks! And agreed, definitely happy to discuss it further now though as a standalone change.
<laanwj>
shiza: seems like expected behavior, though hopefully the error message why the tests failed is clear so people don't end up going through a debugging rabbit hole
<laanwj>
shiza: i also think it's possible to make the tests use an alternative directory for the temporary output (to be able to run them on systems that have small /tmp by design) but i don't remember exactly how
<shiza>
laanwj: OK OK. I think it didn't give any "drive full" message and simply failed to assert things, but I would look again to be sure.
<laanwj>
ok if not that would be useful to have
kappa has joined #bitcoin-core-dev
<shiza>
ok
promag has quit [Remote host closed the connection]
promag has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
Guest67 has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
promag has quit [Remote host closed the connection]
cmirror has quit [Ping timeout: 252 seconds]
promag has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
promag has quit [Remote host closed the connection]
promag has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
yanmaani has quit [Ping timeout: 276 seconds]
sipsorcery has joined #bitcoin-core-dev
yanmaani has joined #bitcoin-core-dev
Guest92 has joined #bitcoin-core-dev
jonatack has joined #bitcoin-core-dev
Guest92 has left #bitcoin-core-dev [#bitcoin-core-dev]
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
saranshsharma has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
saranshsharma has quit [Ping timeout: 265 seconds]
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] katesalazar opened pull request #23100: Abort tests early upon filling the test logs drive (master...20210926) https://github.com/bitcoin/bitcoin/pull/23100
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]