<fanquake>
I'm certain this was solved but it seems to have reappeared
Chris_Stewart_5 has quit [Remote host closed the connection]
Chris_Stewart_5 has joined #bitcoin-core-dev
grndslm has quit [Quit: Leaving]
Chris_Stewart_5 has quit [Remote host closed the connection]
Chris_Stewart_5 has joined #bitcoin-core-dev
Chris_Stewart_5 has quit [Remote host closed the connection]
Chris_Stewart_5 has joined #bitcoin-core-dev
Chris_Stewart_5 has quit [Remote host closed the connection]
Chris_Stewart_5 has joined #bitcoin-core-dev
Chris_Stewart_5 has quit [Remote host closed the connection]
Chris_Stewart_5 has joined #bitcoin-core-dev
Chris_Stewart_5 has quit [Remote host closed the connection]
Chris_Stewart_5 has joined #bitcoin-core-dev
Chris_Stewart_5 has quit [Remote host closed the connection]
Chris_Stewart_5 has joined #bitcoin-core-dev
Chris_Stewart_5 has quit [Remote host closed the connection]
Chris_Stewart_5 has joined #bitcoin-core-dev
Chris_Stewart_5 has quit [Remote host closed the connection]
Chris_Stewart_5 has joined #bitcoin-core-dev
Chris_Stewart_5 has quit [Remote host closed the connection]
Chris_Stewart_5 has joined #bitcoin-core-dev
Chris_Stewart_5 has quit [Remote host closed the connection]
Chris_Stewart_5 has joined #bitcoin-core-dev
Chris_Stewart_5 has quit [Remote host closed the connection]
Chris_Stewart_5 has joined #bitcoin-core-dev
Chris_Stewart_5 has quit [Remote host closed the connection]
Chris_Stewart_5 has joined #bitcoin-core-dev
Chris_Stewart_5 has quit [Remote host closed the connection]
Chris_Stewart_5 has joined #bitcoin-core-dev
Chris_Stewart_5 has quit [Remote host closed the connection]
Chris_Stewart_5 has joined #bitcoin-core-dev
dermoth has quit [Ping timeout: 265 seconds]
Chris_Stewart_5 has quit [Remote host closed the connection]
Chris_Stewart_5 has joined #bitcoin-core-dev
bitdex has joined #bitcoin-core-dev
Chris_Stewart_5 has quit [Remote host closed the connection]
Chris_Stewart_5 has joined #bitcoin-core-dev
Chris_Stewart_5 has quit [Remote host closed the connection]
Chris_Stewart_5 has joined #bitcoin-core-dev
Chris_Stewart_5 has quit [Remote host closed the connection]
Chris_Stewart_5 has joined #bitcoin-core-dev
Chris_Stewart_5 has quit [Remote host closed the connection]
Chris_Stewart_5 has joined #bitcoin-core-dev
dermoth has joined #bitcoin-core-dev
Chris_Stewart_5 has quit [Remote host closed the connection]
Chris_Stewart_5 has joined #bitcoin-core-dev
Chris_Stewart_5 has quit [Remote host closed the connection]
Chris_Stewart_5 has joined #bitcoin-core-dev
Chris_Stewart_5 has quit [Remote host closed the connection]
Chris_Stewart_5 has joined #bitcoin-core-dev
Chris_Stewart_5 has quit [Remote host closed the connection]
Chris_Stewart_5 has joined #bitcoin-core-dev
Chris_Stewart_5 has quit [Remote host closed the connection]
Chris_Stewart_5 has joined #bitcoin-core-dev
Chris_Stewart_5 has quit [Remote host closed the connection]
Chris_Stewart_5 has joined #bitcoin-core-dev
Chris_Stewart_5 has quit [Remote host closed the connection]
Chris_Stewart_5 has joined #bitcoin-core-dev
Chris_Stewart_5 has quit [Remote host closed the connection]
Chris_Stewart_5 has joined #bitcoin-core-dev
Chris_Stewart_5 has quit [Remote host closed the connection]
Chris_Stewart_5 has joined #bitcoin-core-dev
Chris_Stewart_5 has quit [Remote host closed the connection]
Chris_Stewart_5 has joined #bitcoin-core-dev
cmirror has quit [Remote host closed the connection]
cmirror has joined #bitcoin-core-dev
Chris_Stewart_5 has quit [Remote host closed the connection]
Chris_Stewart_5 has joined #bitcoin-core-dev
Chris_Stewart_5 has quit [Remote host closed the connection]
Chris_Stewart_5 has joined #bitcoin-core-dev
Chris_Stewart_5 has quit [Remote host closed the connection]
Chris_Stewart_5 has joined #bitcoin-core-dev
Chris_Stewart_5 has quit [Remote host closed the connection]
Chris_Stewart_5 has joined #bitcoin-core-dev
Chris_Stewart_5 has quit [Remote host closed the connection]
Chris_Stewart_5 has joined #bitcoin-core-dev
dviola has quit [Quit: WeeChat 3.2]
Chris_Stewart_5 has quit [Remote host closed the connection]
Chris_Stewart_5 has joined #bitcoin-core-dev
Chris_Stewart_5 has quit [Remote host closed the connection]
Chris_Stewart_5 has joined #bitcoin-core-dev
Chris_Stewart_5 has quit [Remote host closed the connection]
Chris_Stewart_5 has joined #bitcoin-core-dev
Chris_Stewart_5 has quit [Remote host closed the connection]
Chris_Stewart_5 has joined #bitcoin-core-dev
Chris_Stewart_5 has quit [Remote host closed the connection]
Chris_Stewart_5 has joined #bitcoin-core-dev
Chris_Stewart_5 has quit [Remote host closed the connection]
Chris_Stewart_5 has joined #bitcoin-core-dev
Chris_Stewart_5 has quit [Remote host closed the connection]
Chris_Stewart_5 has joined #bitcoin-core-dev
Chris_Stewart_5 has quit [Remote host closed the connection]
Chris_Stewart_5 has joined #bitcoin-core-dev
Chris_Stewart_5 has quit [Remote host closed the connection]
Chris_Stewart_5 has joined #bitcoin-core-dev
Chris_Stewart_5 has quit [Remote host closed the connection]
Chris_Stewart_5 has joined #bitcoin-core-dev
Chris_Stewart_5 has quit [Remote host closed the connection]
Chris_Stewart_5 has joined #bitcoin-core-dev
Chris_Stewart_5 has quit [Remote host closed the connection]
Chris_Stewart_5 has joined #bitcoin-core-dev
Chris_Stewart_5 has quit [Remote host closed the connection]
Chris_Stewart_5 has joined #bitcoin-core-dev
Chris_Stewart_5 has quit [Remote host closed the connection]
Chris_Stewart_5 has joined #bitcoin-core-dev
Chris_Stewart_5 has quit [Remote host closed the connection]
Chris_Stewart_5 has joined #bitcoin-core-dev
Chris_Stewart_5 has quit [Remote host closed the connection]
Chris_Stewart_5 has joined #bitcoin-core-dev
Chris_Stewart_5 has quit [Remote host closed the connection]
Chris_Stewart_5 has joined #bitcoin-core-dev
Chris_Stewart_5 has quit [Remote host closed the connection]
Chris_Stewart_5 has joined #bitcoin-core-dev
Chris_Stewart_5 has quit [Remote host closed the connection]
Chris_Stewart_5 has joined #bitcoin-core-dev
AaronvanW has quit [Quit: Leaving...]
Chris_Stewart_5 has quit [Remote host closed the connection]
Chris_Stewart_5 has joined #bitcoin-core-dev
Chris_Stewart_5 has quit [Remote host closed the connection]
Chris_Stewart_5 has joined #bitcoin-core-dev
Chris_Stewart_5 has quit [Remote host closed the connection]
Chris_Stewart_5 has joined #bitcoin-core-dev
Chris_Stewart_5 has quit [Remote host closed the connection]
Chris_Stewart_5 has joined #bitcoin-core-dev
Chris_Stewart_5 has quit [Remote host closed the connection]
Chris_Stewart_5 has joined #bitcoin-core-dev
Chris_Stewart_5 has quit [Remote host closed the connection]
Chris_Stewart_5 has joined #bitcoin-core-dev
Chris_Stewart_5 has quit [Remote host closed the connection]
Chris_Stewart_5 has joined #bitcoin-core-dev
Chris_Stewart_5 has quit [Remote host closed the connection]
Chris_Stewart_5 has joined #bitcoin-core-dev
Chris_Stewart_5 has quit [Remote host closed the connection]
Chris_Stewart_5 has joined #bitcoin-core-dev
Chris_Stewart_5 has quit [Remote host closed the connection]
Chris_Stewart_5 has joined #bitcoin-core-dev
Chris_Stewart_5 has quit [Remote host closed the connection]
Chris_Stewart_5 has joined #bitcoin-core-dev
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] fanquake opened pull request #22936: test: don't try and use os.killpg() on Windows (master...windows_no_killpg) https://github.com/bitcoin/bitcoin/pull/22936
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
Chris_Stewart_5 has quit [Remote host closed the connection]
Chris_Stewart_5 has joined #bitcoin-core-dev
Chris_Stewart_5 has quit [Remote host closed the connection]
<bitcoin-git>
bitcoin/master c427a58 Hennadii Stepanov: doc: Set PYTHONUTF8=1 for functional tests on Windows
<bitcoin-git>
bitcoin/master b653415 fanquake: Merge bitcoin/bitcoin#22926: doc: Set PYTHONUTF8=1 for functional tests on...
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] fanquake merged pull request #22926: doc: Set PYTHONUTF8=1 for functional tests on Windows (master...210908-utf) https://github.com/bitcoin/bitcoin/pull/22926
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
Chris_Stewart_5 has quit [Remote host closed the connection]
Chris_Stewart_5 has joined #bitcoin-core-dev
Chris_Stewart_5 has quit [Remote host closed the connection]
Chris_Stewart_5 has joined #bitcoin-core-dev
Chris_Stewart_5 has quit [Remote host closed the connection]
Chris_Stewart_5 has joined #bitcoin-core-dev
Chris_Stewart_5 has quit [Remote host closed the connection]
Chris_Stewart_5 has joined #bitcoin-core-dev
Chris_Stewart_5 has quit [Remote host closed the connection]
Chris_Stewart_5 has joined #bitcoin-core-dev
Chris_Stewart_5 has quit [Remote host closed the connection]
Chris_Stewart_5 has joined #bitcoin-core-dev
Chris_Stewart_5 has quit [Remote host closed the connection]
Chris_Stewart_5 has joined #bitcoin-core-dev
Chris_Stewart_5 has quit [Remote host closed the connection]
Chris_Stewart_5 has joined #bitcoin-core-dev
Chris_Stewart_5 has quit [Remote host closed the connection]
Chris_Stewart_5 has joined #bitcoin-core-dev
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
bitcoin/master bfdf4ef John Newbery: [asmap] Remove SanityCheckASMap() from netaddress
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
Chris_Stewart_5 has quit [Remote host closed the connection]
Chris_Stewart_5 has joined #bitcoin-core-dev
<lucaferr>
when doing libsecp256k1 secp256k1_schnorrsig_sign, could the secp256k1_schnorrsig_verify fail for legal inputs? I.e. should these be executed in tandem in a while loop until a successful and verifiable signature is produced?
dr-orlovsky has joined #bitcoin-core-dev
Chris_Stewart_5 has quit [Remote host closed the connection]
Chris_Stewart_5 has joined #bitcoin-core-dev
Chris_Stewart_5 has quit [Remote host closed the connection]
Chris_Stewart_5 has joined #bitcoin-core-dev
Chris_Stewart_5 has quit [Remote host closed the connection]
Chris_Stewart_5 has joined #bitcoin-core-dev
Chris_Stewart_5 has quit [Remote host closed the connection]
Chris_Stewart_5 has joined #bitcoin-core-dev
Chris_Stewart_5 has quit [Remote host closed the connection]
Chris_Stewart_5 has joined #bitcoin-core-dev
Chris_Stewart_5 has quit [Remote host closed the connection]
Chris_Stewart_5 has joined #bitcoin-core-dev
Chris_Stewart_5 has quit [Remote host closed the connection]
<bitcoin-git>
bitcoin/master fa55c3d MarcoFalke: Raise InitError when peers.dat is invalid or corrupted
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] MarcoFalke merged pull request #22762: Raise InitError when peers.dat is invalid or corrupted (master...2108-InitErrorAddrmanCorrupt) https://github.com/bitcoin/bitcoin/pull/22762
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
Chris_Stewart_5 has quit [Remote host closed the connection]
Chris_Stewart_5 has joined #bitcoin-core-dev
smartin has quit [Quit: smartin]
Chris_Stewart_5 has quit [Remote host closed the connection]
Chris_Stewart_5 has joined #bitcoin-core-dev
Chris_Stewart_5 has quit [Remote host closed the connection]
Chris_Stewart_5 has joined #bitcoin-core-dev
Chris_Stewart_5 has quit [Remote host closed the connection]
Chris_Stewart_5 has joined #bitcoin-core-dev
Chris_Stewart_5 has quit [Remote host closed the connection]
Chris_Stewart_5 has joined #bitcoin-core-dev
bomb-on has joined #bitcoin-core-dev
saranshsharma has joined #bitcoin-core-dev
Chris_Stewart_5 has quit [Remote host closed the connection]
Chris_Stewart_5 has joined #bitcoin-core-dev
Chris_Stewart_5 has quit [Remote host closed the connection]
Chris_Stewart_5 has joined #bitcoin-core-dev
saranshsharma has quit [Ping timeout: 252 seconds]
lucaferr has quit [Remote host closed the connection]
Chris_Stewart_5 has quit [Remote host closed the connection]
Chris_Stewart_5 has joined #bitcoin-core-dev
Chris_Stewart_5 has quit [Remote host closed the connection]
Chris_Stewart_5 has joined #bitcoin-core-dev
Chris_Stewart_5 has quit [Remote host closed the connection]
Chris_Stewart_5 has joined #bitcoin-core-dev
Chris_Stewart_5 has quit [Remote host closed the connection]
Chris_Stewart_5 has joined #bitcoin-core-dev
Chris_Stewart_5 has quit [Remote host closed the connection]
Chris_Stewart_5 has joined #bitcoin-core-dev
saranshsharma has joined #bitcoin-core-dev
Chris_Stewart_5 has quit [Remote host closed the connection]
Chris_Stewart_5 has joined #bitcoin-core-dev
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] rajarshimaitra opened pull request #22938: test: Add remaining scenarios of 0 waste, in wallet waste_test (master...waste-test-add) https://github.com/bitcoin/bitcoin/pull/22938
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
Chris_Stewart_5 has quit [Remote host closed the connection]
Chris_Stewart_5 has joined #bitcoin-core-dev
Chris_Stewart_5 has quit [Remote host closed the connection]
Chris_Stewart_5 has joined #bitcoin-core-dev
lucaferr has joined #bitcoin-core-dev
saranshsharma has quit [Ping timeout: 252 seconds]
Chris_Stewart_5 has quit [Remote host closed the connection]
Chris_Stewart_5 has joined #bitcoin-core-dev
Chris_Stewart_5 has quit [Remote host closed the connection]
Chris_Stewart_5 has joined #bitcoin-core-dev
saranshsharma has joined #bitcoin-core-dev
Chris_Stewart_5 has quit [Remote host closed the connection]
Chris_Stewart_5 has joined #bitcoin-core-dev
<meshcollider>
lucaferr: I think if sign returns 1 then verify will always accept the signature it produced
<lucaferr>
meshcollider: ah, thanks. was a bit confused by the wording in the docs.
saranshsharma has quit [Ping timeout: 265 seconds]
Chris_Stewart_5 has quit [Remote host closed the connection]
Chris_Stewart_5 has joined #bitcoin-core-dev
Chris_Stewart_5 has quit [Remote host closed the connection]
Chris_Stewart_5 has joined #bitcoin-core-dev
Chris_Stewart_5 has quit [Remote host closed the connection]
Chris_Stewart_5 has joined #bitcoin-core-dev
Chris_Stewart_5 has quit [Remote host closed the connection]
Chris_Stewart_5 has joined #bitcoin-core-dev
earnestly has quit [Read error: Connection reset by peer]
Chris_Stewart_5 has quit [Remote host closed the connection]
Chris_Stewart_5 has joined #bitcoin-core-dev
bomb-on has quit [Ping timeout: 252 seconds]
Chris_Stewart_5 has quit [Remote host closed the connection]
Chris_Stewart_5 has joined #bitcoin-core-dev
Chris_Stewart_5 has quit [Remote host closed the connection]
Chris_Stewart_5 has joined #bitcoin-core-dev
Chris_Stewart_5 has quit [Remote host closed the connection]
Chris_Stewart_5 has joined #bitcoin-core-dev
saranshsharma has joined #bitcoin-core-dev
Chris_Stewart_5 has quit [Remote host closed the connection]
Chris_Stewart_5 has joined #bitcoin-core-dev
Chris_Stewart_5 has quit [Remote host closed the connection]
saranshsharma has quit [Ping timeout: 252 seconds]
Chris_Stewart_5 has joined #bitcoin-core-dev
saranshsharma has joined #bitcoin-core-dev
Chris_Stewart_5 has quit [Remote host closed the connection]
Chris_Stewart_5 has joined #bitcoin-core-dev
saranshsharma has quit [Ping timeout: 260 seconds]
Chris_Stewart_5 has quit [Remote host closed the connection]
Chris_Stewart_5 has joined #bitcoin-core-dev
Chris_Stewart_5 has quit [Remote host closed the connection]
Chris_Stewart_5 has joined #bitcoin-core-dev
Chris_Stewart_5 has quit [Remote host closed the connection]
saranshsharma has joined #bitcoin-core-dev
saranshsharma has quit [Ping timeout: 252 seconds]
earnestly has joined #bitcoin-core-dev
Guyver2 has joined #bitcoin-core-dev
saranshsharma has joined #bitcoin-core-dev
dviola has joined #bitcoin-core-dev
saranshsharma has quit [Ping timeout: 252 seconds]
sipsorcery has joined #bitcoin-core-dev
gnaf has quit [Quit: Konversation terminated!]
gnaf has joined #bitcoin-core-dev
saranshsharma has joined #bitcoin-core-dev
lucaferr has quit [Remote host closed the connection]
greasefire has quit [Remote host closed the connection]
saranshsharma has quit [Ping timeout: 260 seconds]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] MarcoFalke opened pull request #22939: fuzz: Reset addrman when consistency check fails (master...2109-fuzzAddrmanCheck) https://github.com/bitcoin/bitcoin/pull/22939
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
saranshsharma has joined #bitcoin-core-dev
saranshsharma has quit [Ping timeout: 260 seconds]
sipsorcery has quit [Remote host closed the connection]
sipsorcery has joined #bitcoin-core-dev
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] MarcoFalke opened pull request #22940: fuzz: Move all addrman fuzz targets to one file (master...2109-fuzzMergeAddrman) https://github.com/bitcoin/bitcoin/pull/22940
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
lkqwejhhgasdjhgn has quit [Quit: Konversation terminated!]
saranshsharma has joined #bitcoin-core-dev
saranshsharma has quit [Ping timeout: 265 seconds]
<achow101>
is it necessary to get those into the miniscript repo in order to rebase?
<meshcollider>
The main thing I've been working on there is to make miniscript parsing from strings and decoding from scripts non-recursive
<meshcollider>
achow101: of course I could just merge them in myself and rebase but I think it's better if the PR reflects the miniscript repo so everyone can compare the two
<achow101>
i guess so
<meshcollider>
They aren't huge changes but obviously there are a lot fewer people reviewing changes over there than in core
<achow101>
it's likely they will diverge once review actually gets going
<michaelfolkson>
In what ways were they recursive?
<meshcollider>
So mainly things are just waiting for sipa to have some time
<meshcollider>
michaelfolkson: the current Parse() implementation recurses on every miniscript expression basically
<achow101>
is the miniscript repo being updated/up-to-date with rust-miniscript?
<meshcollider>
Because the tests in master haven't been updated for the new symantics
<michaelfolkson>
That PR is "Update miniscript to bitcoin core...."
<michaelfolkson>
There's not any new semantics in Core is there?
<meshcollider>
michaelfolkson: there are a few other compatibility changes needed to work with the latest core, not in terms of miniscript, but in terms of script.cpp etc.
<michaelfolkson>
Hmm ok
<meshcollider>
IIRC the hex decoding functions and stuff
<meshcollider>
Minor changes but it won't build otherwise
<michaelfolkson>
But better to ignore Core for now and just look at the Miniscript repo with that 58 PR
<michaelfolkson>
(merged)
<meshcollider>
You'll need core to build and run miniscript_tests
<meshcollider>
Any other topics btw?
AaronvanW has quit [Remote host closed the connection]
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
AaronvanW has joined #bitcoin-core-dev
tla2k21 has joined #bitcoin-core-dev
prayank has joined #bitcoin-core-dev
<prayank>
-getinfo runs few RPC, prepare result and print it. Is there anything wrong in using std::min(val1,val2) where val1 and val2 are in the result. And use this minimum number in a function which will be called when we run -getinfo. IDK tried lot of things. There is no error but everything freezes if I use std::min, Ctrl+C in bitcoind terminal gets stuck at "releasing wallets" and I had to reboot everytime I try this.
AaronvanW has quit [Ping timeout: 260 seconds]
<sipa>
that's almost certainly unrelated to the use of std::min(val1,val2)
<prayank>
If I comment that line and use a random number like 100, it works fine.
<sipa>
very hard to say without knowing what your actual code is
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
gnaf has quit [Ping timeout: 252 seconds]
sipsorcery has quit [Ping timeout: 260 seconds]
sipsorcery has joined #bitcoin-core-dev
vysn has quit [Ping timeout: 260 seconds]
Talkless has quit [Quit: Konversation terminated!]
gnaf has joined #bitcoin-core-dev
dongcarl has joined #bitcoin-core-dev
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] JeremyRubin opened pull request #22948: [Tests] Computer the Power Set of all flags instead of one by one exclusion (master...flag-powerset) https://github.com/bitcoin/bitcoin/pull/22948
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]