bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
___nick___ has quit [Ping timeout: 246 seconds]
saranshsharma has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] meshcollider opened pull request #23124: Fix feature_segwit.py failure due to witness (master...202109_fix_feature_segwit) https://github.com/bitcoin/bitcoin/pull/23124
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
saranshsharma has quit [Remote host closed the connection]
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
<fanquake>
Is it just me, or do we have a lot of intermittent CI failures right now
<Amb>
hey all, I am new to opensource... So how to do it? I didn't understand it in contribution.md
c_arc has joined #bitcoin-core-dev
Amb has quit [Quit: Client closed]
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
lukedashjr has joined #bitcoin-core-dev
luke-jr has quit [Ping timeout: 252 seconds]
lukedashjr is now known as luke-jr
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
saranshsharma has joined #bitcoin-core-dev
saranshsharma has quit [Remote host closed the connection]
<bitcoin-git>
bitcoin/master 6fc2cd3 Sebastian Falbesoner: test: introduce helper to create random P2WPKH scriptPubKeys
<bitcoin-git>
bitcoin/master aa26797 Sebastian Falbesoner: test: MiniWallet: add `send_to` method to create arbitrary txouts
<bitcoin-git>
bitcoin/master cfdb6ba Sebastian Falbesoner: test: use MiniWallet for p2p_filter.py
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] MarcoFalke merged pull request #23079: test: use MiniWallet for p2p_filter.py (master...202109-test-use_MiniWallet_for_p2p_filter) https://github.com/bitcoin/bitcoin/pull/23079
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
saranshsharma has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] vincenzopalazzo opened pull request #23127: tests: Use test utils each time that it is possible (master...tests/use_testutils) https://github.com/bitcoin/bitcoin/pull/23127
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
kappa has joined #bitcoin-core-dev
saranshsharma has quit [Remote host closed the connection]
saranshs_ has joined #bitcoin-core-dev
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] dougEfresh closed pull request #23109: net: Bypass increasing nMaxOutbound for peers with download permission (master...max_update_exclude_dl_perm) https://github.com/bitcoin/bitcoin/pull/23109
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
saranshs_ has quit [Ping timeout: 264 seconds]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] dougEfresh opened pull request #23128: doc: Remove TODO 'exclude peers with download permission' (master...remove-todo-max-dl-permission) https://github.com/bitcoin/bitcoin/pull/23128
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
c_arc has joined #bitcoin-core-dev
earnestly has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
yanmaani has quit [Ping timeout: 276 seconds]
vincenzopalazzo has quit [Quit: Bridge terminating on SIGTERM]
Murch[m] has quit [Quit: Bridge terminating on SIGTERM]
Enki[m] has quit [Quit: Bridge terminating on SIGTERM]
tutwidi[m] has quit [Quit: Bridge terminating on SIGTERM]
devrandom has quit [Quit: Bridge terminating on SIGTERM]
xor9[m] has quit [Quit: Bridge terminating on SIGTERM]
merkle_noob[m] has quit [Quit: Bridge terminating on SIGTERM]
vasanth2[m] has quit [Quit: Bridge terminating on SIGTERM]
kakolainen[m] has quit [Quit: Bridge terminating on SIGTERM]
stick[m] has quit [Quit: Bridge terminating on SIGTERM]
RCasatta[m] has quit [Quit: Bridge terminating on SIGTERM]
siv2r[m] has quit [Quit: Bridge terminating on SIGTERM]
cdecker[m] has quit [Quit: Bridge terminating on SIGTERM]
kvaciral[m] has quit [Quit: Bridge terminating on SIGTERM]
<Guest5751>
Hey guys, on Laanwjs's blog he wrote: "In the long run, move away from a website for code distribution completely. No matter who owns it, a website on the clearnet can be shut down with the press of a button, and it seems that the global internet is gearing up to make censorship increasingly easy. We need a decentralized web. For us, one option
<Guest5751>
would be IPFS, which is starting to catch on. For the binaries themselves there’s already the option of downloading through torrents." Do you know if anyone is already hosting Bitcoin's source code on IPFS?
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[gui] hebasto merged pull request #430: Improvements to the open up transaction in third-party link action (master...3party-tx-links-cleanup) https://github.com/bitcoin-core/gui/pull/430
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] naumenkogs closed pull request #18421: Periodically update DNS caches for better privacy of non-reachable nodes (master...2020_03_dns_cache_update) https://github.com/bitcoin/bitcoin/pull/18421
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
masta`` has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
dougEfish has joined #bitcoin-core-dev
<yanmaani>
Has it been discussed to standardize all the argument parsing boilerplate in the RPCs?
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
<yanmaani>
Guest5751, laanwj: IPFS is very bad technologically. ZeroNet is strictly superior to it in all measurable aspects.
<yanmaani>
Though if you're going to run have humans running it, why not just a tor onion service?
<yanmaani>
radicle is based on ethereum. There's been some experimental projects to do Git over BitTorrent, but otherwise doing Git over ZeroNet (or IPFS, sigh...) would work.
<sipa>
vasild: i just read that yesterday; i think at least historically, there is a different argument too... it's not so much the concern of an actually harmful Dos, but some the worry that some webserver say would suddenly get a bunch of incoming connections from bitcoin nodes, and risk that causing negative press or so
<Guest5751>
How did the experiments of Git over BitTorrent go? yanmaani
<yanmaani>
If you want REAL decentralized git, just do it like the linux kernel does. still need a mailing list tho
<yanmaani>
Guest5751: not terribly, but it's not very well-implemented.
<Guest5751>
could you tell me what they do in very simple terms? I will research it myself! yanmaani
<Guest5751>
ohh ok I see yanmaani
<yanmaani>
Basically, the problem is when you update the repo
<yanmaani>
because everyone needs the latest version
<yanmaani>
and that's not super easy - DHT or whatever is not guaranteed, using DNS is centralized, Namecoin requires you to make a blockchain transaction for each new commit
<yanmaani>
I believe ZeroNet already has the local maximum on that.
<Guest5751>
Interesting... Didn't know about many of these technologies. So would you say that Git over ZeroNet is currently the best option?
<yanmaani>
depends on your goal. Git over ZeroNet isn't terribly well-researched, and obviously has downsides, but I don't think it's that difficult to set up. For censorship-resistance, git over Tor is probably better. For "decentralization" (of development), Git over mailing list is better.
<bitcoin-git>
[bitcoin] MarcoFalke merged pull request #23124: Fix feature_segwit.py failure due to witness (master...202109_fix_feature_segwit) https://github.com/bitcoin/bitcoin/pull/23124
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
<Guest5751>
Probably different than what you mean I am guessing? yanmaani
<sipa>
the bitcoin-dev mailing list is for bitcoin development in general; not for development of the bitcoin-core software implementation
<laanwj>
there is a tor onion service for bitcoincore.org
<yanmaani>
Guest5751: in principle no; people could submit PRs there. In practice I think it would bloat it up, though.
<laanwj>
https://lists.linuxfoundation.org/mailman/listinfo/bitcoin-core-dev was originally intended as a mailing list for bitcoin core development but there was no post on it for years, no one actually wants to use a mailing list for development, at some point it was changed to a notification-only list
<yanmaani>
laanwj: you could run a repo over git over tor, I mean.
<yanmaani>
By "using a mailing list", I mean doing git over email, like Linux.
<laanwj>
no opinion on IPFS, i think the is that the torrent with download is enough, there isn't actually a need to have the site on IPFS or such
<laanwj>
i have a (read-only) git mirror for various projects on an onion service
fedecuci has joined #bitcoin-core-dev
<yanmaani>
right, you only need read-only
<yanmaani>
and then writing over mailing list, or usenet, or whatever fancy solution (like FMS or something)
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
<yanmaani>
there you go, decentralization has been attained :)
fedecuci has quit [Client Quit]
Guest5751 has quit [Quit: Client closed]
<laanwj>
i don't think onion services can be considered decentralized-it's only hosted in one place, by one person; it's more of a workaround for people that can't access github for some reason
<yanmaani>
But that's the case for any maintainer system, no? You can't have multiple maintainers very well.
<yanmaani>
even IPFS or ZeroNet will have one guy with the key, in the end.
<laanwj>
the project has multiple maintainers
<laanwj>
i'm not even that active anymore
<yanmaani>
Right, but as a technical matter, there has to be one guy at the top.
<yanmaani>
for adding new maintainers, etc
<laanwj>
i don't think that is necessarily true
<yanmaani>
How would you do it then, like multisig?
<yanmaani>
you need some notion of "X is and isn't bitcoin", right? as a purely practical matter, what with consensus
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
jonatack has joined #bitcoin-core-dev
<vasild>
sipa: hmm
<vasild>
Is anybody running a node on a public IPv4 address that listens on port 8333 with -debug=net? If yes, I wonder how often does it receive new incoming connections, i.e. grep -E 'connection from .+ accepted' debug.log
<vasild>
(-debug=net is needed to get this printout in the log)
<jonatack>
or if the node is already running, then: bitcoin-cli logging '["net"]'
<vasild>
+1
Guest5779 has joined #bitcoin-core-dev
fedecuci has joined #bitcoin-core-dev
Guest5779 has quit [Client Quit]
<vasild>
If we stop preferring nodes that listen on port 8333, then a potential victim.com:80 (gossiped by a malicious actor) would get new connection attempts to their web server at that frequency
<laanwj>
i don't have net debugging enabled as it's very noisy, could enable it temporarily
<vasild>
My node which listens on !=8333 port is getting new incoming connections at a rate 3-4 per minute.
<sipa>
vasild: interesting... mostly non-bitcoin core nodes i assume?
<jonatack>
same. would love the possibility to log only the high-level, lower-frequency events like disconnections without the low-level, high-frequency messages.
<vasild>
sipa: no idea, I just see "connection from 192.3.11.20:42940 accepted" in the log (for example)
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] brunoerg opened pull request #23135: test: Use asset_equal utils where possible in feature_nulldummy (master...2021-09-assert_equal) https://github.com/bitcoin/bitcoin/pull/23135
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
<vasild>
I just enabled debug=net again to get recent data (thanks, jonatack for bitcoin-cli logging '["net"]', I wasn't aware of it (shame!))
<bitcoin-git>
bitcoin/master f1ed1d3 fanquake: bloom: use constexpr where appropriate
<bitcoin-git>
bitcoin/master a11da75 fanquake: bloom: cleanup includes
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
Guyver2 has quit [Ping timeout: 264 seconds]
Guyver2_ is now known as Guyver2
goatpig has quit [Quit: Konversation terminated!]
kappa has quit [Quit: Client closed]
c_arc has joined #bitcoin-core-dev
dunxen_ has quit [Quit: Bye!]
dunxen has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
lightlike has joined #bitcoin-core-dev
<vasild>
So, for 1h, my public_ipv4:non8333port node received 314 incoming connections. That is about 5 per minute.
<vasild>
But that is not very interesting. The interesting is if port is 8333.
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
mikehu44 has joined #bitcoin-core-dev
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] jonatack opened pull request #23136: test: update fee rate assertion helper in the functional test framework (master...update-assert_fee_amount) https://github.com/bitcoin/bitcoin/pull/23136
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
c_arc has joined #bitcoin-core-dev
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[gui] hebasto merged pull request #436: Include vout when copying transaction ID from coin selection (master...202109_coinselection_copy_vout) https://github.com/bitcoin-core/gui/pull/436
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
<bitcoin-git>
bitcoin/master 10c6929 Samuel Dobson: Include vout when copying transaction ID from coin selection
<bitcoin-git>
bitcoin/master 8d83f9c Hennadii Stepanov: Merge bitcoin-core/gui#436: Include vout when copying transaction ID from ...
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
c_arc has joined #bitcoin-core-dev
Aaronvan_ has quit [Ping timeout: 252 seconds]
AaronvanW has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
<laanwj>
eh, we're not very consistent with apt install/apt-get install usage in build-unix.md
<laanwj>
vasild: i'm not sure it is a very good experiment; i could definitely measure how many connections my, fairly busy, public ipv4 node gets, but that won't be indicative for a randomly spammed port 80 address, because no one will ever succesfully connect to it it wil lfall out of peers databases soon?
<laanwj>
or not even really be propagated that much
mikehu44 has quit [Ping timeout: 245 seconds]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] MarcoFalke closed pull request #23115: bloom: use Span instead of std::vector for `insert` and `contains` (master...18985_rebased) https://github.com/bitcoin/bitcoin/pull/23115
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
c_arc has joined #bitcoin-core-dev
mikehu44 has joined #bitcoin-core-dev
<hebasto>
laanwj: for humans `apt install` seems preferable
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
mikehu44 has quit [Client Quit]
c_arc has joined #bitcoin-core-dev
mikehu44 has joined #bitcoin-core-dev
<laanwj>
hebasto: i have no opinion either way, i think the outcome of the last discussion was to stick with 'apt-get', but apparently it's become a mix now
mikehu44 has quit [Ping timeout: 240 seconds]
Victorsueca has quit [Changing host]
Victorsueca has joined #bitcoin-core-dev
yanmaani has quit [Ping timeout: 276 seconds]
mikehu44 has joined #bitcoin-core-dev
mikehu44 has quit [Ping timeout: 245 seconds]
mikehu44 has joined #bitcoin-core-dev
saranshsharma has joined #bitcoin-core-dev
saranshsharma has quit [Ping timeout: 252 seconds]
saranshsharma has joined #bitcoin-core-dev
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
bitcoin/master aaaa37a MarcoFalke: fuzz: Fix memory leak in system fuzz target
Henrik has quit [Quit: My MacBook Air has gone to sleep. ZZZzzz…]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] jonatack opened pull request #23139: rpc: fix "trusted" field in TransactionDescriptionString(), add coverage (master...fix-rpc-trusted-field-help) https://github.com/bitcoin/bitcoin/pull/23139
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
dodo has quit [Remote host closed the connection]
c_arc has joined #bitcoin-core-dev
dodo has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] sipa opened pull request #23140: Make CAddrman::Select_ select buckets, not positions, first (master...202109_addrmanbias) https://github.com/bitcoin/bitcoin/pull/23140
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[gui] hebasto opened pull request #440: Do not require restart if overridden option is modified (master...210929-restart) https://github.com/bitcoin-core/gui/pull/440
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
vysn has quit [Ping timeout: 245 seconds]
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
bomb-on has quit [Quit: aллилѹіа!]
Guyver2 has quit [Quit: Going offline, see ya! (www.adiirc.com)]
c_arc has joined #bitcoin-core-dev
AaronvanW has quit [Remote host closed the connection]
AaronvanW has joined #bitcoin-core-dev
AaronvanW has quit [Ping timeout: 252 seconds]
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
AaronvanW has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
AaronvanW has quit [Ping timeout: 265 seconds]
c_arc has joined #bitcoin-core-dev
prayank has joined #bitcoin-core-dev
AaronvanW has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
bitdex has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
Henrik has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
Keele has quit [Ping timeout: 268 seconds]
c_arc has joined #bitcoin-core-dev
belcher has quit [Ping timeout: 265 seconds]
c_arc has joined #bitcoin-core-dev
c_arc has joined #bitcoin-core-dev
belcher has joined #bitcoin-core-dev
<meshcollider>
I've hit the error `AssertionError: Fee of 0.00000255 BTC too low! (Should be 0.00000256 BTC)` in CI multiple times in the last few days due to the functional tests using round() rather than truncating. #22949 would fix it, but is it worth opening a PR to fix the test in the meantime?
<gribble>
https://github.com/bitcoin/bitcoin/issues/22949 | fee: Round up fee calculation to avoid a lower than expected feerate by achow101 · Pull Request #22949 · bitcoin/bitcoin · GitHub