<bitcoin-git>
[bitcoin] ryanofsky opened pull request #22976: scripted-diff: Rename overloaded int GetArg to GetIntArg (master...pr/intarg) https://github.com/bitcoin/bitcoin/pull/22976
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
vysn has quit [Ping timeout: 268 seconds]
roconnor has quit [Ping timeout: 265 seconds]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[gui] jarolrod opened pull request #423: qt: make initTranslations a member function of BitcoinApplication class (master...move-init-translations) https://github.com/bitcoin-core/gui/pull/423
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
first_mersible has quit [Quit: Leaving]
cmirror has quit [Remote host closed the connection]
cmirror has joined #bitcoin-core-dev
AaronvanW has quit [Quit: Leaving...]
prayank has joined #bitcoin-core-dev
<prayank>
#proposedmeetingtopic use database for `lockunspent`
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
<laanwj>
this must be a github issue, it definitely still enables
bitdex has quit [Remote host closed the connection]
bitdex has joined #bitcoin-core-dev
<laanwj>
(both travis and cirrus are enabled for bitcoin/bitcoin, no idea if travis is still necessary)
tla2k21 has quit [Ping timeout: 276 seconds]
AaronvanW has quit [Remote host closed the connection]
Guyver2 has quit [Quit: Going offline, see ya! (www.adiirc.com)]
<gleb7>
sipa: Do you remember your rationale while introducing stochastic addrman? I was trying to refactor a part related to peer selection, and I'm trying to understand something
<gleb7>
I'm trying to understand why this check triggers a break, while the next checks trigger a continue. You probably meant some difference for the results of these checks, but I don't understand it.
Guest80 has joined #bitcoin-core-dev
Guest80 has quit [Client Quit]
sr_gi has joined #bitcoin-core-dev
lkqwejhhgasdjhgn has joined #bitcoin-core-dev
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] MarcoFalke closed pull request #22940: fuzz: Move all addrman fuzz targets to one file (master...2109-fuzzMergeAddrman) https://github.com/bitcoin/bitcoin/pull/22940
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
<laanwj>
_aj_: afaik we don't make use of any secrets in our CI flow
<_aj_>
laanwj: i assume there's some secret to authenticate "this is the bitcoin project from github" (which might let you corrupt the ccache and blah), but maybe that wasn't one of the ones that got leaked
<laanwj>
_aj_: travis already fails often enough out itself would be even notice someone messing with it :) that said,there's still a .travis.yml in the repository so i guess we're still using it
<_aj_>
laanwj: we were just using it for linting, and dropped it entirely with #20658 maybe? (except not for 0.21 and earlier?)
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
tla2k21 has joined #bitcoin-core-dev
<laanwj>
MarcoFalke: fanquake: do we still need travis enabled on bitcoin/bitcoin?
<fanquake>
laanwj: no we shouldn’t. Appveyor no longer required either if that is still enabled in some way.
<laanwj>
ok, removing it
<laanwj>
"You're all set. A job has been queued to uninstall Travis CI"
<laanwj>
i don't see appveyor in here (might be installed at another level)
<hebasto>
re "Appveyor no longer required either if that is still enabled in some way." -- non-master branches?
<provoostenator>
laanwj: sorry for the torrent whitelist delay: done
lightlike has joined #bitcoin-core-dev
Henrik has joined #bitcoin-core-dev
vysn has quit [Quit: WeeChat 3.2]
vysn has joined #bitcoin-core-dev
<lucaferr_>
are there plans for a dns seed specifically for taproot enabled nodes?
<laanwj>
provoostenator: thank you!
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] hebasto opened pull request #22980: qa: Ignore `--failfast` option of `test_runner.py` on Windows (master...210915-failfast) https://github.com/bitcoin/bitcoin/pull/22980
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
<jnewbery>
gleb7: !IsValid() also stands in for an empty CNetAddress, which can be returned if addrman is empty or a new address is requested and there are no new addresses. In that case, we would want to break into the outer loop again.
<jnewbery>
Now that we're using c++17, we could change Select to return a std::optional<CAddrInfo>, which would be more obvious
<jnewbery>
for IsLocal(), I think we should continue to the next iteration of the inner loop, since calling Select() again could return a useful address
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
Alina-malina has quit [Ping timeout: 252 seconds]
bitdex has quit [Quit: = ""]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] naumenkogs closed pull request #18925: Add extra thread for scheduler, move TorControl and OpenAddedConnections to scheduler (master...2020_05_extra_scheduler_thread) https://github.com/bitcoin/bitcoin/pull/18925
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
ryanofsky has joined #bitcoin-core-dev
bairen has quit [Quit: Konversation terminated!]
bairen has joined #bitcoin-core-dev
bairen has quit [Client Quit]
bairen has joined #bitcoin-core-dev
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] hebasto closed pull request #22980: qa: Ignore `--failfast` option of `test_runner.py` on Windows (master...210915-failfast) https://github.com/bitcoin/bitcoin/pull/22980
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
Alina-malina has joined #bitcoin-core-dev
smartin has quit [Ping timeout: 252 seconds]
<gleb7>
jnewbery: breaking if it's empty makes perfect sense. But for IsLocal or netgroup check, yeah, I would do continue as well
Henrik has joined #bitcoin-core-dev
common has quit [Quit: Leaving]
Henrik has quit [Quit: My MacBook Air has gone to sleep. ZZZzzz…]
lkqwejhhgasdjhgn has quit [Quit: Konversation terminated!]
AaronvanW has joined #bitcoin-core-dev
Talkless has joined #bitcoin-core-dev
Henrik has joined #bitcoin-core-dev
AaronvanW has quit [Remote host closed the connection]
tripleslash is now known as [\\\\\\\\]
[\\\\\\\\] is now known as [\\\]
Henrik has quit [Quit: My MacBook Air has gone to sleep. ZZZzzz…]
AaronvanW has joined #bitcoin-core-dev
Guest63 has joined #bitcoin-core-dev
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] hebasto opened pull request #22987: qa: Fix "RuntimeError: Event loop is closed" on Windows (master...210915-loop) https://github.com/bitcoin/bitcoin/pull/22987
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
Guyver2_ has joined #bitcoin-core-dev
sipsorcery has joined #bitcoin-core-dev
Guyver2 has quit [Ping timeout: 252 seconds]
Guyver2_ is now known as Guyver2
Henrik has joined #bitcoin-core-dev
common has joined #bitcoin-core-dev
<laanwj>
please don't go overboard with this scripted-diff stuff, yes it makes it easier to make changes all over the source base, this doesn't mean you have to (e.g. #22975)
<laanwj>
scripted diff is meant as a tool to make reviewing some kinds of changes easier--it's not meant an incentive to do the kind of 'change for the sake of changing' for code style and other semi-silly reasons we've always resisted
Aaronvan_ has joined #bitcoin-core-dev
AaronvanW has quit [Ping timeout: 252 seconds]
Henrik has quit [Quit: My MacBook Air has gone to sleep. ZZZzzz…]