Kaizen_Kintsugi_ has quit [Ping timeout: 250 seconds]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
rex4539 has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
rex4539 has quit [Ping timeout: 276 seconds]
vasild has quit [Ping timeout: 276 seconds]
vasild has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 256 seconds]
rex4539 has joined #bitcoin-core-dev
rex4539 has quit [Ping timeout: 276 seconds]
rex4539 has joined #bitcoin-core-dev
rex4539 has quit [Ping timeout: 276 seconds]
yanmaani has quit [Ping timeout: 276 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
yanmaani has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 245 seconds]
jarthur has quit [Ping timeout: 240 seconds]
jarthur_ has joined #bitcoin-core-dev
rex4539 has joined #bitcoin-core-dev
vysn has joined #bitcoin-core-dev
jarthur has joined #bitcoin-core-dev
jarthur_ has quit [Ping timeout: 250 seconds]
sdfgsdfg has joined #bitcoin-core-dev
jarthur has quit [Quit: jarthur]
bitdex has quit [Ping timeout: 276 seconds]
bitdex has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 250 seconds]
rex4539 has quit [Ping timeout: 276 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 245 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 250 seconds]
bitdex has quit [Ping timeout: 276 seconds]
bitdex has joined #bitcoin-core-dev
bitdex has quit [Ping timeout: 276 seconds]
rex4539 has joined #bitcoin-core-dev
rex4539 has quit [Ping timeout: 276 seconds]
brunoerg has joined #bitcoin-core-dev
jarthur has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 245 seconds]
bitdex has joined #bitcoin-core-dev
cmirror has quit [Remote host closed the connection]
cmirror has joined #bitcoin-core-dev
mikehu44 has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 250 seconds]
cmirror has quit [*.net *.split]
sudoforge has quit [*.net *.split]
nathanael has quit [*.net *.split]
kexkey has quit [*.net *.split]
Alina-malina has quit [*.net *.split]
DeanGuss has quit [*.net *.split]
infernix has quit [*.net *.split]
dougefish__ has quit [*.net *.split]
Evel-Knievel has quit [*.net *.split]
cold has quit [*.net *.split]
gribble has quit [*.net *.split]
dodo has quit [*.net *.split]
gleb7454386 has quit [*.net *.split]
emcy has quit [*.net *.split]
baldur has quit [*.net *.split]
warren has quit [*.net *.split]
noonien has quit [*.net *.split]
roconnor has quit [*.net *.split]
tripleslash has quit [*.net *.split]
sdfgsdfg has quit [*.net *.split]
luke-jr has quit [*.net *.split]
An0rak has quit [*.net *.split]
grettke has quit [*.net *.split]
tralfaz has quit [*.net *.split]
mutatrum has quit [*.net *.split]
baakeydow has quit [*.net *.split]
boxframes__ has quit [*.net *.split]
rottenstonks has quit [*.net *.split]
BlueMatt has quit [*.net *.split]
hebasto has quit [*.net *.split]
ziggie has quit [*.net *.split]
cornfeedhobo has quit [*.net *.split]
TallTim has quit [*.net *.split]
reardencode has quit [*.net *.split]
common has quit [*.net *.split]
outfox has quit [*.net *.split]
niska has quit [*.net *.split]
dhruv has quit [*.net *.split]
_flood has quit [*.net *.split]
adiabat has quit [*.net *.split]
Keele_ has quit [*.net *.split]
hsmiths has quit [*.net *.split]
sebx2a has quit [*.net *.split]
m011 has quit [*.net *.split]
cncr04s has quit [*.net *.split]
paulo has quit [*.net *.split]
amnrst has quit [*.net *.split]
jeremyrubin has quit [*.net *.split]
jnewbery has quit [*.net *.split]
meshcollider has quit [*.net *.split]
phantomcircuit has quit [*.net *.split]
belcher has quit [*.net *.split]
BUSY has quit [*.net *.split]
MarcoFalke has quit [*.net *.split]
gnusha has quit [*.net *.split]
mjdietzx has quit [*.net *.split]
Evolver has quit [*.net *.split]
FelixWeis has quit [*.net *.split]
elichai2 has quit [*.net *.split]
notmandatory_ has quit [*.net *.split]
dergoegge has quit [*.net *.split]
rodarmor has quit [*.net *.split]
jarthur has quit [Ping timeout: 256 seconds]
mikehu44 has quit [Read error: Connection reset by peer]
mikehu44 has joined #bitcoin-core-dev
jarthur has joined #bitcoin-core-dev
rex4539 has joined #bitcoin-core-dev
rex4539 has quit [Ping timeout: 276 seconds]
cncr04s has joined #bitcoin-core-dev
jeremyrubin has joined #bitcoin-core-dev
amnrst has joined #bitcoin-core-dev
paulo has joined #bitcoin-core-dev
jnewbery has joined #bitcoin-core-dev
meshcollider has joined #bitcoin-core-dev
phantomcircuit has joined #bitcoin-core-dev
belcher has joined #bitcoin-core-dev
BUSY has joined #bitcoin-core-dev
MarcoFalke has joined #bitcoin-core-dev
gnusha has joined #bitcoin-core-dev
An0rak has joined #bitcoin-core-dev
sdfgsdfg has joined #bitcoin-core-dev
grettke has joined #bitcoin-core-dev
tralfaz has joined #bitcoin-core-dev
mutatrum has joined #bitcoin-core-dev
baakeydow has joined #bitcoin-core-dev
boxframes__ has joined #bitcoin-core-dev
rottenstonks has joined #bitcoin-core-dev
BlueMatt has joined #bitcoin-core-dev
hebasto has joined #bitcoin-core-dev
ziggie has joined #bitcoin-core-dev
TallTim has joined #bitcoin-core-dev
cornfeedhobo has joined #bitcoin-core-dev
reardencode has joined #bitcoin-core-dev
dhruv has joined #bitcoin-core-dev
outfox has joined #bitcoin-core-dev
common has joined #bitcoin-core-dev
niska has joined #bitcoin-core-dev
_flood has joined #bitcoin-core-dev
adiabat has joined #bitcoin-core-dev
Keele_ has joined #bitcoin-core-dev
hsmiths has joined #bitcoin-core-dev
sebx2a has joined #bitcoin-core-dev
m011 has joined #bitcoin-core-dev
cmirror has joined #bitcoin-core-dev
nathanael has joined #bitcoin-core-dev
kexkey has joined #bitcoin-core-dev
Alina-malina has joined #bitcoin-core-dev
sudoforge has joined #bitcoin-core-dev
infernix has joined #bitcoin-core-dev
DeanGuss has joined #bitcoin-core-dev
dougefish__ has joined #bitcoin-core-dev
Evel-Knievel has joined #bitcoin-core-dev
cold has joined #bitcoin-core-dev
gribble has joined #bitcoin-core-dev
dodo has joined #bitcoin-core-dev
gleb7454386 has joined #bitcoin-core-dev
emcy has joined #bitcoin-core-dev
baldur has joined #bitcoin-core-dev
warren has joined #bitcoin-core-dev
noonien has joined #bitcoin-core-dev
roconnor has joined #bitcoin-core-dev
tripleslash has joined #bitcoin-core-dev
mjdietzx has joined #bitcoin-core-dev
Evolver has joined #bitcoin-core-dev
FelixWeis has joined #bitcoin-core-dev
elichai2 has joined #bitcoin-core-dev
notmandatory_ has joined #bitcoin-core-dev
dergoegge has joined #bitcoin-core-dev
rodarmor has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 252 seconds]
sdfgsdfg has quit [Quit: ayo yoyo ayo yoyo hololo, hololo.]
grettke has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
brunoerg has joined #bitcoin-core-dev
sudoforge has quit [Ping timeout: 256 seconds]
brunoerg has quit [Ping timeout: 250 seconds]
<vasild>
Shall we target https://github.com/bitcoin/bitcoin/pull/23542 for 23.0? I think there is a consensus that it should be done in general and some discussion about the details - which ports to consider "bad" and where to document/define those.
SpellChecker has quit [Remote host closed the connection]
SpellChecker has joined #bitcoin-core-dev
rex4539 has joined #bitcoin-core-dev
rex4539 has quit [Ping timeout: 276 seconds]
rex4539 has joined #bitcoin-core-dev
sdfgsdfg has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 256 seconds]
sipsorcery has joined #bitcoin-core-dev
vysn has quit [Ping timeout: 252 seconds]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
bitcoin/master 11b9684 Sebastian Falbesoner: test: use MiniWallet for rest_interface.py
<bitcoin-git>
bitcoin/master 438e6f4 Sebastian Falbesoner: test: speedup interface_rest.py by whitelisting peers (immediate tx relay)...
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
<stickies-v>
Would anyone be able to restart the CI on #24098 please? Getting "Unable to connect to archive.ubuntu.com:80" on a few tests, but it seems to be a one-off as other recent pushes don't seem to be affected.
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
brunoerg has joined #bitcoin-core-dev
<laanwj>
stickies-v: done
brunoerg has quit [Ping timeout: 250 seconds]
<jamesob>
is there any reason not to use `.at()` in lieu of `[]`-style indexing into vectors? I've come across some UB as a result of using the latter and, in addition to bounds-checking beforehand, think I should probably change the original code to use .at(). Does that sound right?
kexkey has quit [Ping timeout: 256 seconds]
<sipa>
the obvious reason is that at is slowrr
kexkey has joined #bitcoin-core-dev
vysn has quit [Ping timeout: 245 seconds]
in3rsha has joined #bitcoin-core-dev
<laanwj>
if you do bounds checking beforehand you shouldn't need it in the lookup itself, AFAIK c++ compilers can't generally reason that the bounds checking isn't necessary and remove it
<laanwj>
also at() will throw an exception when the index is out of bounds; this does need to be handled, and documented, we don't use exceptions regularly for error handling in this project, let alone "programmer error" level bugs
<jamesob>
yeah makes sense. Was just annoying to track down silent failures during functional test runs
<jamesob>
(for whatever reason the UB failure in this case wasn't loud)
<laanwj>
i... wouldn't be surprised if there's still places left where exceptions are silently swallowed too
<lightlike>
wouldn't sanitizers catch this if enabled?
<laanwj>
the valgrind CI run should at least turn up out of bounds accesses generally
<laanwj>
yes
mikehu44 has quit [Quit: No Ping reply in 180 seconds.]
mikehu44 has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 252 seconds]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] theStack opened pull request #24238: random: use arc4random on OpenBSD (master...202202-random-use_arc4random_on_OpenBSD) https://github.com/bitcoin/bitcoin/pull/24238
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
mikehu44 has quit [Ping timeout: 252 seconds]
mikehu44 has joined #bitcoin-core-dev
baldur has quit [Ping timeout: 256 seconds]
inersha has joined #bitcoin-core-dev
in3rsha has quit [Ping timeout: 256 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 250 seconds]
baldur has joined #bitcoin-core-dev
sudoforge has joined #bitcoin-core-dev
ZeroMaster has joined #bitcoin-core-dev
sha has joined #bitcoin-core-dev
sha is now known as Guest3637
brunoerg has joined #bitcoin-core-dev
yanmaani has joined #bitcoin-core-dev
mikehu44 has quit [Ping timeout: 252 seconds]
<MarcoFalke>
jamesob: In unit test, fuzz tests and the rpc methods, you can certainly use .at() over [] without any downside
mikehu44 has joined #bitcoin-core-dev
<MarcoFalke>
In validation code probably not, since you want to crash the node, not throw (and catch) an exception
<MarcoFalke>
An assert might be better there
brunoerg has quit [Remote host closed the connection]
<MarcoFalke>
For all other code, it is probably a case-by-case decision on what to do
brunoerg has joined #bitcoin-core-dev
yanmaani has quit [Ping timeout: 276 seconds]
salvatoshi has joined #bitcoin-core-dev
Guest3637 is now known as Sha256
Sha256 is now known as mninja
monlovesmango has joined #bitcoin-core-dev
javed has joined #bitcoin-core-dev
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] mzumsande opened pull request #24239: test: fix ceildiv division by using integers (master...202201_test_ceilingfix) https://github.com/bitcoin/bitcoin/pull/24239
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
<cfields>
does "make -C depends download MULTIPROCESS=1" work for anyone? Looks to me like there's an issue with the urls capnp descriptor.
<MarcoFalke>
cfields: It fetches the wrong file *cxx* as opposed to *c++*
<MarcoFalke>
Doesn't seem to happen with "make" (compile)
<MarcoFalke>
Maybe file an issue?
<cfields>
MarcoFalke: right, seems download_path and download_file are reversed.
<cfields>
I can pr a fix, just wanted to confirm. I guess it never worked?
<MarcoFalke>
It does work when compiling
<MarcoFalke>
There is a CI task that compiles
<cfields>
hmm, wonder how.
<cfields>
will keep poking, thanks.
<MarcoFalke>
I could reproduce the "make download MULTIPROCESS=1" issue, btw
<cfields>
ok, thanks. I wonder if maybe at some point they hosted a "cxx" file as well, so it just happened to work.
salvatoshi has quit [Ping timeout: 250 seconds]
grettke has joined #bitcoin-core-dev
<cfields>
MarcoFalke: huh, you're right, it tries to grab different urls for build and download. something's buggy in the logic there. i will investigate.
<cfields>
or there's some difference, anyway.
random_man has quit [Ping timeout: 256 seconds]
<cfields>
aha, found the real issue. PR'ing.
<MarcoFalke>
:eyes:
<cfields>
thanks for the help MarcoFalke
<MarcoFalke>
heh, sure. I didn't really do anything
Talkless has joined #bitcoin-core-dev
mikehu44 has quit [Quit: No Ping reply in 180 seconds.]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] theuni opened pull request #24240: depends: fix capnp's descriptor for make download (master...fix-capnp-fetch) https://github.com/bitcoin/bitcoin/pull/24240
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
ghost43_ has quit [Quit: Leaving]
ghost43 has joined #bitcoin-core-dev
mikehu44 has joined #bitcoin-core-dev
mikehu44 has quit [Client Quit]
monlovesmango has quit [Remote host closed the connection]
monlovesmango has joined #bitcoin-core-dev
mikehu44 has joined #bitcoin-core-dev
monlovesmango has quit [Remote host closed the connection]
monlovesmango has joined #bitcoin-core-dev
monlovesmango has quit [Remote host closed the connection]
monlovesmango has joined #bitcoin-core-dev
brunoerg has quit [Remote host closed the connection]
<bitcoin-git>
[bitcoin] jarolrod opened pull request #24241: doc: cleanup doc on need of Developer Account to obtain macOS SDK (master...macdeploy-readme-cleanups) https://github.com/bitcoin/bitcoin/pull/24241
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
Talkless has quit [Quit: Konversation terminated!]
jarthur has quit [Quit: jarthur]
___nick___ has joined #bitcoin-core-dev
javed has quit [Quit: Client closed]
goatpig has quit [Remote host closed the connection]