luke-jr has quit [Read error: Connection reset by peer]
luke-jr has joined #bitcoin-core-dev
sipsorcery has quit [Ping timeout: 252 seconds]
brunoerg has joined #bitcoin-core-dev
S3RK has quit [Ping timeout: 256 seconds]
S3RK has joined #bitcoin-core-dev
bitdex has joined #bitcoin-core-dev
ronoaldo has quit [Quit: Konversation terminated!]
brunoerg has quit [Ping timeout: 240 seconds]
grettke has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
m011 has quit [Quit: Updating details, brb]
l_sx01 has joined #bitcoin-core-dev
vysn has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] jamesob opened pull request #24364: refactor: remove duplicate code from BlockAssembler (master...2022-02-ba-dup-code) https://github.com/bitcoin/bitcoin/pull/24364
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
brunoerg has quit [Ping timeout: 252 seconds]
kexkey has quit [Ping timeout: 240 seconds]
kexkey has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
kexkey has quit [Ping timeout: 240 seconds]
bitdex has quit [Ping timeout: 240 seconds]
bitdex has joined #bitcoin-core-dev
<roasbeef>
hey y'all, been finishing up my taproot impl over the past few days, the generated test vectors are amazing so kudos to all that contributed there
<roasbeef>
also the BIP text is superb as well, though I think certain statements/ordering in BIP 342 when it comes to the checksig ops are ambigious
<roasbeef>
for example this line:
<roasbeef>
> For OP_CHECKSIGVERIFY, execution continues without any further changes to the stack.
<roasbeef>
my original interpretation was the the verify op now doesn't pop anything from teh stack and just leaves it there, w/ the new behavior being to only exit if the sig is invalid
<roasbeef>
however test case 44b2a5681330965efa5dadccd65e4296cb9bb54c showed be that isn't the case, and the op is effectively unchanged (checksigverify)
<roasbeef>
what do y'all think of modifying that line to something like this
<roasbeef>
> For CHECKSIGVERIFY, execution continues as normal
<laanwj>
hebasto: maybe, i'm not sure, "change a message" is not really the kind of commit we tend to appreciate from new contributors (especially as they tend to lack the knowledge of the code to make sure it's correct)
mikehu44 has joined #bitcoin-core-dev
<hebasto>
laanwj: you're right
brunoerg has quit [Ping timeout: 252 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
brunoerg has joined #bitcoin-core-dev
sdfgsdfg has joined #bitcoin-core-dev
dongcarl has quit [Ping timeout: 256 seconds]
<jonatack>
laanwj: wrt 23542, potential privacy gain but if many DNS seeds take advantage of it before the seeder and bitcoin core code reading them are updated... be good to have those updated before this release (or the next one)
<jonatack>
(i.e. at the same time)
nanotube has joined #bitcoin-core-dev
dongcarl has joined #bitcoin-core-dev
nanotube has quit [Ping timeout: 256 seconds]
sipsorcery has quit [Ping timeout: 240 seconds]
prayank has joined #bitcoin-core-dev
<prayank>
laanwj: it looks ready for merge with multiple ACKs
prayank has quit [Client Quit]
<jonatack>
hm, upgrading the seeder doesn't seem trivial (and it also doesn't do torv3), and we have alternatives
brunoerg has quit [Ping timeout: 252 seconds]
<hebasto>
jonatack: thanks for quick response wrt transifex feedback -- I've resolved both transifex issues
brunoerg has joined #bitcoin-core-dev
vysn has quit [Remote host closed the connection]
brunoerg has quit [Ping timeout: 240 seconds]
brunoerg has joined #bitcoin-core-dev
<jonatack>
hebasto: i'm looking at fixing 24366 too
nanotube has joined #bitcoin-core-dev
<jonatack>
and given current events, the potentially improved privacy and network robustness of 23542 probably outweighs the dns seeds issue, so +1 on having it in 23.0
rex4539 has quit [Remote host closed the connection]
rex4539 has joined #bitcoin-core-dev
<willcl_ark>
It seems unlikely that, on updating to 23.0, many users will suddenly decide to change their listening port from the default, and so there should be time to upgrade the DNS seeding mechanism (or switch to something else). However having this PR merged does mean that there would be a client available that could quickly respond to an ISP-level blocking of port 8333, should something like that occur, which seems advantageous IMO.
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] laanwj merged pull request #24331: util: Revert back `MoveFileExW` call for MinGW-w64 (master...220213-rename) https://github.com/bitcoin/bitcoin/pull/24331
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
kcalvinalvin has joined #bitcoin-core-dev
dviola has quit [Changing host]
dviola has joined #bitcoin-core-dev
mikehu44 has quit [Ping timeout: 240 seconds]
mikehu44 has joined #bitcoin-core-dev
sdfgsdfg has quit [Quit: ayo yoyo ayo yoyo hololo, hololo.]
AaronvanW has joined #bitcoin-core-dev
gossie has joined #bitcoin-core-dev
bitdex has quit [Quit: = ""]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] jonatack opened pull request #24367: User-facing content fixups from transifex translator feedback (master...fixes-based-on-transifex-translator-feedback) https://github.com/bitcoin/bitcoin/pull/24367
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
<hebasto>
as we have not yet updated translations due to reaching "translation string freeze" point, could we consider #24367 for 23.0 assuming finishing reviewing in a couple of days?
<gribble>
https://github.com/bitcoin/bitcoin/issues/24367 | User-facing content and codebase doc fixups from transifex translator feedback by jonatack · Pull Request #24367 · bitcoin/bitcoin · GitHub
brunoerg has quit [Remote host closed the connection]
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 252 seconds]
<laanwj>
i'm starting to feel this syscall-based sandbox is unmaintainable, just too much micro-management
<laanwj>
hebasto: sure...
<hebasto>
laanwj: thanks!
jonatack has quit [Ping timeout: 256 seconds]
<laanwj>
had a functional test fail on ubuntu 22.04 without any idea why, turns out it's a mysterious crash that happens only with -sandbox=log-and-abort, which is the default
AaronvanW has quit [Remote host closed the connection]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] jonatack opened pull request #24370: doc: mention quality filter in getnodeaddresses and -addrinfo helps (master...mention-quality-filter-in-getnodeaddresses-and-addrinfo) https://github.com/bitcoin/bitcoin/pull/24370
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
<vasild>
laanwj: I think it will be long time before #23542 makes an impact (widespread non-8333 listening ports), if ever. So, from this point of view, it is ok wrt the DNS seeds limitation and it is ok to have it in 23.0. OTOH, I do not think that it is urgent.
<sipa>
I agree. I don't expect that dns seeds will be a concern for a long time.
<vasild>
IMO it is fine either way (include or not include it in 23.0)
brunoerg has quit [Remote host closed the connection]
mikehu44_ has joined #bitcoin-core-dev
<vasild>
or at least I don't have a strong opinion
<sipa>
This change is mostly getting nodes on the network to be even able to connect out to non-standard ports. When and how to actually start encouraging people running on non-standard ports (or even getting rid of the default port concept entirely) is a much longer term thing.
<vasild>
right!
<lightlike>
I agree. As long as we don't start a campaign "everybody move away from the standard port, quickly" it should be fine.
<vasild>
exactly
<sipa>
Also note that DNS seeds aren't a means for getting good nodes on the network in terms of features - they're about finding an initial set of nodes to bootstrap from. Those nodes do get sent GETADDR messages, which get ADDR/ADDRV2 responses, and can convey non-default ports.
<achow101>
Can #24365 be added? It is a bug fix for a crashing issue
<gribble>
https://github.com/bitcoin/bitcoin/issues/24365 | wallet: Dont generate keys for wallets with private keys disabled during upgradewallet by achow101 · Pull Request #24365 · bitcoin/bitcoin · GitHub
<laanwj>
achow101: it's already added
<MarcoFalke>
added
Guest68 has joined #bitcoin-core-dev
Guest68 has quit [Client Quit]
bomb-on has joined #bitcoin-core-dev
<laanwj>
hebasto: i don't know
<jonatack>
have a couple of doc improvements that might be nice ( they may not need to be tagged if doc improvements can be merged anytime)
<laanwj>
hebasto: it was brought up last week though, fairly sure fanquake is working on it
<hebasto>
laanwj: ok
<laanwj>
jonatack: yeah, i think we can just merge those when they're ready
<fanquake>
yes, have been looking at that
<hebasto>
fanquake: is there a chance for 23.0 to be notarized?
brunoerg has quit [Remote host closed the connection]
<achow101>
I think notarization will also require some changes to signapple so it may take some time for me to work that out too
<fanquake>
yes I think we should be able to work it out for 23.0
<laanwj>
great
<luke-jr>
I thought we were intentionally not notarising?
<laanwj>
let's leave that on the milestone then
<hebasto>
luke-jr: could you remind reasons for that?
<luke-jr>
hebasto: IIRC it pinged Apple every time a user launches it?
<hebasto>
yeap, it does, at least once
<laanwj>
as i understand it it does that for every binary that is launched the first time
<luke-jr>
so my understanding was that we intentionally didn't want that, for user privacy
<core-meetingbot`>
Meeting ended Thu Feb 17 19:24:32 2022 UTC.
<b10c>
thanks laanwj!
ghost43 has quit [Remote host closed the connection]
<Murch>
<jonatack> "Murch: sendall is shorter, too!" <- Yep. And I think it might be more obvious what to expect from the RPC before reading the help under the monicker "sendall" than under "sweepwallet"
<bitcoin-git>
bitcoin/master 3a618c1 Andrew Chow: Merge bitcoin/bitcoin#24281: docs: Update to match new default wallet type...
<bitcoin-git>
bitcoin/master 8e9699c Bitcoin Hodler: Update doc to match new default wallet type
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] achow101 merged pull request #24281: docs: Update to match new default wallet type (master...doc-fix-default-wallet) https://github.com/bitcoin/bitcoin/pull/24281
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
ghost43 has quit [Remote host closed the connection]
ghost43 has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 252 seconds]
hashfunc107 has quit [Ping timeout: 256 seconds]
Alina-malina has quit [Ping timeout: 272 seconds]
Alina-malina has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
ghost43 has quit [Remote host closed the connection]
ghost43 has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 256 seconds]
ghost43 has quit [Remote host closed the connection]