<bitcoin-git>
[gui] jonatack opened pull request #549: gui, refactor: use std::chrono for formatDurationStr() helper (master...formatDurationStr-std-chrono) https://github.com/bitcoin-core/gui/pull/549
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
bitdex has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
bitdex has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
meshcollider has joined #bitcoin-core-dev
paulo has joined #bitcoin-core-dev
sipsorcery has quit [Ping timeout: 252 seconds]
sipsorcery has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
sipsorcery has quit [Remote host closed the connection]
ronoaldo has joined #bitcoin-core-dev
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] JeremyRand opened pull request #24345: doc: Release process: fix broken link to Guix building docs (master...guix-link) https://github.com/bitcoin/bitcoin/pull/24345
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
rex4539 has joined #bitcoin-core-dev
bairen has quit [Remote host closed the connection]
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
Guest75 has joined #bitcoin-core-dev
kexkey has quit [Ping timeout: 256 seconds]
kexkey has joined #bitcoin-core-dev
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] MarcoFalke opened pull request #24347: rpc: Fix implicit-integer-sign-change in verifychain (master...2202-rpcInt) https://github.com/bitcoin/bitcoin/pull/24347
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
vysn has quit [Ping timeout: 240 seconds]
Guest75 has quit [Quit: Client closed]
cold has quit [Ping timeout: 240 seconds]
AaronvanW has joined #bitcoin-core-dev
rex4539 has joined #bitcoin-core-dev
<provoostenator>
Was BIP 8 assigned later than BIP 9 with the idea of filling the single digit range in descending order with things that relate to upgrades?
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
<michaelfolkson>
provoostenator: Probably should be in #bitcoin-dev (and I think only luke-jr can answer it) but BIP 148, 149 weren't given single digits and allocated at similar time. But they were entitled to be SegWit specific rather than general activation mechanism
rex4539 has joined #bitcoin-core-dev
brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
<provoostenator>
michaelfolkson: indeed the distinction I was assuming is that it's a generic mechanism. Per soft fork deployment logic is also found in BIP 34, 66, 341
cold has joined #bitcoin-core-dev
<provoostenator>
Can move to #bitcoin-dev if the answer is "complicated" :-)
<yanmaani>
Why doesn't Bitcoin Core sync db after completing ibd?
<yanmaani>
to reproduce: install bitcoin core, sync it until it's like a week behind, close it orderly
<yanmaani>
start bitcoin again, wait for it to sync up, kill it with -9
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
<laanwj>
psa: the feature freeze is today
Kiminuo has joined #bitcoin-core-dev
Kiminuo has quit [Client Quit]
Kiminuo has joined #bitcoin-core-dev
<laanwj>
yanmaani: because flushing is bad for performance (this may matter for mining etc), a one-time utxo cache flush after ibd has been proposed (pretty sure there's some issues and PRs about it if you search around) but it's not something people unconditionally want
<sipa>
@provoostenator In normal circumstances that will still result in a performance hit; most of the benefit the cace provides is in preventing utxos that are created and quickly spent from ever hitting disk at all.
<sipa>
Once you flush to disk, whether you wipe the cache or not, you must deal with writing all the spends of utxos that were flushed.
jonatack has quit [Quit: Connection closed]
<laanwj>
it's nice that all the boost dependencies are header-only now, no need to install boost packages anymore beyond boost-dev (for debian)
brunoerg has quit [Remote host closed the connection]
<sipa>
@laanwj Indeed. And with the musl build we'll even be able to create fully standalone binaries that aren't huge.
brunoerg has joined #bitcoin-core-dev
bitdex has quit [Quit: = ""]
brunoerg has quit [Ping timeout: 252 seconds]
SpellChecker has joined #bitcoin-core-dev
test_ is now known as _flood
brunoerg has joined #bitcoin-core-dev
<Kiminuo>
Is the header-only Boost generated using some script? I mean do they have .h and .cpp files and somehow do some magic to generate .h files only?
<hebasto>
only `*.h` files
<hebasto>
in our depends they are just copied from source
<hebasto>
to be precise --- `*.hpp` files
brunoerg has quit [Ping timeout: 240 seconds]
jonatack has joined #bitcoin-core-dev
<sipa>
the boost test framework just supports both headers-only and library-linked modes
<sipa>
this isn't true for all of boost; most of its modules only support one of the twi
<sipa>
two
mikehu44_ has joined #bitcoin-core-dev
mikehu44 has quit [Ping timeout: 252 seconds]
vasild has quit [Remote host closed the connection]
vasild has joined #bitcoin-core-dev
<laanwj>
yeah its just that generic algorithms and data structures tend to be header-only, and that's the part of boost remaining, there is no manipulation of boost itself
<sipa>
@willcl_ark All deltas for transactions that aren't currently in the mempool.
<willcl_ark>
Pieter: Ok, thanks, I think I see how it's working now :)
sudoforge has joined #bitcoin-core-dev
luke-jr has quit [Read error: Connection reset by peer]
luke-jr has joined #bitcoin-core-dev
rex4539 has quit [Ping timeout: 240 seconds]
rex4539 has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
<provoostenator>
sipa: I see, so in that case it's a safety/performance trade-off, because _if_ a freshly synced node with a huge db cache crashes, its's very bad
<provoostenator>
But once it's synced, performance isn't as big a deal as during IBD.
<sipa>
Sure, no objection to flushing after IBD, or more frequently, or using this flush-but-not-wipe in certain circumstances as implemented by that PR.
<sipa>
Just as long as we're aware it's a trade-off.
<provoostenator>
I don't know if the "don't wipe" part has any benefit, it's been a while since I read that PR
<sipa>
The last time I benchmarked things (which may have been in 2015 or so...), flushing without wiping generally was barely better than just flushing and wiping, because it results in quickly afterwards still having the cache overflow, triggering a full flush anyway.
gossie has joined #bitcoin-core-dev
brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
yanmaani has quit [Ping timeout: 240 seconds]
gribble has quit [Remote host closed the connection]
brunoerg has quit [Remote host closed the connection]
gribble has joined #bitcoin-core-dev
yanmaani has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Remote host closed the connection]
Talkless has joined #bitcoin-core-dev
vysn has quit [Ping timeout: 240 seconds]
___nick___ has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 252 seconds]
sipsorcery has quit [Ping timeout: 252 seconds]
<luke-jr>
[12:01:42] <yanmaani> Why doesn't Bitcoin Core sync db after completing ibd? <-- that's #15218 (included in Knots)
<bitcoin-git>
bitcoin/master 0243907 Martin Zumsande: index: Don't commit without valid m_best_block_index
<bitcoin-git>
bitcoin/master bfcd60f Martin Zumsande: test: activate all index types in feature_init.py
<bitcoin-git>
bitcoin/master 1e8aa02 MarcoFalke: Merge bitcoin/bitcoin#24117: index: make indices robust against init abort...
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] MarcoFalke merged pull request #24117: index: make indices robust against init aborts (master...202201_index_startup) https://github.com/bitcoin/bitcoin/pull/24117
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
rex4539 has joined #bitcoin-core-dev
rex4539 has quit [Remote host closed the connection]
sipsorcery has joined #bitcoin-core-dev
bomb-on has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
sipsorcery has quit [Ping timeout: 252 seconds]
sipsorcery has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
jonatack has joined #bitcoin-core-dev
<ronoaldo>
I'm not sure if this is the proper place to ask but the bitcoin client qt displays "This is experimental software." when you go to about -> About Bitcoin Core. Is there a goal to consider the software no longer experimental? Like, it won't be experimental when a milestone/feature set is reached.
brunoerg has quit [Remote host closed the connection]
brunoerg has quit [Remote host closed the connection]
anrichp has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
jarthur has joined #bitcoin-core-dev
grettke has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 252 seconds]
___nick___ has quit [Ping timeout: 252 seconds]
brunoerg has joined #bitcoin-core-dev
Talkless has quit [Quit: Konversation terminated!]
Guyver2 has quit [Quit: Going offline, see ya! (www.adiirc.com)]
brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
kexkey has quit [Quit: kexkey]
rex4539 has joined #bitcoin-core-dev
brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
<sipa>
achow101: What do you think about making descriptor->ToPrivateString() just use all available private keys, and never fail, rather than failing if any private key is missing?
<sipa>
In any nontrivial descriptor, you're not ever going to have all private keys.
<sipa>
But exporting the ones you have is still useful.
<earnestly>
Hm, none of the issues which are linked from that 21883 explain anything besides one which states "we're going to leave this as is for now" (and one or two about it not being a complete contrib)
brunoerg has quit [Ping timeout: 252 seconds]
<earnestly>
"I think we're still experimenting", well fair enough then