bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] MarcoFalke closed pull request #19002: docs: Document that 'fee' is unavailable when there are non-wallet inputs (master...202005-docs-fee) https://github.com/bitcoin/bitcoin/pull/19002
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
ghost43 has quit [Remote host closed the connection]
<laanwj>
module 'dns.resolver' has no attribute 'resolve', no of course it wouldn't :)
brunoerg has joined #bitcoin-core-dev
<laanwj>
dns.resolver.get_default_resolver() gives me a Resolver object, but apparently it too doesn't have a 'resolve' method as documented, have i done something to my python
<laanwj>
ohh
<laanwj>
jonatack: your fix for the deprecation message in dd7b5f46d85401254630abf6976f59b5b8eed181 made it not work on Ubuntu 20.04's default version of dns_python
<laanwj>
no worries i'll just get it from pip that should work right, at least in a venv
<provoostenator>
Mmm, I just managed to produce a (signet) transaction from a 1-of-2 multisig (watch-only, external signer) where the min relay fee was not met.
<provoostenator>
On master
<provoostenator>
I'll dig a bit more, might be a regression. Did we change anything in the fee calculation code recently?
flooded is now known as _flood
<provoostenator>
wsh(sortedmulti
<provoostenator>
Crafted in the GUI with the fee rate set to 1.
<provoostenator>
(the GUI should probably use an exclamation mark, not the usual ?, when a transaction status is '0/unconfirmed, not in memory pool')
<laanwj>
provoostenator: anecdotally i've also noticed bitcoin core estimates fees on the low side recently for transactions it makes, haven't encountered not meeting the minrelayfee though
<provoostenator>
Since we've decoupled the wallet from the mempool, this might be a more common situation, e.g. when the mempool is full and a user is patient and sets it to 1 sat / byte)
<provoostenator>
laanwj: I haven't noticed that, but I almost always use a manual fee rate. As I did in this case.
<laanwj>
ok
<provoostenator>
Just a random guess: are we assuming the external signer tries equally hard as we do to keep the ECDSA signature short?
roconnor_ has joined #bitcoin-core-dev
roconnor has quit [Ping timeout: 250 seconds]
brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
<provoostenator>
The signature was 72 bytes (Ledger), whereas our wallet always keeps it <=71 bytes since #13666.
<provoostenator>
So this might not be a regression, but just something I never noticed.
ghost43 has quit [Remote host closed the connection]
ghost43 has joined #bitcoin-core-dev
ghost43 has quit [Remote host closed the connection]
brunoerg has quit [Remote host closed the connection]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] laanwj opened pull request #24417: net: Update hardcoded seeds for 23.x (master...2022-02-hardcoded-seeds-update) https://github.com/bitcoin/bitcoin/pull/24417
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
ghost43 has joined #bitcoin-core-dev
<laanwj>
i'd expect it makes the same assumptions from the external signer
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 250 seconds]
ghost43 has quit [Remote host closed the connection]
ghost43 has joined #bitcoin-core-dev
Guyver2_ has joined #bitcoin-core-dev
Guyver2 has quit [Ping timeout: 240 seconds]
Guyver2_ is now known as Guyver2
kabaum has quit [Ping timeout: 272 seconds]
kinlo has joined #bitcoin-core-dev
<willcl_ark>
What purpose exactly does the `CTransactionRef` serve? e.g. when processing incoming transactions in https://github.com/bitcoin/bitcoin/blob/master/src/net_processing.cpp#L3289 In the subsequent lines we seem to use a combination of `tx` and `ptx` for various operations and I don't see what the distinction is.
brunoerg has joined #bitcoin-core-dev
mikehu44_ has quit [Ping timeout: 256 seconds]
<sipa>
It's a reference-counted pointer to a transaction.
<sipa>
You can copy the CTransactionRef and pass it along, without copying/moving the transaction itself.
<sipa>
When the last CTransactionRef pointing a given CTransaction disappears, the latter is automatically deleted.
<laanwj>
(to do otherwise and not make pessimistic assumptions would require some 'what will be the size of the signature' query to the external signer)
ghost43_ has joined #bitcoin-core-dev
ghost43 has quit [Remote host closed the connection]
ghost43_ has quit [Remote host closed the connection]
ghost43 has joined #bitcoin-core-dev
<willcl_ark>
Thanks Pieter. Are we deciding to use the Ref based on whether the tx has to be passed along in full, and the original (non-ref) in places where we are just calling a method on it, e.g. `tx.HasWitness()`?
<sipa>
you can do anything with a `CTransactionRef` that you can do with a `CTransaction` (e.g. you can use `tx->HasWitness()`, if ptx is of type `CTransactionRef`), but not the other way around.
<sipa>
If you only have a transaction, you can't turn it back into a ref without a copy.
<jonatack>
laanwj: oops, sorry about that. loooooking at the hardcoded seeds update.
<sipa>
So if you want to go "store" a transaction somewhere, it's better to have a CTransactionRef.
<willcl_ark>
Right, ok. I still feel like I'm missing why, after we create our nice ref counted smart pointer, we use the original `tx` again later at all? I was just trying to see if there was any rationale behind that
<sipa>
Generally there are no "bare" CTransactions floating around in the validation/network code, except in tests, I'd expect.
<sipa>
Even e.g. the transactions in a block are CTransactionRefs.
<willcl_ark>
Right
<sipa>
You can dereference a CTransactionRef (`*ptx`) to get the underlying immutable CTransaction.
meshcollider has joined #bitcoin-core-dev
paulo has joined #bitcoin-core-dev
bitcoin-git has joined #bitcoin-core-dev
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
<laanwj>
sipa: thanks
<darosior>
Me neither. I thought about BIP370 (PSBT v2) but that isn't merged and the newly-written descriptor BIPs but they were already implemented previously.
Nekorand has joined #bitcoin-core-dev
<michaelfolkson>
darosior: The descriptor BIPs are in that BIPs doc
<darosior>
michaelfolkson: yea i presumed it's for the changelog
<laanwj>
prayank: Initial is the unprocessed statistics from the input file, i'd suggest refering to the python script to see the implementation of each pass
<jonatack>
prayank: the number of ipv4, ipv6, and onion nodes found in the seeder raw data (initial pass)
<laanwj>
the exact numbers in the different passes aren't important, but the table is printed to be able to see if an absurd number of nodes is lost in some pass (e.g. due to some misconfiguration or bug)
<prayank>
laanwj: jonatack: Thanks
<jonatack>
right, i reckoned it was sanity check monitoring, and info to have an idea of the data quantity and quality
prayank has quit [Quit: irc thread exit]
ghost43_ has quit [Remote host closed the connection]
ghost43 has joined #bitcoin-core-dev
<laanwj>
sipas crawler doesn't index torv3 addresses, so none are coming in
<laanwj>
some are added manually
<sipa>
testnet only has torv3 seed nodes?
<laanwj>
looks like it!
<laanwj>
tbh i'm no longer running a testnet node myself, so haven't personally updated or even looked at testnet info for a long time
<sipa>
Yeah, not complaining, just wondering.
<sipa>
I don't run one either (at least not permanently).
<laanwj>
i'm kinda surprised too
<sipa>
laanwj: It has been that case since your commit ccd4369a23ca78cc348bc66a7a8c69a971ffcbf7 in 2015...
<sipa>
and then last year updated from only torv2 ones to only torv3 ones in 6fe05168587ee818e6ae4483a5984a5893131e44 by jonatack.
jb55 has joined #bitcoin-core-dev
vysn has quit [Ping timeout: 260 seconds]
brunoerg has quit [Remote host closed the connection]
sudoforge has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
<laanwj>
i would guess it was meant to be temporary, at some point there were only stale ipv4/6 ones which were better to remove, and no new ones were ever added
ghost43 has quit [Remote host closed the connection]
ghost43 has joined #bitcoin-core-dev
ghost43 has quit [Remote host closed the connection]
ghost43 has joined #bitcoin-core-dev
brunoerg has quit [Remote host closed the connection]
vasild has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
vasild has joined #bitcoin-core-dev
brunoerg has quit [Remote host closed the connection]
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
Guyver2 has quit [Ping timeout: 256 seconds]
Guyver2_ is now known as Guyver2
brunoerg has joined #bitcoin-core-dev
<achow101>
provoostenator: for watch only wallets, it should be assuming a max sized sig
<achow101>
we only assume low r grinding if the wallet can sign for the coins
<achow101>
(at least, that's how it's supposed to behave)
<achow101>
provoostenator: how far off the feerate did it end up being? From that, you can usually guess how big the coin selection thought the transaction was going to be. There should be something logged in the debug.log as well.
brunoerg has quit [Ping timeout: 240 seconds]
Talkless has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
grettke has joined #bitcoin-core-dev
ghost43 has quit [Remote host closed the connection]
ghost43 has joined #bitcoin-core-dev
rex4539 has quit [Remote host closed the connection]
rex4539 has joined #bitcoin-core-dev
ghost43 has quit [Remote host closed the connection]
ghost43 has joined #bitcoin-core-dev
jonatack has quit [Remote host closed the connection]
vysn has joined #bitcoin-core-dev
rex4539 has quit []
jespada has quit [Read error: Connection reset by peer]
ghost43 has quit [Remote host closed the connection]
brunoerg has quit [Ping timeout: 268 seconds]
ghost43 has joined #bitcoin-core-dev
Guest3 has joined #bitcoin-core-dev
pigeons has joined #bitcoin-core-dev
ghost43_ has joined #bitcoin-core-dev
ghost43 has quit [Ping timeout: 240 seconds]
rex4539 has joined #bitcoin-core-dev
rex4539 has quit [Client Quit]
setpill has quit [Quit: setpill]
jarthur has joined #bitcoin-core-dev
Guest3 has quit [Quit: Client closed]
bomb-on has quit [Read error: Connection reset by peer]
<jeremyrubin>
##ctv-bip-review meeting time
bomb-on has joined #bitcoin-core-dev
ghost43_ has quit [Remote host closed the connection]
ghost43 has joined #bitcoin-core-dev
Talkless has quit [Quit: Konversation terminated!]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
x88x88x has joined #bitcoin-core-dev
Kaizen_K_ has quit [Ping timeout: 256 seconds]
ghost43 has quit [Remote host closed the connection]
ghost43 has joined #bitcoin-core-dev
lukedashjr has joined #bitcoin-core-dev
luke-jr has quit [Ping timeout: 240 seconds]
lukedashjr is now known as luke-jr
Kaizen_Kintsugi_ has quit [Remote host closed the connection]
Guyver2_ has joined #bitcoin-core-dev
realies0 has joined #bitcoin-core-dev
realies has quit [Read error: Connection reset by peer]
realies0 is now known as realies
Guyver2 has quit [Ping timeout: 250 seconds]
Guyver2_ is now known as Guyver2
brunoerg has joined #bitcoin-core-dev
Nekorand has joined #bitcoin-core-dev
ghost43 has quit [Remote host closed the connection]
ghost43 has joined #bitcoin-core-dev
jonatack has joined #bitcoin-core-dev
theStack_ has quit [Ping timeout: 256 seconds]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
Nekorand has quit [Quit: Leaving]
brunoerg has quit [Ping timeout: 245 seconds]
Guyver2 has quit [Quit: Going offline, see ya! (www.adiirc.com)]
brunoerg has joined #bitcoin-core-dev
ghost43 has quit [Remote host closed the connection]
ghost43 has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 250 seconds]
jespada has joined #bitcoin-core-dev
luke-jr has quit [Ping timeout: 240 seconds]
luke-jr has joined #bitcoin-core-dev
luke-jr has quit [Ping timeout: 256 seconds]
lukedashjr has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
ghost43 has quit [Remote host closed the connection]
ghost43 has joined #bitcoin-core-dev
lukedashjr is now known as luke-jr
lukedashjr has joined #bitcoin-core-dev
luke-jr has quit [Ping timeout: 256 seconds]
lukedashjr is now known as luke-jr
lukedashjr has joined #bitcoin-core-dev
luke-jr has quit [Ping timeout: 256 seconds]
jespada has quit [Read error: Connection reset by peer]
luke-jr has joined #bitcoin-core-dev
lukedashjr has quit [Ping timeout: 272 seconds]
lukedashjr has joined #bitcoin-core-dev
luke-jr has quit [Ping timeout: 256 seconds]
lukedashjr is now known as luke-jr
metallicc has joined #bitcoin-core-dev
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[gui] luke-jr opened pull request #557: Revert "qt: Do not use QObject::tr plural syntax for numbers with a unit symbol" (master...gui_numeric_GBs) https://github.com/bitcoin-core/gui/pull/557
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
AaronvanW has quit [Quit: Leaving...]
ghost43 has quit [Remote host closed the connection]
ghost43 has joined #bitcoin-core-dev
ghost43 has quit [Remote host closed the connection]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] jonatack opened pull request #24424: doc: release process chainparams updates (master...release-process-chainparams-updates) https://github.com/bitcoin/bitcoin/pull/24424
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]