brunoerg has quit [Remote host closed the connection]
rex4539 has quit [Ping timeout: 276 seconds]
grettke has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
rex4539 has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
rex4539 has quit [Ping timeout: 276 seconds]
grettke has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 250 seconds]
rex4539 has joined #bitcoin-core-dev
rex4539 has quit [Ping timeout: 276 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
bomb-on has quit [Quit: aллилѹіа!]
brunoerg has joined #bitcoin-core-dev
rex4539 has joined #bitcoin-core-dev
rex4539 has quit [Ping timeout: 276 seconds]
rex4539 has joined #bitcoin-core-dev
rex4539 has quit [Ping timeout: 276 seconds]
rex4539 has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
rex4539 has quit [Ping timeout: 276 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 256 seconds]
kinlo has joined #bitcoin-core-dev
jarthur_ has joined #bitcoin-core-dev
jarthur has quit [Ping timeout: 250 seconds]
grettke has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 250 seconds]
rex4539 has joined #bitcoin-core-dev
grettke has joined #bitcoin-core-dev
rex4539 has quit [Ping timeout: 276 seconds]
brunoerg has joined #bitcoin-core-dev
cmirror has quit [Remote host closed the connection]
cmirror has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 256 seconds]
rex4539 has joined #bitcoin-core-dev
rex4539 has quit [Ping timeout: 276 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 250 seconds]
brunoerg has joined #bitcoin-core-dev
sudoforge has quit [Ping timeout: 256 seconds]
cmirror has quit [Ping timeout: 256 seconds]
boxframes has joined #bitcoin-core-dev
mikehu44 has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 256 seconds]
rex4539 has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 256 seconds]
rex4539 has quit [Ping timeout: 276 seconds]
<laanwj>
the bitcoin core release key expires soon, i guess i'll have to bump it one more time as there may still be a <22.0 release
szkl has quit [Quit: Connection closed for inactivity]
<laanwj>
there's will also be issues with verifying old relelases after it expires, gpg's lack of a concept of "it was valid at the time of signing" continues to be a problem, just like with commit signing
sipsorcery has joined #bitcoin-core-dev
<laanwj>
i could remove the expiration date completely but otoh i kind of like it to expire, because it sends the right signal that it won't be used in the future, and in the hypothetical case someone uses it for new releases it shouldn't be trusted
rex4539 has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
jonatack has quit [Quit: Ping timeout (120 seconds)]
brunoerg has quit [Ping timeout: 250 seconds]
noonien has quit [Ping timeout: 250 seconds]
brunoerg has joined #bitcoin-core-dev
Guyver2 has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
boxframes has quit [Ping timeout: 240 seconds]
Guyver2 has quit [Remote host closed the connection]
Kaizen_Kintsugi_ has quit [Ping timeout: 256 seconds]
AaronvanW has joined #bitcoin-core-dev
sipsorcery has quit [Ping timeout: 240 seconds]
Guyver2 has joined #bitcoin-core-dev
dviola has joined #bitcoin-core-dev
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] hebasto opened pull request #24288: build, refactor: Drop redundant `$(package)_download_file` assignments (master...220208-filename) https://github.com/bitcoin/bitcoin/pull/24288
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
sipsorcery has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 250 seconds]
jonatack has joined #bitcoin-core-dev
mutatrum has quit [Quit: No Ping reply in 180 seconds.]
mutatrum has joined #bitcoin-core-dev
boxframes has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
<provoostenator>
laanwj: do you have an example of git commit for which the key expired?
brunoerg has quit [Ping timeout: 256 seconds]
boxframes has quit [Quit: Leaving]
Saloframes has joined #bitcoin-core-dev
kexkey has quit [Ping timeout: 256 seconds]
kexkey has joined #bitcoin-core-dev
Saloframes has quit [Changing host]
Saloframes has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
<laanwj>
provoostenator: no, not really, but i remember this being a topic of discussion in the past
Guest45 has joined #bitcoin-core-dev
<Guest45>
Здравсвуйте!
<provoostenator>
Ok, git help verify doesn't mention the behavior around expired keys
<laanwj>
it rejects signatures when gpg does, does nothing special around expiry
<Guest45>
Help restore access to the wallet
<provoostenator>
Well it was sane, it would ignore expiration depending on the age of the commit. But I guess that might put too much trust in the commit timestamp.
<provoostenator>
OpenTimeStamps to the rescue?
Guest45 has quit [Quit: Client closed]
dougefish has quit [Ping timeout: 260 seconds]
<provoostenator>
#23790 should be marked for 0.23 imo (and there is a fix in the GUI repo)
Kaizen_Kintsugi_ has quit [Ping timeout: 245 seconds]
bomb-on has joined #bitcoin-core-dev
vasild has quit [Remote host closed the connection]
vasild has joined #bitcoin-core-dev
<laanwj>
provoostenator: right, blindly trusting the commit timestamp would be a bad idea; at the least it would have to look at the ordering of the commits too, although timestamps aren't necessarily monotonically increasing (e.g. some old commits might get merged sometimes), they should be between merge commits though
<laanwj>
there isn't even a command line option to tell gpg to 'verify the signature as if it is this other date', would have to use faketime right now
<laanwj>
i'm surprised there's not something like that in the infamous labyrinth of obscure options that gnupg has
bfsfhkacjzgcytf has quit [Quit: Ping timeout (120 seconds)]
<_aj_>
laanwj: apt-get install faketime ? :)
bfsfhkacjzgcytf has joined #bitcoin-core-dev
yanmaani has joined #bitcoin-core-dev
<laanwj>
sure, just that using a shared library interposer hack seems overkill for something like that
<dongcarl>
Basically bitcoin-chainstate is a binary that, upon invocation with a datadir path as the first argument, will load the datadir, print out information about it, then wait for blocks (encoded in hex) on stdin to call ProcessNewBlock on. THE PROBLEM is that when I start with an empty datadir, and feed it block 1 and block 2, then exit, the next time
<dongcarl>
ryanofsky: Hmmm I think it's called by ProcessNewBlock?
<dongcarl>
It seems like after ProcessNewBlock is called, the rev file is created, so at least that is being persisted
<ryanofsky>
idk, that's just where i'd add the print or breakpoint as a sanity check
<dongcarl>
ryanofsky: True, I will try that out
<sipa>
blk and rev files are written immediately during processing
<sipa>
but block index and chainstate are delayed
<dongcarl>
sipa: Hmmmm, is the tip loaded from blk files or something else?
brunoerg has quit [Remote host closed the connection]
<sipa>
mapBlockIndex is loaded from the block index
brunoerg has joined #bitcoin-core-dev
<sipa>
the blk files aren't used for anything except reading actual block contents from fisk
<sipa>
disk
<dongcarl>
Okay I see, so I need to make sure I'm flushing the block index and chainstate
<ryanofsky>
grep DB_BEST_BLOCK
<sipa>
Yes, if you're not flushing, there is no database, and without database you're at restart back to the same state you were before syncing.
<dongcarl>
ryanofsky: Isn't that only relevant for external indexes?
<ryanofsky>
No external indexes are not exactly in sync with validation code, and have their own independent best block locators
<sipa>
the chainstate has a record that says "i correspond to the utxo set as of block X"
<sipa>
i assume that's what ryan is referring to
<ryanofsky>
yeah i'm referring to the best block in txdb.cpp, not anything in indexes/
<dongcarl>
Oh okay there's a variable named DB_BEST_BLOCK in index/base.cpp as well so I got confused
<dongcarl>
it seems like FlushStateToDisk does take care of flushing the block index and chainstate, so perhaps it's the FlushStateMode that I need to worry about
<dongcarl>
My debugger says that after I feed the block, FlushStateToDisk gets called 3 time: once with NONE, then with IF_NEEDED, then with PERIODIC
<dongcarl>
I'm guessing none of those 3 FlushStateModes actually resulted in a real flush
<jnewbery>
dongcarl: have you seen ForceFlushStateToDisk()?
<jnewbery>
maybe try calling that in your prologue?
sipsorcery has joined #bitcoin-core-dev
<dongcarl>
Ah, that indeed looks like the correct solution given that it's in Shutdown! 😅
brunoerg has quit [Remote host closed the connection]
<jnewbery>
also, isn't it an epilogue? :)
* dongcarl
ducks in shame
<cfields>
that's at least the second time dongcarl has ducked in shame for that, heh.
<dongcarl>
Huzzah! ForceFlushStateToDisk works!
<dongcarl>
Thanks all!
<jnewbery>
🎉
<sipa>
Every beginning is the end of something else.
<dongcarl>
And every end, the beginning of something!
rex4539 has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
arik has joined #bitcoin-core-dev
___nick___ has joined #bitcoin-core-dev
rex4539 has quit [Ping timeout: 276 seconds]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] MarcoFalke opened pull request #24292: Revert "ci: Run fuzzer task for the master branch only" (master...2202-ciFuzz) https://github.com/bitcoin/bitcoin/pull/24292
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]