bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
<laanwj>
Murch: regarding naming, it's easy to misinterpet "sweep" as "sweep an external private key to this wallet" instead of "sweep the entire wallet or a subset of the utxos to *some destination*", i was initially confused as well it might be more common
<laanwj>
PSA: translations for 23.x have been opened
mikehu44 has joined #bitcoin-core-dev
AaronvanW has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
sudoforge has quit [Quit: 404]
cmirror has quit [Ping timeout: 256 seconds]
dviola has quit [Changing host]
dviola has joined #bitcoin-core-dev
sipsorcery has quit [Ping timeout: 240 seconds]
earnestly has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
sipsorcery has joined #bitcoin-core-dev
ghost43 has quit [Remote host closed the connection]
ghost43 has joined #bitcoin-core-dev
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] brunoerg opened pull request #24258: test: check localaddresses in getnetworkinfo for nodes with proxy (master...2022-02-check-localaddresses) https://github.com/bitcoin/bitcoin/pull/24258
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
brunoerg has quit [Remote host closed the connection]
<bitcoin-git>
bitcoin/master f7a19ef Shashwat: qt,refactor: Use std::chrono in TrafficGraphWidget class
<bitcoin-git>
bitcoin/master 5c6b3d5 Hennadii Stepanov: Merge bitcoin-core/gui#524: Replace int with std::chrono in for the timer-...
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[gui] hebasto merged pull request #524: Replace int with std::chrono in for the timer->setInterval() argument (master...220112-chrono) https://github.com/bitcoin-core/gui/pull/524
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
geyaeb has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 256 seconds]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] MarcoFalke closed pull request #23545: scripted-diff: Use clang-tidy syntax for C++ named arguments (master...2109-docNamedArgs) https://github.com/bitcoin/bitcoin/pull/23545
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
dougefish__ has quit [Remote host closed the connection]
brunoerg has quit [Remote host closed the connection]
bomb-on has joined #bitcoin-core-dev
dunxen has quit [Quit: Bye!]
<laanwj>
apparently we didn't do a hardcoded seeds update for 22.0 (at least not for ipv4/ipv6, and we don't really have an automated way to generate hardcoded seeds for torv3/i2p/cjdns yet)
hendi has quit [Ping timeout: 245 seconds]
<fanquake>
I'm not sure there are enough (reliable) seeds of those type yet
brunoerg has joined #bitcoin-core-dev
<laanwj>
maybe for torv3, but agree on the other ones
<fanquake>
removing sed seems like a good solution :p
<fanquake>
we have a history of doing that
<laanwj>
i remember there was some other problem with it too, but i don't remember what anymore
<fanquake>
I must be naive to think that man page generation would be a "solved" problem
<laanwj>
i might just reimplement the script from scratch in python or something
<fanquake>
sounds more fun than bash. throw away the cruft
<laanwj>
right, at least it makes explicit what is really happening, and why, i'm tired of line-noise style programming
<jonatack>
fwiw bitcoin-cli -addrinfo shows more than 10k onion (torv3) peers for me
<jonatack>
(i2p 160, cjdns 4)
jamesob2 has joined #bitcoin-core-dev
jamesob has quit [Read error: Connection reset by peer]
jamesob2 is now known as jamesob
<lightlike>
jonatack: https://bitnodes.io/nodes/ also indicates a LOT of onion nodes, more than 50% of all listening nodes
sloorush has joined #bitcoin-core-dev
<jonatack>
lightlike: bitnode numbers seem low, especially for IP peers; i usually see 40k-55k ipv4 and 8k-10k+ ipv6 in -addrinfo (depending on how long ago i lost or swapped out peers.dat for testing)
<lightlike>
jonatack: I think bitnode only lists listening peers it can successfully connect to. -addrinfo should additionally include lots of peers that self-advertise their address, but are unreachable for others, e.g. behind firewalls.
<jonatack>
right
brunoerg has quit [Remote host closed the connection]
Guyver2 has joined #bitcoin-core-dev
kabaum has quit [Ping timeout: 250 seconds]
brunoerg has joined #bitcoin-core-dev
sdfgsdfg has quit [Quit: ayo yoyo ayo yoyo hololo, hololo.]
brunoerg has quit [Ping timeout: 250 seconds]
<Murch>
laanwj: Thanks, I'll ponder whether I can come up with a better name.
<lightlike>
Murch: maybe just "sweepwallet", so it's in line with other commands that affect an entire wallet, such as backupwallet, dumpwallet, importwallet, restorewallet?
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
<Murch>
<lightlike> "Murch: maybe just "sweepwallet",..." <- It can either sweep the whole UTXO pool (which is the default behavior), or just a given UTXO set, though.
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
yanmaani has quit [Ping timeout: 276 seconds]
<laanwj>
Murch: lightlike: sweepwallet SGTM, it makes it clear that a wallet (or subset) is being swept, and not, say, a private key
Guyver2_ has joined #bitcoin-core-dev
<gleb7454386>
Getting this error on macos: `test/lint/lint-python.sh: line 106: syntax error near unexpected token `<'`
brunoerg has joined #bitcoin-core-dev
noonien has joined #bitcoin-core-dev
Guyver2 has quit [Ping timeout: 256 seconds]
Guyver2_ is now known as Guyver2
<gleb7454386>
The next line is supposed to explain something: `test/lint/lint-python.sh: line 106: `mapfile -t FILES < <(git ls-files "test/functional/*.py" "contrib/devtools/*.py")'`
brunoerg has quit [Ping timeout: 250 seconds]
yanmaani has joined #bitcoin-core-dev
outfox has quit [Ping timeout: 250 seconds]
<laanwj>
gleb7454386: are you sure you're running it in bash and not another shell?
<jonatack>
gleb7454386: on master? (lint-python.sh is green for me on debian testing)
outfox has joined #bitcoin-core-dev
outfox has quit [Changing host]
outfox has joined #bitcoin-core-dev
<laanwj>
it uses arrays which is a bash-ism, maybe someone should rewrite lint-python in python *hides*
<sipa>
Hopefully in linted python.
<laanwj>
heh
<jonatack>
oh right, maybe the macos bash -> zsh thing
<laanwj>
i don't think i've ever seen "mapfile" used, nor a double redirect like "< <"
Guyver2_ has joined #bitcoin-core-dev
Guyver2 has quit [Ping timeout: 256 seconds]
Guyver2_ is now known as Guyver2
<gleb7454386>
i call it this way: `sh test/lint/lint-python.sh`
<laanwj>
you need to use bash, not sh
<gleb7454386>
ah thank you
<laanwj>
sh is usually a link to some other, minimal posix compatible shell
<gleb7454386>
now it gives `test/lint/lint-python.sh: line 106: mapfile: command not found`, but i can probably figure that out...
<laanwj>
note that the first line of test/lint/lint-python.sh correctly specifies bash, so if you launch it as binary it should find the right interpreter
<laanwj>
huh, that's an internal command
<gleb7454386>
my system hash bash 3, and apparently bash 4 is needed
<laanwj>
that's definitely old, bash 5 has been out for quite a while now
<gleb7454386>
mine setup is just a regular macbook from last year without any modifications... but yeah, whatever, from here i can definitely figure it out :)
<laanwj>
i didn't know there were still significant changes to shell syntax in modern times tbh
<laanwj>
it's too bad posix shell never got a array syntax so they all roll their own
<laanwj>
without arrays even handling basic things like filenames with spaces is broken
yanmaani has quit [Ping timeout: 276 seconds]
<cfields>
I would've assumed the "< <" was a bug. I still can't parse it. Does "<(" have special meaning?
<bitcoin-git>
[bitcoin] hebasto opened pull request #24265: Drop StripRedundantLastElementsOfPath() function and re-enable Windows tests (master...220204-norm) https://github.com/bitcoin/bitcoin/pull/24265
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
sloorush has quit [Ping timeout: 240 seconds]
davterra has quit [Remote host closed the connection]
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
brunoerg has quit [Ping timeout: 256 seconds]
prayank has joined #bitcoin-core-dev
Guest9067 has joined #bitcoin-core-dev
Guest9067 has quit [Client Quit]
sipsorcery has joined #bitcoin-core-dev
morcos has quit [Remote host closed the connection]
morcos has joined #bitcoin-core-dev
prayank has left #bitcoin-core-dev [#bitcoin-core-dev]
brunoerg has joined #bitcoin-core-dev
prayank has joined #bitcoin-core-dev
greypw254 has joined #bitcoin-core-dev
<prayank>
Recently one dependency was removed from core: boost. I could remember some discusion about it when I worked on a PR and it was interesting to see that one reviewer had to use sudo to test it: #21944