09:18 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #26277: test: Remove confusing DUMMY_P2WPKH_SCRIPT (master...2210-test-no-dummy-🌮) https://github.com/bitcoin/bitcoin/pull/26277

10:18 <bitcoin-git> [bitcoin] dergoegge closed pull request #21603: log: Mitigate disk filling attacks by rate limiting LogPrintf (master...log_ratelimiting) https://github.com/bitcoin/bitcoin/pull/21603

12:41 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #26278: test: Actually set sequence in MiniWallet create_self_transfer_multi (master...2210-test-seq-🕕) https://github.com/bitcoin/bitcoin/pull/26278

12:56 <bitcoin-git> [bitcoin] luke-jr closed pull request #26270: Bugfix: Wallet: ResubmitWalletTransactions: Only bump m_next_resend if actually doing a relay (master...fix_wallet_nextresend_only_relaying) https://github.com/bitcoin/bitcoin/pull/26270

13:05 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #26280: rpc: Return coinbase flag in scantxoutset (master...2210-rpc-coinbase-scan-🐥) https://github.com/bitcoin/bitcoin/pull/26280

13:47 <instagibbs> whats the rpc way to check if acceptnonstdtxn is set to 1?

13:53 <laanwj> instagibbs: doesn't look like it's reported on any RPC

13:54 <instagibbs> ok I'll scrape log instead

14:07 <bitcoin-git> [bitcoin] stickies-v opened pull request #26281: docs: fix m_children to be a member of CTxMemPoolEntry (master...mempool-docs-children) https://github.com/bitcoin/bitcoin/pull/26281

19:02 <achow101> #startmeeting

19:02 <core-meetingbot> Meeting started Fri Oct 7 19:02:14 2022 UTC. The chair is achow101. Information about MeetBot at https://bitcoin.jonasschnelli.ch/ircmeetings.

19:02 <core-meetingbot> Available commands: action commands idea info link nick

19:02 <achow101> #bitcoin-core-dev Wallet Meeting: achow101 _aj_ amiti ariard BlueMatt cfields Chris_Stewart_5 darosior digi_james dongcarl elichai2 emilengler fanquake fjahr furszy gleb glozow gmaxwell gwillen hebasto instagibbs jamesob jarolrod jb55 jeremyrubin jl2012 jnewbery jonasschnelli jonatack josibake jtimon kallewoof kanzure kvaciral laanwj larryruane lightlike luke-jr maaku marcofalke meshcollider michagogo moneyball morcos Murch nehan NicolasDorier

19:02 <achow101> paveljanik petertodd phantomcircuit promag provoostenator ryanofsky sdaftuar S3RK sipa vasild

19:02 <achow101> Haven't had a wallet meeting in a while. Does anyone have anything to discuss?

19:03 <furszy> hi

19:03 <brunoerg> hi

19:05 <furszy> just one small thing

19:05 <furszy> was thinking about #25269 yesterday

19:05 <gribble> https://github.com/bitcoin/bitcoin/issues/25269 | wallet: re-activate the not triggered "AmountWithFeeExceedsBalance" error by furszy · Pull Request #25269 · bitcoin/bitcoin · GitHub

19:07 <furszy> the topic would be whether someone would care about that behavior change or not.

19:09 <achow101> it seems like the kind of error that would be returned out of coin selection rather than transaction creation?

19:09 <achow101> I do think it would be a useful error as it can be confusing when the balance is enough for the recipient amount but not for the fee

19:13 <furszy> yeah, could be there too. The thing is do we want to include it for v24.0?

19:13 <achow101> No, not for 24.0

19:13 <achow101> it's not a regression, nor a bug

19:13 <achow101> Improving these error messages is basically a feature

19:13 <furszy> we were throwing it before actually

19:14 <furszy> it was removed in #20640 by mistake

19:14 <gribble> https://github.com/bitcoin/bitcoin/issues/20640 | wallet, refactor: return out-params of CreateTransaction() as optional struct by theStack · Pull Request #20640 · bitcoin/bitcoin · GitHub

19:14 <furszy> thus why the wallet model had this stuff

19:14 <furszy> https://github.com/bitcoin/bitcoin/pull/25269/commits/aa2b2172106fbd89812efb0c7010c9a400e7dd0f

19:15 <achow101> oh, I'll have to take a closer look into it

19:16 <achow101> if we've accidentally removed it for this release, then I think we should try to put it back

19:16 <achow101> but if doing that is too involved, we can just add a "known issue" in the release notes

19:16 <achow101> I don't think it's critical

19:17 <furszy> yeah for sure, not critical at all. Just something that came up to my head yesterday.

19:18 <bitcoin-git> [bitcoin] jamesob opened pull request #26282: wallet: have prune error take precedence over assumedvalid (master...2022-10-fix-au-wallet) https://github.com/bitcoin/bitcoin/pull/26282

19:19 <achow101> anything else to discuss?

19:22 <achow101> seems not

19:22 <achow101> #endmeeting

19:22 <core-meetingbot> topic: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt / http://gnusha.org/bitcoin-core-dev/proposedwalletmeetingtopics.txt

19:22 <core-meetingbot> Meeting ended Fri Oct 7 19:22:14 2022 UTC.

19:22 <core-meetingbot> Minutes: https://bitcoin.jonasschnelli.ch/ircmeetings/logs/bitcoin-core-dev/2022/bitcoin-core-dev.2022-10-07-19.02.moin.txt