yanmaani2 has quit [Remote host closed the connection]
AaronvanW has quit [Ping timeout: 260 seconds]
amovfx has quit [Ping timeout: 246 seconds]
amovfx has joined #bitcoin-core-dev
yanmaani2 has joined #bitcoin-core-dev
amovfx_ has joined #bitcoin-core-dev
jonatack has joined #bitcoin-core-dev
amovfx has quit [Ping timeout: 252 seconds]
dviola has quit [Ping timeout: 272 seconds]
amovfx has joined #bitcoin-core-dev
amovfx_ has quit [Ping timeout: 252 seconds]
amovfx has quit [Ping timeout: 255 seconds]
jon_atack has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 255 seconds]
upekkha has quit [Quit: upekkha]
upekkha has joined #bitcoin-core-dev
jon_atack has quit [Ping timeout: 246 seconds]
amovfx has joined #bitcoin-core-dev
AaronvanW has joined #bitcoin-core-dev
amovfx_ has joined #bitcoin-core-dev
amovfx has quit [Ping timeout: 246 seconds]
jonatack1 has joined #bitcoin-core-dev
amovfx has joined #bitcoin-core-dev
jonatack2 has joined #bitcoin-core-dev
jonatack1 has quit [Ping timeout: 255 seconds]
AaronvanW has quit [Ping timeout: 272 seconds]
jonatack3 has joined #bitcoin-core-dev
jonatack2 has quit [Ping timeout: 255 seconds]
amovfx_ has quit [Ping timeout: 252 seconds]
jonatack has joined #bitcoin-core-dev
jonatack3 has quit [Ping timeout: 252 seconds]
amovfx has quit [Ping timeout: 252 seconds]
yanmaani2 has quit [Remote host closed the connection]
yanmaani2 has joined #bitcoin-core-dev
amovfx has joined #bitcoin-core-dev
amovfx has quit [Ping timeout: 246 seconds]
cmirror has quit [Remote host closed the connection]
cmirror has joined #bitcoin-core-dev
amovfx has joined #bitcoin-core-dev
cm has quit [Quit: Bye.]
cm has joined #bitcoin-core-dev
amovfx_ has joined #bitcoin-core-dev
amovfx has quit [Ping timeout: 246 seconds]
<bitcoin-git>
[bitcoin] satsie opened pull request #26358: doc: Rearrange a few lines in the dependency graph of libraries (master...patch-1) https://github.com/bitcoin/bitcoin/pull/26358
Guest50 has joined #bitcoin-core-dev
vasild has quit [Remote host closed the connection]
vasild has joined #bitcoin-core-dev
mikehu44 has joined #bitcoin-core-dev
Guest50 has quit [Quit: Client closed]
amovfx has joined #bitcoin-core-dev
amovfx has quit [Ping timeout: 255 seconds]
mikehu44 has quit [Ping timeout: 252 seconds]
AaronvanW has joined #bitcoin-core-dev
jamesob has quit [Ping timeout: 248 seconds]
mikehu44 has joined #bitcoin-core-dev
jamesob has joined #bitcoin-core-dev
amovfx_ has quit [Ping timeout: 255 seconds]
amovfx has joined #bitcoin-core-dev
dviola has joined #bitcoin-core-dev
AaronvanW has quit [Ping timeout: 246 seconds]
amovfx_ has joined #bitcoin-core-dev
amovfx_ has quit [Ping timeout: 252 seconds]
z3nii has joined #bitcoin-core-dev
amovfx_ has joined #bitcoin-core-dev
ghost43 has quit [Remote host closed the connection]
ghost43 has joined #bitcoin-core-dev
z3nii has quit [Quit: Leaving]
ghost43 has quit [Ping timeout: 258 seconds]
amovfx has quit [Ping timeout: 246 seconds]
ghost43 has joined #bitcoin-core-dev
amovfx has joined #bitcoin-core-dev
chipxxx has quit [Ping timeout: 252 seconds]
amovfx has quit [Ping timeout: 252 seconds]
dhruv has quit [Quit: leaving]
dhruv has joined #bitcoin-core-dev
face_ has quit [Remote host closed the connection]
AaronvanW has joined #bitcoin-core-dev
amovfx_ has quit [Ping timeout: 246 seconds]
amovfx has joined #bitcoin-core-dev
amovfx has quit [Ping timeout: 252 seconds]
amovfx has joined #bitcoin-core-dev
amovfx has quit [Ping timeout: 252 seconds]
amovfx has joined #bitcoin-core-dev
chipxxx has joined #bitcoin-core-dev
<gleb071>
Have we ever considered making feelers more gently than "just connect and then quickly disconnect"? E.g. with a specific p2p message.
<gleb071>
I reckon this might simplify a bunch of p2p code.
AaronvanW has quit [Ping timeout: 272 seconds]
amovfx_ has joined #bitcoin-core-dev
amovfx_ has quit [Ping timeout: 246 seconds]
<bitcoin-git>
[bitcoin] naumenkogs opened pull request #26359: p2p, refactor: #23443 (Erlay support signaling) follow-ups (master...2021-11-erlay1_followup) https://github.com/bitcoin/bitcoin/pull/26359
<bitcoin-git>
[bitcoin] fanquake merged pull request #25727: util, config: error on startup if `conf` or `reindex` are set in config file (master...josibake-update-config-errors) https://github.com/bitcoin/bitcoin/pull/25727
<bitcoin-git>
[bitcoin] fanquake opened pull request #26360: build: remove threadinterrupt from libbitcoinkernel (master...kernel_remove_threadinterrupt) https://github.com/bitcoin/bitcoin/pull/26360
bitcoin-git has quit [Quit: Bridge terminating on SIGTERM]
provoostenator has quit [Quit: Bridge terminating on SIGTERM]
vincenzopalazzo has quit [Quit: Bridge terminating on SIGTERM]
sipa has quit [Quit: Bridge terminating on SIGTERM]
BlueMatt[m] has quit [Quit: Bridge terminating on SIGTERM]
robertspigler has quit [Quit: Bridge terminating on SIGTERM]
stratospher[m] has quit [Quit: Bridge terminating on SIGTERM]
josie[m] has quit [Quit: Bridge terminating on SIGTERM]
kvaciral has quit [Quit: Bridge terminating on SIGTERM]
SakshamSolanki[m has quit [Quit: Bridge terminating on SIGTERM]
arturomf94[m] has quit [Quit: Bridge terminating on SIGTERM]
cotsuka has quit [Quit: Bridge terminating on SIGTERM]
euclid[m] has quit [Quit: Bridge terminating on SIGTERM]
willcl_ark has quit [Quit: Bridge terminating on SIGTERM]
Murch has quit [Quit: Bridge terminating on SIGTERM]
kakolainen[m] has quit [Quit: Bridge terminating on SIGTERM]
ishaanam[m] has quit [Quit: Bridge terminating on SIGTERM]
denise[m] has quit [Quit: Bridge terminating on SIGTERM]
Murch has joined #bitcoin-core-dev
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] aureleoules closed pull request #25903: Use static member functions from class instead of instances (master...2022-08-tidy-use-static-functions) https://github.com/bitcoin/bitcoin/pull/25903
<bitcoin-git>
bitcoin/master dddd1ac MacroFake: net: Set relay in version msg to peers with relay permission
<bitcoin-git>
bitcoin/master 8c5c98d MacroFake: Merge bitcoin/bitcoin#26248: net: Set relay in version msg to peers with r...
<bitcoin-git>
[bitcoin] MarcoFalke merged pull request #26248: net: Set relay in version msg to peers with relay permission in -blocksonly mode (master...2210-version-relay-🥐) https://github.com/bitcoin/bitcoin/pull/26248
<MacroFake>
Looks like a Cirrus bug. You are running a branch, but the CI somehow treats it like a pull request (nr 17)?
csgui has quit [Quit: Client closed]
<bitcoin-git>
[bitcoin] MarcoFalke opened pull request #26361: NO MERGE gui test [skip ci] [ci skip] (master...2210-no-merge-gui-test-🏌) https://github.com/bitcoin/bitcoin/pull/26361
amovfx has joined #bitcoin-core-dev
amovfx_ has joined #bitcoin-core-dev
<MacroFake>
re about the gui repo: I think the gui should stay in the tree (whether a monotroo with several repos or a single repo), splitting it up completely is a separate discussion and comes with downsides
<MacroFake>
re about devs not knowing the gui repo exists: Is there any data to back it up? I haven't seen any regular dev open a pull against the main repo when it should have been opened against the gui repo.
amovfx_ has quit [Ping timeout: 252 seconds]
amovfx has quit [Ping timeout: 252 seconds]
<MacroFake>
re about lack of review in the gui repo: I am not sure if moving development into the main repo is going to fix that. It just feels like it is going to fail in the same way the attempt by DrahtBot to ping reviewers directly failed. (It filled everyone's inbox but no one paid attention)
<MacroFake>
Maybe the readme could be clarified to mention that reviewers are encouraged to subscribe to the gui repo, if that is the only thing that is holding them back?
<_aj_>
MacroFake: is drahtbot going to comment on the prs in the gui repo as well?
<MacroFake>
yes, it already does
<_aj_>
MacroFake: cool; it hasn't commented on that one, is all
<MacroFake>
Running on a spinning disk takes some time to calculate the conflicts (10 minutes per pull). Maybe I should use the dryrun option for git merge?
<_aj_>
MacroFake: make a git worktree on a tmpfs, maybe?
<achow101>
MacroFake: I think the lack of review in GUI is the data for people not remembering it exists
<MacroFake>
Well you don't know. It could also mean that people don't want to review.
amovfx_ has quit [Ping timeout: 246 seconds]
<achow101>
Other than also speaking to people who say they would like to do more GUI work but often forget the gui exists since they look for prs to review by looking at the main repo pr list?
<MacroFake>
Are they subscribed to the gui repo?
<achow101>
apparently a significant portion of contributors do not subscribe entire repos since the volume is often very high, they instead subscribe to specific individual issues/prs that they are intereseted in
ws11__ has quit [Quit: Connection closed for inactivity]
amovfx_ has joined #bitcoin-core-dev
amovfx_ has quit [Ping timeout: 255 seconds]
Guyver2_ has left #bitcoin-core-dev [#bitcoin-core-dev]
SpellChecker has quit [Remote host closed the connection]
SpellChecker has joined #bitcoin-core-dev
adiabat_ has quit [Remote host closed the connection]
<luke-jr>
achow101: there's a lack of review on the main repo too ;)
amovfx_ has joined #bitcoin-core-dev
<luke-jr>
[15:54:36] <achow101> apparently a significant portion of contributors do not subscribe entire repos since the volume is often very high, they instead subscribe to specific individual issues/prs that they are intereseted in <-- this speaks to the benefit fo the GUI repo: you can subscribe to all GUI stuff, and get little noise
amovfx_ has quit [Ping timeout: 252 seconds]
amovfx has quit [Ping timeout: 255 seconds]
Guyver2 has joined #bitcoin-core-dev
Guyver2 has left #bitcoin-core-dev [#bitcoin-core-dev]