<bitcoin-git>
bitcoin/master fa51cc9 MacroFake: refactor: Use type-safe time point for CWallet::m_next_resend
<bitcoin-git>
bitcoin/master 50cc8ef fanquake: Merge bitcoin/bitcoin#26302: refactor: Use type-safe time point for CWalle...
<bitcoin-git>
[bitcoin] fanquake merged pull request #26302: refactor: Use type-safe time point for CWallet::m_next_resend (master...2210-wallet-time-🤗) https://github.com/bitcoin/bitcoin/pull/26302
andrewtoth has quit [Remote host closed the connection]
andrewtoth has joined #bitcoin-core-dev
amovfx has quit [Ping timeout: 276 seconds]
amovfx has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] andrewtoth opened pull request #26375: validation, zmq: pass block in UpdatedBlockTip to avoid duplicate read (master...no-read-zmq) https://github.com/bitcoin/bitcoin/pull/26375
amovfx has quit [Ping timeout: 250 seconds]
mikehu44 has joined #bitcoin-core-dev
cmirror has quit [Remote host closed the connection]
cmirror has joined #bitcoin-core-dev
amovfx has joined #bitcoin-core-dev
<jeremyrubin>
ah i see
amovfx has quit [Ping timeout: 276 seconds]
<jeremyrubin>
jamesob given that timeout interval is 20 minutes and ping is 2 minutes, i don't think at least core to core you'd get a disconnect by not pinging immediately?
<sipa>
bitcoin core doesn't require the peer to ping ever, at all
<sipa>
the question is whether "ping immediately after connection" is part of "the protocol", but since the latter has no formal specification, and is just defined by what actual software does, now and historically, that's hard to define
yanmaani2 has quit [Remote host closed the connection]
yanmaani2 has joined #bitcoin-core-dev
flooded has joined #bitcoin-core-dev
_flood has quit [Ping timeout: 272 seconds]
amovfx has joined #bitcoin-core-dev
amovfx has quit [Ping timeout: 276 seconds]
amovfx_ has quit [Remote host closed the connection]
amovfx has joined #bitcoin-core-dev
amovfx has quit [Ping timeout: 272 seconds]
robertnielsen has joined #bitcoin-core-dev
zeropoint has joined #bitcoin-core-dev
zeropoint has quit [Client Quit]
zeropoint has joined #bitcoin-core-dev
zeropoint has quit [Client Quit]
jonatack3 has quit [Read error: Connection reset by peer]
amovfx has joined #bitcoin-core-dev
<vasild>
jamesob: I think that it is more sound to initialize m_ping_start to "now" instead of 0. But maybe it is not worth to change it, given the coding, review, bikeshed, possibly breaking alternative implementations, etc vs almost no gain.
<bitcoin-git>
bitcoin/master 1184a66 Stacie Waleyko: doc: Rearrange some lines in the dependency graph of libraries
<bitcoin-git>
bitcoin/master c056735 MacroFake: Merge bitcoin/bitcoin#26358: doc: Rearrange a few lines in the dependency ...
<bitcoin-git>
[bitcoin] MarcoFalke merged pull request #26358: doc: Rearrange a few lines in the dependency graph of libraries (master...patch-1) https://github.com/bitcoin/bitcoin/pull/26358
<bitcoin-git>
bitcoin/master 8fb3fd2 MacroFake: Merge bitcoin-core/gui#673: Use fallback value for Version and User Agent ...
<bitcoin-git>
bitcoin/master c2a21c0 Jon Atack: gui: use fallback value for Version and User Agent during peer connection
<bitcoin-git>
[gui] MarcoFalke merged pull request #673: Use fallback value for Version and User Agent during peer connection (master...2022-09-display-fallback-for-gui-peers-version-and-user-agent) https://github.com/bitcoin-core/gui/pull/673
earnestly has quit [Remote host closed the connection]
<bitcoin-git>
[bitcoin] MarcoFalke closed pull request #26361: NO MERGE gui test [skip ci] [ci skip] (master...2210-no-merge-gui-test-🏌) https://github.com/bitcoin/bitcoin/pull/26361
earnestly has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] MarcoFalke opened pull request #26376: test: Use type-safe NodeSeconds for TestMemPoolEntryHelper (master...2210-time-🏾) https://github.com/bitcoin/bitcoin/pull/26376
<bitcoin-git>
[bitcoin] MarcoFalke merged pull request #26333: [23.x] Revert "build: Use Homebrew's sqlite package if it is available" (23.x...revert_slow_macos_sqlite_23_x) https://github.com/bitcoin/bitcoin/pull/26333
darosior has quit [Read error: Connection reset by peer]
<bitcoin-git>
[bitcoin] MarcoFalke merged pull request #26350: [22.x] Revert "build: Use Homebrew's sqlite package if it is available" (22.x...revert_slow_macos_sqlite_22_x) https://github.com/bitcoin/bitcoin/pull/26350
vasild has quit [Remote host closed the connection]
amovfx has joined #bitcoin-core-dev
amovfx has quit [Ping timeout: 250 seconds]
bomb-on has quit [Ping timeout: 252 seconds]
dermoth has joined #bitcoin-core-dev
vasild has joined #bitcoin-core-dev
mikehu44 has quit [Quit: No Ping reply in 180 seconds.]
mikehu44 has joined #bitcoin-core-dev
amovfx has joined #bitcoin-core-dev
amovfx has quit [Ping timeout: 276 seconds]
amovfx has joined #bitcoin-core-dev
mikehu44 has quit [Ping timeout: 272 seconds]
mikehu44 has joined #bitcoin-core-dev
amovfx has quit [Ping timeout: 272 seconds]
cryptapus has quit [Quit: Konversation terminated!]
cryptapus has joined #bitcoin-core-dev
mikehu44_ has joined #bitcoin-core-dev
mikehu44 has quit [Ping timeout: 276 seconds]
AaronvanW has quit [Remote host closed the connection]
mikehu44_ has quit [Ping timeout: 250 seconds]
brunoerg has joined #bitcoin-core-dev
mikehu44 has joined #bitcoin-core-dev
amovfx has joined #bitcoin-core-dev
amovfx has quit [Ping timeout: 276 seconds]
bitdex has quit [Quit: = ""]
<bitcoin-git>
[bitcoin] hebasto opened pull request #26377: test: Make `system_tests/run_command` test locale and platform agnostic (master...221024-nonloc) https://github.com/bitcoin/bitcoin/pull/26377
<bitcoin-git>
[bitcoin] MarcoFalke opened pull request #26378: refactor: Pass reference to last header, not pointer (master...2210-p2p-less-pointers-🍟) https://github.com/bitcoin/bitcoin/pull/26378
<bitcoin-git>
[bitcoin] glozow merged pull request #26355: p2p: Handle IsContinuationOfLowWorkHeadersSync return value correctly when new headers sync is started (master...2022-10-nbits-headerssync) https://github.com/bitcoin/bitcoin/pull/26355
<bitcoin-git>
[bitcoin] glozow opened pull request #26382: [24.x] p2p: Handle IsContinuationOfLowWorkHeadersSync return value correctly when new headers sync is started (24.x...2022-10-backport-26355) https://github.com/bitcoin/bitcoin/pull/26382
<bytes1440000>
I am not sure how useful is this poll with 25 votes but I am not a big twitter influencer. It was about "defaults" in bitcoin projects and kind of mixed response: https://twitter.com/1440000bytes/status/1584311735741140992
<bytes1440000>
Context: Recent default that is being discussed in some PRs in bitcoin core and on mailing list
bytes1440000 has left #bitcoin-core-dev [#bitcoin-core-dev]
NorrinRadd has quit [Quit: NorrinRadd]
andrewtoth has quit [Remote host closed the connection]
andrewtoth has joined #bitcoin-core-dev
<ariard>
would be more useful to have a twitter survey with how much months/years a full-rbf deployment timeline could be, or if automatic preferential peering is preferred
<ariard>
ideally with for each vote, a rational attached
NorrinRadd has joined #bitcoin-core-dev
yanmaani2 has quit [Ping timeout: 258 seconds]
amovfx has quit [Ping timeout: 255 seconds]
Guyver2 has joined #bitcoin-core-dev
Guyver2 has left #bitcoin-core-dev [#bitcoin-core-dev]
yanmaani2 has joined #bitcoin-core-dev
hg has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] sipa opened pull request #26383: Add feature_taproot case involved invalid internal pubkey (master...202210_invalid_internal) https://github.com/bitcoin/bitcoin/pull/26383
halo has joined #bitcoin-core-dev
halosghost has quit [Ping timeout: 272 seconds]
jonatack3 has quit [Read error: Connection reset by peer]
hg has quit [Ping timeout: 272 seconds]
amovfx has joined #bitcoin-core-dev
jonatack3 has joined #bitcoin-core-dev
Talkless has quit [Quit: Konversation terminated!]
brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 250 seconds]
Guest3 has joined #bitcoin-core-dev
Guest3 has left #bitcoin-core-dev [#bitcoin-core-dev]
amovfx_ has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
NorrinRadd has quit [Quit: NorrinRadd]
brunoerg has quit [Ping timeout: 255 seconds]
amovfx has quit [Ping timeout: 246 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 272 seconds]
gribble has quit [*.net *.split]
javi404 has quit [*.net *.split]
aureleoules has quit [*.net *.split]
ariard has quit [*.net *.split]
jonasschnelli has quit [*.net *.split]
luke-jr has quit [*.net *.split]
lbia has quit [*.net *.split]
windsok has quit [*.net *.split]
jb55 has quit [*.net *.split]
[D] has quit [*.net *.split]
fanquake has quit [*.net *.split]
real_or_random has quit [*.net *.split]
johnzweng has quit [*.net *.split]
mimmy has quit [*.net *.split]
GoldmanSats_ has quit [*.net *.split]
GoldmanSats_ has joined #bitcoin-core-dev
jonasschnelli has joined #bitcoin-core-dev
ariard has joined #bitcoin-core-dev
real_or_random has joined #bitcoin-core-dev
aureleoules has joined #bitcoin-core-dev
fanquake has joined #bitcoin-core-dev
javi404 has joined #bitcoin-core-dev
jb55 has joined #bitcoin-core-dev
johnzweng has joined #bitcoin-core-dev
windsok has joined #bitcoin-core-dev
[D] has joined #bitcoin-core-dev
mimmy has joined #bitcoin-core-dev
luke-jr has joined #bitcoin-core-dev
lbia has joined #bitcoin-core-dev
amovfx_ has quit [Remote host closed the connection]
amovfx has joined #bitcoin-core-dev
gribble has joined #bitcoin-core-dev
amovfx has quit [Ping timeout: 246 seconds]
brunoerg has joined #bitcoin-core-dev
jonatack3 has quit [Quit: WeeChat 3.7]
amovfx has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 250 seconds]
amovfx_ has joined #bitcoin-core-dev
amovfx has quit [Ping timeout: 246 seconds]
amovfx has joined #bitcoin-core-dev
amovfx has quit [Read error: Connection reset by peer]
amovfx has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
jonatack has joined #bitcoin-core-dev
jon_atack has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 272 seconds]
jonatack1 has joined #bitcoin-core-dev
jon_atack has quit [Ping timeout: 272 seconds]
amovfx has quit [Remote host closed the connection]
amovfx has joined #bitcoin-core-dev
amovfx has quit [Remote host closed the connection]
amovfx has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
bitdex has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
bitdex has quit [Ping timeout: 258 seconds]
amovfx_ has quit [Ping timeout: 272 seconds]
amovfx has quit [Remote host closed the connection]
amovfx has joined #bitcoin-core-dev
amovfx has quit [Ping timeout: 240 seconds]
brunoerg has joined #bitcoin-core-dev
bitdex has joined #bitcoin-core-dev
amovfx has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 250 seconds]
jonatack1 has quit [Quit: WeeChat 3.7]
amovfx_ has joined #bitcoin-core-dev
yanmaani2 has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
yanmaani2 has joined #bitcoin-core-dev
halo has quit [Quit: WeeChat 3.7]
jonatack has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
amovfx_ has quit [Remote host closed the connection]