#bitcoin-core-dev on 2022-10-23 — searchable irc log

00:05 AaronvanW has quit [Ping timeout: 276 seconds]

00:07 amovfx has quit [Remote host closed the connection]

00:08 amovfx has joined #bitcoin-core-dev

00:15 amovfx_ has joined #bitcoin-core-dev

01:18 amovfx_ has quit [Ping timeout: 272 seconds]

01:22 amovfx_ has joined #bitcoin-core-dev

01:26 amovfx has quit [Remote host closed the connection]

01:27 amovfx has joined #bitcoin-core-dev

01:29 amovfx_ has quit [Ping timeout: 276 seconds]

01:32 amovfx has quit [Ping timeout: 276 seconds]

01:39 jarthur_ has quit [Quit: jarthur_]

01:47 jarthur has joined #bitcoin-core-dev

01:51 amovfx has joined #bitcoin-core-dev

01:53 amovfx_ has joined #bitcoin-core-dev

02:02 SpellChecker_ has joined #bitcoin-core-dev

02:03 jonatack has quit [Ping timeout: 252 seconds]

02:03 AaronvanW has joined #bitcoin-core-dev

02:03 SpellChecker has quit [Remote host closed the connection]

02:36 AaronvanW has quit [Ping timeout: 250 seconds]

03:05 amovfx_ has quit [Ping timeout: 276 seconds]

03:15 jonatack has joined #bitcoin-core-dev

03:27 amovfx_ has joined #bitcoin-core-dev

03:32 <bitcoin-git> [bitcoin] atErik opened pull request #26370: Update build-osx.md (master...patch-1) https://github.com/bitcoin/bitcoin/pull/26370

03:58 amovfx has quit [Ping timeout: 250 seconds]

04:01 cmirror has quit [Remote host closed the connection]

04:01 cmirror has joined #bitcoin-core-dev

04:16 chip_x has joined #bitcoin-core-dev

04:19 chipxxx has quit [Ping timeout: 276 seconds]

04:27 amovfx has joined #bitcoin-core-dev

04:33 amovfx has quit [Ping timeout: 276 seconds]

04:34 amovfx_ has quit [Ping timeout: 272 seconds]

04:34 AaronvanW has joined #bitcoin-core-dev

04:46 amovfx has joined #bitcoin-core-dev

04:47 amovfx_ has joined #bitcoin-core-dev

04:51 amovfx has quit [Ping timeout: 272 seconds]

04:52 z3nii has joined #bitcoin-core-dev

05:04 amovfx has joined #bitcoin-core-dev

05:06 AaronvanW has quit [Ping timeout: 250 seconds]

05:51 amovfx_ has quit [Ping timeout: 276 seconds]

06:07 amovfx has quit [Ping timeout: 276 seconds]

06:26 <bitcoin-git> [bitcoin] SatoshiBTCXBT opened pull request #26371: Satoshi btcxbt patch 16 (master...SatoshiBTCXBT-patch-16) https://github.com/bitcoin/bitcoin/pull/26371

06:26 <bitcoin-git> [bitcoin] SatoshiBTCXBT closed pull request #26371: Satoshi btcxbt patch 16 (master...SatoshiBTCXBT-patch-16) https://github.com/bitcoin/bitcoin/pull/26371

06:36 amovfx has joined #bitcoin-core-dev

06:38 amovfx_ has joined #bitcoin-core-dev

06:41 amovfx has quit [Ping timeout: 272 seconds]

06:59 amovfx has joined #bitcoin-core-dev

07:05 AaronvanW has joined #bitcoin-core-dev

07:05 amovfx has quit [Ping timeout: 276 seconds]

07:09 <bitcoin-git> [bitcoin] hebasto opened pull request #26372: build, msvc: Drop no longer required macro definitions for leveldb (master...221023-msvc-cleanup) https://github.com/bitcoin/bitcoin/pull/26372

07:12 Guest6Ecc has joined #bitcoin-core-dev

07:16 z3nii has quit [Quit: Leaving]

07:21 Guest6Ecc has quit [Quit: Client closed]

07:24 cold has quit [Ping timeout: 264 seconds]

07:25 cold has joined #bitcoin-core-dev

07:33 amovfx has joined #bitcoin-core-dev

07:37 amovfx has quit [Ping timeout: 250 seconds]

07:48 amovfx_ has quit [Ping timeout: 276 seconds]

07:59 amovfx has joined #bitcoin-core-dev

08:04 amovfx has quit [Ping timeout: 276 seconds]

08:16 amovfx has joined #bitcoin-core-dev

08:28 amovfx_ has joined #bitcoin-core-dev

09:03 Talkless has joined #bitcoin-core-dev

09:19 amovfx has quit [Ping timeout: 250 seconds]

09:21 jarthur has quit [Quit: jarthur]

09:26 jarthur has joined #bitcoin-core-dev

09:32 amovfx_ has quit [Ping timeout: 276 seconds]

09:32 amovfx has joined #bitcoin-core-dev

09:37 amovfx has quit [Ping timeout: 276 seconds]

09:39 sipsorcery has joined #bitcoin-core-dev

09:44 amovfx has joined #bitcoin-core-dev

09:48 amovfx has quit [Ping timeout: 272 seconds]

10:02 amovfx has joined #bitcoin-core-dev

10:05 AaronvanW has quit [Remote host closed the connection]

10:06 fanta1 has joined #bitcoin-core-dev

10:08 szkl has joined #bitcoin-core-dev

10:13 sipsorcery has quit [Ping timeout: 276 seconds]

10:16 amovfx_ has joined #bitcoin-core-dev

10:20 cold has quit [Quit: Quitting...]

10:20 cold has joined #bitcoin-core-dev

10:37 AaronvanW has joined #bitcoin-core-dev

11:06 amovfx has quit [Ping timeout: 250 seconds]

11:10 AaronvanW has quit [Ping timeout: 250 seconds]

11:19 amovfx has joined #bitcoin-core-dev

11:20 amovfx_ has quit [Ping timeout: 276 seconds]

11:23 AaronvanW has joined #bitcoin-core-dev

11:25 amovfx has quit [Ping timeout: 276 seconds]

11:33 amovfx has joined #bitcoin-core-dev

11:38 amovfx has quit [Ping timeout: 250 seconds]

11:42 ___nick___ has joined #bitcoin-core-dev

11:52 amovfx has joined #bitcoin-core-dev

11:54 amovfx_ has joined #bitcoin-core-dev

11:58 sipsorcery has joined #bitcoin-core-dev

12:35 mikehu44 has joined #bitcoin-core-dev

12:50 mikehu44 has quit [Ping timeout: 272 seconds]

12:55 amovfx has quit [Ping timeout: 276 seconds]

12:58 amovfx_ has quit [Ping timeout: 250 seconds]

12:59 mikehu44 has joined #bitcoin-core-dev

13:13 amovfx has joined #bitcoin-core-dev

13:18 amovfx has quit [Ping timeout: 276 seconds]

13:22 <jamesob> It seems like we do ping/pong cycle at the completion of connection negotiation with each peer... is this a formal part of the protocol or just coincidental?

13:23 amovfx has joined #bitcoin-core-dev

13:28 amovfx has quit [Ping timeout: 276 seconds]

13:30 <sipa> ping was part of the original codebase, pong was added in bip31

13:30 amovfx has joined #bitcoin-core-dev

13:31 <jamesob> I guess to put a finer point on the question: is it a reasonable expectation that we will always "ping/pong" shortly after the establishment of a new p2p connection?

13:32 <sipa> unfortunately, specifications aren't helpful for determining that

13:33 <jamesob> I'd be happy with a "de facto, based on the implementation" answer, but the code makes that kind of tricky to figure out

13:33 <sipa> i suspect bitcoin core has always done this, but other implementations may or may not have relied on the assumption that it always is

13:34 <sipa> especially with ping existing since satoshi times, it's all about expectations, not specifications

13:35 <jamesob> heh

13:35 amovfx has quit [Ping timeout: 272 seconds]

13:36 <sipa> and there are significant disagreements about what various people/inplementators think the protocol is

13:36 <sipa> (see recent ml discussion)

13:36 <jamesob> for anyone playing at home, this is in fact the case per Core implementation based on the fact that `peer.m_ping_start` is initialized to 0 and subsequently only set in this one function (https://github.com/jamesob/bitcoin/blob/447f50e4aed9a8b1d80e1891cda85801aeb80b4e/src/net_processing.cpp#L5023), which is invoked at the beginning of every

13:36 <jamesob> SendMessages call

13:37 <jamesob> sipa: ml?? nobody goes there anymore, too crowded

13:38 <sipa> haha

13:49 amovfx has joined #bitcoin-core-dev

13:51 vasild has quit [Remote host closed the connection]

13:54 vasild has joined #bitcoin-core-dev

13:59 amovfx_ has joined #bitcoin-core-dev

14:07 <bitcoin-git> [bitcoin] hebasto opened pull request #26373: Update minisketch subtree to latest upstream (master...221023-ms-subtree) https://github.com/bitcoin/bitcoin/pull/26373

14:09 AaronvanW has quit [Remote host closed the connection]

14:39 mikehu44 has quit [Ping timeout: 272 seconds]

14:40 AaronvanW has joined #bitcoin-core-dev

14:42 Guyver2 has joined #bitcoin-core-dev

14:51 Guyver2 has left #bitcoin-core-dev [Closing Window]

14:53 amovfx has quit [Ping timeout: 276 seconds]

14:59 AaronvanW has quit [Quit: Leaving...]

15:02 amovfx_ has quit [Ping timeout: 250 seconds]

15:17 jon_atack has joined #bitcoin-core-dev

15:19 jonatack has quit [Ping timeout: 255 seconds]

15:21 amovfx has joined #bitcoin-core-dev

15:26 amovfx has quit [Ping timeout: 250 seconds]

15:33 amovfx has joined #bitcoin-core-dev

15:39 amovfx has quit [Ping timeout: 276 seconds]

15:41 amovfx has joined #bitcoin-core-dev

15:45 jonatack1 has joined #bitcoin-core-dev

15:47 jon_atack has quit [Ping timeout: 276 seconds]

15:51 jonatack2 has joined #bitcoin-core-dev

15:53 amovfx_ has joined #bitcoin-core-dev

15:54 jonatack1 has quit [Ping timeout: 276 seconds]

16:10 jonatack3 has joined #bitcoin-core-dev

16:13 jonatack2 has quit [Ping timeout: 276 seconds]

16:18 test__ is now known as _flood

16:45 amovfx has quit [Ping timeout: 276 seconds]

16:56 amovfx_ has quit [Ping timeout: 276 seconds]

16:58 amovfx has joined #bitcoin-core-dev

17:02 amovfx has quit [Ping timeout: 272 seconds]

17:14 amovfx has joined #bitcoin-core-dev

17:15 <jeremyrubin> jamesob afaict ping interval is 2 mins, so "shortly thereafter" seems to be false?

17:25 vasild has quit [Remote host closed the connection]

17:26 amovfx_ has joined #bitcoin-core-dev

17:31 amovfx_ has quit [Ping timeout: 276 seconds]

17:41 vasild has joined #bitcoin-core-dev

17:58 jonatack3 has quit [Ping timeout: 272 seconds]

18:00 amovfx_ has joined #bitcoin-core-dev

18:00 ___nick___ has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.]

18:02 ___nick___ has joined #bitcoin-core-dev

18:02 ___nick___ has quit [Client Quit]

18:05 ___nick___ has joined #bitcoin-core-dev

18:11 bitdex has quit [Ping timeout: 258 seconds]

18:12 bitdex has joined #bitcoin-core-dev

18:18 amovfx has quit [Ping timeout: 276 seconds]

18:20 amovfx has joined #bitcoin-core-dev

18:23 mudsip has joined #bitcoin-core-dev

18:24 amovfx has quit [Ping timeout: 250 seconds]

18:29 mudsip has quit []

18:31 amovfx has joined #bitcoin-core-dev

19:03 amovfx_ has quit [Ping timeout: 260 seconds]

19:06 amovfx_ has joined #bitcoin-core-dev

19:32 robertnielsen has quit [Quit: Client closed]

19:35 amovfx has quit [Ping timeout: 276 seconds]

19:46 Talkless has quit [Quit: Konversation terminated!]

19:55 amovfx has joined #bitcoin-core-dev

19:59 <sipa> @jeremyrubin The last sent timer is initliazed to 0, so the first SendMessages run would conclude it's been more than 2 minutes, and thus immediately send one.

20:00 amovfx has quit [Ping timeout: 250 seconds]

20:04 ___nick___ has quit [Ping timeout: 272 seconds]

20:29 amovfx has joined #bitcoin-core-dev

20:33 <sipa> I think that's what @jamesob is saying

21:34 amovfx has quit [Ping timeout: 276 seconds]

21:34 fanta1 has quit [Quit: fanta1]

22:01 amovfx has joined #bitcoin-core-dev

22:07 amovfx has quit [Ping timeout: 272 seconds]

22:20 amovfx has joined #bitcoin-core-dev

22:27 sipsorcery has quit [Ping timeout: 250 seconds]

23:22 amovfx has quit [Ping timeout: 276 seconds]

23:29 <ariard> that type of PR: https://github.com/bitcoin/bitcoin/pull/25434#issuecomment-1288227190 blocked on lot of context across layers, let me think that it could be interesting to have a board/wiki page on "Mempool" subjects and to know if progress is blocked on the mailing list/meeting discussions/conceptual code review/lack of review bandwidth etc

23:29 <ariard> i believe we used to have one; dunno if still maintained would be valuable to allocate review time efficiently

23:32 mudsip has joined #bitcoin-core-dev

23:33 mudsip has quit [Client Quit]

23:38 amovfx has joined #bitcoin-core-dev

23:42 amovfx has quit [Ping timeout: 250 seconds]

23:52 amovfx has joined #bitcoin-core-dev

23:55 baakeydo1 has quit [Ping timeout: 248 seconds]

23:57 amovfx has quit [Ping timeout: 276 seconds]

23:59 amovfx has joined #bitcoin-core-dev