PaperSword has quit [Remote host closed the connection]
b_101 has joined #bitcoin-core-dev
PaperSword has joined #bitcoin-core-dev
PaperSword has quit [Client Quit]
andrew_mo_ has quit [Ping timeout: 260 seconds]
andrew_mo_ has joined #bitcoin-core-dev
PaperSword has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 248 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 252 seconds]
andrew_mo_ has joined #bitcoin-core-dev
bitdex has quit [Remote host closed the connection]
andrew_mo_ has quit [Ping timeout: 248 seconds]
orville has quit [Quit: <exit all I/O streams / EOF>]
bitdex has joined #bitcoin-core-dev
MrFrancis has quit [Ping timeout: 255 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 248 seconds]
<achow101>
fjahr: asmap-data was removed since it was empty
andrew_mo_ has joined #bitcoin-core-dev
andrew_m_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 248 seconds]
andrew_m_ has quit [Ping timeout: 248 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 248 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 268 seconds]
andrew_mo_ has joined #bitcoin-core-dev
cmirror has quit [Remote host closed the connection]
cmirror has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 268 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_m_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 252 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_m_ has quit [Ping timeout: 252 seconds]
andrew_m_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 248 seconds]
andrew_m_ has quit [Ping timeout: 260 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 248 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 260 seconds]
AmunRa has quit [Remote host closed the connection]
AmunRa has joined #bitcoin-core-dev
b_101 has quit [Ping timeout: 260 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 252 seconds]
as2333 has quit [Quit: as2333]
b_101 has joined #bitcoin-core-dev
andrew_mo_ has joined #bitcoin-core-dev
b_101 has quit [Ping timeout: 252 seconds]
andrew_mo_ has quit [Ping timeout: 252 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_m_ has joined #bitcoin-core-dev
andrew___ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 255 seconds]
andrew___ has quit [Read error: Connection reset by peer]
andrew_mo_ has joined #bitcoin-core-dev
andrew_m_ has quit [Ping timeout: 252 seconds]
andrew_mo_ has quit [Read error: Connection reset by peer]
andrew_m_ has joined #bitcoin-core-dev
realies has quit [Quit: ~]
realies has joined #bitcoin-core-dev
andrew_m_ has quit [Remote host closed the connection]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 248 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Remote host closed the connection]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Remote host closed the connection]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 248 seconds]
salvatoshi has joined #bitcoin-core-dev
<phantomcircuit>
achow101: thank you for review, was useful i have some things to improve
<phantomcircuit>
achow101: to be clear i dont think that the existing blockfilterindex has any value for bitcoin core, it's only value is in generating the filters for clients
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 252 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 246 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 255 seconds]
andrew_mo_ has joined #bitcoin-core-dev
jarthur has quit [Read error: Connection reset by peer]
<bitcoin-git>
[bitcoin] MarcoFalke merged pull request #26705: clang-tidy: Fix `modernize-use-default-member-init` in headers and force to check all headers (master...221215-tidy) https://github.com/bitcoin/bitcoin/pull/26705
andrew_mo_ has quit [Ping timeout: 252 seconds]
andrew_mo_ has joined #bitcoin-core-dev
AaronvanW has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 260 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 248 seconds]
MrFrancis has joined #bitcoin-core-dev
Guyver2 has left #bitcoin-core-dev [Closing Window]
andrew_mo_ has joined #bitcoin-core-dev
AmunRa has quit [Ping timeout: 255 seconds]
AmunRa has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 248 seconds]
andrew_mo_ has joined #bitcoin-core-dev
Livestradamus4 has joined #bitcoin-core-dev
Livestradamus has quit [Ping timeout: 252 seconds]
Livestradamus4 is now known as Livestradamus
andrew_mo_ has quit [Ping timeout: 248 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_m_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 246 seconds]
andrew_m_ has quit [Ping timeout: 260 seconds]
<willcl_ark>
I think we can get more complete bug reports from users via issues if we update our issue template to use the new yaml format (GitHub). IMO these forms are easier for users to fill in, and in being so they can persuade the user to provide more details in the initial report. I've been trying this out on my master branch, but I'm curious to know if there is any general reason I'm not aware of that we'd stick to the older *.md
<fanquake>
Swapping seems like a good idea. Those templates / forms look good
<willcl_ark>
OK, I'll open a PR to get more general feedback then
<fanquake>
Can probably make more of the fields required, and if people don't bother to fill them properly/stuff them with nonsense, it's grounds for closing the issue
<fanquake>
(in bug report at least)
<willcl_ark>
Yep! There are also dropdowns and checkboxes available to us liek this...
<fanquake>
is there some fancy way to make the "gui issue" button just redirect to GUI repo, so we never actually get those isues
<bitcoin-git>
bitcoin/master 7a820ce Hennadii Stepanov: test, build: Separate `read_json` function into its own module
<bitcoin-git>
bitcoin/master 17acbc1 fanquake: Merge bitcoin/bitcoin#25974: test, build: Separate `read_json` function in...
<bitcoin-git>
[bitcoin] fanquake merged pull request #25974: test, build: Separate `read_json` function into its own module (master...220901-test) https://github.com/bitcoin/bitcoin/pull/25974
<bitcoin-git>
bitcoin/master 87f11ef Sebastian Falbesoner: refactor: use `Hash` helper for double-SHA256 calculations
<bitcoin-git>
bitcoin/master 8fc3bcf MarcoFalke: Merge bitcoin/bitcoin#27010: refactor: use `Hash` helpers for double-SHA25...
<bitcoin-git>
[bitcoin] MarcoFalke merged pull request #27010: refactor: use `Hash` helpers for double-SHA256 calculations (master...202301-refactor-use_double_sha256_helper) https://github.com/bitcoin/bitcoin/pull/27010
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 248 seconds]
roze_paul has joined #bitcoin-core-dev
roze_paul has quit [Client Quit]
nanotube has quit [Ping timeout: 260 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 252 seconds]
MrFrancis has quit [Ping timeout: 256 seconds]
<fjahr>
I created a fake asmap-data repo here, just to demo how a pr review process might look like as a basis for further discussion: https://github.com/fjahr/asmap-data/pull/1
<bitcoin-git>
[bitcoin] fanquake opened pull request #27016: mapport: require miniupnpc API version 17 or later (master...mostly_non_broken_upnp_verions) https://github.com/bitcoin/bitcoin/pull/27016
andrew_mo_ has joined #bitcoin-core-dev
b_101 has quit [Ping timeout: 248 seconds]
nanotube has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 268 seconds]
roze_paul has joined #bitcoin-core-dev
halosghost has joined #bitcoin-core-dev
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 265 seconds]
b_101 has joined #bitcoin-core-dev
bugs_ has joined #bitcoin-core-dev
b_101 has quit [Ping timeout: 246 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 252 seconds]
AaronvanW has quit [Remote host closed the connection]
b_101 has joined #bitcoin-core-dev
andrew_mo_ has joined #bitcoin-core-dev
andrew_m_ has joined #bitcoin-core-dev
andrewtoth_ has joined #bitcoin-core-dev
b_101 has quit [Ping timeout: 260 seconds]
andrew_mo_ has quit [Ping timeout: 248 seconds]
b_101 has joined #bitcoin-core-dev
pablomartin has joined #bitcoin-core-dev
hernanmarino has joined #bitcoin-core-dev
andrew_m_ has quit [Ping timeout: 248 seconds]
<sdaftuar>
instagibbs: might be easier to talk through here if the explanation i posted in #26933 isn't clear
szkl has quit [Quit: Connection closed for inactivity]
brunoerg has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 260 seconds]
<instagibbs>
sdaftuar, yeah im not exactly clear on it
<instagibbs>
I'm probably glossing over key words in your explanation
<instagibbs>
so there's the key issue that's being discussed, where a transaction that doesn't meet min relay may make it into mempool via package relay, and then the cpfp'ing child is dropped due to rbf. This results in essentially 0-fee transactions floating in the mempool never to be mined
<sdaftuar>
right, so i have 2 solutions to that:
<sdaftuar>
1) mine everything
<sdaftuar>
2) to handle the literally 0-fee case, trim descendant packages that are below the minrelayfee
nanotube has quit [Ping timeout: 265 seconds]
<sdaftuar>
because 0-fee transactions are bad for miners to include in blocks (strictly worse for them)
<instagibbs>
1) mine everything, except 0-fee ?
<sdaftuar>
if we trim whenever we add something to the mempool, there won't be any 0-fee packages that get selected
andrew_mo_ has joined #bitcoin-core-dev
<sdaftuar>
because everything will have some descendant that bumps its feerate to above 0 (but possibly still less than minrelayfee)
<instagibbs>
Why doesn't this run into the concern about trimming too much?
<sdaftuar>
you mean, we might trim something that has a good ancestor score?
<instagibbs>
say, a single tx evicts 100 CPFP children, making 2500 0-fee ancestors lying around
<instagibbs>
I'm surely missing a concept which is obvious to you which is why I'm trying to get very concrete
<sdaftuar>
oh, i see. i guess that is possible, but not so different from what can happen already with rbf?
<instagibbs>
It would mean TrimToFee step might do 2500 trims vs 100(bip125 direct conflict limit)
<sdaftuar>
yes but those 100 might have 24 ancestors each, which all need to be updated (even if not removed). i'm not sure how much more expensive removal is than updating.
andrew_mo_ has quit [Ping timeout: 252 seconds]
<instagibbs>
I plead ignorance on that for sure
<sdaftuar>
also, when the mempool is actually busy, we can do a lot of eviction already i think? a big transaction can come in and evict a lot of packages
<sdaftuar>
yeah, roughly. actually i'm not sure how the mempool memory works out exactly for verifying that calculation, but i think he's approximately right
<sdaftuar>
i think another way i'd put it is, we have bigger DoS problems with transaction acceptance than what I anticipate to be the case with trimtosize evicting 0-fee things
<sdaftuar>
that's not a great answer, perhaps, because weshould fix everything! :)
<sdaftuar>
but i dont' think the approach here woudl be something that we couldn't engineer to be fast if we needed to
<instagibbs>
ok well I think I understand your comments now, I had a bit of a disconnect vs the prior convo
<sdaftuar>
we should benchmark eviction to make sure it's not super slow for some reason, too.
<sdaftuar>
obviously we wouldn't want to introduce some new form of DoS
andrew_mo_ has joined #bitcoin-core-dev
AaronvanW has quit [Ping timeout: 268 seconds]
Talkless has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 252 seconds]
Talkless has quit [Remote host closed the connection]
Talkless has joined #bitcoin-core-dev
andrew_mo_ has joined #bitcoin-core-dev
AmishBTC has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 252 seconds]
bugs_ has quit [Ping timeout: 256 seconds]
andrew_mo_ has joined #bitcoin-core-dev
mably has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 248 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 246 seconds]
andrew_mo_ has joined #bitcoin-core-dev
pablomartin has quit [Quit: Leaving]
andrew_mo_ has quit [Ping timeout: 255 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 252 seconds]
brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 248 seconds]
andrewtoth_ has quit [Remote host closed the connection]
<bitcoin-git>
[bitcoin] glozow opened pull request #27018: mempool / miner: regularly flush below-minrelayfeerate entries, mine everything in the mempool (master...2023-01-flushandmine) https://github.com/bitcoin/bitcoin/pull/27018
<glozow>
sdaftuar: instagibbs: #27018 implements the alternative approach suggested. We can also consider a combination of the two if we are concerned about the 2500-tx replacement scenario.
<gribble>
https://github.com/bitcoin/bitcoin/issues/27018 | mempool / miner: regularly flush below-minrelayfeerate entries, mine everything in the mempool by glozow · Pull Request #27018 · bitcoin/bitcoin · GitHub
AaronvanW has quit [Ping timeout: 248 seconds]
<sdaftuar>
glozow: awesome, thanks! also i did not think of this: "This means you can remove a transaction from your own mempool by calling prioritisetransaction with a negative value"
<sdaftuar>
my first impression is that i think that is sort of awesome behavior... but will give it more thought.
jon_atack has quit [Ping timeout: 260 seconds]
<sipa>
fjahr: A few comments, I haven't looked at any code yet.
<sipa>
Have you seen https://github.com/sipa/asmap/blob/nextgen/bottleneck.py? It does the "last common ASN" analysis/filtering for bgpdump output for me in ~2 hours for 700M bgpdump lines. Perhaps that's faster than what you have?
<glozow>
Yes I think it’s quite convenient for testing, though hopefully users don’t get confused and think they can cancel a tx after broadcasting
jon_atack has joined #bitcoin-core-dev
<sipa>
I don't understand where the multimap idea fits in. I realize that there can be conflicting data, so there are multiple ASNs for a single IP range, but even if this were encodable in the asmap file format, how would Bitcoin Core use it? Unless there is a useful way to incorporate this information, my thinking is that you just need a deterministic mechanism for picking one of the options.
<sipa>
Also, have you thought about how the data would (eventually) be included in Bitcoin Core? My thinking is that over time we'd perhaps just want it built into the binary, and that this built-in version would be used as default unless overridden. For auditability, that probably means a way to export the encoded asmap data, and/or RPCs to perform lookups in it.
nanotube has joined #bitcoin-core-dev
jon_atack has quit [Ping timeout: 252 seconds]
<sipa>
In my own experiments, in case there are multiple viable ASNs for the same IP range, it almost always seems there is one that appears in far more routes than the others, so that'd be an obvious way for selection.
<sdaftuar>
glozow: agreed, that is a concern. i wonder what usage patterns are common among miners for that RPC: would it make sense to restrict to the values to being nonnegative? (guessing that would break someone's use case, but really i have no idea)
AaronvanW has joined #bitcoin-core-dev
AaronvanW has quit [Ping timeout: 252 seconds]
b_101 has quit [Ping timeout: 248 seconds]
<codo>
Does bitcoin-git detect when there is conversation and then keeps silent? Or is there no github activity because people are busy having the conversation?
<sipa>
codo: Neither.
b_101 has joined #bitcoin-core-dev
<codo>
It appears to be more chatty on my screen when there is no conversation?
<sipa>
I can't imagine that's anything but a coincidence.
Norrin has quit [Ping timeout: 255 seconds]
Norrin has joined #bitcoin-core-dev
b_101 has quit [Ping timeout: 260 seconds]
b_101 has joined #bitcoin-core-dev
andrew_m_ has quit [Remote host closed the connection]
andrew_mo_ has joined #bitcoin-core-dev
jon_atack has joined #bitcoin-core-dev
hernanmarino has quit [Quit: Leaving]
abarakandi has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 248 seconds]
Talkless has quit [Quit: Konversation terminated!]
<bitcoin-git>
bitcoin/master 6d31900 furszy: wallet: migrate wallet, exit early if no legacy data exist
<bitcoin-git>
bitcoin/master fdd363e Andrew Chow: Merge bitcoin/bitcoin#26910: wallet: migrate wallet, exit early if no lega...
<bitcoin-git>
[bitcoin] achow101 merged pull request #26910: wallet: migrate wallet, exit early if no legacy data exist (master...2022_wallet_prevent_descriptors_migration) https://github.com/bitcoin/bitcoin/pull/26910