FrancisMr has joined #bitcoin-core-dev
FrancisMr has quit [Ping timeout: 252 seconds]
Evel-Knievel has quit [Ping timeout: 255 seconds]
Evel-Knievel has joined #bitcoin-core-dev
Evel-Knievel has quit [Read error: Connection reset by peer]
Evel-Knievel has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] fanquake closed pull request #27047: Update SECURITY.md (master...patch-1) https://github.com/bitcoin/bitcoin/pull/27047
doppo has quit [Quit: leaving]
doppo has joined #bitcoin-core-dev
doppo has quit [Client Quit]
doppo has joined #bitcoin-core-dev
Yihen has joined #bitcoin-core-dev
<midnight> p/w 25
<sipa> yes
earnestly has quit [Read error: Connection reset by peer]
Evel-Knievel has quit [Ping timeout: 268 seconds]
Evel-Knievel has joined #bitcoin-core-dev
FrancisMr has joined #bitcoin-core-dev
Evel-Knievel has quit [Ping timeout: 248 seconds]
Evel-Knievel has joined #bitcoin-core-dev
Evel-Knievel has quit [Ping timeout: 248 seconds]
Evel-Knievel has joined #bitcoin-core-dev
<bitcoin-git> [gui] pablomartin4btc opened pull request #708: qt: mask values on transactions view (master...mask-values-on-transaction-table) https://github.com/bitcoin-core/gui/pull/708
FrancisMr has quit [Ping timeout: 252 seconds]
Evel-Knievel has quit [Ping timeout: 248 seconds]
Evel-Knievel has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] BitcoinMechanic opened pull request #27049: git install command (master...osx-instructions) https://github.com/bitcoin/bitcoin/pull/27049
Evel-Knievel has quit [Remote host closed the connection]
Evel-Knievel has joined #bitcoin-core-dev
Evel-Knievel has quit [Ping timeout: 252 seconds]
Evel-Knievel has joined #bitcoin-core-dev
cmirror has quit [Remote host closed the connection]
cmirror has joined #bitcoin-core-dev
Evel-Knievel has quit [Ping timeout: 248 seconds]
Evel-Knievel has joined #bitcoin-core-dev
Evel-Knievel has quit [Ping timeout: 265 seconds]
Evel-Knievel has joined #bitcoin-core-dev
martin_1 has joined #bitcoin-core-dev
martin_1 has quit [Client Quit]
<bitcoin-git> [gui] RandyMcMillan closed pull request #702: Map Ctrl+0 to clear RPC console (master...1674512069/5271c77f8/a62231bca-console-clear-key-code) https://github.com/bitcoin-core/gui/pull/702
jarthur has quit [Quit: jarthur]
Evel-Knievel has quit [Ping timeout: 248 seconds]
Evel-Knievel has joined #bitcoin-core-dev
Guest50 has joined #bitcoin-core-dev
Guest50 has quit [Client Quit]
puneri123 has joined #bitcoin-core-dev
puneri123 has quit [Quit: Client closed]
dviola has quit [Quit: WeeChat 3.8]
dviola has joined #bitcoin-core-dev
Evel-Knievel has quit [Ping timeout: 246 seconds]
Evel-Knievel has joined #bitcoin-core-dev
Evel-Knievel has quit [Ping timeout: 248 seconds]
Evel-Knievel has joined #bitcoin-core-dev
Evel-Knievel has quit [Ping timeout: 260 seconds]
Evel-Knievel has joined #bitcoin-core-dev
salvatoshi has joined #bitcoin-core-dev
goatpig has joined #bitcoin-core-dev
Pasha has quit [Ping timeout: 248 seconds]
Cory has joined #bitcoin-core-dev
dermoth has quit [Ping timeout: 255 seconds]
dermoth has joined #bitcoin-core-dev
rszarka has joined #bitcoin-core-dev
Guyver2 has joined #bitcoin-core-dev
robszarka has quit [Ping timeout: 248 seconds]
arturomf94[m] has quit [Quit: You have been kicked for being idle]
Guest70 has joined #bitcoin-core-dev
Guest70 has quit [Client Quit]
<bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/d8f982603722...aff75463e2c7
<bitcoin-git> bitcoin/master b803229 John Moffett: Remove use of snprintf and simplify
<bitcoin-git> bitcoin/master aff7546 MarcoFalke: Merge bitcoin/bitcoin#27036: test: Remove last uses of snprintf and simpli...
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #27036: test: Remove last uses of snprintf and simplify (master...2023_02_FixDBWrapperTest) https://github.com/bitcoin/bitcoin/pull/27036
<yancy> sipa github does have an API for issues/PRs/etc so I guess those could be stored and managed elsewhere also. Maybe that's what Gitlab does, not really very familiar with Gitlab
realSatoshiNakam has joined #bitcoin-core-dev
FrancisMr has joined #bitcoin-core-dev
realSatoshiNakam has quit [Client Quit]
AaronvanW has joined #bitcoin-core-dev
earnestly has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] fanquake closed pull request #27049: doc: git install command (master...osx-instructions) https://github.com/bitcoin/bitcoin/pull/27049
b_101 has joined #bitcoin-core-dev
b_101_ has quit [Ping timeout: 260 seconds]
Livestradamus2 has joined #bitcoin-core-dev
Livestradamus has quit [Ping timeout: 260 seconds]
Livestradamus2 is now known as Livestradamus
Unhinged has joined #bitcoin-core-dev
Unhinged has quit [Client Quit]
<fjahr> yancy: yes, the data is available via API and GL is using that to import it. It can also be stored somewhere else but then when the project is excluded from these platforms we would also ideally have a system that we can switch to quickly, that is still running, can't be stopped as easily and let's us continue development with relatively low friction. A self-hosted GL instance could give us that because it displays the PRs,
<fjahr> issues and their discussions very similarly to GH and the conversations and development flows could continue in a similar fashion. CI integration is a similar issue but that will be even more tricky I think. If GH excludes us it's probably safe to assume that CircleCI might do the same.
brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
buddy85 has joined #bitcoin-core-dev
buddy85 has quit [K-Lined]
dviola has quit [Ping timeout: 248 seconds]
AaronvanW has quit [Remote host closed the connection]
<fjahr> achow101: I have written down the asmap release step-by-step how it could work for v25 specifically: https://gist.github.com/fjahr/f879769228f4f1c49b49d348f80d7635 I hope that makes it more clear.
Guyver2 has quit [Quit: Going offline, see ya! (www.adiirc.com)]
dviola has joined #bitcoin-core-dev
<phantomcircuit> sipa: it does though, since if you get a true positive and a false positive the false positive isn't relevant, but is still part of your calculation
AaronvanW has joined #bitcoin-core-dev
<fanquake> fjahr: What's the reason this data can't already be getting reviewed and tested prior to feature freeze?
<fanquake> What counts as an "issue" during an rc?
<fanquake> Not a fan of the idea of having to delay a relase for multiple weeks, because every couple days someone might pop up to say that the asmap file isn't quite correct (where, as far as I understand we don't know exactly what *correct* is?).
FrancisMr has quit [Ping timeout: 252 seconds]
roze_paul has joined #bitcoin-core-dev
bitdex has quit [Quit: = ""]
roze_paul has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.]
FrancisMr has joined #bitcoin-core-dev
<fjahr> fanquake: Right, I am explicitly trying to put together a process where the chance of a delay is minimized unless there is evidence of a substantial issue. It's the big reason I am also arguing against the "diffing logic" in my longer write-up because there we really lack an idea of how we can say diff x is ok and diff y is not ok. See also the last sentence in
<fjahr> The reason we might not want to do it before feature freeze is that the routing table changes more and more over time and the fresher the data is, the better it should be for the users. Of course a few days don’t make a huge difference when compared to a 6 months release cycle, so I would be fine if a file is created a week before feature freeze for example. I am just trying to anchor the process to the steps we already
<fjahr> have in place to make is explicit and this seemed like a good choice but happy to change it if there are better suggestions.
<fjahr> An example of an issue that could be discovered is that a BGP hijack or leak occured around the time the file was created (something like https://www.kentik.com/blog/new-year-new-bgp-leaks/) and the route found it’s way into the asmap file that is chosen. A fix for this case could both be choosing another file that does not have the attack included or just removing the problematic line(s) from the file. Another issue
<fjahr> could be that someone who runs their node on a specific IP looks up which AS their IP is mapped to in the file finds that the mapping is completely wrong. This case would probably require a bit of research (how did this happen, is this actually issue or is the users ISP is just not announcing prefixes themself etc.) and then rough consensus should decide if the file should be swapped.
<fjahr> We will probably want to do a dry run of the process. Not sure if a dry run without an actual release gives us enough eyes though. Maybe for v25 we go through as many steps of the process but at the end we don’t ship the file in the binary. Instead we just say: ‘hey, this would have been the file we would have shipped, so it’s somewhat “official”. Please use it if you want to use asmap in your node.’
Guest88 has joined #bitcoin-core-dev
Guest88 has quit [Client Quit]
jespada has quit [Remote host closed the connection]
jespada has joined #bitcoin-core-dev
Guest39 has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] fanquake closed pull request #25050: CValidationInterface: ValidationInterfaceUnregistering, called when being unregistered (master...validationIF_unregister) https://github.com/bitcoin/bitcoin/pull/25050
Guest39 has quit [Client Quit]
Guest39 has joined #bitcoin-core-dev
Guest39 has quit [Client Quit]
brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
FrancisMr has quit [Ping timeout: 268 seconds]
<pinheadmz> I set up a bitcoin/bitcoin github repo activity ticker on telegram: https://t.me/bitcoincoregithub
<pinheadmz> It tracks issues as well as comments, a bit of a firehose right now but I like getting the pulse of the entire project that way
<pinheadmz> feedback welcome
<bitcoin-git> [bitcoin] fanquake closed pull request #25434: mempool: Add option to bypass contextual timelocks in testmempoolaccept (master...bypass-timelocks) https://github.com/bitcoin/bitcoin/pull/25434
Guyver2 has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] dergoegge opened pull request #27050: p2p, validation: Don't download witnesses for assumed-valid blocks when running in prune mode (master...2023-02-av-wit-🧙) https://github.com/bitcoin/bitcoin/pull/27050
<vasild> pinheadmz: consider https://github.com/bitcoin-core/gui too
<pinheadmz> vasild good idea, I need a maintainer to set up the webhook, achow101 helped me with core repo
<vasild> pinheadmz: I guess that would be achow101 again
FrancisMr has joined #bitcoin-core-dev
bugs_ has joined #bitcoin-core-dev
earnestly has quit [Ping timeout: 260 seconds]
brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
aielima has joined #bitcoin-core-dev
FrancisMr has quit [Read error: Connection reset by peer]
FrancisMr has joined #bitcoin-core-dev
AaronvanW has quit [Remote host closed the connection]
halosghost has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] fanquake closed pull request #21319: RPC/Blockchain: Optimise getblock for simple disk-hex case (master...getblock_optimise) https://github.com/bitcoin/bitcoin/pull/21319
<jonatack> pinheadmz: nice! subscribed. perhaps an alternative to email notifications.
halosghost has quit [Ping timeout: 256 seconds]
AaronvanW has joined #bitcoin-core-dev
FrancisMr has quit [Ping timeout: 248 seconds]
Talkless has joined #bitcoin-core-dev
FrancisMr has joined #bitcoin-core-dev
halosghost has joined #bitcoin-core-dev
salvatoshi has quit [Ping timeout: 246 seconds]
AaronvanW has quit [Ping timeout: 252 seconds]
as2333 has joined #bitcoin-core-dev
FrancisMr has quit [Ping timeout: 246 seconds]
FrancisMr has joined #bitcoin-core-dev
martin_1 has joined #bitcoin-core-dev
pablomartin has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] LarryRuane opened pull request #27052: test: rpc: add last block announcement time to getpeerinfo result (master...2023-02-getpeerinfo) https://github.com/bitcoin/bitcoin/pull/27052
pablomartin has quit [Remote host closed the connection]
pablomartin has joined #bitcoin-core-dev
dviola has quit [Quit: WeeChat 3.8]
FrancisMr has quit [Ping timeout: 248 seconds]
AaronvanW has joined #bitcoin-core-dev
dviola has joined #bitcoin-core-dev
halosghost has quit [Read error: Connection reset by peer]
halosghost has joined #bitcoin-core-dev
martin_2 has joined #bitcoin-core-dev
robszarka has joined #bitcoin-core-dev
rszarka has quit [Ping timeout: 248 seconds]
martin_1 has quit [Ping timeout: 248 seconds]
aielima has quit [Ping timeout: 255 seconds]
aielima has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] achow101 pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/aff75463e2c7...52ddbd52f980
<bitcoin-git> bitcoin/master 935acdc pasta: refactor: modernize the implementation of uint256.*
<bitcoin-git> bitcoin/master 52ddbd5 Andrew Chow: Merge bitcoin/bitcoin#26345: refactor: modernize the implementation of uin...
<bitcoin-git> [bitcoin] achow101 merged pull request #26345: refactor: modernize the implementation of uint256.* (master...refactor/uint256-modernize) https://github.com/bitcoin/bitcoin/pull/26345
roze_paul has joined #bitcoin-core-dev
roze_paul has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.]
martin_2 has quit [Ping timeout: 252 seconds]
jarthur has joined #bitcoin-core-dev
fiatjaf_ has joined #bitcoin-core-dev
aielima has quit [Quit: Ciao]
brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
andrewtoth has joined #bitcoin-core-dev
Talkless has quit [Quit: Konversation terminated!]
<bitcoin-git> [bitcoin] pinheadmz opened pull request #27053: wallet: reuse change dest when re-creating TX with avoidpartialspends (master...change-addresses) https://github.com/bitcoin/bitcoin/pull/27053
b_101_ has joined #bitcoin-core-dev
hsmiths has quit [Quit: hsmiths]
b_101 has quit [Ping timeout: 268 seconds]
hsmiths has joined #bitcoin-core-dev
b_101_ has quit [Read error: Connection reset by peer]
b_101 has joined #bitcoin-core-dev
b_101_ has joined #bitcoin-core-dev
b_101 has quit [Ping timeout: 252 seconds]
AaronvanW has quit [Quit: Leaving...]
roze_paul has joined #bitcoin-core-dev
pablomartin has quit [Ping timeout: 260 seconds]
halosghost has quit [Read error: Connection reset by peer]
roze_paul has quit [Client Quit]
halosghost has joined #bitcoin-core-dev
brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
fiatjaf_ has quit [Quit: Leaving]
<kanzure> let me know if anyone has had recent (last ~week) difficulty sending email to bitcoin-dev mailing list (i have been tweaking some anti-spam settings) https://twitter.com/kanzure/status/1622667957120770082
rszarka has joined #bitcoin-core-dev
Guyver2 has quit [Quit: Going offline, see ya! (www.adiirc.com)]
johnzwen- has joined #bitcoin-core-dev
ajonas__ has joined #bitcoin-core-dev
gnusha_ has joined #bitcoin-core-dev
nickler_ has joined #bitcoin-core-dev
kanzure_ has joined #bitcoin-core-dev
[\\\] has joined #bitcoin-core-dev
robszarka has quit [*.net *.split]
tripleslash has quit [*.net *.split]
euclid[m] has quit [*.net *.split]
ajonas has quit [*.net *.split]
vincenzopalazzo has quit [*.net *.split]
gnusha has quit [*.net *.split]
kanzure has quit [*.net *.split]
johnzweng has quit [*.net *.split]
nickler has quit [*.net *.split]
ajonas__ is now known as ajonas
vincenzopalazzo has joined #bitcoin-core-dev
euclid[m] has joined #bitcoin-core-dev
brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
bugs_ has quit [Quit: Leaving]
FrancisMr has joined #bitcoin-core-dev
szkl has quit [Quit: Connection closed for inactivity]
halosghost has quit [Quit: WeeChat 3.8]
FrancisMr has quit [Ping timeout: 248 seconds]
FrancisMr has joined #bitcoin-core-dev