#bitcoin-core-dev on 2023-03-03 — searchable irc log

00:00 jhns_ has joined #bitcoin-core-dev

00:01 p2plife_ has joined #bitcoin-core-dev

00:01 p2plife has quit [Quit: quit]

00:02 jhns has quit [Read error: Connection reset by peer]

00:02 jhns_ is now known as jhns

00:08 brunoerg has joined #bitcoin-core-dev

00:10 sipsorcery_ has quit [Ping timeout: 252 seconds]

00:12 instagibbs1 has joined #bitcoin-core-dev

00:13 brunoerg has quit [Ping timeout: 260 seconds]

00:14 instagibbs has quit [Ping timeout: 268 seconds]

00:14 instagibbs1 is now known as instagibbs

00:25 cryptapus has quit [Read error: Connection reset by peer]

00:28 PaperSword has joined #bitcoin-core-dev

00:33 <PaperSword> If a data type just consists of 2 string should one use pair or create a new typedef?

00:34 Guest6 has joined #bitcoin-core-dev

00:39 Guest6 has quit [Quit: Client closed]

00:42 brunoerg has joined #bitcoin-core-dev

00:46 brunoerg has quit [Ping timeout: 264 seconds]

00:47 <PaperSword> If a data type just consists of 2 strings should one use pair or create a new typedef struct or class?

00:49 <_aj_> a struct makes it easier to not get confused about which string is which

00:49 <_aj_> no general rule though, i think?

00:50 <_aj_> (if it's c++ (pair) you don't need a typedef if you create a struct/class?)

00:55 <PaperSword> Yeah that is correct the biggest difference that i can see is that a pair is less readable because of the fact each member is accessed by .first and .second

00:55 <PaperSword> A struct on the other hand you must declare it, but allows for access to memebers via a name.

00:55 <PaperSword> In my cast I am creating maps of bech32 HRPs to the network string name.

01:05 <_aj_> use structured binding instead of .first and .second? auto [a,b] = pair; ?

01:31 brunoerg has joined #bitcoin-core-dev

01:36 brunoerg has quit [Ping timeout: 256 seconds]

01:46 cryptapus has joined #bitcoin-core-dev

01:58 ghost43 has quit [Quit: Leaving]

01:58 ghost43 has joined #bitcoin-core-dev

02:01 brunoerg has joined #bitcoin-core-dev

02:06 brunoerg has quit [Ping timeout: 248 seconds]

02:21 <PaperSword> @_aj_ the structured binding feature looks like a very elegant solution. C++17 and newer only.

02:24 jarthur has quit [Ping timeout: 248 seconds]

02:27 jarthur has joined #bitcoin-core-dev

02:31 brunoerg has joined #bitcoin-core-dev

02:36 brunoerg has quit [Ping timeout: 268 seconds]

02:41 onetwo has quit [Read error: Connection reset by peer]

02:44 onetwo has joined #bitcoin-core-dev

02:56 <sipa> use `auto& [a, b] = pair;` to avoid copies if they're non-trivial element types (e.g. strings you should not copy)

02:58 brunoerg has joined #bitcoin-core-dev

03:03 brunoerg has quit [Ping timeout: 255 seconds]

03:12 robszarka has joined #bitcoin-core-dev

03:15 rszarka has quit [Ping timeout: 248 seconds]

03:36 <PaperSword> Thanks @sipa! Yeah these structured bindings are a very cool feature I had not explored.

03:37 brunoerg has joined #bitcoin-core-dev

03:42 brunoerg has quit [Ping timeout: 246 seconds]

03:48 brunoerg has joined #bitcoin-core-dev

03:53 brunoerg has quit [Ping timeout: 248 seconds]

04:05 brunoerg has joined #bitcoin-core-dev

04:10 brunoerg has quit [Ping timeout: 260 seconds]

04:11 jon_atack has joined #bitcoin-core-dev

04:14 jonatack has quit [Ping timeout: 248 seconds]

04:22 brunoerg has joined #bitcoin-core-dev

04:27 brunoerg has quit [Ping timeout: 248 seconds]

04:33 brunoerg has joined #bitcoin-core-dev

04:37 brunoerg has quit [Ping timeout: 256 seconds]

04:44 brunoerg has joined #bitcoin-core-dev

04:46 realies has quit [Quit: ~]

04:47 realies has joined #bitcoin-core-dev

04:49 brunoerg has quit [Ping timeout: 268 seconds]

04:52 realies has quit [Ping timeout: 248 seconds]

05:01 cmirror has quit [Remote host closed the connection]

05:01 cmirror has joined #bitcoin-core-dev

05:04 puchka has quit [Ping timeout: 248 seconds]

05:06 puchka has joined #bitcoin-core-dev

05:09 realies has joined #bitcoin-core-dev

05:12 brunoerg has joined #bitcoin-core-dev

05:14 realies has quit [Quit: ~]

05:16 brunoerg has quit [Ping timeout: 264 seconds]

05:23 brunoerg has joined #bitcoin-core-dev

05:27 brunoerg has quit [Ping timeout: 248 seconds]

05:35 dougefish_ has quit [Ping timeout: 248 seconds]

05:39 dougefish has joined #bitcoin-core-dev

05:45 brunoerg has joined #bitcoin-core-dev

05:48 puchka has quit [Ping timeout: 268 seconds]

05:49 brunoerg has quit [Ping timeout: 248 seconds]

05:50 puchka has joined #bitcoin-core-dev

06:19 brunoerg has joined #bitcoin-core-dev

06:23 brunoerg has quit [Ping timeout: 252 seconds]

06:30 brunoerg has joined #bitcoin-core-dev

06:34 brunoerg has quit [Ping timeout: 248 seconds]

06:40 brunoerg has joined #bitcoin-core-dev

06:45 brunoerg has quit [Ping timeout: 256 seconds]

06:46 brunoerg has joined #bitcoin-core-dev

06:47 TheRec_ has joined #bitcoin-core-dev

06:51 brunoerg has quit [Ping timeout: 252 seconds]

06:55 jarthur has quit [*.net *.split]

06:55 dviola has quit [*.net *.split]

06:55 b_101 has quit [*.net *.split]

06:55 TheRec has quit [*.net *.split]

06:55 outfox has quit [*.net *.split]

06:55 Ara has quit [*.net *.split]

06:55 codo has quit [*.net *.split]

06:55 baakeydow has quit [*.net *.split]

06:55 sturles has quit [*.net *.split]

06:55 cornfeedhobo has quit [*.net *.split]

06:55 roasbeef has quit [*.net *.split]

06:55 warren has quit [*.net *.split]

06:55 Lightsword has quit [*.net *.split]

06:55 ajonas has quit [*.net *.split]

06:55 ariard has quit [*.net *.split]

06:55 furszy has quit [*.net *.split]

06:55 yancy has quit [*.net *.split]

06:55 jeremyrubin has quit [*.net *.split]

06:56 jarthur has joined #bitcoin-core-dev

06:56 dviola has joined #bitcoin-core-dev

06:56 b_101 has joined #bitcoin-core-dev

06:56 outfox has joined #bitcoin-core-dev

06:56 Ara has joined #bitcoin-core-dev

06:56 codo has joined #bitcoin-core-dev

06:56 baakeydow has joined #bitcoin-core-dev

06:56 sturles has joined #bitcoin-core-dev

06:56 roasbeef has joined #bitcoin-core-dev

06:56 warren has joined #bitcoin-core-dev

06:56 cornfeedhobo has joined #bitcoin-core-dev

06:57 brunoerg has joined #bitcoin-core-dev

07:02 brunoerg has quit [Ping timeout: 252 seconds]

07:03 brunoerg has joined #bitcoin-core-dev

07:08 brunoerg has quit [Ping timeout: 246 seconds]

07:14 brunoerg has joined #bitcoin-core-dev

07:16 jarthur has quit [Ping timeout: 248 seconds]

07:19 brunoerg has quit [Ping timeout: 264 seconds]

07:19 jarthur has joined #bitcoin-core-dev

07:20 brunoerg has joined #bitcoin-core-dev

07:24 brunoerg has quit [Ping timeout: 248 seconds]

07:31 brunoerg has joined #bitcoin-core-dev

07:35 dviola has quit [Ping timeout: 248 seconds]

07:36 brunoerg has quit [Ping timeout: 265 seconds]

07:36 dviola has joined #bitcoin-core-dev

07:42 brunoerg has joined #bitcoin-core-dev

07:47 brunoerg has quit [Ping timeout: 248 seconds]

07:53 brunoerg has joined #bitcoin-core-dev

07:58 brunoerg has quit [Ping timeout: 255 seconds]

07:59 goatpig_ has joined #bitcoin-core-dev

08:05 brunoerg has joined #bitcoin-core-dev

08:07 martins has joined #bitcoin-core-dev

08:07 jeremyrubin has joined #bitcoin-core-dev

08:09 brunoerg has quit [Ping timeout: 248 seconds]

08:16 Guyver2 has joined #bitcoin-core-dev

08:24 b_101_ has joined #bitcoin-core-dev

08:25 b_101 has quit [Ping timeout: 248 seconds]

08:27 brunoerg has joined #bitcoin-core-dev

08:27 dviola has left #bitcoin-core-dev [#bitcoin-core-dev]

08:27 dviola has joined #bitcoin-core-dev

08:31 brunoerg has quit [Ping timeout: 248 seconds]

08:37 martins has quit [Read error: Connection reset by peer]

08:43 brunoerg has joined #bitcoin-core-dev

08:48 brunoerg has quit [Ping timeout: 260 seconds]

08:49 p2plife_ has quit [Quit: quit]

08:50 p2plife has joined #bitcoin-core-dev

08:54 brunoerg has joined #bitcoin-core-dev

08:59 brunoerg has quit [Ping timeout: 248 seconds]

09:00 brunoerg has joined #bitcoin-core-dev

09:04 Guyver2 has left #bitcoin-core-dev [Closing Window]

09:05 brunoerg has quit [Ping timeout: 260 seconds]

09:25 brunoerg has joined #bitcoin-core-dev

09:30 brunoerg has quit [Ping timeout: 265 seconds]

09:31 brunoerg has joined #bitcoin-core-dev

09:36 brunoerg has quit [Ping timeout: 264 seconds]

09:52 brunoerg has joined #bitcoin-core-dev

09:57 brunoerg has quit [Ping timeout: 248 seconds]

10:10 brunoerg has joined #bitcoin-core-dev

10:15 brunoerg has quit [Ping timeout: 265 seconds]

10:16 brunoerg has joined #bitcoin-core-dev

10:21 brunoerg has quit [Ping timeout: 265 seconds]

10:27 brunoerg has joined #bitcoin-core-dev

10:32 brunoerg has quit [Ping timeout: 260 seconds]

10:38 brunoerg has joined #bitcoin-core-dev

10:43 brunoerg has quit [Ping timeout: 264 seconds]

10:49 brunoerg has joined #bitcoin-core-dev

10:53 brunoerg has quit [Ping timeout: 246 seconds]

10:55 brunoerg has joined #bitcoin-core-dev

10:59 brunoerg has quit [Ping timeout: 248 seconds]

11:06 brunoerg has joined #bitcoin-core-dev

11:10 brunoerg has quit [Ping timeout: 260 seconds]

11:27 jespada has quit [Remote host closed the connection]

11:28 jespada has joined #bitcoin-core-dev

11:37 brunoerg has joined #bitcoin-core-dev

11:41 brunoerg has quit [Ping timeout: 248 seconds]

11:48 Guest4 has joined #bitcoin-core-dev

11:56 Guest4 has quit [Quit: Ping timeout (120 seconds)]

11:56 Guest4 has joined #bitcoin-core-dev

11:57 Guest4 has quit [Client Quit]

11:59 brunoerg has joined #bitcoin-core-dev

12:03 brunoerg has quit [Ping timeout: 248 seconds]

12:10 brunoerg has joined #bitcoin-core-dev

12:15 brunoerg has quit [Ping timeout: 260 seconds]

12:16 brunoerg has joined #bitcoin-core-dev

13:42 jespada has quit [Quit: Textual IRC Client: www.textualapp.com]

13:53 scg has joined #bitcoin-core-dev

14:04 scg has quit [Quit: Client closed]

14:04 scg has joined #bitcoin-core-dev

14:16 brunoerg has quit [Remote host closed the connection]

14:17 brunoerg has joined #bitcoin-core-dev

14:24 <bitcoin-git> [bitcoin] fanquake pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/a12b27a2a6da...3b88c8502534

14:24 <bitcoin-git> bitcoin/master 1d02e59 stickies-v: test: add cases to JSON parsing

14:24 <bitcoin-git> bitcoin/master 7727603 stickies-v: refactor: reduce unnecessary complexity in ParseNonRFCJSONValue

14:24 <bitcoin-git> bitcoin/master 545ff92 stickies-v: refactor: use string_view for RPC named argument values

14:24 <bitcoin-git> [bitcoin] fanquake merged pull request #26612: refactor: RPC: pass named argument value as string_view (master...rpc-convert-string-view) https://github.com/bitcoin/bitcoin/pull/26612

14:37 ghost43 has quit [Quit: Leaving]

14:38 ghost43 has joined #bitcoin-core-dev

14:47 instagibbs has quit [Quit: Ping timeout (120 seconds)]

14:47 instagibbs has joined #bitcoin-core-dev

14:51 Guyver2 has joined #bitcoin-core-dev

14:52 Guyver2 has left #bitcoin-core-dev [#bitcoin-core-dev]

14:54 instagibbs has quit [Read error: Connection reset by peer]

15:07 robobub has quit [Quit: Connection closed for inactivity]

15:09 bugs_ has joined #bitcoin-core-dev

15:13 <bitcoin-git> [bitcoin] furszy opened pull request #27195: bumpfee: allow send coins back to yourself (master...2022_bumpfee_send_coins_back_to_yourself) https://github.com/bitcoin/bitcoin/pull/27195

16:03 yanmaani has quit [Ping timeout: 255 seconds]

16:07 yanmaani has joined #bitcoin-core-dev

16:17 instagibbs has joined #bitcoin-core-dev

16:20 hg has joined #bitcoin-core-dev

16:40 Guest54 has joined #bitcoin-core-dev

16:42 Guest54 has quit [Client Quit]

17:00 mudsip has joined #bitcoin-core-dev

17:01 mudsip has quit [Client Quit]

17:04 Guest99 has joined #bitcoin-core-dev

17:04 Guest99 has quit [Client Quit]

17:29 zeropoint has joined #bitcoin-core-dev

17:36 instagibbs has quit [Quit: The Lounge - https://thelounge.chat]

17:37 instagibbs has joined #bitcoin-core-dev

17:40 yanmaani has quit [Ping timeout: 255 seconds]

17:42 yanmaani has joined #bitcoin-core-dev

18:00 yanmaani has quit [Remote host closed the connection]

18:00 yanmaani has joined #bitcoin-core-dev

18:09 puchka has quit [Ping timeout: 252 seconds]

18:21 cm has quit [Quit: Bye.]

18:27 cm has joined #bitcoin-core-dev

18:31 emzy has quit [Quit: http://quassel-irc.org - Chat comfortably. Anywhere.]

18:31 qxs has quit [Ping timeout: 255 seconds]

18:33 emzy has joined #bitcoin-core-dev

18:33 qxs has joined #bitcoin-core-dev

18:39 sat-naka has joined #bitcoin-core-dev

18:48 sat-naka has quit [Quit: Client closed]

18:54 zeropoint has quit [Quit: leaving]

19:24 SpellChecker_ has joined #bitcoin-core-dev

19:31 SpellChecker has quit [Ping timeout: 255 seconds]

19:54 ___nick___ has joined #bitcoin-core-dev

19:56 meshcollider has quit [Changing host]

19:56 meshcollider has joined #bitcoin-core-dev

20:02 sipsorcery_ has joined #bitcoin-core-dev

20:07 ghost43 has quit [Quit: Leaving]

20:08 ghost43 has joined #bitcoin-core-dev

20:10 Guest49 has joined #bitcoin-core-dev

20:21 Guest49 has quit [Quit: Client closed]

20:38 guilauzier has joined #bitcoin-core-dev

20:45 guilauzier has quit [Quit: Ping timeout (120 seconds)]

20:53 Talkless has joined #bitcoin-core-dev

21:03 ___nick___ has quit [Quit: No Ping reply in 180 seconds.]

21:05 ___nick___ has joined #bitcoin-core-dev

21:13 ___nick___ has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.]

21:13 brunoerg has quit [Remote host closed the connection]

21:14 brunoerg has joined #bitcoin-core-dev

21:15 ___nick___ has joined #bitcoin-core-dev

21:17 ___nick___ has quit [Client Quit]

21:18 brunoerg has quit [Ping timeout: 248 seconds]

21:18 zeropoint has joined #bitcoin-core-dev

21:19 ___nick___ has joined #bitcoin-core-dev

21:31 zeropoint has quit [Quit: leaving]

21:47 brunoerg has joined #bitcoin-core-dev

21:52 brunoerg has quit [Ping timeout: 264 seconds]

21:53 <bitcoin-git> [bitcoin] hernanmarino opened pull request #27197: Fixed typos in comments to make linter happy (master...fix-typos-linter) https://github.com/bitcoin/bitcoin/pull/27197

21:58 brunoerg has joined #bitcoin-core-dev

22:02 Talkless has quit [Quit: Konversation terminated!]

22:03 brunoerg has quit [Ping timeout: 260 seconds]

22:09 brunoerg has joined #bitcoin-core-dev

22:14 brunoerg has quit [Ping timeout: 260 seconds]

22:20 brunoerg has joined #bitcoin-core-dev

22:25 brunoerg has quit [Ping timeout: 248 seconds]

22:34 neromm[m] has joined #bitcoin-core-dev

22:38 jon_atack has quit [Ping timeout: 246 seconds]

22:46 bugs_ has quit [Quit: Leaving]

22:54 brunoerg has joined #bitcoin-core-dev

22:59 brunoerg has quit [Ping timeout: 248 seconds]

23:05 brunoerg has joined #bitcoin-core-dev

23:05 ghost43 has quit [Remote host closed the connection]

23:05 ghost43 has joined #bitcoin-core-dev

23:09 brunoerg has quit [Ping timeout: 255 seconds]

23:11 brunoerg has joined #bitcoin-core-dev

23:12 nanotube has quit [Ping timeout: 255 seconds]

23:15 hg has quit [Quit: WeeChat 3.8]

23:15 brunoerg has quit [Ping timeout: 248 seconds]

23:19 bitdex has joined #bitcoin-core-dev

23:39 brunoerg has joined #bitcoin-core-dev

23:43 brunoerg has quit [Ping timeout: 264 seconds]

23:48 amishbtc_ has quit [Quit: Leaving]

23:55 AmishBTC has joined #bitcoin-core-dev

23:56 scg has quit [Quit: Client closed]