vasild has quit [Remote host closed the connection]
vasild has joined #bitcoin-core-dev
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 250 seconds]
<PaperSword>
I am struggling a bit to understand why I am getting a linter error for this statement
<PaperSword>
Error: Expected 0 argument(s) after format string but found 2 argument(s): tfm::format("Invalid chain prefix for %s. Expected %s got %s", networkLabel, params.Bech32HRP(), bech32Hrp)
<PaperSword>
^---- failure generated from lint-format-strings.py
<PaperSword>
My intent was just to get a formatted string back.
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 276 seconds]
andrew_mo_ has joined #bitcoin-core-dev
<luke-jr>
PaperSword: sounds like a linter bug :x
andrew_mo_ has quit [Ping timeout: 276 seconds]
ghost43 has quit [Remote host closed the connection]
ghost43 has joined #bitcoin-core-dev
<achow101>
PaperSword: we don't generally use tfm::format directly, so I think the linter is confused by it
<PaperSword>
So should I just go back to using addition operators?
<sipa>
You can use strprintf, I bet.
andrew_mo_ has joined #bitcoin-core-dev
<PaperSword>
strprintf looks like it would do the job nicely.
dviola has left #bitcoin-core-dev [#bitcoin-core-dev]
dviola has joined #bitcoin-core-dev
andrew_mo_ has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 255 seconds]
andrew_mo_ has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 250 seconds]
brunoerg has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 276 seconds]
brunoerg has quit [Ping timeout: 246 seconds]
brunoerg has joined #bitcoin-core-dev
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 276 seconds]
andrew_mo_ has joined #bitcoin-core-dev
ishaanam[m] has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 248 seconds]
preimage has joined #bitcoin-core-dev
PaperSword has quit [Ping timeout: 255 seconds]
andrew_mo_ has joined #bitcoin-core-dev
AaronvanW has quit [Remote host closed the connection]
AaronvanW has joined #bitcoin-core-dev
AaronvanW has quit [Read error: Connection reset by peer]
andrew_mo_ has quit [Ping timeout: 252 seconds]
wim96 has joined #bitcoin-core-dev
andrew_mo_ has joined #bitcoin-core-dev
wim96 has quit [Quit: Connection closed]
andrew_mo_ has quit [Ping timeout: 250 seconds]
andrew_mo_ has joined #bitcoin-core-dev
AaronvanW has joined #bitcoin-core-dev
andrew_mo_ has quit [Read error: Connection reset by peer]
andrew_mo_ has joined #bitcoin-core-dev
rolf1 has joined #bitcoin-core-dev
rolf1 has quit [Client Quit]
andrew_mo_ has quit [Ping timeout: 248 seconds]
AaronvanW has quit [Remote host closed the connection]
andrew_mo_ has joined #bitcoin-core-dev
andrew_m_ has joined #bitcoin-core-dev
andrew___ has joined #bitcoin-core-dev
AaronvanW has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 246 seconds]
andrew_m_ has quit [Ping timeout: 246 seconds]
andrew___ has quit [Ping timeout: 265 seconds]
andrew_mo_ has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] ismaelsadeeq opened pull request #27269: test: Support decoding segwit address in address_to_scriptpubkey() (master...add-bech32-testnet-address-to-scriptpubkey) https://github.com/bitcoin/bitcoin/pull/27269
andrew_mo_ has quit [Ping timeout: 268 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_m_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 252 seconds]
andrew_m_ has quit [Ping timeout: 268 seconds]
<achow101>
guix builders: code 24.1rc1 code signatures are pushed. the tag in the detached sigs repo was force pushed to a different commit, you may need to force fetch it. also you may need to redo the entire guix build if you've already attempted to guix-codesign with the previous sig
<provoostenator>
I did :-) How do you undo an earlier build again?
<achow101>
rm -rf guix-build-24.1rc1/
<earnestly>
achow101: Is there a way to make such a state impossible?
<achow101>
the way is for me to test attaching all of the code sigs before pushing a tag :)
<earnestly>
But can that be mechanised in such a way to make the accident essentially unexpressible
<earnestly>
Always wonder about such things
<achow101>
I don't think so
<earnestly>
github did add some features that would reject certain types of pushes iirc
<achow101>
unless we can make github do the guix build and codesigning, I don't think there's a way
<earnestly>
Yeah, fair enough
salvatoshi has quit [Ping timeout: 256 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 255 seconds]
<darosior>
I won't attend the meeting, but can i have #27255 as high prio?
<bitcoin-git>
[bitcoin] dergoegge opened pull request #27270: refactor, net processing: Avoid CNode::m_relays_txs usage (master...2023-03-no-cnode-txrelays) https://github.com/bitcoin/bitcoin/pull/27270
andrew_mo_ has quit [Ping timeout: 248 seconds]
_fractal[m] has joined #bitcoin-core-dev
<bitcoin-git>
[gui] hernanmarino opened pull request #722: Wallet : Allow user to navigate options while encrypting at creation (master...wallet-encryption-navigation) https://github.com/bitcoin-core/gui/pull/722
larryruane_ is now known as LarryRuane
jarthur has joined #bitcoin-core-dev
<ajonas>
#proposedmeetingtopic annual bitcoin core dev survey
andrew_mo_ has joined #bitcoin-core-dev
andrew_m_ has joined #bitcoin-core-dev
MacroFake has quit [Ping timeout: 260 seconds]
MacroFake has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 276 seconds]
jon_atack has quit [Read error: Connection reset by peer]
nickler_ has quit [Ping timeout: 256 seconds]
nickler has joined #bitcoin-core-dev
andrew_m_ has quit [Ping timeout: 276 seconds]
andrew_mo_ has joined #bitcoin-core-dev
Talkless has joined #bitcoin-core-dev
<kanzure>
oh no my timezones
<pinheadmz>
oh yeah
andrew_mo_ has quit [Ping timeout: 276 seconds]
jonatack has joined #bitcoin-core-dev
<provoostenator>
Oh wow, I had to do: git fetch --tags --force
<provoostenator>
(and build it again)
Guest72 has joined #bitcoin-core-dev
Guest72 has quit [Client Quit]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 260 seconds]
<dviola>
sipa: starting without a -dbcache= should use whatever the default one is right?
<bugs_>
unless there is an entry in bitcoin.conf for dbcache
<bitcoin-git>
[bitcoin] instagibbs opened pull request #27271: Fix fund transaction case at 0-value, 0-fee (master...empty_value_crash) https://github.com/bitcoin/bitcoin/pull/27271