#bitcoin-core-dev on 2023-03-22 — searchable irc log

00:03 dougefish has quit [Remote host closed the connection]

00:03 dougefish has joined #bitcoin-core-dev

00:09 MeA_BzZz has quit [Quit: Client closed]

00:42 doppo_ has quit [Ping timeout: 246 seconds]

00:44 infernix has quit [Quit: ZNC - http://znc.sourceforge.net]

00:49 doppo has joined #bitcoin-core-dev

00:52 brunoerg has quit [Remote host closed the connection]

00:53 brunoerg has joined #bitcoin-core-dev

00:58 infernix has joined #bitcoin-core-dev

00:59 brunoerg has quit [Ping timeout: 265 seconds]

01:22 brunoerg has joined #bitcoin-core-dev

01:27 brunoerg has quit [Ping timeout: 264 seconds]

01:55 brunoerg has joined #bitcoin-core-dev

01:58 zeropoint has quit [Quit: leaving]

02:00 brunoerg has quit [Ping timeout: 265 seconds]

02:08 BUSY has quit [Remote host closed the connection]

02:18 TheRec_ has joined #bitcoin-core-dev

02:18 TheRec has quit [Read error: Connection reset by peer]

02:21 brunoerg has joined #bitcoin-core-dev

02:25 brunoerg has quit [Ping timeout: 246 seconds]

02:31 brunoerg has joined #bitcoin-core-dev

02:36 brunoerg has quit [Ping timeout: 265 seconds]

02:48 brunoerg has joined #bitcoin-core-dev

02:51 szkl has quit [Quit: Connection closed for inactivity]

02:52 brunoerg has quit [Ping timeout: 240 seconds]

03:50 brunoerg has joined #bitcoin-core-dev

03:55 brunoerg has quit [Ping timeout: 240 seconds]

04:00 andrewtoth has quit [Remote host closed the connection]

04:00 andrewtoth has joined #bitcoin-core-dev

04:01 cmirror has quit [Remote host closed the connection]

04:01 brunoerg has joined #bitcoin-core-dev

04:01 cmirror has joined #bitcoin-core-dev

04:03 doppo has quit [Ping timeout: 248 seconds]

04:04 doppo has joined #bitcoin-core-dev

04:05 brunoerg has quit [Ping timeout: 265 seconds]

04:07 brunoerg has joined #bitcoin-core-dev

04:11 brunoerg has quit [Ping timeout: 240 seconds]

04:18 brunoerg has joined #bitcoin-core-dev

04:22 brunoerg has quit [Ping timeout: 265 seconds]

04:51 brunoerg has joined #bitcoin-core-dev

04:56 brunoerg has quit [Ping timeout: 265 seconds]

04:57 brunoerg has joined #bitcoin-core-dev

05:01 brunoerg has quit [Ping timeout: 240 seconds]

05:08 brunoerg has joined #bitcoin-core-dev

05:13 brunoerg has quit [Ping timeout: 268 seconds]

05:14 brunoerg has joined #bitcoin-core-dev

05:18 brunoerg has quit [Ping timeout: 265 seconds]

05:19 brunoerg has joined #bitcoin-core-dev

05:24 brunoerg has quit [Ping timeout: 240 seconds]

05:30 brunoerg has joined #bitcoin-core-dev

05:34 brunoerg has quit [Ping timeout: 240 seconds]

05:46 outfox has quit [Ping timeout: 248 seconds]

06:04 brunoerg has joined #bitcoin-core-dev

06:08 brunoerg has quit [Ping timeout: 240 seconds]

06:09 Cory has quit [Changing host]

06:09 Cory has joined #bitcoin-core-dev

06:10 Yihen has joined #bitcoin-core-dev

06:12 Yihen has quit [Remote host closed the connection]

06:13 Yihen has joined #bitcoin-core-dev

06:14 Yihen has quit [Remote host closed the connection]

06:14 brunoerg has joined #bitcoin-core-dev

06:14 Yihen has joined #bitcoin-core-dev

06:16 Yihen has quit [Remote host closed the connection]

06:16 Yihen has joined #bitcoin-core-dev

06:19 brunoerg has quit [Ping timeout: 265 seconds]

06:26 brunoerg has joined #bitcoin-core-dev

06:30 brunoerg has quit [Ping timeout: 265 seconds]

06:36 brunoerg has joined #bitcoin-core-dev

06:41 brunoerg has quit [Ping timeout: 248 seconds]

06:48 brunoerg has joined #bitcoin-core-dev

06:52 brunoerg has quit [Ping timeout: 264 seconds]

06:58 brunoerg has joined #bitcoin-core-dev

07:03 brunoerg has quit [Ping timeout: 260 seconds]

07:05 brunoerg has joined #bitcoin-core-dev

07:06 realies has quit [Ping timeout: 246 seconds]

07:09 brunoerg has quit [Ping timeout: 240 seconds]

07:10 Yihen has quit [Remote host closed the connection]

07:21 brunoerg has joined #bitcoin-core-dev

07:31 brunoerg has quit [Ping timeout: 265 seconds]

07:32 brunoerg has joined #bitcoin-core-dev

07:32 Nullor has joined #bitcoin-core-dev

07:33 Nullor has quit [Quit: Textual IRC Client: www.textualapp.com]

07:36 brunoerg has quit [Ping timeout: 246 seconds]

07:38 brunoerg has joined #bitcoin-core-dev

07:43 brunoerg has quit [Ping timeout: 240 seconds]

07:49 brunoerg has joined #bitcoin-core-dev

07:54 brunoerg has quit [Ping timeout: 240 seconds]

07:59 brunoerg has joined #bitcoin-core-dev

08:04 brunoerg has quit [Ping timeout: 240 seconds]

08:05 brunoerg has joined #bitcoin-core-dev

08:10 brunoerg has quit [Ping timeout: 246 seconds]

08:16 brunoerg has joined #bitcoin-core-dev

08:21 brunoerg has quit [Ping timeout: 265 seconds]

08:26 Guest73 has joined #bitcoin-core-dev

08:26 Guest73 has quit [Client Quit]

08:29 Guyver2 has joined #bitcoin-core-dev

08:31 Guyver2 has left #bitcoin-core-dev [#bitcoin-core-dev]

08:42 <darosior> We should update the website instructions, someone is confused about the lack of builder keys on Github that https://bitcoincore.org/en/download/#verify-your-download links to

08:47 <darosior> (https://bitcoin.stackexchange.com/q/117125/101498

08:55 brunoerg has joined #bitcoin-core-dev

09:00 brunoerg has quit [Ping timeout: 268 seconds]

09:01 brunoerg has joined #bitcoin-core-dev

09:05 brunoerg has quit [Ping timeout: 246 seconds]

09:06 brunoerg has joined #bitcoin-core-dev

09:11 brunoerg has quit [Ping timeout: 260 seconds]

09:17 brunoerg has joined #bitcoin-core-dev

09:22 brunoerg has quit [Ping timeout: 246 seconds]

09:26 <fanquake> darosior: couple PRs open if you want to review: https://github.com/bitcoin-core/bitcoincore.org/pull/878, https://github.com/bitcoin-core/bitcoincore.org/pull/807

09:27 <darosior> Checking out

09:28 brunoerg has joined #bitcoin-core-dev

09:33 brunoerg has quit [Ping timeout: 240 seconds]

09:45 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/664500fc71a3...34551cb97aff

09:45 <bitcoin-git> bitcoin/master fa67b81 MarcoFalke: Refactor: Remove unused FlatFilePos::SetNull

09:45 <bitcoin-git> bitcoin/master 34551cb fanquake: Merge bitcoin/bitcoin#27289: Refactor: Remove unused FlatFilePos::SetNull

09:45 <bitcoin-git> [bitcoin] fanquake merged pull request #27289: Refactor: Remove unused FlatFilePos::SetNull (master...2303-no-flatfile-setnull-🚗) https://github.com/bitcoin/bitcoin/pull/27289

09:56 brunoerg has joined #bitcoin-core-dev

09:56 <darosior> I started a patch to the instructions but it's not as straightforward as it seemed to me at first...

10:00 AaronvanW has joined #bitcoin-core-dev

10:00 brunoerg has quit [Ping timeout: 256 seconds]

10:01 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/34551cb97aff...6e69fead2baf

10:01 <bitcoin-git> bitcoin/master 33337eb MarcoFalke: test: Fix TypeError in wait_for_debug_log

10:01 <bitcoin-git> bitcoin/master 6e69fea fanquake: Merge bitcoin/bitcoin#27280: test: Fix TypeError (expected str instance, b...

10:01 <bitcoin-git> [bitcoin] fanquake merged pull request #27280: test: Fix TypeError (expected str instance, bytes found) in wait_for_debug_log (master...2303-test-type-error-bytes-🤓) https://github.com/bitcoin/bitcoin/pull/27280

10:02 brunoerg has joined #bitcoin-core-dev

10:02 <bitcoin-git> [bitcoin] fanquake opened pull request #27296: guix: import/sync python-lief (0.12.3) package definition from upstream (master...import_lief_curr_upstream) https://github.com/bitcoin/bitcoin/pull/27296

10:07 brunoerg has quit [Ping timeout: 240 seconds]

10:17 <darosior> Alright, that's something to start with: https://github.com/bitcoin-core/bitcoincore.org/pull/957/checks?check_run_id=12187455363

10:18 <darosior> Woops i meant to link the PR not the CI check.

10:25 brunoerg has joined #bitcoin-core-dev

10:29 brunoerg has quit [Ping timeout: 246 seconds]

10:30 brunoerg has joined #bitcoin-core-dev

10:35 brunoerg has quit [Ping timeout: 268 seconds]

10:42 midnight has quit [Ping timeout: 252 seconds]

10:43 cold has quit [Ping timeout: 255 seconds]

10:44 cold has joined #bitcoin-core-dev

10:44 midnight has joined #bitcoin-core-dev

10:47 brunoerg has joined #bitcoin-core-dev

10:52 brunoerg has quit [Ping timeout: 250 seconds]

11:04 brunoerg has joined #bitcoin-core-dev

11:08 brunoerg has quit [Ping timeout: 265 seconds]

11:15 brunoerg has joined #bitcoin-core-dev

11:17 <bitcoin-git> [bitcoin] fanquake pushed 11 commits to master: https://github.com/bitcoin/bitcoin/compare/6e69fead2baf...a70911492fcd

11:17 <bitcoin-git> bitcoin/master 15209d9 Hennadii Stepanov: consensus, refactor: Avoid `CScriptCheck::swap` in `CheckInputScripts`

11:17 <bitcoin-git> bitcoin/master 0682003 Hennadii Stepanov: test, refactor: Avoid `CScriptCheck::swap` in `transaction_tests`

11:17 <bitcoin-git> bitcoin/master 6c2d597 Hennadii Stepanov: refactor: Use move semantics in `CCheckQueue::Add`

11:17 <bitcoin-git> [bitcoin] fanquake merged pull request #26749: refactor: Use move semantics instead of custom swap functions (master...221224-move) https://github.com/bitcoin/bitcoin/pull/26749

11:18 jon_atack has joined #bitcoin-core-dev

11:19 <fanquake> Does anyone else ever have an issue where the unit tests running under valgrind sometimes stall/fail to complete after the very-last unit test?

11:19 jonatack has quit [Ping timeout: 268 seconds]

11:19 <fanquake> Something I've seen intermittently, which was fixed some time, but seems to have returned

11:19 brunoerg has quit [Ping timeout: 264 seconds]

11:21 brunoerg has joined #bitcoin-core-dev

11:25 brunoerg has quit [Ping timeout: 240 seconds]

11:38 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #27297: test: Remove unused Check* default constructors (master...2303-test-remove-dead-code-😼) https://github.com/bitcoin/bitcoin/pull/27297

11:42 brunoerg has joined #bitcoin-core-dev

11:47 brunoerg has quit [Ping timeout: 240 seconds]

11:52 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #27298: ci: Use TSan v2 (llvm-16, take 3) (master...2303-ci-tsan-v2-llvm-16-take-3-🌡) https://github.com/bitcoin/bitcoin/pull/27298

12:14 b_101_ has quit [Ping timeout: 255 seconds]

12:15 b_101 has joined #bitcoin-core-dev

12:16 brunoerg has joined #bitcoin-core-dev

12:21 brunoerg has quit [Ping timeout: 240 seconds]

12:23 brunoerg has joined #bitcoin-core-dev

12:26 aureleoules has quit [Ping timeout: 260 seconds]

12:30 aureleoules has joined #bitcoin-core-dev

12:31 brunoerg has quit [Remote host closed the connection]

12:32 brunoerg has joined #bitcoin-core-dev

12:36 brunoerg has quit [Ping timeout: 240 seconds]

12:43 brunoerg has joined #bitcoin-core-dev

12:45 ghost43_ has joined #bitcoin-core-dev

12:46 ghost43 has quit [Ping timeout: 255 seconds]

12:47 bitdex has quit [Quit: = ""]

12:47 brunoerg has quit [Ping timeout: 265 seconds]

12:49 brunoerg has joined #bitcoin-core-dev

12:53 brunoerg has quit [Ping timeout: 265 seconds]

12:56 aureleoules has quit [Ping timeout: 248 seconds]

12:58 aureleoules has joined #bitcoin-core-dev

13:08 AaronvanW has quit [Remote host closed the connection]

13:10 brunoerg has joined #bitcoin-core-dev

13:15 brunoerg has quit [Ping timeout: 240 seconds]

13:22 brunoerg has joined #bitcoin-core-dev

13:26 brunoerg has quit [Ping timeout: 240 seconds]

13:33 brunoerg has joined #bitcoin-core-dev

13:39 AaronvanW has joined #bitcoin-core-dev

13:44 brunoerg has quit [Remote host closed the connection]

13:44 brunoerg has joined #bitcoin-core-dev

13:52 <bitcoin-git> [bitcoin] willcl-ark opened pull request #27300: build: debug enable addrman consistency checks (master...enable-addrman-consist) https://github.com/bitcoin/bitcoin/pull/27300

13:57 <bitcoin-git> [bitcoin] fanquake opened pull request #27301: depends: fontconfig 2.14.2 (master...fontconfig_2_14_2) https://github.com/bitcoin/bitcoin/pull/27301

14:13 AaronvanW has quit [Ping timeout: 268 seconds]

14:15 <bitcoin-git> [bitcoin] instagibbs closed pull request #27019: bench: Expand mempool eviction benchmarking (master...bench_eviction) https://github.com/bitcoin/bitcoin/pull/27019

14:23 outfox has joined #bitcoin-core-dev

14:31 AaronvanW has joined #bitcoin-core-dev

14:48 angusp has quit [Remote host closed the connection]

14:51 angusp has joined #bitcoin-core-dev

15:14 gambpang has joined #bitcoin-core-dev

15:24 <pinheadmz> https://github.com/bitcoin/bitcoin/blob/a70911492fcd1f726782cca2f1ffac18c25e8fb4/src/chain.h#L186

15:24 <pinheadmz> does this need to be changed for 25.0 ?

15:25 <pinheadmz> i guess, ~800M tx is about 30 bits?

15:26 <sipa> we're only at 816553407 txn

15:26 <sipa> so we have at least 208000 blocks left before hitting 2^32

15:28 <theStack> fwiw there was a pr opened tackling this last year, but it didn't get any review: #24912

15:28 <gribble> https://github.com/bitcoin/bitcoin/issues/24912 | refactor: update CBlockIndex::nChainTx to be uint64_t by mruddy · Pull Request #24912 · bitcoin/bitcoin · GitHub

15:30 bugs_ has joined #bitcoin-core-dev

15:31 <instagibbs> probably should resurrect that since nodes will also have to update to not hit it? that got closed very quickly for a longer timeframe PR

15:40 pablomartin has joined #bitcoin-core-dev

15:48 mudsip has joined #bitcoin-core-dev

15:48 mudsip has quit [Client Quit]

15:50 angusp has quit [Write error: Broken pipe]

15:56 pakaro has joined #bitcoin-core-dev

15:56 angusp has joined #bitcoin-core-dev

16:12 pakaro has quit [Ping timeout: 276 seconds]

16:16 aielima has joined #bitcoin-core-dev

16:17 Guest76 has joined #bitcoin-core-dev

16:18 brunoerg has quit [Ping timeout: 240 seconds]

16:19 sudoforge has joined #bitcoin-core-dev

16:19 Guest76 has quit [Client Quit]

16:19 Guest76 has joined #bitcoin-core-dev

16:25 brunoerg has joined #bitcoin-core-dev

16:29 brunoerg has quit [Ping timeout: 265 seconds]

16:32 brunoerg has joined #bitcoin-core-dev

16:44 pakaro has joined #bitcoin-core-dev

16:48 AaronvanW has quit [Remote host closed the connection]

16:49 pakaro has quit [Ping timeout: 246 seconds]

16:49 pakaro has joined #bitcoin-core-dev

16:54 hernanmarino has joined #bitcoin-core-dev

16:55 <bitcoin-git> bitcoin/master d7cc503 Greg Sanders: Fix fund transaction case at 0-value, 0-fee

16:55 <bitcoin-git> bitcoin/master fc7c21f Andrew Chow: Merge bitcoin/bitcoin#27271: RPC: Fix fund transaction crash when at 0-val...

16:55 <bitcoin-git> [bitcoin] achow101 pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/a70911492fcd...fc7c21f664fd

16:55 <bitcoin-git> [bitcoin] achow101 merged pull request #27271: RPC: Fix fund transaction crash when at 0-value, 0-fee (master...empty_value_crash) https://github.com/bitcoin/bitcoin/pull/27271

16:59 luke-jr_ has joined #bitcoin-core-dev

16:59 brunoerg has quit [Remote host closed the connection]

17:00 brunoerg has joined #bitcoin-core-dev

17:00 luke-jr has quit [Ping timeout: 248 seconds]

17:19 AaronvanW has joined #bitcoin-core-dev

17:29 brunoerg has quit [Remote host closed the connection]

17:30 brunoerg has joined #bitcoin-core-dev

17:38 <bitcoin-git> [bitcoin] ryanofsky opened pull request #27302: init: Error if ignored bitcoin.conf file is found (master...pr/ignoredconf) https://github.com/bitcoin/bitcoin/pull/27302

17:46 gambpang has quit [Remote host closed the connection]

17:53 AaronvanW has quit [Ping timeout: 268 seconds]

17:53 ___nick___ has joined #bitcoin-core-dev

17:55 sudoforge has quit [Read error: Connection reset by peer]

17:55 sudoforge has joined #bitcoin-core-dev

17:56 pablomartin has quit [Ping timeout: 240 seconds]

17:58 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/fc7c21f664fd...4c6b7d330a4e

17:58 <bitcoin-git> bitcoin/master fae3490 MarcoFalke: test: Remove unused Check* default constructors

17:58 <bitcoin-git> bitcoin/master 4c6b7d3 fanquake: Merge bitcoin/bitcoin#27297: test: Remove unused Check* default constructo...

17:58 <bitcoin-git> [bitcoin] fanquake merged pull request #27297: test: Remove unused Check* default constructors (master...2303-test-remove-dead-code-😼) https://github.com/bitcoin/bitcoin/pull/27297

17:59 brunoerg has quit [Remote host closed the connection]

18:00 brunoerg has joined #bitcoin-core-dev

18:04 Talkless has joined #bitcoin-core-dev

18:06 pakaro has quit [Ping timeout: 240 seconds]

18:16 ___nick___ has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.]

18:19 ___nick___ has joined #bitcoin-core-dev

18:19 ___nick___ has quit [Client Quit]

18:20 pakaro has joined #bitcoin-core-dev

18:22 ___nick___ has joined #bitcoin-core-dev

18:31 sudoforge has quit [Ping timeout: 250 seconds]

18:32 Guest76 has quit [Quit: Client closed]

18:35 pablomartin has joined #bitcoin-core-dev

18:40 pakaro has quit [Ping timeout: 246 seconds]

18:49 Guest52 has joined #bitcoin-core-dev

18:49 pablomartin has quit [Ping timeout: 246 seconds]

18:55 Guest52 has quit [Quit: Client closed]

18:56 ddisqq has joined #bitcoin-core-dev

19:05 <bitcoin-git> [bitcoin] pinheadmz opened pull request #27303: system: cache config file path before potentially updating datadir (master...cache-conf-file) https://github.com/bitcoin/bitcoin/pull/27303

19:14 AaronvanW has joined #bitcoin-core-dev

19:24 aielima has quit [Quit: Ciao]

19:27 wim96 has joined #bitcoin-core-dev

19:37 Guest55 has joined #bitcoin-core-dev

19:38 Guest55 has quit [Client Quit]

19:41 AaronvanW has quit [Quit: Leaving...]

19:43 sudoforge has joined #bitcoin-core-dev

19:50 wim96 has quit [Quit: Connection closed]

20:05 Talkless has quit [Quit: Konversation terminated!]

20:16 ddisqq has quit [Remote host closed the connection]

20:17 ddisqq has joined #bitcoin-core-dev

20:21 chip_x has joined #bitcoin-core-dev

20:22 ddisqq has quit [Ping timeout: 276 seconds]

20:26 chip_x has quit [Quit: Leaving]

20:36 ddisqq has joined #bitcoin-core-dev

20:43 sgiath has quit [Ping timeout: 260 seconds]

20:46 sgiath has joined #bitcoin-core-dev

20:47 jon_atack has quit [Ping timeout: 240 seconds]

20:49 jon_atack has joined #bitcoin-core-dev

20:53 ddisqq has quit [Quit: Leaving...]

20:54 ddisqq has joined #bitcoin-core-dev

21:04 ___nick___ has quit [Ping timeout: 265 seconds]

21:21 ddisqq has quit [Remote host closed the connection]

21:22 ddisqq has joined #bitcoin-core-dev

21:23 vasild has quit [Ping timeout: 255 seconds]

21:26 ddisqq has quit [Ping timeout: 240 seconds]

21:27 realies has joined #bitcoin-core-dev

21:29 vasild has joined #bitcoin-core-dev

21:30 <bitcoin-git> [bitcoin] ishaanam opened pull request #27307: wallet: track mempool conflicts with wallet transactions (master...track_mempool_wallet_conflicts) https://github.com/bitcoin/bitcoin/pull/27307

21:30 abubakar has joined #bitcoin-core-dev

21:31 codo has quit [Ping timeout: 248 seconds]

21:31 codo has joined #bitcoin-core-dev

21:40 marus has joined #bitcoin-core-dev

21:41 abubakar_ has joined #bitcoin-core-dev

21:44 marus has quit [Client Quit]

21:44 Thoams has joined #bitcoin-core-dev

21:45 abubakar has quit [Ping timeout: 268 seconds]

21:45 abubakar_ has quit [Read error: Connection reset by peer]

21:47 abubakar has joined #bitcoin-core-dev

21:47 bugs_ has quit [Quit: Leaving]

21:55 ddisqq has joined #bitcoin-core-dev

22:04 ddisqq has quit [Ping timeout: 255 seconds]

22:18 Guest73 has joined #bitcoin-core-dev

22:19 Guest73 has quit [Client Quit]

22:20 Thoams has quit [Ping timeout: 276 seconds]

22:37 ddisqq has joined #bitcoin-core-dev

22:42 ddisqq has quit [Ping timeout: 240 seconds]

22:45 jarthur has quit [Quit: jarthur]

23:02 ddisqq has joined #bitcoin-core-dev

23:02 vasild has quit [Ping timeout: 255 seconds]

23:04 vasild has joined #bitcoin-core-dev

23:05 <bitcoin-git> [bitcoin] achow101 opened pull request #27308: bumpfee: avoid making bumped transactions with too low fee when replacing outputs (master...fix-bumpfee-replaced-outputs-fee-calc) https://github.com/bitcoin/bitcoin/pull/27308

23:07 ddisqq has quit [Ping timeout: 276 seconds]

23:21 ddisqq has joined #bitcoin-core-dev

23:21 sudoforge has quit [Quit: 404]

23:25 ddisqq has quit [Ping timeout: 240 seconds]

23:39 ddisqq has joined #bitcoin-core-dev

23:49 ddisqq has quit [Ping timeout: 268 seconds]