andrew_mo_ has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 248 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 248 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 248 seconds]
jespada has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
jespada has quit [Client Quit]
brunoerg has quit [Ping timeout: 248 seconds]
brunoerg has joined #bitcoin-core-dev
andrew_mo_ has joined #bitcoin-core-dev
jespada has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
andrew_mo_ has quit [Ping timeout: 276 seconds]
brunoerg has joined #bitcoin-core-dev
andrew_mo_ has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 248 seconds]
brunoerg has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 248 seconds]
brunoerg has quit [Ping timeout: 248 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 255 seconds]
AaronvanW has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 252 seconds]
brunoerg has joined #bitcoin-core-dev
javi404 has quit [Quit: No Ping reply in 180 seconds.]
brunoerg has quit [Ping timeout: 260 seconds]
javi404 has joined #bitcoin-core-dev
nulldoot2k_ has quit [Quit: Leaving]
vyHamii has joined #bitcoin-core-dev
nanotube has quit [Ping timeout: 268 seconds]
AaronvanW has joined #bitcoin-core-dev
yanmaani1 has quit [Remote host closed the connection]
yanmaani1 has joined #bitcoin-core-dev
SpellChecker has quit [Remote host closed the connection]
SpellChecker has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 255 seconds]
jespada has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
brunoerg has joined #bitcoin-core-dev
AaronvanW has quit [Ping timeout: 255 seconds]
hgst has quit [Quit: WeeChat 3.8]
brunoerg has quit [Ping timeout: 248 seconds]
nulldoot2k_ has joined #bitcoin-core-dev
vyHamii has quit [Ping timeout: 255 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 248 seconds]
brunoerg has joined #bitcoin-core-dev
andrew_mo_ has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 248 seconds]
andrew_mo_ has quit [Ping timeout: 248 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 248 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 276 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 252 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 252 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 248 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 248 seconds]
brunoerg has joined #bitcoin-core-dev
pablomartin has joined #bitcoin-core-dev
AaronvanW has joined #bitcoin-core-dev
jon_atack has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 255 seconds]
AaronvanW has quit [Ping timeout: 255 seconds]
nanotube has joined #bitcoin-core-dev
cmirror has quit [Remote host closed the connection]
cmirror has joined #bitcoin-core-dev
<martinus> fanquake: ah right, there's https://github.com/bitcoin/bitcoin/issues/26916
martinus has quit [Remote host closed the connection]
martinus has joined #bitcoin-core-dev
nanotube has quit [Ping timeout: 255 seconds]
nanotube has joined #bitcoin-core-dev
dunxen has quit [Quit: Client limit exceeded: 20000]
AaronvanW has joined #bitcoin-core-dev
jarthur has quit [Quit: jarthur]
pablomartin has quit [Ping timeout: 276 seconds]
AaronvanW has quit [Ping timeout: 276 seconds]
nulldoot2k__ has joined #bitcoin-core-dev
nulldoot2k_ has quit [Ping timeout: 248 seconds]
AaronvanW has joined #bitcoin-core-dev
robobub has quit [Quit: Connection closed for inactivity]
salvatoshi has joined #bitcoin-core-dev
sipsorcery_ has joined #bitcoin-core-dev
sipsorcery has joined #bitcoin-core-dev
mekster669493 has quit [Read error: Connection reset by peer]
mekster669493 has joined #bitcoin-core-dev
Guyver2 has joined #bitcoin-core-dev
Guyver2 has left #bitcoin-core-dev [Closing Window]
AaronvanW has quit [Ping timeout: 255 seconds]
puchka has joined #bitcoin-core-dev
puchka has quit [Ping timeout: 276 seconds]
<vasild> NACK on further integration and reliance on GitHub. It is convenient, but it's a trap. Did you forget what happened with tornadocash? Somebody at a US govt agency sneezes and GitHub obliterates the repository and the developer's accounts _just hours later_. GitHub even overdid and ~(*!@&ed up things they were not asked to... like a good citizen, you know, to "prevent financing terrorism".
<vasild> What about hosting the binaries on a .onion site + .i2p site + torrents, _without clearnet_? That would be good training for users. And the static site too + a clearnet version like https://unsafe.robosats.com/ that suggests users to (learn to) visit the .onion site.
dunxen has joined #bitcoin-core-dev
AaronvanW has joined #bitcoin-core-dev
<vasild> This does not necessary have to be operated by the same people who merge the pull requests.
martinus has quit [Read error: Connection reset by peer]
martinus has joined #bitcoin-core-dev
sipsorcery_ has quit [Ping timeout: 260 seconds]
sipsorcery has quit [Ping timeout: 260 seconds]
puchka has joined #bitcoin-core-dev
mekster669493 has quit [Ping timeout: 255 seconds]
mekster669493 has joined #bitcoin-core-dev
Guest60 has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] MarcoFalke reopened pull request #18933: rpc: Add submit option to generateblock (master...2004-rpcBlock) https://github.com/bitcoin/bitcoin/pull/18933
martinus has quit [Remote host closed the connection]
martinus has joined #bitcoin-core-dev
Guest60 has quit [Quit: Client closed]
jespada has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] willcl-ark opened pull request #27236: util: fix argsman dupe key error (master...argsman-dupe-key) https://github.com/bitcoin/bitcoin/pull/27236
<bitcoin-git> [bitcoin] MarcoFalke opened pull request #27237: 2303 test block header throw 📞 (master...2303-test-block-header-throw-📞) https://github.com/bitcoin/bitcoin/pull/27237
puchka has quit [Ping timeout: 268 seconds]
puchka has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] TheCharlatan opened pull request #27238: refactor: Split logging utilities from system.h (master...splitSystemLogging) https://github.com/bitcoin/bitcoin/pull/27238
puchka has quit [Ping timeout: 248 seconds]
puchka has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] MarcoFalke opened pull request #27239: refactor: Consistenly use context args over gArgs in node/interfaces (master...2303-args-consistent-🏯) https://github.com/bitcoin/bitcoin/pull/27239
b_101_ has joined #bitcoin-core-dev
b_101 has quit [Ping timeout: 276 seconds]
<bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/f7bdcfc83f57...6e662a89851c
<bitcoin-git> bitcoin/master cd761e6 Fabian Jahr: rpc: Add note on guarantees to getblockfrompeer
<bitcoin-git> bitcoin/master fe329dc Fabian Jahr: test: Add test for getblockfrompeer on pruned nodes
<bitcoin-git> bitcoin/master 6e662a8 fanquake: Merge bitcoin/bitcoin#23813: Add test and docs for getblockfrompeer with p...
<bitcoin-git> [bitcoin] fanquake merged pull request #23813: Add test and docs for getblockfrompeer with pruning (master...2021-12-getblockfrompeer-follow-up) https://github.com/bitcoin/bitcoin/pull/23813
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/6e662a89851c...6f5eb7a39e71
<bitcoin-git> bitcoin/master faa6715 MarcoFalke: test: Use self.wait_until over wait_until_helper
<bitcoin-git> bitcoin/master 6f5eb7a fanquake: Merge bitcoin/bitcoin#27226: test: Use self.wait_until over wait_until_hel...
<bitcoin-git> [bitcoin] fanquake merged pull request #27226: test: Use self.wait_until over wait_until_helper (master...2303-test-wait-self-🛩) https://github.com/bitcoin/bitcoin/pull/27226
bitdex has quit [Quit: = ""]
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/6f5eb7a39e71...3e7dd4ff3369
<bitcoin-git> bitcoin/master 89cd20c Sebastian Falbesoner: test: add coverage for sigop limit policy (`-bytespersigop` setting)
<bitcoin-git> bitcoin/master 3e7dd4f fanquake: Merge bitcoin/bitcoin#27171: test: add coverage for sigop limit policy (`-...
<bitcoin-git> [bitcoin] fanquake merged pull request #27171: test: add coverage for sigop limit policy (`-bytespersigop` setting) (master...202302-add_bytespersigop_test) https://github.com/bitcoin/bitcoin/pull/27171
<bitcoin-git> [gui] fanquake closed pull request #539: Scale network graph based on time interval (master...1643263956-network-graph-issue-532) https://github.com/bitcoin-core/gui/pull/539
jespada has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/3e7dd4ff3369...99b64eec1bcc
<bitcoin-git> bitcoin/master 5c938e7 ekzyis: Use string interpolation for default value of -listen
<bitcoin-git> bitcoin/master 99b64ee fanquake: Merge bitcoin/bitcoin#27232: Use string interpolation for default value of...
<bitcoin-git> [bitcoin] fanquake merged pull request #27232: Use string interpolation for default value of -listen (master...use-string-interpolation-for-default-value-of-listen) https://github.com/bitcoin/bitcoin/pull/27232
<bitcoin-git> [bitcoin] MuhammadFathurNurRizky opened pull request #27240: Year update (master...patch-1) https://github.com/bitcoin/bitcoin/pull/27240
<bitcoin-git> [bitcoin] fanquake closed pull request #27240: Year update (master...patch-1) https://github.com/bitcoin/bitcoin/pull/27240
jespada has joined #bitcoin-core-dev
AaronvanW has quit [Quit: Leaving...]
merlinB has joined #bitcoin-core-dev
merlinB has quit [Client Quit]
lattice has joined #bitcoin-core-dev
smallestfry92 has joined #bitcoin-core-dev
bugs_ has joined #bitcoin-core-dev
smallestfry924 has joined #bitcoin-core-dev
smallestfry924 has quit [Client Quit]
realies has joined #bitcoin-core-dev
ircuser has joined #bitcoin-core-dev
<smallestfry92> Hi, I have some confusion about rebroadcasting & tx-relay.
<smallestfry92> Let's assume I broadcast a transaction to my peers via `sendrawtransaction` and it propagates throughout the network.
<smallestfry92> Then the transaction gets removed from the majority of mempools because it gets RBF'd (I won't go into detail here, but the RBF tx itself gets replaced). When my bitcoind node relays the transaction, the `m_tx_inventory_known_filter` will be populated for each of my peers that opted in to tx-relay.
<smallestfry92> I invoke `sendrawtransaction` again after I see that the transaction has been removed from my mempool and hasn't confirmed. This will call `RelayTransaction` again and the transaction might not be relayed again to certain peers depending on if `m_tx_inventory_known_filter` evicted the txid. It will be relayed to any new peers since the filter will
<smallestfry92> probably not give a false positive. If my bitcoind node only gives the transaction to new peers, how effective is rebroadcast here? It seems to me that because of `m_tx_inventory_known_filter`, the transaction will not traverse any of the same edges in the tx-relay network topology unless the filter evicts the txid. Is this correct? If so, it seems
<smallestfry92> like rebroadcasting a transaction like this doesn't work.
brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
SpellChecker has quit [Remote host closed the connection]
SpellChecker has joined #bitcoin-core-dev
brunoerg has quit [Remote host closed the connection]
Guest18 has joined #bitcoin-core-dev
Guest18 has quit [Client Quit]
brunoerg has joined #bitcoin-core-dev
jespada has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/99b64eec1bcc...c7f1d95f5288
<bitcoin-git> bitcoin/master 54c4d03 TheCharlatan: doc: Show how less noisy clang-tidy output can be achieved
<bitcoin-git> bitcoin/master c7f1d95 fanquake: Merge bitcoin/bitcoin#27205: doc: Show how less noisy clang-tidy output ca...
<bitcoin-git> [bitcoin] fanquake merged pull request #27205: doc: Show how less noisy clang-tidy output can be achieved (master...dev-notes-clang-tidy) https://github.com/bitcoin/bitcoin/pull/27205
dviola has joined #bitcoin-core-dev
pablomartin has joined #bitcoin-core-dev
salvatoshi has quit [Ping timeout: 255 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 255 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 276 seconds]
jarthur has joined #bitcoin-core-dev
jespada has joined #bitcoin-core-dev
brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Remote host closed the connection]
andrew_mo_ has joined #bitcoin-core-dev
pablomartin has quit [Remote host closed the connection]
pablomartin has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 246 seconds]
<achow101> #startmeeting
<achow101> #bitcoin-core-dev Wallet Meeting: achow101 _aj_ amiti ariard aureleoules b10c BlueMatt brunoerg cfields darosior dergoegge dongcarl fanquake fjahr furszy gleb glozow hebasto instagibbs jamesob jarolrod jonatack josibake kallewoof kanzure kouloumos kvaciral laanwj LarryRuane lightlike luke-jr MacroFake Murch phantomcircuit pinheadmz promag provoostenator ryanofsky sdaftuar S3RK stickies-v sipa theStack vasild
<furszy> hi
<achow101> There are no preproposed wallet meeting topics this week
<achow101> does anyone have anything to discuss
<larryruane> Hi
<furszy> probably we should investigate #20870 deeper
<gribble> https://github.com/bitcoin/bitcoin/issues/20870 | Option to ignore small inputs when internal wallet is building TXes? · Issue #20870 · bitcoin/bitcoin · GitHub
<achow101> I think the issue there is that the definition of small is subjective
pkr2 has joined #bitcoin-core-dev
<achow101> our definition of small is dust. this is probably too low for most people
<sipa> Perhaps a less lowlevel possibility is offering a way to control the long-term feerate estimate used for coin selection, on a per-transaction basis?
<sipa> Because I believe if that estimate is accurate, coin selection should effectively always do the right thing.
<achow101> that's a possibility
<furszy> but that is not as friendly (UX wise) as rising the "small UTXO" definition
<furszy> or well, letting the user change that. Which probably they already can
andrew_mo_ has quit [Remote host closed the connection]
<achow101> currently changing them requires using bitcoin.conf options, which means restarting to change
andrew_mo_ has joined #bitcoin-core-dev
<furszy> I meant, it's different to let the user change the long-term feerate vs let them provide an "min UTXO value".
<furszy> the first one will need training, the second one would be easier for them.
<furszy> "min selectable UTXO value" (or whatever name we want)
<achow101> would definitely want to see simulations of how that would affect the wallet
<achow101> but in principle, it doesn't seem that bad
<sipa> furszy: I worry that the second is too easy to understand and will just be misused
<sipa> there is a lot of nuance to understand when it's actually in your own best interest to spend a small UTXO
<furszy> hmm yeah, good point
<achow101> anything else to discuss?
<achow101> #endmeeting
<achow101> jonasschnelli: looks like the meeting bot is having trouble posting to the channel
smallestfry92 has quit [Quit: Client closed]
ircuser has quit [Quit: Client closed]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
pkr2 has quit [Quit: Client closed]
andrew_mo_ has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
sipsorcery_ has joined #bitcoin-core-dev
sipsorcery has joined #bitcoin-core-dev
pablomartin has quit [Ping timeout: 255 seconds]
andrew_mo_ has joined #bitcoin-core-dev
jespada has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
andrew_mo_ has quit [Remote host closed the connection]
pablomartin has joined #bitcoin-core-dev
<Murch> Knapsack is permitted to spend uneconomical UTXOs, and in fact, will very aggressively select such. If it ends up being the best solution, we might spend uneconomical inputs even at high feerates.
Guest46 has joined #bitcoin-core-dev
<sipa> Oh really, I was unaware. I thought that wasn't the case since the introduction of effective value.
<Murch> No, Knapsack remains unchanged, because some people objected to changing its behavior in the past
<Murch> I’d prefer to replace it over improving it at this point
luke-jr has joined #bitcoin-core-dev
<sipa> For knapsack to be best solution, it would pretty much need to be the only solution, I'd think? Because uneconomical spends should have a high waste metric?
andrew_mo_ has joined #bitcoin-core-dev
Guest46 has quit [Ping timeout: 260 seconds]
pablomartin has quit [Ping timeout: 248 seconds]
salvatoshi has joined #bitcoin-core-dev
pablomartin has joined #bitcoin-core-dev
pablomartin has quit [Ping timeout: 248 seconds]
luke-jr has quit [Ping timeout: 248 seconds]
andrew_mo_ has quit [Remote host closed the connection]
andrew_mo_ has joined #bitcoin-core-dev
luke-jr has joined #bitcoin-core-dev
brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
flooded has quit [Read error: Connection reset by peer]
flooded has joined #bitcoin-core-dev
flooded has quit [Read error: Connection reset by peer]
flooded has joined #bitcoin-core-dev
flooded has quit [Read error: Connection reset by peer]
flooded has joined #bitcoin-core-dev
flooded has quit [Read error: Connection reset by peer]
brunoerg has quit [Ping timeout: 260 seconds]
flooded has joined #bitcoin-core-dev
flooded has quit [Remote host closed the connection]
flooded has joined #bitcoin-core-dev
andrew_mo_ has quit [Remote host closed the connection]
Talkless has joined #bitcoin-core-dev
salvatoshi has quit [Ping timeout: 248 seconds]
test_ has joined #bitcoin-core-dev
flooded has quit [Ping timeout: 248 seconds]
test__ has joined #bitcoin-core-dev
test__ has quit [Remote host closed the connection]
test__ has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
flooded has joined #bitcoin-core-dev
test_ has quit [Ping timeout: 276 seconds]
test__ has quit [Ping timeout: 276 seconds]
salvatoshi has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 255 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 248 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 248 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
salvatoshi has quit [Ping timeout: 268 seconds]
brunoerg has joined #bitcoin-core-dev
salvatoshi has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 248 seconds]
lattice has quit [Quit: WeeChat 3.8]
andrew_mo_ has joined #bitcoin-core-dev
sipsorcery_ has quit [Ping timeout: 255 seconds]
sipsorcery has quit [Ping timeout: 255 seconds]
brunoerg has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 268 seconds]
puchka has quit [Ping timeout: 276 seconds]
brunoerg has quit [Ping timeout: 248 seconds]
brunoerg has joined #bitcoin-core-dev
darosior has quit [Read error: Connection reset by peer]
darosior has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 252 seconds]
brunoerg has joined #bitcoin-core-dev
salvatoshi has quit [Ping timeout: 248 seconds]
Talkless has quit [Quit: Konversation terminated!]
bugs_ has quit [Quit: Leaving]
brunoerg has quit [Ping timeout: 255 seconds]
darosior has quit [Ping timeout: 276 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 248 seconds]
andrew_mo_ has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
puchka has joined #bitcoin-core-dev
bitdex has joined #bitcoin-core-dev
darosior has joined #bitcoin-core-dev