00:12 <bitcoin-git> [bitcoin] aureleoules closed pull request #26858: wallet: Use defined purposes instead of inlining (master...2023-01-purpose-refactor) https://github.com/bitcoin/bitcoin/pull/26858

09:52 <darosior> andytoshi: don't know if you seen it, but slightly related: https://github.com/bitcoin/bitcoin/issues/19151

12:38 <bitcoin-git> [bitcoin] vstoyanov opened pull request #27333: ci: cleanup of CI_EXEC & CI_EXEC_ROOT (refs #27321) (master...bitcoin#27321) https://github.com/bitcoin/bitcoin/pull/27333

13:08 <vstoyanov> Hey. What would be a good first issue which is not taken. I went through all of them labeled that way and they are all at some stage of discussion/implementation. I sort of lack the intuition/context-awareness to read between the lines and pick something up. Bot C++ and shell/infra are Ok for me

13:08 <vstoyanov> Both*

13:15 <andytoshi> darosior: thanks! it is slightly related, in that we're both trying to add more-or-less the same capability

14:39 <martinus> In prevector.h, the destructor calls "_union.indirect_contents.indirect = nullptr;". Any particular reason why this is done? It's done that ever since https://github.com/bitcoin/bitcoin/pull/6914/ was merged in 2015

14:55 <bitcoin-git> [bitcoin] martinus opened pull request #27334: util: implement `noexcept` move assignment & move ctor for `prevector` (master...2023-03-prevector-move) https://github.com/bitcoin/bitcoin/pull/27334

16:43 <vasild> vstoyanov: I can't name a particular issue, but in general you can also look at ones not labeled "good first issue". Or you can start by reviewing some opened PR - or at least try to compile the code and run the tests, that helps to gather some knowledge and is useful to the project too.

16:47 <vstoyanov> Hi Vasil, I'm well past compiling the code and running tests :) I already opened a PR on the only free 'good first issue' I saw and asked if another one is stale indeed - unfortunately they all seem to be in some stage of completion.

16:47 <vstoyanov> Jonatack told me that the real shortage is in reviewers, so I read his guides and will probably go this way for now.

16:47 <vstoyanov> Apologies, it's been a long time since I last used IRC

18:25 <bitcoin-git> [bitcoin] martinus closed pull request #23169: fix initialization in FastRandomContext: removes undefined behavior & uninitialized read (master...2021-10-fix-Wmaybe-uninitialized-warnings) https://github.com/bitcoin/bitcoin/pull/23169

20:33 <ariard> Been asked what was going with Chaincode with the Jackson Lewis letter - After one more what-the-fuck communication from the other side (thanks Alex), here my version of the story: https://gist.github.com/ariard/a4e81e6c0f17d71803352774cac8c77c

20:33 <ariard> And I don't give a fuck anymore :)

21:31 <bitcoin-git> [bitcoin] EthanHeilman opened pull request #27335: Fixes compile errors in MSVC build #27332 (master...fixmsvc) https://github.com/bitcoin/bitcoin/pull/27335

23:10 <Ev0x1> d

23:11 <Ev0x1> Hello ! Tell me what to do, I do not quite understand how multisignature works !

23:11 <Ev0x1> I created an address with two public keys with the command createmultisig 2 ...

23:11 <Ev0x1> How do I get the money that came to this address and then sign it?

23:24 <andytoshi> achow101: https://github.com/bitcoin/bitcoin/blob/master/src/wallet/wallet.cpp#L3599-L3602 i think this code should check whether a spookyman already exists with this ID

23:25 <andytoshi> currently this function is only called in two places -- in one we generate a uniformly random seed so the spkman will have a unique ID, so that's fine. in the other the key might come from wallet migration data but (i think) the original DB will have a unique seed, so it's also fine

23:26 <andytoshi> but if we provide any way for a user to import new seeds, you can get dupes, and then bad things happen (we overwrite an old scriptpubkeyman, which i think will lose data, at least in-memory, and then when we try to record the seed for the new spkman in the db, we get an error because (thankfully) we set fOverwrite=false somewhere)

23:26 <andytoshi> i say "thankfully" because otherwise this would've been pretty hard to notice :P