<bitcoin-git>
[bitcoin] fanquake closed pull request #22417: util/system: Close non-std fds when execing slave processes (master...bpchild_closefds) https://github.com/bitcoin/bitcoin/pull/22417
brunoerg has quit [Ping timeout: 248 seconds]
brunoerg has joined #bitcoin-core-dev
flooded is now known as _flood
<bitcoin-git>
[bitcoin] darosior opened pull request #27382: miniscript: explicit cast instead of comparing integers of different signs (master...miniscript_comp_int_size) https://github.com/bitcoin/bitcoin/pull/27382
MatrixBot123 has joined #bitcoin-core-dev
sudoforge has quit [Ping timeout: 255 seconds]
sudoforge has joined #bitcoin-core-dev
sudoforge has quit [Read error: Connection reset by peer]
AaronvanW has quit [Remote host closed the connection]
ddisqq has quit [Remote host closed the connection]
ddisqq has joined #bitcoin-core-dev
ddisqq has quit [Ping timeout: 276 seconds]
<fanquake>
furszy why? The fix is already milestoned
Talkless has joined #bitcoin-core-dev
ddisqq has joined #bitcoin-core-dev
scg has joined #bitcoin-core-dev
<scg>
I found this discrepancy in repo regarding sighash SINGLE in taproot/schnorr sighash between reference implementation and functional tests. test/functional/test_framework/script.py::TaprootSignatureMsg - if out_type == SIGHASH_SINGLE and there is no corresponding output to the input being signed zero vector of len 32 is added to the message. In
<scg>
src/script/interpreter.cpp::SignatureHashSchnorr this is prohibited by - if (in_pos >= tx_to.vout.size()) return false;
bitdex has joined #bitcoin-core-dev
<scg>
So I assume functional tests sighash is wrong and should return failure if output is out of range ?
<scg>
this would be same behavior as in legacy sighash where this is not allowed and not like in segwit v0 where it actually is allowed
<sipa>
@scg Yeah, I believe this is intentional. In order to be able to verify that out of bounds sighash_single use is prohibited in consensus, the test framework needs to be able to produce something there.
<scg>
oh, make sense...
<scg>
any idea why is out of bound sighash_single allowed in segwit v0 ?
<sipa>
It was probably just overlooked.
bugs_ has quit [Quit: Leaving]
bitdex_ has joined #bitcoin-core-dev
ddisqq has quit [Ping timeout: 276 seconds]
salvatoshi has joined #bitcoin-core-dev
bitdex has quit [Ping timeout: 255 seconds]
ddisqq has joined #bitcoin-core-dev
ddisqq has quit [Ping timeout: 250 seconds]
<scg>
seems like it would require soft-fork to fix it - currently you with segwit v0 sighash SINGLE where output is out of bound you get same thing as with NONE (just actual sighash differs in msg)
bitdex_ has quit [Remote host closed the connection]
bitdex_ has joined #bitcoin-core-dev
scg has quit [Quit: Client closed]
Talkless has quit [Quit: Konversation terminated!]
flooded has joined #bitcoin-core-dev
test_ has quit [Ping timeout: 255 seconds]
ddisqq has joined #bitcoin-core-dev
ddisqq has quit [Ping timeout: 255 seconds]
gambpang has quit [Remote host closed the connection]
AaronvanW has quit [Remote host closed the connection]
pablomartin has quit [Ping timeout: 255 seconds]
preimage has quit [Quit: WeeChat 3.8]
brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
AaronvanW has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 265 seconds]
salvatoshi has quit [Ping timeout: 265 seconds]
<bitcoin-git>
[bitcoin] jonatack opened pull request #27385: net: extract Network and BIP155Network logic to node/network (master...2023-04-extract-network) https://github.com/bitcoin/bitcoin/pull/27385
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 250 seconds]
brunoerg has joined #bitcoin-core-dev
earnestly has quit [Read error: Connection reset by peer]
brunoerg has quit [Ping timeout: 252 seconds]
ddisqq has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
earnestly has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
brunoerg has joined #bitcoin-core-dev
AaronvanW has quit [Ping timeout: 255 seconds]
brunoerg has quit [Ping timeout: 265 seconds]
ddisqq has quit [Remote host closed the connection]