ChanServ changed the topic of #bitcoin-core-dev to: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Weekly Meeting Thursday @ 14:00 UTC | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt / http://gnusha.org/bitcoin-core-dev/proposed
brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 264 seconds]
Guest65 has joined #bitcoin-core-dev
Guest65 has quit [Client Quit]
brunoerg has joined #bitcoin-core-dev
bitdex has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 265 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 264 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 246 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 264 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
cmirror has quit [Remote host closed the connection]
cmirror has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 264 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
mxz has quit [Quit: cya]
mxz has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 264 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 265 seconds]
brunoerg has joined #bitcoin-core-dev
yanmaani2 has quit [Ping timeout: 240 seconds]
brunoerg has quit [Ping timeout: 240 seconds]
yanmaani2 has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
AaronvanW has quit [Remote host closed the connection]
puchka has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 264 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Read error: Connection reset by peer]
stevenwy37 has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 250 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 264 seconds]
brunoerg has joined #bitcoin-core-dev
aielima has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 268 seconds]
stevenwy37 has quit [Remote host closed the connection]
stevenwy37 has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 246 seconds]
earnestly has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 256 seconds]
Guyver2 has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] MarcoFalke opened pull request #27667: ci: Remove unused errtrace trap ERR (master...2305-ci-trap-err-) https://github.com/bitcoin/bitcoin/pull/27667
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 265 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
jarthur has quit [Quit: jarthur]
brunoerg has joined #bitcoin-core-dev
AaronvanW has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 268 seconds]
b_101 has quit [Ping timeout: 240 seconds]
b_101 has joined #bitcoin-core-dev
denise[m] has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/d7700d3a2647...b34e19a2bf9f
<bitcoin-git> bitcoin/master 0282b21 Andrew Chow: walletdb: Remove unused CreateMockWalletDatabase
<bitcoin-git> bitcoin/master b34e19a fanquake: Merge bitcoin/bitcoin#27665: walletdb: Remove unused CreateMockWalletDatab...
<bitcoin-git> [bitcoin] fanquake merged pull request #27665: walletdb: Remove unused CreateMockWalletDatabase (master...rm-mockdb) https://github.com/bitcoin/bitcoin/pull/27665
brunoerg has quit [Ping timeout: 265 seconds]
AaronvanW has quit [Remote host closed the connection]
<bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/b34e19a2bf9f...f7036a47459a
<bitcoin-git> bitcoin/master 258f930 brunoerg: test: fix spelling in `interface_usdt_utxocache`
<bitcoin-git> bitcoin/master e9dcac1 brunoerg: add `lief` to `spelling.ignore-words`
<bitcoin-git> bitcoin/master f7036a4 fanquake: Merge bitcoin/bitcoin#27664: docs: fix spelling errors
<bitcoin-git> [bitcoin] fanquake merged pull request #27664: docs: fix spelling errors (master...2023-05-spell-error) https://github.com/bitcoin/bitcoin/pull/27664
<bitcoin-git> [bitcoin] fanquake opened pull request #27668: guix: document when certain patches can be dropped (master...guix_patch_doc) https://github.com/bitcoin/bitcoin/pull/27668
Guyver2 has left #bitcoin-core-dev [Closing Window]
brunoerg has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] fanquake pushed 4 commits to 24.x: https://github.com/bitcoin/bitcoin/compare/16ab124e5f87...3116ccd790e7
<bitcoin-git> bitcoin/24.x 8af2d2f fanquake: build: bump version to 24.1 final
<bitcoin-git> bitcoin/24.x b36dff9 fanquake: doc: update manual pages for 24.1
<bitcoin-git> bitcoin/24.x 89a5a41 fanquake: doc: update release notes for 24.1
<bitcoin-git> [bitcoin] fanquake merged pull request #27660: [24.1] Final Changes (24.x...v24.1_finalize) https://github.com/bitcoin/bitcoin/pull/27660
<bitcoin-git> [bitcoin] fanquake pushed tag v24.1: https://github.com/bitcoin/bitcoin/compare/v24.1
brunoerg has quit [Ping timeout: 240 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
dberkelmans has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
vasild has quit [Remote host closed the connection]
vasild has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
stevenwy37 has quit [Remote host closed the connection]
stevenwy37 has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/f7036a47459a...d819840f38db
<bitcoin-git> bitcoin/master 1b1ffbd TheCharlatan: Build: Log when test -f fails in Makefile
<bitcoin-git> bitcoin/master 541012e TheCharlatan: Build: Use AM_V_GEN in Makefiles where appropriate
<bitcoin-git> bitcoin/master d819840 fanquake: Merge bitcoin/bitcoin#27041: Build: Improve handling of suppressed logging...
<bitcoin-git> [bitcoin] fanquake merged pull request #27041: Build: Improve handling of suppressed logging in Makefiles (master...2023-02-make-log-test-f) https://github.com/bitcoin/bitcoin/pull/27041
brunoerg has quit [Ping timeout: 265 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
brunoerg has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/d819840f38db...edd2a8644531
<bitcoin-git> bitcoin/master ea7b852 Hennadii Stepanov: build: Use newest `config.{guess,sub}` available
<bitcoin-git> bitcoin/master edd2a86 fanquake: Merge bitcoin/bitcoin#26422: build: Use newest `config.{guess,sub}` availa...
<bitcoin-git> [bitcoin] fanquake merged pull request #26422: build: Use newest `config.{guess,sub}` available (master...221030-config) https://github.com/bitcoin/bitcoin/pull/26422
Guest54 has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] fanquake opened pull request #27670: guix: remove redundant glibc patches (master...redundant_guix_glibc_patches) https://github.com/bitcoin/bitcoin/pull/27670
brunoerg has quit [Ping timeout: 265 seconds]
<bitcoin-git> [bitcoin] fanquake opened pull request #27671: depends: Boost 1.82.0 (master...boost_1_82_0) https://github.com/bitcoin/bitcoin/pull/27671
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
<bitcoin-git> [bitcoin] MarcoFalke opened pull request #27672: fuzz: Print error message when FUZZ is missing (master...2305-fuzz-log-FUZZ-) https://github.com/bitcoin/bitcoin/pull/27672
<bitcoin-git> [bitcoin] Sjors opened pull request #27673: ConnectTip: don't log total disk read time in bench (master...2023/05/div-zero) https://github.com/bitcoin/bitcoin/pull/27673
brunoerg has joined #bitcoin-core-dev
Guest54 has quit [Quit: Client closed]
brunoerg has quit [Ping timeout: 240 seconds]
bitdex has quit [Quit: = ""]
flooded has joined #bitcoin-core-dev
test__ has quit [Ping timeout: 268 seconds]
elichai2 has quit []
elichai2 has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 265 seconds]
<bitcoin-git> [bitcoin] hebasto opened pull request #27674: ci: Fix "Number of CPUs" output (master...230516-nproc) https://github.com/bitcoin/bitcoin/pull/27674
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 264 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 264 seconds]
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/edd2a8644531...03a4e8dd4c63
<bitcoin-git> bitcoin/master 03a4e8d fanquake: Merge bitcoin/bitcoin#27674: ci: Fix "Number of CPUs" output
<bitcoin-git> bitcoin/master 5d49d98 Hennadii Stepanov: ci: Fix "Number of CPUs" output
<bitcoin-git> [bitcoin] fanquake merged pull request #27674: ci: Fix "Number of CPUs" output (master...230516-nproc) https://github.com/bitcoin/bitcoin/pull/27674
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 265 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 246 seconds]
stevenwy37 has quit [Remote host closed the connection]
bugs_ has joined #bitcoin-core-dev
stevenwy37 has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
dberkelmans has quit [Quit: Client closed]
brunoerg has quit [Ping timeout: 265 seconds]
brunoerg has joined #bitcoin-core-dev
<fanquake> Good time for everyone to take a look over the https://github.com/bitcoin-core/bitcoin-devwiki/wiki/25.0-Release-Notes-Draft, and see if there's anything significant missing
preimage has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
<willcl_ark> Is it worth adding details on #27358 ?
<gribble> https://github.com/bitcoin/bitcoin/issues/27358 | contrib: allow multi-sig binary verification v2 by theuni · Pull Request #27358 · bitcoin/bitcoin · GitHub
<sipa> I'd say so.
Guest88 has joined #bitcoin-core-dev
<willcl_ark> OK I can do that
Guest88 has quit [Client Quit]
<instagibbs> might want to mention the performance improvements under heavier mempool load
brunoerg has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] ajtowns opened pull request #27675: net_processing: Drop m_recently_announced_invs bloom filter (master...202305-droprecentinvbloom) https://github.com/bitcoin/bitcoin/pull/27675
brunoerg has quit [Ping timeout: 240 seconds]
flooded is now known as _flood
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
<bitcoin-git> [gui] hebasto opened pull request #729: qt, test: Add missed header (master...230516-header) https://github.com/bitcoin-core/gui/pull/729
<hebasto> ^ that is about the recent link errors in CI MSVC builds
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
<fanquake> looks like it makes all other jobs fail?
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/03a4e8dd4c63...904631e0fc00
<bitcoin-git> bitcoin/master fad09b7 MarcoFalke: ci: Remove unused errtrace trap ERR
<bitcoin-git> bitcoin/master 904631e fanquake: Merge bitcoin/bitcoin#27667: ci: Remove unused errtrace trap ERR
<bitcoin-git> [bitcoin] fanquake merged pull request #27667: ci: Remove unused errtrace trap ERR (master...2305-ci-trap-err-) https://github.com/bitcoin/bitcoin/pull/27667
<bitcoin-git> [bitcoin] fanquake pushed 4 commits to 23.x: https://github.com/bitcoin/bitcoin/compare/2e9fc2e353fe...4d2f2fae9782
<bitcoin-git> bitcoin/23.x 5fbb86e fanquake: build: bump version to 23.2 final
<bitcoin-git> bitcoin/23.x 6c5781e fanquake: doc: update manual pages for 23.2
<bitcoin-git> bitcoin/23.x 7ae9373 fanquake: doc: update release notes for 23.2
<bitcoin-git> [bitcoin] fanquake merged pull request #27663: [23.2] Final Changes (23.x...v23.2_finalize) https://github.com/bitcoin/bitcoin/pull/27663
<bitcoin-git> [bitcoin] fanquake pushed tag v23.2: https://github.com/bitcoin/bitcoin/compare/v23.2
stevenwy37 has quit [Quit: Leaving...]
flooded has joined #bitcoin-core-dev
___nick___ has joined #bitcoin-core-dev
brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
_flood has quit [Ping timeout: 248 seconds]
brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
<vasild> _aj_: wrt https://github.com/bitcoin/bitcoin/pull/27509#discussion_r1192851862, if we send INV first then, I guess we have to wait for some time to get GETDATA and if not then close anyway (without sending the tx). How much time do you think makes sense?
<vasild> and then we wait to get INV about that transaction from some of our normal connections which would be a sign it propagated through the network.
<_aj_> vasild: send INV sha256("hackhack" + counter) to 1000 real peers, and see how long it takes them to send you a GETDATA?
<vasild> ok, fair enough :)
<_aj_> vasild: at least 10s; maybe 30s or a minute would be my gut feel *shrug*
___nick___ has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.]
<bugs_> lots of nodes will have lower upload bw than download so it can be longer
___nick___ has joined #bitcoin-core-dev
<vasild> I am still not convinced either way and will probably implement both to experiment. My initial thinking was to fire a bunch of "broadcasts" as quickly as possible, assuming individual ones can fail for various reasons and then wait for INV from the network. Spending time to make an individual broadcast more realiable, or even speding time only to figure out that an individual broadcast is
<vasild> unsuccessful can maybe be skipped, but I have to make experiments...
___nick___ has quit [Client Quit]
___nick___ has joined #bitcoin-core-dev
brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] theuni opened pull request #27676: macOS: Bump minimum required runtime version and prepare for building with upstream LLVM (master...macos-min-bump) https://github.com/bitcoin/bitcoin/pull/27676
jarthur has joined #bitcoin-core-dev
cm_ has joined #bitcoin-core-dev
cm has quit [Ping timeout: 246 seconds]
cm_ is now known as cm
brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
puchka has quit [Ping timeout: 264 seconds]
puchka has joined #bitcoin-core-dev
Talkless has joined #bitcoin-core-dev
brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
vysn has joined #bitcoin-core-dev
Talkless has quit [Quit: Konversation terminated!]
brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
PaperSword has quit [Remote host closed the connection]
vasild has quit [Remote host closed the connection]
<bitcoin-git> [bitcoin] brunoerg opened pull request #27678: fuzz: net, add `recv_flood_size`, `prefer_evict` in `ConsumeNode` (master...2023-05-fuzz-net-consumenode) https://github.com/bitcoin/bitcoin/pull/27678
vysn has quit [Remote host closed the connection]
vasild has joined #bitcoin-core-dev
___nick___ has quit [Ping timeout: 240 seconds]
PaperSword has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] pinheadmz opened pull request #27679: ZMQ: Support UNIX domain sockets (master...zmq-unix-domain-socket) https://github.com/bitcoin/bitcoin/pull/27679
EleYah has joined #bitcoin-core-dev
Guest61 has joined #bitcoin-core-dev
Guest61 has quit [Client Quit]
<hebasto> what are design/conceptual reasons why `CValidationInterface::BlockChecked` is _not_ called on a background thread (as other callbacks do)?
bugs_ has quit [Quit: Leaving]
BlueMatt has quit [Ping timeout: 260 seconds]
fundamentals has joined #bitcoin-core-dev
fundamentals has quit [Client Quit]
preimage has quit [Quit: WeeChat 3.8]
aielima has quit [Quit: Ciao]
Guest89 has joined #bitcoin-core-dev
Guest89 has quit [Client Quit]
bitdex has joined #bitcoin-core-dev
bitdex has quit [Remote host closed the connection]
bitdex_ has joined #bitcoin-core-dev
puchka has quit [Ping timeout: 268 seconds]