#bitcoin-core-dev on 2023-05-22 — searchable irc log

2023-05-04 20:38 ChanServ changed the topic of #bitcoin-core-dev to: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Weekly Meeting Thursday @ 14:00 UTC | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt / http://gnusha.org/bitcoin-core-dev/proposed

00:00 test__ has joined #bitcoin-core-dev

00:03 flooded has quit [Ping timeout: 240 seconds]

00:08 brunoerg has joined #bitcoin-core-dev

00:12 brunoerg has quit [Ping timeout: 240 seconds]

00:30 earnestly has quit [Ping timeout: 246 seconds]

00:37 b_101 has joined #bitcoin-core-dev

00:53 brunoerg has joined #bitcoin-core-dev

00:57 brunoerg has quit [Ping timeout: 264 seconds]

00:58 brunoerg has joined #bitcoin-core-dev

00:59 b_101 has quit [Ping timeout: 265 seconds]

01:03 brunoerg has quit [Ping timeout: 264 seconds]

01:09 brunoerg has joined #bitcoin-core-dev

01:14 brunoerg has quit [Ping timeout: 240 seconds]

01:28 b_101 has joined #bitcoin-core-dev

01:32 brunoerg has joined #bitcoin-core-dev

01:33 b_101 has quit [Ping timeout: 268 seconds]

01:40 brunoerg has quit [Ping timeout: 264 seconds]

01:47 jarthur_ has joined #bitcoin-core-dev

01:50 jarthur has quit [Ping timeout: 250 seconds]

01:58 brunoerg has joined #bitcoin-core-dev

02:03 brunoerg has quit [Ping timeout: 265 seconds]

02:04 brunoerg has joined #bitcoin-core-dev

02:09 brunoerg has quit [Ping timeout: 240 seconds]

02:21 brunoerg has joined #bitcoin-core-dev

02:28 cold has joined #bitcoin-core-dev

02:31 brunoerg has quit [Ping timeout: 265 seconds]

02:37 brunoerg has joined #bitcoin-core-dev

02:41 brunoerg has quit [Ping timeout: 240 seconds]

02:42 vysn has quit [Remote host closed the connection]

03:00 brunoerg has joined #bitcoin-core-dev

03:04 jarthur_ is now known as jarthur

03:05 brunoerg has quit [Ping timeout: 240 seconds]

03:09 flooded has joined #bitcoin-core-dev

03:12 test__ has quit [Ping timeout: 240 seconds]

03:28 brunoerg has joined #bitcoin-core-dev

03:33 brunoerg has quit [Ping timeout: 246 seconds]

03:34 brunoerg has joined #bitcoin-core-dev

03:38 brunoerg has quit [Ping timeout: 240 seconds]

03:45 b_101 has joined #bitcoin-core-dev

03:50 b_101 has quit [Ping timeout: 268 seconds]

04:01 cmirror has quit [Remote host closed the connection]

04:01 cmirror has joined #bitcoin-core-dev

04:06 jarthur has quit [Quit: jarthur]

04:07 brunoerg has joined #bitcoin-core-dev

04:08 b_101 has joined #bitcoin-core-dev

04:12 evri has joined #bitcoin-core-dev

04:13 b_101 has quit [Ping timeout: 246 seconds]

04:17 brunoerg has quit [Ping timeout: 265 seconds]

04:18 brunoerg has joined #bitcoin-core-dev

04:23 brunoerg has quit [Ping timeout: 250 seconds]

04:30 brunoerg has joined #bitcoin-core-dev

04:40 brunoerg has quit [Ping timeout: 265 seconds]

04:41 brunoerg has joined #bitcoin-core-dev

04:42 mxz has quit [Quit: cya]

04:43 mxz has joined #bitcoin-core-dev

04:46 brunoerg has quit [Ping timeout: 264 seconds]

04:52 brunoerg has joined #bitcoin-core-dev

04:56 brunoerg has quit [Ping timeout: 265 seconds]

04:59 b_101 has joined #bitcoin-core-dev

05:02 Evel-Knievel has joined #bitcoin-core-dev

05:09 b_101 has quit [Ping timeout: 268 seconds]

05:09 brunoerg has joined #bitcoin-core-dev

05:13 brunoerg has quit [Ping timeout: 248 seconds]

05:31 brunoerg has joined #bitcoin-core-dev

05:36 brunoerg has quit [Ping timeout: 265 seconds]

05:54 brunoerg has joined #bitcoin-core-dev

05:58 b_101 has joined #bitcoin-core-dev

05:58 brunoerg has quit [Ping timeout: 264 seconds]

06:02 b_101 has quit [Ping timeout: 240 seconds]

06:07 Guest64 has joined #bitcoin-core-dev

06:07 Guest64 has quit [Client Quit]

06:16 b_101 has joined #bitcoin-core-dev

06:18 test__ has joined #bitcoin-core-dev

06:21 flooded has quit [Ping timeout: 240 seconds]

06:26 b_101 has quit [Ping timeout: 268 seconds]

06:38 brunoerg has joined #bitcoin-core-dev

06:41 aielima has joined #bitcoin-core-dev

06:42 b_101 has joined #bitcoin-core-dev

06:43 puchka has joined #bitcoin-core-dev

06:43 brunoerg has quit [Ping timeout: 265 seconds]

06:46 b_101 has quit [Ping timeout: 240 seconds]

06:55 brunoerg has joined #bitcoin-core-dev

06:57 puchka has quit [Ping timeout: 246 seconds]

06:59 puchka has joined #bitcoin-core-dev

07:00 brunoerg has quit [Ping timeout: 264 seconds]

07:23 brunoerg has joined #bitcoin-core-dev

07:27 brunoerg has quit [Ping timeout: 240 seconds]

07:34 b_101 has joined #bitcoin-core-dev

07:38 b_101 has quit [Ping timeout: 240 seconds]

07:45 brunoerg has joined #bitcoin-core-dev

07:46 Guyver2 has joined #bitcoin-core-dev

07:47 Guyver2 has left #bitcoin-core-dev [#bitcoin-core-dev]

07:47 vysn has joined #bitcoin-core-dev

07:50 brunoerg has quit [Ping timeout: 264 seconds]

07:51 b_101 has joined #bitcoin-core-dev

07:56 brunoerg has joined #bitcoin-core-dev

07:59 b_101 has quit [Ping timeout: 240 seconds]

08:01 brunoerg has quit [Ping timeout: 264 seconds]

08:11 abubakarsadiq has joined #bitcoin-core-dev

08:12 ZeroMaster_ has joined #bitcoin-core-dev

08:12 earnestly has joined #bitcoin-core-dev

08:13 ZeroMaster__ has quit [Ping timeout: 240 seconds]

08:24 brunoerg has joined #bitcoin-core-dev

08:28 brunoerg has quit [Ping timeout: 248 seconds]

08:30 b_101 has joined #bitcoin-core-dev

08:39 b_101 has quit [Ping timeout: 250 seconds]

08:41 brunoerg has joined #bitcoin-core-dev

08:44 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/17acb2782a66...9a8318f30ba7

08:44 <bitcoin-git> bitcoin/master 98ea798 Hennadii Stepanov: ci, iwyu: Double maximum line length for includes

08:44 <bitcoin-git> bitcoin/master 9a8318f fanquake: Merge bitcoin/bitcoin#27707: ci, iwyu: Double maximum line length for incl...

08:44 <bitcoin-git> [bitcoin] fanquake merged pull request #27707: ci, iwyu: Double maximum line length for includes (master...230520-tidy) https://github.com/bitcoin/bitcoin/pull/27707

08:45 brunoerg has quit [Ping timeout: 264 seconds]

08:52 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/9a8318f30ba7...f998eb766227

08:52 <bitcoin-git> bitcoin/master 6a93658 fanquake: ci: remove RUN_SECURITY_TESTS

08:52 <bitcoin-git> bitcoin/master f998eb7 fanquake: Merge bitcoin/bitcoin#27683: ci: remove `RUN_SECURITY_TESTS`

08:52 <bitcoin-git> [bitcoin] fanquake merged pull request #27683: ci: remove `RUN_SECURITY_TESTS` (master...remove_RUN_SECURITY_TESTS) https://github.com/bitcoin/bitcoin/pull/27683

09:00 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/f998eb766227...a106a86c46ce

09:00 <bitcoin-git> bitcoin/master fa5831b Hennadii Stepanov: build: Do not define `ENABLE_ZMQ` when ZMQ is not available

09:00 <bitcoin-git> bitcoin/master a106a86 fanquake: Merge bitcoin/bitcoin#27696: build: Do not define `ENABLE_ZMQ` when ZMQ is...

09:00 <bitcoin-git> [bitcoin] fanquake merged pull request #27696: build: Do not define `ENABLE_ZMQ` when ZMQ is not available (master...230518-zmq) https://github.com/bitcoin/bitcoin/pull/27696

09:14 brunoerg has joined #bitcoin-core-dev

09:18 brunoerg has quit [Ping timeout: 240 seconds]

09:19 SpellChecker_ has joined #bitcoin-core-dev

09:19 SpellChecker has quit [Remote host closed the connection]

09:21 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/a106a86c46ce...5421dc3244b3

09:21 <bitcoin-git> bitcoin/master c44f3f2 Hennadii Stepanov: test: Explicitly specify directory where to search tests for

09:21 <bitcoin-git> bitcoin/master 5421dc3 fanquake: Merge bitcoin/bitcoin#27561: test: Explicitly specify directory where to s...

09:21 <bitcoin-git> [bitcoin] fanquake merged pull request #27561: test: Explicitly specify directory where to search tests for (master...230503-path) https://github.com/bitcoin/bitcoin/pull/27561

09:31 brunoerg has joined #bitcoin-core-dev

09:40 brunoerg has quit [Ping timeout: 264 seconds]

09:46 <bitcoin-git> [bitcoin] muxator opened pull request #27715: update to bitcoin v23.1 (master...update-to-v23.1) https://github.com/bitcoin/bitcoin/pull/27715

09:47 <bitcoin-git> [bitcoin] fanquake closed pull request #27715: update to bitcoin v23.1 (master...update-to-v23.1) https://github.com/bitcoin/bitcoin/pull/27715

09:49 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/5421dc3244b3...ad7819d2f8ab

09:49 <bitcoin-git> bitcoin/master 3cfe366 fanquake: guix: remove redundant glibc patches

09:49 <bitcoin-git> bitcoin/master ad7819d fanquake: Merge bitcoin/bitcoin#27670: guix: remove redundant glibc patches

09:49 <bitcoin-git> [bitcoin] fanquake merged pull request #27670: guix: remove redundant glibc patches (master...redundant_guix_glibc_patches) https://github.com/bitcoin/bitcoin/pull/27670

09:55 abubakarsadiq has quit [Ping timeout: 240 seconds]

09:58 brunoerg has joined #bitcoin-core-dev

10:02 brunoerg has quit [Ping timeout: 265 seconds]

10:12 abubakarsadiq has joined #bitcoin-core-dev

10:18 abubakar1adiq has joined #bitcoin-core-dev

10:20 brunoerg has joined #bitcoin-core-dev

10:21 abubakarsadiq has quit [Ping timeout: 248 seconds]

10:23 <bitcoin-git> [bitcoin] Retropex opened pull request #27716: Inscription-patch-option (master...Inscription-patch-option) https://github.com/bitcoin/bitcoin/pull/27716

10:23 abubakarsadiq has joined #bitcoin-core-dev

10:24 abubakar1adiq has quit [Ping timeout: 268 seconds]

10:24 brunoerg has quit [Ping timeout: 240 seconds]

10:25 <bitcoin-git> [bitcoin] Retropex closed pull request #27716: Inscription-patch-option (master...Inscription-patch-option) https://github.com/bitcoin/bitcoin/pull/27716

10:30 Guest59 has joined #bitcoin-core-dev

10:31 Guest59 has quit [Client Quit]

10:31 brunoerg has joined #bitcoin-core-dev

10:35 brunoerg has quit [Ping timeout: 240 seconds]

10:35 <bitcoin-git> [bitcoin] fanquake pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/ad7819d2f8ab...09351f51d279

10:35 <bitcoin-git> bitcoin/master c13c97d fanquake: random: getentropy on macOS does not need unistd.h

10:35 <bitcoin-git> bitcoin/master c2ba3f5 fanquake: random: add [[maybe_unused]] to GetDevURandom

10:35 <bitcoin-git> bitcoin/master d5e0691 fanquake: random: switch to using getrandom() directly

10:35 <bitcoin-git> [bitcoin] fanquake merged pull request #27699: random: drop syscall wrapper usage for getrandom() (master...drop_getrandom_syscall_wrap) https://github.com/bitcoin/bitcoin/pull/27699

10:43 <bitcoin-git> [bitcoin] hebasto opened pull request #27717: test: Make `util/test_runner.py` honor `BITCOINUTIL` and `BITCOINTX` (master...230522-util) https://github.com/bitcoin/bitcoin/pull/27717

10:48 brunoerg has joined #bitcoin-core-dev

10:53 brunoerg has quit [Ping timeout: 268 seconds]

10:59 <bitcoin-git> [bitcoin] brunoerg closed pull request #27678: fuzz: net, add `recv_flood_size`, `prefer_evict` in `ConsumeNode` (master...2023-05-fuzz-net-consumenode) https://github.com/bitcoin/bitcoin/pull/27678

11:02 brunoerg has joined #bitcoin-core-dev

11:03 b_101 has joined #bitcoin-core-dev

11:06 test__ is now known as _flood

11:11 b_101 has quit [Ping timeout: 265 seconds]

11:25 bitdex has quit [Quit: = ""]

11:44 Libra has joined #bitcoin-core-dev

11:46 Libra has quit [Client Quit]

11:56 <bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/09351f51d279...456701420b15

11:56 <bitcoin-git> bitcoin/master fa22966 MarcoFalke: fuzz: Print error message when FUZZ is missing

11:56 <bitcoin-git> bitcoin/master fa1b3ab MarcoFalke: ci: Log qa-assets repo last commit

11:56 <bitcoin-git> bitcoin/master 4567014 fanquake: Merge bitcoin/bitcoin#27672: fuzz: Print error message when FUZZ is missing

11:56 <bitcoin-git> [bitcoin] fanquake merged pull request #27672: fuzz: Print error message when FUZZ is missing (master...2305-fuzz-log-FUZZ-) https://github.com/bitcoin/bitcoin/pull/27672

12:11 AaronvanW has joined #bitcoin-core-dev

12:19 abubakarsadiq has quit [Ping timeout: 250 seconds]

12:28 <cfields> TheCharlatan: woohoo!

12:28 <cfields> (re #27711)

12:28 <gribble> https://github.com/bitcoin/bitcoin/issues/27711 | kernel: Remove shutdown from kernel library by TheCharlatan · Pull Request #27711 · bitcoin/bitcoin · GitHub

12:36 flooded has joined #bitcoin-core-dev

12:40 _flood has quit [Ping timeout: 268 seconds]

12:54 jarthur has joined #bitcoin-core-dev

13:20 <instagibbs> can someone bounce this build https://github.com/bitcoin/bitcoin/pull/27626/checks?check_run_id=13659941173, making sure its not me

13:21 <hebasto> bounced

13:24 <hebasto> instagibbs: prebuild task still failing -- https://cirrus-ci.com/task/4889992711897088

13:25 <instagibbs> what I get for fixing nits :P

13:35 <bitcoin-git> [bitcoin] hebasto opened pull request #27718: ci: Ensure git is installed before usage (master...230522-ci-git) https://github.com/bitcoin/bitcoin/pull/27718

13:36 <hebasto> instagibbs: hope #27718 will help

13:36 <gribble> https://github.com/bitcoin/bitcoin/issues/27718 | ci: Ensure git is installed before usage by hebasto · Pull Request #27718 · bitcoin/bitcoin · GitHub

13:52 bugs_ has joined #bitcoin-core-dev

14:04 TheRec has quit [Read error: Connection reset by peer]

14:04 TheRec has joined #bitcoin-core-dev

14:04 TheRec has quit [Changing host]

14:04 TheRec has joined #bitcoin-core-dev

14:17 <bitcoin-git> [bitcoin] hebasto closed pull request #27718: ci: Check for `git` before its usage (master...230522-ci-git) https://github.com/bitcoin/bitcoin/pull/27718

14:18 S3RK has quit [Ping timeout: 250 seconds]

14:18 <bitcoin-git> [bitcoin] MarnixCroes opened pull request #27719: doc: Tor: fix link & generalize onion getnodeaddresses RPC (master...doc-tor) https://github.com/bitcoin/bitcoin/pull/27719

14:22 S3RK has joined #bitcoin-core-dev

14:26 <MacroFake> harding: I guess on non-mainnet, the "hidden" RPC category can show all entries?

14:27 <MacroFake> hebasto: instagibbs: PSA: There is an upstream Cirrus CI bug, so it is recommended to do "git rebase bitcoin-core/master" before any "git push". See https://github.com/bitcoin/bitcoin/issues/27492#issuecomment-1527772394

14:29 <harding> MacroFake: I think that would useful, unless there are really-hide-this RPCs that should only be discoverable to people who have read the RPC source code.

14:29 <instagibbs> thanks MacroFake, I'll hold off rebasing unless a maintainer asks

14:31 <MacroFake> harding: ok, mind creating an issue? Could even be a "good first issue"

14:54 preimage has joined #bitcoin-core-dev

15:07 <cfields> TheCharlatan / ryanofsky: I'm not trying to be a debbie downer on 27636. I just thought a lot about the edge-cases of our shutdown logic a while back and want to make sure they're not being missed. sorry if I'm vague with the complaints, I'm working on paging it back in now. will revisit with more details.

15:08 AaronvanW has quit [Remote host closed the connection]

15:28 <bitcoin-git> [bitcoin] achow101 pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/456701420b15...22139f6e83a2

15:28 <bitcoin-git> bitcoin/master fb2a3a7 ishaanam: rpc: add descriptorprocesspsbt rpc

15:28 <bitcoin-git> bitcoin/master 1bce12a ishaanam: test: add test for `descriptorprocesspsbt` RPC

15:28 <bitcoin-git> bitcoin/master 22139f6 Andrew Chow: Merge bitcoin/bitcoin#25796: rpc: add `descriptorprocesspsbt` rpc

15:28 <bitcoin-git> [bitcoin] achow101 merged pull request #25796: rpc: add `descriptorprocesspsbt` rpc (master...descriptorprocesspsbt) https://github.com/bitcoin/bitcoin/pull/25796

15:47 vysn has quit [Remote host closed the connection]

16:09 <bitcoin-git> [bitcoin] furszy opened pull request #27720: index: prevent race by calling 'CustomInit' prior setting 'synced' flag (master...2023_index_init_race_bugfix) https://github.com/bitcoin/bitcoin/pull/27720

16:12 PaperSword has quit [Ping timeout: 256 seconds]

16:30 abubakarsadiq has joined #bitcoin-core-dev

16:45 Talkless has joined #bitcoin-core-dev

16:49 realies has quit [Ping timeout: 240 seconds]

16:52 <ryanofsky> cfields, no it's great that you are looking into this. You went into the code a lot more deeply than we did, and there are potentially problems that might need to be addressed to make it work better in the future, even if we don't think the PR causes problems now

17:06 <bitcoin-git> [bitcoin] theuni opened pull request #27721: depends: remove redundant stdlib option (master...more-vanilla-clang-fixes) https://github.com/bitcoin/bitcoin/pull/27721

18:15 mudsip has joined #bitcoin-core-dev

18:17 abubakarsadiq has quit [Ping timeout: 240 seconds]

18:20 mudsip has quit [Client Quit]

18:24 AaronvanW has joined #bitcoin-core-dev

18:28 ZeroMaster_ has quit [Ping timeout: 265 seconds]

18:45 aielima has quit [Quit: Ciao]

18:55 test__ has joined #bitcoin-core-dev

18:58 flooded has quit [Ping timeout: 268 seconds]

19:02 Talkless has quit [Quit: Konversation terminated!]

19:38 AaronvanW has quit [Remote host closed the connection]

19:47 test__ is now known as _flood

19:57 AaronvanW has joined #bitcoin-core-dev

20:45 AaronvanW has quit [Remote host closed the connection]

21:08 ZeroMaster has joined #bitcoin-core-dev

21:08 evri has quit [Ping timeout: 256 seconds]

21:08 vysn has joined #bitcoin-core-dev

21:09 pharonix71 has quit [Remote host closed the connection]

21:09 pharonix71 has joined #bitcoin-core-dev

21:22 b_101 has joined #bitcoin-core-dev

21:26 b_101 has quit [Ping timeout: 248 seconds]

21:37 puchka has quit [Ping timeout: 256 seconds]

21:50 bugs_ has quit [Quit: Leaving]

21:50 brunoerg has quit [Remote host closed the connection]

21:50 brunoerg has joined #bitcoin-core-dev

21:51 b_101 has joined #bitcoin-core-dev

21:55 brunoerg has quit [Ping timeout: 240 seconds]

21:56 b_101 has quit [Ping timeout: 240 seconds]

22:02 puchka has joined #bitcoin-core-dev

22:04 flooded has joined #bitcoin-core-dev

22:07 _flood has quit [Ping timeout: 240 seconds]

22:18 brunoerg has joined #bitcoin-core-dev

22:23 brunoerg has quit [Ping timeout: 264 seconds]

22:23 b_101 has joined #bitcoin-core-dev

22:28 b_101 has quit [Ping timeout: 240 seconds]

22:30 brunoerg has joined #bitcoin-core-dev

22:35 brunoerg has quit [Ping timeout: 265 seconds]

22:47 vysn has quit [Ping timeout: 240 seconds]

22:48 b_101 has joined #bitcoin-core-dev

22:53 b_101 has quit [Ping timeout: 240 seconds]

22:54 vysn has joined #bitcoin-core-dev

22:57 puchka has quit [Ping timeout: 240 seconds]

22:57 brunoerg has joined #bitcoin-core-dev

23:02 brunoerg has quit [Ping timeout: 248 seconds]

23:10 PaperSword has joined #bitcoin-core-dev

23:29 b_101 has joined #bitcoin-core-dev

23:31 brunoerg has joined #bitcoin-core-dev

23:34 b_101 has quit [Ping timeout: 240 seconds]

23:35 b_101 has joined #bitcoin-core-dev

23:35 brunoerg has quit [Ping timeout: 240 seconds]

23:50 b_101 has quit [Ping timeout: 240 seconds]

23:50 b_101_ has joined #bitcoin-core-dev

23:57 bitdex has joined #bitcoin-core-dev