ChanServ changed the topic of #bitcoin-core-dev to: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Weekly Meeting Thursday @ 14:00 UTC | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt / http://gnusha.org/bitcoin-core-dev/proposed
bitdex_ has quit [Ping timeout: 240 seconds]
bitdex_ has joined #bitcoin-core-dev
earnestly has quit [Ping timeout: 240 seconds]
brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 265 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 265 seconds]
BlueMatt has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
jarthur_ has joined #bitcoin-core-dev
jarthur has quit [Ping timeout: 240 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 246 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 265 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 265 seconds]
Guest28 has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
brunoerg has joined #bitcoin-core-dev
cm has quit [Ping timeout: 246 seconds]
cm has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 264 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 246 seconds]
test__ has joined #bitcoin-core-dev
Guest28 has quit [Quit: Client closed]
brunoerg has joined #bitcoin-core-dev
flooded has quit [Ping timeout: 268 seconds]
brunoerg has quit [Ping timeout: 240 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
brunoerg has joined #bitcoin-core-dev
cmirror has quit [Remote host closed the connection]
cmirror has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 265 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 256 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 264 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
Guest54 has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
brunoerg has joined #bitcoin-core-dev
EleYah has quit [Quit: EleYah]
brunoerg has quit [Ping timeout: 250 seconds]
brunoerg has joined #bitcoin-core-dev
puchka has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 265 seconds]
Guest54 has quit [Ping timeout: 245 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 268 seconds]
Guyver2 has joined #bitcoin-core-dev
ghost43_ has quit [Remote host closed the connection]
ghost43 has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
flooded has joined #bitcoin-core-dev
<kouloumos> Part of #18963 involved moving `BlockChecked` to a background thread; afaiu there were no objections for this particular change in that series of PRs, although there wasn't much review interest
<gribble> https://github.com/bitcoin/bitcoin/issues/18963 | [WIP] rebase: Call ProcessNewBlock() asynchronously by dongcarl · Pull Request #18963 · bitcoin/bitcoin · GitHub
test__ has quit [Ping timeout: 240 seconds]
brunoerg has quit [Ping timeout: 265 seconds]
<hebasto> kouloumos: thanks
Guyver2 has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
vysn has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 250 seconds]
<josie> question for the gdb gurus: I'm starting and loading bitcoind with the following commands: $ gdb; file src/bitcoind; b <insert breakpoint>; run -signet
<josie> each time I do this, the node does IBD, which is pretty annoying when debugging
aielima has joined #bitcoin-core-dev
<josie> is this normal? or is there something about how I am starting bitcoind which is causing this?
evri has joined #bitcoin-core-dev
<kouloumos> and it does that on startup even after you already completed IBD on signet on a previous session?
<josie> kouloumos: yep
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 264 seconds]
<vasild> josie: that should be the same as running "src/bitcoind -signet" without gdb
<vasild> does it behave differently if you run "src/bitcoind -signet" compared to inside gdb?
<vasild> gdb --args src/bitcoind -signet; b <insert breakpoint>; run <-- this will do the same but is a bit more convenient if you use it repeatedly
<vasild> no need to exit gdb to restart from the beginning, just execute "run" again, this way the breakpoints and the arguments (-signet) will remain set
___nick___ has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] MarcoFalke opened pull request #27682: build: Bump minimum Clang to clang-10 (master...2305-clang-10-) https://github.com/bitcoin/bitcoin/pull/27682
<josie> vasild: running with gdb --args <etc> also goes through IDB every time I start it
<kouloumos> I cannot reproduce your issue. But in general, I find attaching to the process more convenient. Because gdb allows for programmability through python, I wrote a helper that waits for the pid to start and then attaches on it. You can find it as part of this script: https://github.com/kouloumos/bitcoin/commit/0b468517f316590a0502827c4ae989ce948433cf . The script is doing more things, but for the general case you just need
<kouloumos> to do `gdb src/bitcoind; source extend_gdb.py; b <insert breakpoint>; attach_bitcoind` and then start your bitcoind process.
<josie> kouloumos: thanks, I'll give this a try
<josie> vasild: interestingly, executing "run" in gdb multiple times also causes it to go through IBD every time
<vasild> josie: yes, because it restarts the process from the beginning (like it kills/terminates any existent process and starts a new one)
<vasild> but does it do the same if you start "src/bitcoind -signet" witout gdb?
brunoerg has joined #bitcoin-core-dev
<kouloumos> josie: I removed the unrelated logic, you can find the simplified version here https://gist.github.com/kouloumos/e0a9c6c58b594d879644efad2d90a443
brunoerg has quit [Ping timeout: 265 seconds]
<josie> vasild: nope, this only happens inside gdb, so I'm guessing something isn't setup correctly. I'll dig into the gdb docs more
<vasild> huh
<bitcoin-git> [bitcoin] hebasto pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/904631e0fc00...a75c77ea903c
<bitcoin-git> bitcoin/master 36e2d51 Hennadii Stepanov: qt, test: Add missed header
<bitcoin-git> bitcoin/master a75c77e Hennadii Stepanov: Merge bitcoin-core/gui#729: test: Add missed header
<bitcoin-git> [gui] hebasto merged pull request #729: test: Add missed header (master...230516-header) https://github.com/bitcoin-core/gui/pull/729
<vasild> do you have ~/.gdbinit? maybe that does some extra stuff?
<vasild> is the breakpoint hit before it goes in IBD? could it be timing related?
aielima has quit [Quit: Ciao]
<vasild> if no more clues, I would find where in the code it decides to go IBD or not and add poor-man's printout "entering IBD because variable x equals 5", "not entering IBD because x equals ..." and run inside and outside gdb and see what gets printed
<josie> vasild: don't have a gdbinit , and no, the breakpoint is after IBD finishes. I don't think its an issue with bitcoin core, since it runs fine outside of gdb, so I'm guessing it has something to do with permissions or gdb not being able to read the blk files?
b_101 has quit [Ping timeout: 240 seconds]
brunoerg has joined #bitcoin-core-dev
b_101 has joined #bitcoin-core-dev
<josie> anywho, thanks for the help. was hoping it was a simple thing like missing a gdb parameter, but looks like something is broken on my end. will spend some more time debugging the debugger after I finish debugging the actual thing lol
brunoerg has quit [Ping timeout: 265 seconds]
Cory has quit [Ping timeout: 265 seconds]
Cory has joined #bitcoin-core-dev
<fanquake> To github.com:bitcoin-core/bitcoin-detached-sigs.git
<fanquake> * [new tag] v23.2 -> v23.2
<fanquake> To github.com:bitcoin-core/bitcoin-detached-sigs.git
<fanquake> * [new tag] v24.1 -> v24.1
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 248 seconds]
<vasild> josie: no idea then :( "prog -foo" should execute prog in the same way as "gdb --args prog -foo"
<willcl_ark> Is there a reason the `guix-clean` script doesn't clean up the "guix-build-25.0rc2/output" directory?
<willcl_ark> It's set as a precious_dir, but I'm not sure why we wouldn't clean that out. It was confusing me why `guix-attest` was outputting "all.SHA256SUMS" after I had run `guix-clean` and not yet codesigned...
<bitcoin-git> [bitcoin] fanquake opened pull request #27683: ci: remove `RUN_SECURITY_TESTS` (master...remove_RUN_SECURITY_TESTS) https://github.com/bitcoin/bitcoin/pull/27683
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 248 seconds]
<bitcoin-git> [bitcoin] hebasto opened pull request #27684: Avoid lock order inversion in `Chainstate::ConnectTip` function (master...230516-punish) https://github.com/bitcoin/bitcoin/pull/27684
AaronvanW has joined #bitcoin-core-dev
AaronvanW has quit [Read error: Connection reset by peer]
AaronvanW has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
AaronvanW has quit [Read error: Connection reset by peer]
AaronvanW has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 264 seconds]
AaronvanW has quit [Read error: Connection reset by peer]
AaronvanW has joined #bitcoin-core-dev
AaronvanW has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 265 seconds]
<bitcoin-git> [bitcoin] MarcoFalke opened pull request #27685: doc: Rework build-unix.md (master...2305-doc-unix-) https://github.com/bitcoin/bitcoin/pull/27685
flooded is now known as _flood
<fjahr> josie: did you check if it's using the right datadir?
AaronvanW has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
<josie> fjahr: yeah, I think I figured it out: the issue I was troubleshooting was somehow corrupting the chainstate/blk files when triggered. I tested this by triggering the error in gdb, exiting, and then restarting the node and confirming that it went into IBD again. restarting the node with -reindex and then running in gdb worked (e.g did not do IBD again)
brunoerg has joined #bitcoin-core-dev
<fanquake> Why is the MSVC build still failing in new PRs
<fanquake> i.e in #27685. Which has the supposed fix from https://github.com/bitcoin-core/gui/pull/729
<gribble> https://github.com/bitcoin/bitcoin/issues/27685 | doc: Rework build-unix.md by MarcoFalke · Pull Request #27685 · bitcoin/bitcoin · GitHub
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/a75c77ea903c...4c3d67a2d0d9
<bitcoin-git> bitcoin/master ddddf49 MarcoFalke: ci: Run iwyu on all src files
<bitcoin-git> bitcoin/master 4c3d67a fanquake: Merge bitcoin/bitcoin#27571: ci: Run iwyu on all src files
<bitcoin-git> [bitcoin] fanquake merged pull request #27571: ci: Run iwyu on all src files (master...2305-ci-iwyu-) https://github.com/bitcoin/bitcoin/pull/27571
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/4c3d67a2d0d9...594f05db19fa
<bitcoin-git> bitcoin/master a09269a fanquake: guix: document when certain guix patches can be dropped
<bitcoin-git> bitcoin/master 594f05d fanquake: Merge bitcoin/bitcoin#27668: guix: document when certain patches can be dr...
<bitcoin-git> [bitcoin] fanquake merged pull request #27668: guix: document when certain patches can be dropped (master...guix_patch_doc) https://github.com/bitcoin/bitcoin/pull/27668
<bitcoin-git> [bitcoin] fanquake opened pull request #27686: [25.x] Changes for rc3 || finalize (25.x...v25.0_finalize) https://github.com/bitcoin/bitcoin/pull/27686
<fanquake> Does anyone have backport candiates for 25.0rc3? If yes, leave a comment in #27686
<gribble> https://github.com/bitcoin/bitcoin/issues/27686 | [25.x] Changes for rc3 || finalize by fanquake · Pull Request #27686 · bitcoin/bitcoin · GitHub
brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
AaronvanW has quit [Remote host closed the connection]
AlexWiederin has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] hebasto opened pull request #27687: msvc: Provide `ObjectFileName` explicitly (master...230517-object) https://github.com/bitcoin/bitcoin/pull/27687
bugs_ has joined #bitcoin-core-dev
flooded has joined #bitcoin-core-dev
vasild has quit [Remote host closed the connection]
_flood has quit [Ping timeout: 256 seconds]
alex-wiederin has joined #bitcoin-core-dev
vasild has joined #bitcoin-core-dev
AlexWiederin has quit [Quit: Client closed]
alex-wiederin is now known as AlexWiederin
kallewoof has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.]
kalle has joined #bitcoin-core-dev
AlexWiederin has quit [Ping timeout: 240 seconds]
kalle has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.]
nanotube has joined #bitcoin-core-dev
kalle has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] fanquake opened pull request #27688: doc: remove Security section from build-unix.md (master...build_unix_drop_security) https://github.com/bitcoin/bitcoin/pull/27688
nanotube has quit [Ping timeout: 268 seconds]
<stickies-v> could someone please grant https://github.com/ismaelsadeeq write access to the bitcoin-dev wiki please? he's working on the v25RC (or final, if already released at that point) testing guide and will be ready to add it soon
<fanquake> stickies-v: invited
<stickies-v> ty
<bitcoin-git> [bitcoin] fanquake opened pull request #27689: doc: remove mention of glibc 2.10+ (master...remove_glibc_vesion_malloc_info) https://github.com/bitcoin/bitcoin/pull/27689
nanotube has joined #bitcoin-core-dev
bitdex_ has quit [Quit: = ""]
<bitcoin-git> [bitcoin] MarcoFalke opened pull request #27690: ci: Use credits for ARM task (master...2305-ci-arm-credits-) https://github.com/bitcoin/bitcoin/pull/27690
alex-wiederin has joined #bitcoin-core-dev
alex-wiederin has quit [Client Quit]
SpellChecker_ has quit [Remote host closed the connection]
SpellChecker has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] hebasto closed pull request #27084: ci: A few fixes of `ccache` issues (master...230211-cccc) https://github.com/bitcoin/bitcoin/pull/27084
TallTim has quit [Ping timeout: 246 seconds]
TallTim has joined #bitcoin-core-dev
Guyver2 has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] fanquake closed pull request #27671: depends: Boost 1.82.0 (master...boost_1_82_0) https://github.com/bitcoin/bitcoin/pull/27671
<bitcoin-git> [bitcoin] fanquake closed pull request #25908: p2p: remove adjusted time (master...remove_adjusted_time) https://github.com/bitcoin/bitcoin/pull/25908
puchka has quit [Ping timeout: 240 seconds]
puchka has joined #bitcoin-core-dev
jarthur_ is now known as jarthur
puchka has quit [Ping timeout: 268 seconds]
puchka has joined #bitcoin-core-dev
stevenwy37 has joined #bitcoin-core-dev
alex-wiederin has joined #bitcoin-core-dev
alex-wiederin has quit [Ping timeout: 240 seconds]
preimage has joined #bitcoin-core-dev
alex-wiederin has joined #bitcoin-core-dev
alex-wiederin is now known as alex_wiederin
AaronvanW has joined #bitcoin-core-dev
AaronvanW has quit [Remote host closed the connection]
yashraj has joined #bitcoin-core-dev
stevenwy37 has quit [Remote host closed the connection]
AbubakarIsmail[m has joined #bitcoin-core-dev
earnestly has joined #bitcoin-core-dev
stevenwy37 has joined #bitcoin-core-dev
Talkless has joined #bitcoin-core-dev
___nick___ has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.]
___nick___ has joined #bitcoin-core-dev
___nick___ has quit [Client Quit]
___nick___ has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] ryanofsky pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/594f05db19fa...4e8a7654f623
<bitcoin-git> bitcoin/master 97844d9 Martin Zumsande: index: Enable reindex-chainstate with active indexes
<bitcoin-git> bitcoin/master 60bec3c Martin Zumsande: index: Use first block from locator instead of looking for fork point
<bitcoin-git> bitcoin/master 4e8a765 Ryan Ofsky: Merge bitcoin/bitcoin#25193: indexes: Read the locator's top block during ...
<bitcoin-git> [bitcoin] ryanofsky merged pull request #25193: indexes: Read the locator's top block during init, allow interaction with reindex-chainstate (master...202205_index_allow_reindex_chainstate) https://github.com/bitcoin/bitcoin/pull/25193
<pinheadmz> yay ryanofsky first merge ?
<ryanofsky> ya
<ryanofsky> achow101, I got "ERROR: Permission to bitcoin-core/gui.git denied to ryanofsky."
<achow101> whoops, forgot that's a different org. should be able to push there now
<ryanofsky> Thanks, that worked
Guyver2 has left #bitcoin-core-dev [Closing Window]
stevenwy37 has quit [Quit: Leaving...]
alex_wiederin has quit [Quit: WeeChat 3.8]
alex-wiederin has joined #bitcoin-core-dev
alex-wiederin has quit [Client Quit]
amirreza91 has joined #bitcoin-core-dev
<cfields> \o/
amirreza91 has quit [Client Quit]
yashraj has quit []
b_101 has quit [Ping timeout: 240 seconds]
___nick___ has quit [Ping timeout: 240 seconds]
pinheadmz[m] has joined #bitcoin-core-dev
mudsip has joined #bitcoin-core-dev
alex-wiederin has joined #bitcoin-core-dev
alex-wiederin has quit [Client Quit]
freesprung has joined #bitcoin-core-dev
freesprung has quit [Ping timeout: 256 seconds]
puchka has quit [Ping timeout: 240 seconds]
Talkless has quit [Quit: Konversation terminated!]
mudsip has quit []
<glozow> \o/
<darosior> :)
vysn has quit [Remote host closed the connection]
evri has quit [Ping timeout: 240 seconds]
b_101 has joined #bitcoin-core-dev
abubakarsadiq has joined #bitcoin-core-dev
b_101 has quit [Ping timeout: 240 seconds]
bugs_ has quit [Quit: Leaving]
abubakarsadiq_ has joined #bitcoin-core-dev
abubakarsadiq has quit [Quit: Lost terminal]
abubakarsadiq_ has quit [Quit: Konversation terminated!]
abubakarsadiq has joined #bitcoin-core-dev
earnestly has quit [Ping timeout: 265 seconds]
abubakarsadiq has quit [Quit: Konversation terminated!]
abubakarsadiq has joined #bitcoin-core-dev
abubakarsadiq has quit [Quit: Konversation terminated!]
abubakarsadiq has joined #bitcoin-core-dev
vysn has joined #bitcoin-core-dev
abubakarsadiq has quit [Quit: Konversation terminated!]
Guest40 has joined #bitcoin-core-dev