ChanServ changed the topic of #bitcoin-core-dev to: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Weekly Meeting Thursday @ 14:00 UTC | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt
brunoerg has joined #bitcoin-core-dev
zato has quit [Quit: Om mani padme hum]
brunoerg has quit [Ping timeout: 240 seconds]
monlovesmango has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
monlovesmango has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 276 seconds]
Guest64 has joined #bitcoin-core-dev
Guest64 has quit [Client Quit]
monlovesmango has quit [Remote host closed the connection]
salvatoshi has quit [Ping timeout: 256 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
monlovesmango has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 255 seconds]
luke-jr has quit [Ping timeout: 252 seconds]
monlovesmango has quit [Remote host closed the connection]
monlovesmango has joined #bitcoin-core-dev
not_reserved has quit [Quit: Client closed]
monlovesmango has quit [Remote host closed the connection]
monlovesmango has joined #bitcoin-core-dev
monloves_ has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
monlovesmango has quit [Ping timeout: 268 seconds]
brunoerg has quit [Ping timeout: 256 seconds]
upekkha has quit []
upekkha has joined #bitcoin-core-dev
not_reserved has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
luke-jr has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 246 seconds]
brunoerg has joined #bitcoin-core-dev
cguida_ has quit [Ping timeout: 256 seconds]
brunoerg has quit [Ping timeout: 255 seconds]
jespada has quit [Ping timeout: 264 seconds]
jespada has joined #bitcoin-core-dev
not_reserved has quit [Quit: Client closed]
not_reserved has joined #bitcoin-core-dev
rbatty has quit [Quit: rbatty]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 256 seconds]
bitdex has joined #bitcoin-core-dev
monloves_ has quit [Remote host closed the connection]
cmirror has quit [Remote host closed the connection]
cmirror has joined #bitcoin-core-dev
monlovesmango has joined #bitcoin-core-dev
JTL is now known as JLT
JLT is now known as JTL
bitdex has quit [Remote host closed the connection]
qxs has quit [Remote host closed the connection]
qxs has joined #bitcoin-core-dev
bitdex has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 255 seconds]
monlovesmango has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 268 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 256 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
brunoerg has joined #bitcoin-core-dev
javi404 has quit [Ping timeout: 260 seconds]
brunoerg has quit [Ping timeout: 256 seconds]
javi404 has joined #bitcoin-core-dev
salvatoshi has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
Guyver2 has joined #bitcoin-core-dev
not_reserved has quit [Quit: Client closed]
brunoerg has quit [Ping timeout: 255 seconds]
Guyver2 has left #bitcoin-core-dev [Closing Window]
PaperSword has quit [Quit: PaperSword]
sipsorcery_ has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
sipsorcery has quit [Ping timeout: 264 seconds]
brunoerg has quit [Ping timeout: 268 seconds]
<bitcoin-git> [bitcoin] hebasto opened pull request #29059: Revert "ci: Only run functional tests on windows in master" (master...231212-msvc-revert) https://github.com/bitcoin/bitcoin/pull/29059
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 255 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 245 seconds]
<bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/d5e5810bd36f...622e79e0fbb8
<bitcoin-git> bitcoin/master fa604eb MarcoFalke: refactor: Use reference instead of pointer in IsBlockPruned
<bitcoin-git> bitcoin/master fa5989d MarcoFalke: refactor: rpc: Pass CBlockIndex by reference instead of pointer
<bitcoin-git> bitcoin/master 622e79e fanquake: Merge bitcoin/bitcoin#29021: refactor: rpc: Pass CBlockIndex by reference ...
<bitcoin-git> [bitcoin] fanquake merged pull request #29021: refactor: rpc: Pass CBlockIndex by reference instead of pointer (master...2312-less-segfault-) https://github.com/bitcoin/bitcoin/pull/29021
brunoerg has joined #bitcoin-core-dev
midnight has quit [Ping timeout: 268 seconds]
cold has quit [Ping timeout: 255 seconds]
midnight has joined #bitcoin-core-dev
cold has joined #bitcoin-core-dev
brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 256 seconds]
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/622e79e0fbb8...7a283836eb78
<bitcoin-git> bitcoin/master d58f89d Marnix: doc: update/clarify max outbound connection count
<bitcoin-git> bitcoin/master 7a28383 fanquake: Merge bitcoin/bitcoin#29052: doc/reduce-traffic: update/clarify max outbou...
<bitcoin-git> [bitcoin] fanquake merged pull request #29052: doc/reduce-traffic: update/clarify max outbound connection count (master...doc-reduce-traffic) https://github.com/bitcoin/bitcoin/pull/29052
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/7a283836eb78...60f677375e52
<bitcoin-git> bitcoin/master fb0b6ca Andrew Chow: tests, bench: Remove incorrect LoadWallet() calls
<bitcoin-git> bitcoin/master bd7f5d3 Andrew Chow: wallet: Assert that the wallet is not initialized in LoadWallet
<bitcoin-git> bitcoin/master 60f6773 fanquake: Merge bitcoin/bitcoin#29055: tests, bench: Fix issue with CWallet::LoadWal...
<bitcoin-git> [bitcoin] fanquake merged pull request #29055: tests, bench: Fix issue with CWallet::LoadWallet() being called in the wrong places (master...assert-loadwallet-before-init) https://github.com/bitcoin/bitcoin/pull/29055
<fanquake> Looks like any ranges usage is going to come with a LLVM/Clang 16+ requirement: https://github.com/bitcoin/bitcoin/pull/28687#issuecomment-1851843817.
<fanquake> We can discuss changes our compiler requirments, but this will come with other potential issues
<fanquake> i.e oss-fuzz is currently pinned to clang 15, and it's unclear when that may change
<fanquake> Hopefully that might happen in the first few months of the new year, but the upgrade discussion has been going since Aug 2022
<fanquake> Using any other compiler inside oss-fuzz is officially unsupported
<dergoegge> I think if it weren't for oss-fuzz it should be fine to bump the minimum clang version to 16
AaronvanW has joined #bitcoin-core-dev
Guest65 has joined #bitcoin-core-dev
jonatack has joined #bitcoin-core-dev
<maflcko> dergoegge: Are you sure? The latest Ubuntu LTS does not ship clang-16
jon_atack has quit [Read error: Connection reset by peer]
<maflcko> I think we should be conservative and (even if the latest LTS has the compiler) give everyone plenty of time to stay on the old LTS for some time
Guest65 has quit [Client Quit]
flooded has joined #bitcoin-core-dev
vasild has quit [Remote host closed the connection]
vasild has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] ismaelsadeeq opened pull request #29060: Policy: Report reason inputs are non standard (master...11-2023-non-standard-inputs-error-messages) https://github.com/bitcoin/bitcoin/pull/29060
theStack has quit [Ping timeout: 256 seconds]
TheRec has quit []
theStack has joined #bitcoin-core-dev
bitdex has quit [Quit: = ""]
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/60f677375e52...a7484be65f76
<bitcoin-git> bitcoin/master 7b22cd8 Hennadii Stepanov: Revert "ci: Only run functional tests on windows in master"
<bitcoin-git> bitcoin/master a7484be fanquake: Merge bitcoin/bitcoin#29059: Revert "ci: Only run functional tests on wind...
<bitcoin-git> [bitcoin] fanquake merged pull request #29059: Revert "ci: Only run functional tests on windows in master" (master...231212-msvc-revert) https://github.com/bitcoin/bitcoin/pull/29059
vasild has quit [Remote host closed the connection]
vasild has joined #bitcoin-core-dev
jon_atack has joined #bitcoin-core-dev
jonatack has quit [Read error: Connection reset by peer]
<bitcoin-git> [bitcoin] BrandonOdiwuor opened pull request #29062: Calculate used balance from GetBalance(...) (master...getbalance-add-used) https://github.com/bitcoin/bitcoin/pull/29062
koolazer has quit [Read error: Connection reset by peer]
sipsorcery_ has quit [Ping timeout: 256 seconds]
PaperSword has joined #bitcoin-core-dev
<dergoegge> maflcko: can't they upgrade their compiler?
<dergoegge> why do we need to support old versions of a compiler that we don't build releases with and that also doesn't support desirable c++20 features?
PaperSword has quit [Quit: PaperSword]
PaperSword has joined #bitcoin-core-dev
<sipa> dergoegge: for example, it would be a bad situation if businesses/miners choose not to update to a new version because they're on a supporter, maintained, distro version, and don't feel like upgrading their infrastructure just yet
<sipa> (this has happened in the past, though it may have been an excuse)
cguida_ has joined #bitcoin-core-dev
<sipa> at some point it's a judgment call of course - we don't keep supporting super old systems at some point, but i don't think that wanting to support ranges (is that all?) is a reason on itself to drop support for supported distros
<pinheadmz> _aj_ kalle running a custom signet for an educational project - got everything working but surprised to see constant 100% CPU while mining. Sort of expected 9:59 of idle time then 1s grind for each block.
<dergoegge> sipa: I mean in this particular case they can just switch to gcc? that seems slightly better anyway since that is the release compiler
<dergoegge> but i get the arguments and if we don't consider the c++20 features in question (i'm only aware of ranges) important enough then it's probably better to wait
<dergoegge> and i guess we already waited to switch to c++20 in the first place for the same reason
<bitcoin-git> [bitcoincore.org] glozow pushed 2 commits to master: https://github.com/bitcoin-core/bitcoincore.org/compare/9efc6a0ac6ce...d484aa258a40
<bitcoin-git> bitcoincore.org/master 31572b9 fanquake: maintenance: update table post v26.0 release
<bitcoin-git> bitcoincore.org/master d484aa2 glozow: Merge bitcoin-core/bitcoincore.org#1000: maintenance: update table post v2...
<bitcoin-git> [bitcoincore.org] glozow merged pull request #1000: maintenance: update table post v26.0 release (master...24_eol) https://github.com/bitcoin-core/bitcoincore.org/pull/1000
kevkevin_ has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 260 seconds]
<bitcoin-git> [bitcoin] achow101 pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/a7484be65f76...d646ca35d991
<bitcoin-git> bitcoin/master 5cea25b Murch: wallet: skip BnB when SFFO is active
<bitcoin-git> bitcoin/master 0c57557 furszy: wallet: create tx, log resulting coin selection info
<bitcoin-git> bitcoin/master 05e5ff1 furszy: test: add coverage for BnB-SFFO restriction
<bitcoin-git> [bitcoin] achow101 merged pull request #28994: wallet: skip BnB when SFFO is enabled (master...2023_wallet_sffo_skip_bnb) https://github.com/bitcoin/bitcoin/pull/28994
<sipa> dergoegge: fair enough - a preference for clang probably only really exists for mac systems
<sipa> but those don't generally run in corporate server settings
<fanquake> that preference also exists in oss-fuzz and probably most serious test infrastructure?
<sipa> fanquake: good point
zato has joined #bitcoin-core-dev
bugs_ has joined #bitcoin-core-dev
monlovesmango has joined #bitcoin-core-dev
preimage has joined #bitcoin-core-dev
szkl has quit [Quit: Connection closed for inactivity]
pablomartin has joined #bitcoin-core-dev
theStack has quit [Ping timeout: 256 seconds]
dviola has joined #bitcoin-core-dev
salvatoshi has quit [Ping timeout: 260 seconds]
pablomartin4btc has joined #bitcoin-core-dev
pablomartin has quit [Ping timeout: 276 seconds]
salvatoshi has joined #bitcoin-core-dev
<fanquake> 2023-12-12T17:50:30Z scheduler thread exit
<fanquake> libc++abi: terminating due to uncaught exception of type std::__1::system_error: mutex lock failed: Invalid argument
<fanquake> [1] 31453 abort src/bitcoind -v2transport
<fanquake> Second time I've seen this, during shutdown, after doing a ctrl-c on bitcoind, in the last month or so (macOS, master etc)
<fanquake> Don't have any other info, maybe someone has seen the same?
<bitcoin-git> [bitcoin] dergoegge opened pull request #29064: fuzz: Improve fuzzing stability for minisketch harness (master...2023-12-fuzz-stability-minisketch) https://github.com/bitcoin/bitcoin/pull/29064
Guest96 has joined #bitcoin-core-dev
theStack has joined #bitcoin-core-dev
Talkless has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] furszy opened pull request #29065: bench: wallet, fix change position out of range error (master...2023_bench_wallet_fix) https://github.com/bitcoin/bitcoin/pull/29065
<bitcoin-git> [bitcoin] hebasto opened pull request #29066: doc: Bump minimum required Boost version due to migration to C++20 (master...231212-boost) https://github.com/bitcoin/bitcoin/pull/29066
<bitcoin-git> [bitcoin] maflcko opened pull request #29067: test: Treat msg_version.relay as unsigned, Remove `struct` packing in messages.py (master...2312-test-less-struct-) https://github.com/bitcoin/bitcoin/pull/29067
___nick___ has joined #bitcoin-core-dev
sipsorcery_ has joined #bitcoin-core-dev
___nick___ has quit [Client Quit]
___nick___ has joined #bitcoin-core-dev
___nick___ has quit [Client Quit]
___nick___ has joined #bitcoin-core-dev
<Murch[m]> Hey vim users, does someone know how I convince my vim to stop telling me that all the includes don’t exist?
<Murch[m]> Every time I open a file, I’m getting "No such file or directory" for the first include
cguida_ has quit [Ping timeout: 240 seconds]
<Murch[m]> I assume it’s somehow related to all the include paths being defined from the base directory rather than in relative paths
GoldmanSats____ has quit [Ping timeout: 260 seconds]
GoldmanSats____ has joined #bitcoin-core-dev
gleb has quit [Ping timeout: 260 seconds]
gleb has joined #bitcoin-core-dev
<Murch[m]> I think the error message may be generated by Syntastic
sipsorcery_ has quit [Ping timeout: 246 seconds]
<bitcoin-git> [bitcoin] maflcko opened pull request #29068: test: Actually fail when a python unit test fails (master...2312-test-fail-fail-) https://github.com/bitcoin/bitcoin/pull/29068
<dergoegge> Murch[m]: is your vim config public?
sipsorcery_ has joined #bitcoin-core-dev
cguida_ has joined #bitcoin-core-dev
<Murch[m]> dergoegge: TIL that Syntastic and YouCompleteMe are partially incompatible and YCM provides all the features of Syntastic for C++
<Murch[m]> After removing Syntastic the error no longer shows
<Murch[m]> So, very likely the problem was mostly in front of the keyboard
<dergoegge> great i was about to recommend not to use syntastic since that is unmaintained :D
<Murch[m]> Thanks for looking into it!
AaronvanW has quit [Quit: Leaving...]
vysn has quit [Remote host closed the connection]
<maflcko> > dergoegge: I mean in this particular case they can just switch to gcc?
<maflcko> Not sure. g++ is slower, uses more memory and produces more false positive warnings, compared to clang++, so not everyone would want to switch to that
<maflcko> Also, installing a newer compiler isn't always trivial when it is missing from the vanilla package manager. It either requires a new third-party packaging depedency or compiling from source, which is non-trivial.
___nick___ has quit [Ping timeout: 240 seconds]
mekster669493 has quit [Quit: mekster669493]
mekster669493 has joined #bitcoin-core-dev
<_aj_> pinheadmz: it backdates the first block and will grind 100 blocks at 100% cpu so you can start spending coins asap; otherwise "miner calibrate" and set "--nbits", or just set "--min-nbits" ?
<pinheadmz> ok so that 100% cpu is just the first 100 blocks? If I use --seconds=600 itll only fire up grind when it needs to?
<pinheadmz> (After height 100)
realies has joined #bitcoin-core-dev
<_aj_> pinheadmz: err, --seconds=600 asks for an nbits that will take 600 seconds to mine on average, so opposite of what you want?
<_aj_> pinheadmz: --seconds=25 is the default
<pinheadmz> i see lemme rephrase - can i run the miner with --ongoing and NOT use 100% cpu forever
<_aj_> pinheadmz: yeah; "miner calibrate --seconds=10" -- tell me an nbits that will take ~10s on this computer everytime i want a block. "miner generate --ongoing -nbits=$WHAT_CALIBRATE_TELLS_YOU ..."
<pinheadmz> ok awesome thanks mate
<_aj_> or "miner generate --ongoing --min-nbits" for "as fast as possible"
<pinheadmz> and that will generate 100 blocks asap, then slow to 1 every 10 min?
<_aj_> it'll be faster than 1-every-10-min for a while until it retargets to hit your specified nbits
<_aj_> (up to 1-every-2.5-min, eg)
monlovesmango has quit [Remote host closed the connection]
bugs_ has quit [Quit: Leaving]
test_ has joined #bitcoin-core-dev
flooded has quit [Ping timeout: 268 seconds]
monlovesmango has joined #bitcoin-core-dev
monlovesmango has quit [Ping timeout: 260 seconds]
preimage has quit [Quit: WeeChat 4.1.1]
monlovesmango has joined #bitcoin-core-dev
jonatack has joined #bitcoin-core-dev
jon_atack has quit [Read error: Connection reset by peer]
pablomartin4btc has quit [Remote host closed the connection]
brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 264 seconds]
cncr04s_ has quit [Quit: See you real soon!]
cncr04s has joined #bitcoin-core-dev
vincenzopalazzo has quit [Remote host closed the connection]
vincenzopalazzo has joined #bitcoin-core-dev
cguida_ has quit [Ping timeout: 256 seconds]
brunoerg has joined #bitcoin-core-dev
realies has quit [Remote host closed the connection]
realies has joined #bitcoin-core-dev
bob_x1 has quit [Remote host closed the connection]
brunoerg has quit [Ping timeout: 252 seconds]
bob_x1 has joined #bitcoin-core-dev
realies has quit [Remote host closed the connection]
realies has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
sipsorcery has joined #bitcoin-core-dev
cguida_ has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
sipsorcery_ has quit [Ping timeout: 256 seconds]
brunoerg has quit [Ping timeout: 256 seconds]