<bitcoin-git>
[bitcoin] fanquake merged pull request #28894: wallet: batch all individual spkms setup db writes in a single db txn (master...2023_wallet_batch_keypool_creation) https://github.com/bitcoin/bitcoin/pull/28894
<bitcoin-git>
guix.sigs/main 905454d coinforensics: Add codesigned attestations by CoinForensics for v26.0
<bitcoin-git>
guix.sigs/main 73e6068 fanquake: Merge pull request #1005 from coinforensics/main
marcofleon has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] dergoegge opened pull request #29031: fuzz: Improve fuzzing stability for txorphan harness (master...2023-12-fuzz-stability-txorphan) https://github.com/bitcoin/bitcoin/pull/29031
bitdex has quit [Quit: = ""]
sipsorcery has quit [Ping timeout: 246 seconds]
marcofleon has quit [Quit: Connection closed]
preimage has joined #bitcoin-core-dev
AaronvanW has joined #bitcoin-core-dev
gossie has joined #bitcoin-core-dev
dviola has joined #bitcoin-core-dev
zato has joined #bitcoin-core-dev
<theStack>
do we have any preference on how to detect the operating system in functional tests? there are at least three ways, returning different results: os.name, sys.platform and platform.system(), and we currently use all of them. that seems a bit messy
AaronvanW has quit [Ping timeout: 264 seconds]
<instagibbs>
dergoegge thanks, follow-up, how are you measuring stability of fuzz tests? I don't see any docs on this
<fanquake>
theStack: can you consolidate to whatever is most modern and supported by our minimum
<fanquake>
iirc sys.platform?
<theStack>
fanquake: sure. if anyone has hints what is most modern, happy to hear
<theStack>
oh okay
<fanquake>
which was introduced least recently
<fanquake>
it might actually be platform.system
<theStack>
sys.platform is a bit weird as it encodes the major version within the name, e.g. 'openbsd7' for openbsd 7.4, even though it is not a real major/minor version system. they just increase by 0.1 on every release
<theStack>
yeah, my guess would also be platform.system(). will double-check
<fanquake>
cool. do we actually (still) need platform versions?
<theStack>
not that i'm aware of. only found some windows-specific stuff in test_runner, using a special method ("if os.name != 'nt' or sys.getwindowsversion() >= ...")
<bitcoin-git>
[bitcoin] Sjors opened pull request #29032: signet: fixing mining for OP_TRUE challenge (master...2023/12/signet-no-challenge) https://github.com/bitcoin/bitcoin/pull/29032
<dergoegge>
instagibbs: to get the stability metric you need to fuzz with afl++
<dergoegge>
I'll try adding something about that to the docs soon
<instagibbs>
ok, makes sense why i didnt find it then
PaperSword has quit [Quit: PaperSword]
PaperSword has joined #bitcoin-core-dev
cguida_ has joined #bitcoin-core-dev
test_ has joined #bitcoin-core-dev
flooded has quit [Ping timeout: 256 seconds]
salvatoshi has quit [Ping timeout: 256 seconds]
longorio has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] theStack opened pull request #29034: test: detect OS in functional tests consistently using `platform.system()` (master...202312-test-consolidate_os_detection_in_python) https://github.com/bitcoin/bitcoin/pull/29034
monlovesmango has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] theStack opened pull request #29035: test: fix `addnode` functional test failure on OpenBSD (master...202312-test-fix_rpc_net_on_openbsd) https://github.com/bitcoin/bitcoin/pull/29035