ChanServ changed the topic of #bitcoin-core-dev to: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Weekly Meeting Thursday @ 14:00 UTC | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt
bitdex has joined #bitcoin-core-dev
pablomartin4btc has joined #bitcoin-core-dev
pablomartin has quit [Ping timeout: 268 seconds]
jarthur_ has joined #bitcoin-core-dev
jarthur_ has quit [Client Quit]
jarthur has quit [Ping timeout: 260 seconds]
ion- has quit [Ping timeout: 256 seconds]
ion- has joined #bitcoin-core-dev
ion- has quit [Ping timeout: 264 seconds]
ion- has joined #bitcoin-core-dev
ion- has quit [Ping timeout: 252 seconds]
ion- has joined #bitcoin-core-dev
jon_atack has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 268 seconds]
jonatack has joined #bitcoin-core-dev
jon_atack has quit [Ping timeout: 256 seconds]
cmirror has quit [Remote host closed the connection]
cmirror has joined #bitcoin-core-dev
Guest98 has joined #bitcoin-core-dev
furszy has quit [Quit: ZNC - https://znc.in]
furszy has joined #bitcoin-core-dev
blockdyor has joined #bitcoin-core-dev
Chris_Stewart_5 has quit [Ping timeout: 272 seconds]
Chris_Stewart_5 has joined #bitcoin-core-dev
ion- has quit [Remote host closed the connection]
ion- has joined #bitcoin-core-dev
ion- has quit [Ping timeout: 256 seconds]
ion- has joined #bitcoin-core-dev
ion- has quit [Ping timeout: 256 seconds]
the_mariner has joined #bitcoin-core-dev
the_mariner has quit [Ping timeout: 255 seconds]
ion- has joined #bitcoin-core-dev
jon_atack has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 264 seconds]
Guyver2 has joined #bitcoin-core-dev
gribble has quit [Remote host closed the connection]
salvatoshi has joined #bitcoin-core-dev
gribble has joined #bitcoin-core-dev
javi404 has quit [Ping timeout: 260 seconds]
javi404 has joined #bitcoin-core-dev
ion- has quit [Remote host closed the connection]
ion- has joined #bitcoin-core-dev
Guest98 has quit [Quit: Client closed]
aleggg has quit [Ping timeout: 256 seconds]
aleggg has joined #bitcoin-core-dev
ion- has quit [Remote host closed the connection]
ion- has joined #bitcoin-core-dev
ion- has quit [Remote host closed the connection]
Guyver2 has left #bitcoin-core-dev [Closing Window]
ion- has joined #bitcoin-core-dev
salvatoshi has quit [Remote host closed the connection]
BrandonOdiwuor has joined #bitcoin-core-dev
Chris_Stewart_5 has quit [Ping timeout: 268 seconds]
Chris_Stewart_5 has joined #bitcoin-core-dev
jon_atack has quit [Ping timeout: 264 seconds]
<bitcoin-git> [bitcoin] hebasto opened pull request #29910: Refactor `subprocess.hpp` to follow our conventions (master...240419-sp-win32) https://github.com/bitcoin/bitcoin/pull/29910
the_mariner has joined #bitcoin-core-dev
the_mariner has quit [Ping timeout: 264 seconds]
furszy has quit [Changing host]
furszy has joined #bitcoin-core-dev
brunoerg has quit [Remote host closed the connection]
the_mariner has joined #bitcoin-core-dev
Chris_Stewart_5 has quit [Ping timeout: 252 seconds]
Chris_Stewart_5 has joined #bitcoin-core-dev
ion- has quit [Remote host closed the connection]
ion- has joined #bitcoin-core-dev
ion- has quit [Ping timeout: 256 seconds]
<fanquake> https://github.com/bitcoin-core/packaging/issues/226 - bitcoin-core 27.0 snap crashed on start
ion- has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] furszy opened pull request #29913: bugfix: update chainman best_header after block reconsideration (master...2024_fix_reconsiderblock_bestheader) https://github.com/bitcoin/bitcoin/pull/29913
VonNaturAustreVe has joined #bitcoin-core-dev
VonNaturAustreVe has quit [Client Quit]
VonNaturAustreVe has joined #bitcoin-core-dev
VonNaturAustreVe has quit [Changing host]
VonNaturAustreVe has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
bitdex has quit [Ping timeout: 260 seconds]
brunoerg_ has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 268 seconds]
VonNaturAustreVe has quit [Quit: Leaving]
BrandonOdiwuor has quit [Ping timeout: 250 seconds]
brunoerg_ has quit [Ping timeout: 268 seconds]
abubakarsadiq has joined #bitcoin-core-dev
ion- has quit [Remote host closed the connection]
ion- has joined #bitcoin-core-dev
ion- has quit [Remote host closed the connection]
<josie> git status
<fanquake> nothing to commit, working tree clean
<josie> if only that were true...
<sipa> git push upstream -d master
preimage has joined #bitcoin-core-dev
jonatack has joined #bitcoin-core-dev
ion- has joined #bitcoin-core-dev
<josie> sipa: that's certainly one way to fix all the bugs
brunoerg has joined #bitcoin-core-dev
bugs_ has joined #bitcoin-core-dev
brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
<_aj_> mightn't fix all the bugs, but should remove any merge conflicts?
ion- has quit [Ping timeout: 260 seconds]
ion- has joined #bitcoin-core-dev
ion- has quit [Ping timeout: 268 seconds]
ion- has joined #bitcoin-core-dev
BrandonOdiwuor has joined #bitcoin-core-dev
ion- has quit [Ping timeout: 268 seconds]
ion- has joined #bitcoin-core-dev
ion- has quit [Remote host closed the connection]
ion- has joined #bitcoin-core-dev
ion- has quit [Remote host closed the connection]
ion- has joined #bitcoin-core-dev
ion- has quit [Remote host closed the connection]
preimage has quit [Ping timeout: 240 seconds]
preimage has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] glozow closed pull request #29827: test: p2p: add test for rejected tx request logic (`m_recent_rejects` filter) (master...202404-test-p2p-check_rejected_tx_requests) https://github.com/bitcoin/bitcoin/pull/29827
the_mariner has quit [Ping timeout: 256 seconds]
the_mariner has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] instagibbs opened pull request #29915: test: Don't fetch orphan parent when parent is in orphanage (master...2024-04-parent_orphan_orphan_nofetch) https://github.com/bitcoin/bitcoin/pull/29915
the_mariner has quit [Ping timeout: 268 seconds]
___nick___ has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 260 seconds]
jonatack has joined #bitcoin-core-dev
the_mariner has joined #bitcoin-core-dev
the_mariner has quit [Ping timeout: 256 seconds]
jon_atack has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 268 seconds]
preimage has quit [Quit: WeeChat 4.2.2]
<roasbeef> so we're seeing some weird behavior on testnet with bitcoin nodes, iiuc ppl are mining a ton of empty blocks, and occasionally we get an error that: ConnectBlock(): coinbase pays too much (actual=26389831 vs limit=26389830)
<roasbeef> searched the tracker, and closest I could find was: https://github.com/bitcoin/bitcoin/issues/7301
<roasbeef> this ends up leading to a segfault
<sipa> bitcoind segfaults?
<roasbeef> we've tried to reindex (mentioned as a solution in that issue), but then it still ends up choking on blocks later
<roasbeef> yes
<roasbeef> this is bitciond 26
<achow101> Try 27?
<sipa> without a way to reproduce this is hard to investigate
<roasbeef> hehe these are connected to lnd nodes, and bitcoind 27 added breaking behavior in sendrawtransaction so we can't update those yet (we have v0.17.5 staged, should drop shortly), but thought this was exceptional enough that I should dig into it
<roasbeef> sec pulling logs
<achow101> that looks valid
<Murch[m]> Is this v26.0 or v26.1?
<gribble> https://github.com/bitcoin/bitcoin/issues/2 | Long-term, safe, store-of-value · Issue #2 · bitcoin/bitcoin · GitHub
jarthur has joined #bitcoin-core-dev
<roasbeef> better one that shows the restart afterwards: https://zerobin.org/?979a92e4bc5edfae#k9Gsq8Yo1dQrUhEGkHfuHXxqYTCmBXPgojqkb9AiPGy
<roasbeef> Bitcoin Core version v26.0.0 (release build)
<achow101> that looks like it was a clean shut down, not a segfault?
<roasbeef> the logs don't capture it here, but we see a SIGSEGV
<roasbeef> this also isn't happening to all the nodes
<sipa> last line is about loading block index, so it's segfaulting during startup?
<gribble> https://github.com/bitcoin/bitcoin/issues/8 | RPC command to sign text with wallet private key · Issue #8 · bitcoin/bitcoin · GitHub
<achow101> my testnet node handled that block fine
<achow101> but it is 27.99
<sipa> i'm spinning up a 26.0 on testnet
<achow101> roasbeef: any chance of a coredump?
<roasbeef> lemmie see
<sipa> if it's reproducible after a restart, perhaps the datadir is useful to have
<achow101> (may contain keys and other private data, blah blah, share privately if you care)
<roasbeef> they're running in k8s, so the container can be wiped/re-created pretty quickly (re obtaining a core dump), can try to extract the state to run it on a normal host also
<roasbeef> the datadir is persistent tho
<roasbeef> just testnet, no wallet instance
<sipa> roasbeef: if you restart bitcoind, does it immediately/quickly segfault again?
<roasbeef> after restart it'll go back to processing blocks to catch up, then will hit a problematic block and repeat the cycle
<gribble> https://github.com/bitcoin/bitcoin/issues/4 | Export/Import wallet in a human readable, future-proof format · Issue #4 · bitcoin/bitcoin · GitHub
<roasbeef> we're reindexing another instance, that one is nearly done
<sdaftuar> i appear to be seeing some of the same issues as roasbeef on my 23.0 testnet node
<roasbeef> ok we were able to get the core dump file
<sdaftuar> (no crashes on my node though, just seeing some of the same invalid blocks)
<sipa> sdaftuar: i'm thinking the invalid blocks may be legit
<sipa> (as in, someone is actually creating invalid blocks)
<achow101> I think the invalid blocks are expected
<instagibbs> right are we sure any of these blocks are actually valid?
<sdaftuar> oh i thought achow was saying that the block linked above looked valid? my node also thought it was invalid
<sdaftuar> sorry -- i misread my log, a block building on that one was invalid, never mind me
<achow101> roasbeef: post that somewhere, or email it?
flooded has joined #bitcoin-core-dev
<Murch[m]> Could have something to do with this: https://twitter.com/0xB10C/status/1780212733805301931
test_ has joined #bitcoin-core-dev
flooded has quit [Ping timeout: 252 seconds]
<roasbeef> achow101: uploading to gdrive rn
<jon_atack> at first look git blaming the related code not seeing any recent (v26 era or later) relevant changes
szkl has joined #bitcoin-core-dev
<sipa> roasbeef: is this a release binary?
<roasbeef> yeah should be, we see this on start up: 2024-04-19T19:08:24Z Bitcoin Core version v26.0.0 (release build)
___nick___ has quit [Ping timeout: 260 seconds]
hirish has quit [Ping timeout: 256 seconds]
twistedline has quit [Remote host closed the connection]
hirish has joined #bitcoin-core-dev
twistedline has joined #bitcoin-core-dev
Talkless has joined #bitcoin-core-dev
chungus has joined #bitcoin-core-dev
chungus has quit [Client Quit]
djkazic has joined #bitcoin-core-dev
djkazic has quit [Client Quit]
jonatack has joined #bitcoin-core-dev
jon_atack has quit [Ping timeout: 264 seconds]
<sipa> roasbeef: is there any chance you can share the whole datadir?
BrandonOdiwuor has quit [Ping timeout: 250 seconds]
puchka has quit [Quit: leaving]
<roasbeef> sipa: sure
<roasbeef> have the cp command running, will take a bit testnet is like 40 GB now and I haz slow internet
<sipa> ok
the_mariner has joined #bitcoin-core-dev
SpellChecker has quit [Remote host closed the connection]
SpellChecker has joined #bitcoin-core-dev
drnet has joined #bitcoin-core-dev
the_mariner has quit [Ping timeout: 252 seconds]
Talkless has quit [Quit: Konversation terminated!]
<roasbeef> ok uploading to gdrive now
<roasbeef> might take a few hours...
<achow101> Well that coredump was less than helpful
<achow101> Just to double check, what's the hash of the bitcoind you're using?
Guest78 has joined #bitcoin-core-dev
Guest78 has quit [Client Quit]
<roasbeef> achow101: binary hash?
<roasbeef> seeing if someone else on the team can upload the data dir, with my upload speed it'll take like 10 hrs at this rate
<achow101> roasbeef: Yes, of the binary itself
<roasbeef> # sha256sum /opt/bitcoin-26.0/bin/bitcoind
<roasbeef> 6f33b7daa95984eb2d4cbf32070c28da66165d02da9997ce1264fcdd0820030a /opt/bitcoin-26.0/bin/bitcoind
jon_atack has joined #bitcoin-core-dev
<sipa> hmm, doesn't match my binary hash
<sipa> for the 26.0 release
<sipa> ab06620aadcf814c0ef8274566631a0428119f1f7e218566c689d535cb515f75 bitcoind
<achow101> Same
<achow101> That would explain why the coredump was useless
jonatack has quit [Ping timeout: 252 seconds]
<roasbeef> there's someone else on the team that hit it with thier personal bitcoind nodes, which they claim to be just the binary from the release
<sipa> roasbeef: a coredump from them would be useful then
blockdyor has quit [Quit: My iMac has gone to sleep. ZZZzzz…]
Chris_Stewart_5 has quit [Ping timeout: 272 seconds]
Chris_Stewart_5 has joined #bitcoin-core-dev
Guest74 has joined #bitcoin-core-dev
Guest74 has quit [Client Quit]