ChanServ changed the topic of #bitcoin-core-dev to: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Weekly Meeting Thursday @ 14:00 UTC | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt
test_ has joined #bitcoin-core-dev
flooded has quit [Ping timeout: 260 seconds]
zeropoint has quit [Quit: leaving]
nlhcd has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 264 seconds]
jonatack has joined #bitcoin-core-dev
nlhcd has quit [Quit: Quit]
zeropoint has joined #bitcoin-core-dev
cmirror has quit [Remote host closed the connection]
cmirror has joined #bitcoin-core-dev
zeropoint has quit [Quit: leaving]
flooded has joined #bitcoin-core-dev
test_ has quit [Ping timeout: 260 seconds]
puchka1101 has quit [Ping timeout: 268 seconds]
puchka has joined #bitcoin-core-dev
Guest8 has joined #bitcoin-core-dev
Guest8 has quit [Client Quit]
Lockesmith has quit [Remote host closed the connection]
ghost43 has quit [Remote host closed the connection]
Lockesmith has joined #bitcoin-core-dev
ghost43 has joined #bitcoin-core-dev
Talkless has joined #bitcoin-core-dev
test_ has joined #bitcoin-core-dev
flooded has quit [Ping timeout: 260 seconds]
adil1 has joined #bitcoin-core-dev
qxs has joined #bitcoin-core-dev
<laanwj> it looks like the "Drahtbot GUIX build requested" label isn't working
Guyver2 has joined #bitcoin-core-dev
<pinheadmz> Is there a single RPC call to determine the change output of a transaction from my own wallet? So far im calling gettransaction then looping through vout with getaddressinfo
Chris_Stewart_5 has quit [Ping timeout: 246 seconds]
Chris_Stewart_5 has joined #bitcoin-core-dev
adil1 has quit [Quit: adil1]
nlhcd has joined #bitcoin-core-dev
flooded has joined #bitcoin-core-dev
test_ has quit [Ping timeout: 252 seconds]
ghost43_ has joined #bitcoin-core-dev
ghost43 has quit [Remote host closed the connection]
ghost43_ has quit [Remote host closed the connection]
ghost43 has joined #bitcoin-core-dev
Lockesmith has quit [Ping timeout: 260 seconds]
Lockesmith has joined #bitcoin-core-dev
___nick___ has joined #bitcoin-core-dev
ghost43 has quit [Quit: Leaving]
ghost43 has joined #bitcoin-core-dev
Zenton has quit [Ping timeout: 268 seconds]
<furszy> pinheadmz: there isn't a simple way. gettransaction 'details' does not include change outputs.
<pinheadmz> should it? or if verbose, `decoded` could include the ischange flag in the vout array
<furszy> yeah, could add a 'include_change' flag.
<furszy> we are already doing it everywhere else
<laanwj> i think it'd make sense to add that to the verbose output (assuming it doesn't make "decoding" much less efficient), but include_change does something different, it shows change outputs where they'd normaly not be shown
<furszy> "it shows change outputs where they'd normaly not be shown" thats what the user would expect when it provides the flag.
<laanwj> then i'm misunderstanding the point here, i thought it did show all change and non-change outputs, and @pinheadmz wants to add a flag (to the output) to distinguish what is what
<furszy> gettransaction 'details' does not retrieve the change outputs. Thus why he is providing the verbose=1 flag to decode the entire tx, then loop through the vouts etc
<laanwj> ok
nicky has joined #bitcoin-core-dev
<furszy> internally; gettransaction loops over the outputs, organizes the info and returns a record for each output owned by the wallet. So, he is basically doing the work twice.
<pinheadmz> so perhaps makes the most sense to add "category":"change" in the "details" array
<pinheadmz> i dont think that would even necessitate a flag since we're already examining each txout?
<furszy> the 'change' category sounds good to me.
<furszy> the flag is at the RPC level, because we would be showing something that wasn't previously shown (at least not in this command).
jonatack has quit [Ping timeout: 260 seconds]
___nick___ has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.]
<pinheadmz> hm yeah ok (about the flag) although i dunno how that could break a consumer of this RPC, its not like adding extra "receive" items...
___nick___ has joined #bitcoin-core-dev
___nick___ has quit [Client Quit]
Zenton has joined #bitcoin-core-dev
___nick___ has joined #bitcoin-core-dev
gmaxwell has left #bitcoin-core-dev [#bitcoin-core-dev]
nlhcd has quit [Quit: Quit]
nlhcd has joined #bitcoin-core-dev
nlhcd has quit [Remote host closed the connection]
javi404_ is now known as javi404
Guyver2 has left #bitcoin-core-dev [Closing Window]
qxs has quit [Ping timeout: 260 seconds]
qxs has joined #bitcoin-core-dev
_cold is now known as cold
jonatack has joined #bitcoin-core-dev
zeropoint has joined #bitcoin-core-dev
zeropoint has quit [Quit: leaving]
Lockesmith has quit [Ping timeout: 260 seconds]
gnaf has joined #bitcoin-core-dev
Talkless has quit [Quit: Konversation terminated!]
saffi has joined #bitcoin-core-dev
test_ has joined #bitcoin-core-dev
flooded has quit [Ping timeout: 264 seconds]
flooded has joined #bitcoin-core-dev
test_ has quit [Ping timeout: 252 seconds]
test_ has joined #bitcoin-core-dev
gnaf has quit [Read error: Connection reset by peer]
flooded has quit [Ping timeout: 240 seconds]
saffi has quit [Changing host]
saffi has joined #bitcoin-core-dev
saffi has quit [Quit: Connection closed]
saffi has joined #bitcoin-core-dev
<saffi> Hi Everyone !
<saffi> I was going through this PR for python testcases and what it actually does is that it replaces all the != operator with assert not equal. in line with this I see there other operators like greater than and less than in the testcases will it make sense to also replace those with assert greater operators ?
___nick___ has quit [Ping timeout: 240 seconds]
jonatack has quit [Ping timeout: 260 seconds]
nlhcd has joined #bitcoin-core-dev
nlhcd1 has joined #bitcoin-core-dev
nlhcd has quit [Remote host closed the connection]
nlhcd1 has quit [Client Quit]
Guest24 has joined #bitcoin-core-dev
Guest24 has quit [Client Quit]