#bitcoin-core-dev on 2024-07-04 — searchable irc log

2023-05-25 14:25 ChanServ changed the topic of #bitcoin-core-dev to: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Weekly Meeting Thursday @ 14:00 UTC | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt

00:03 kevkevin has quit [Ping timeout: 240 seconds]

00:14 <Murch[m]> Uh, confused by this tweet: https://x.com/bitcoincoreorg/status/1808550001452413419

00:15 <Murch[m]> 25.x is in maintenance end, so I’m not sure why @bitcoincoreorg is tweeting that 25.x is still receiving maintenance updates.

00:16 kevkevin has joined #bitcoin-core-dev

00:18 diego has quit [Quit: WeeChat 4.3.3]

00:19 dviola has joined #bitcoin-core-dev

00:21 kevkevin has quit [Ping timeout: 264 seconds]

00:32 <_aj_> should presumably say "still receiving critical security updates" rather than "maintenance updates", i guess?

00:35 kevkevin has joined #bitcoin-core-dev

00:36 BlueMatt has quit [Quit: Quit]

00:37 BlueMatt has joined #bitcoin-core-dev

00:40 kevkevin has quit [Ping timeout: 268 seconds]

00:40 conman has joined #bitcoin-core-dev

00:48 <bitcoin-git> [bitcoin] theuni opened pull request #30387: contrib: use c++ compiler rather than c compiler for binary checks (master...cxx-security-check) https://github.com/bitcoin/bitcoin/pull/30387

00:50 jon_atack has joined #bitcoin-core-dev

00:50 jonatack has quit [Ping timeout: 264 seconds]

00:52 kevkevin has joined #bitcoin-core-dev

00:57 kevkevin has quit [Ping timeout: 260 seconds]

01:05 kevkevin has joined #bitcoin-core-dev

01:10 kevkevin has quit [Ping timeout: 268 seconds]

01:21 kevkevin has joined #bitcoin-core-dev

01:27 kevkevin has quit [Ping timeout: 260 seconds]

01:41 kevkevin has joined #bitcoin-core-dev

01:46 kevkevin has quit [Ping timeout: 255 seconds]

01:48 kevkevin has joined #bitcoin-core-dev

02:40 kevkevin has quit [Remote host closed the connection]

02:55 bitdex has joined #bitcoin-core-dev

03:03 achow101 has quit [Remote host closed the connection]

03:21 achow101 has joined #bitcoin-core-dev

03:42 <luke-jr> several of the now-disclosed vulnerabilities lack (AFAIK) CVE assignments. has anyone requested them yet? (they're denoted as "TBD" on the CVEs wiki page for now)

04:01 cmirror has quit [Remote host closed the connection]

04:01 cmirror has joined #bitcoin-core-dev

04:41 kevkevin has joined #bitcoin-core-dev

04:46 kevkevin has quit [Ping timeout: 268 seconds]

05:00 mcey_ has quit [Read error: Connection reset by peer]

05:01 mcey has joined #bitcoin-core-dev

05:08 mcey has quit [Ping timeout: 268 seconds]

05:17 TheRec has joined #bitcoin-core-dev

05:18 TheRec_ has quit [Read error: Connection reset by peer]

05:47 BUSY has quit [Ping timeout: 240 seconds]

06:01 BUSY has joined #bitcoin-core-dev

06:05 maflcko has quit [Quit: ZNC 1.8.2+deb2build5 - https://znc.in]

06:07 maflcko has joined #bitcoin-core-dev

06:41 benwestgate has joined #bitcoin-core-dev

06:49 noonien808310429 has quit [Quit: Ping timeout (120 seconds)]

06:49 noonien808310429 has joined #bitcoin-core-dev

06:51 <bitcoin-git> [bitcoin] TheCharlatan opened pull request #30388: bugfix: Check if mempool exists before asserting in ActivateSnapshot (master...assumeUtxoMempool) https://github.com/bitcoin/bitcoin/pull/30388

07:05 Guyver2 has joined #bitcoin-core-dev

07:15 <darosior> luke-jr: yes

07:20 BUSY has quit [Ping timeout: 264 seconds]

07:32 BUSY has joined #bitcoin-core-dev

07:39 BUSY has quit [Ping timeout: 240 seconds]

07:40 puchka has joined #bitcoin-core-dev

07:52 core-meetingbot` has quit [Remote host closed the connection]

07:52 BUSY has joined #bitcoin-core-dev

07:53 jonasschnelli has quit [Remote host closed the connection]

08:07 jonasschnelli has joined #bitcoin-core-dev

08:10 BUSY has quit [Ping timeout: 260 seconds]

08:27 BUSY has joined #bitcoin-core-dev

08:32 BUSY has quit [Ping timeout: 268 seconds]

08:48 BUSY has joined #bitcoin-core-dev

08:57 cornfeedhobo has quit [Quit: ZNC - https://znc.in]

09:05 cornfeedhobo has joined #bitcoin-core-dev

09:13 abubakarsadiq has joined #bitcoin-core-dev

09:51 BUSY has quit [Ping timeout: 260 seconds]

10:03 BUSY has joined #bitcoin-core-dev

10:04 <maflcko> ryanofsky: I went ahead and fixed it in https://github.com/maflcko/DrahtBot/commit/cf46398f045566b28748adac92369b5d0383eb86 . Let me know if there are any other issues with DrahtBot

10:16 achow101 has quit [Quit: No Ping reply in 180 seconds.]

10:17 achow101 has joined #bitcoin-core-dev

10:26 <bitcoin-git> [bitcoin] fanquake pushed 24 commits to master: https://github.com/bitcoin/bitcoin/compare/3714692644f4...5c0cd205a1ab

10:26 <bitcoin-git> bitcoin/master 493a2e0 Pieter Wuille: random: write rand256() in function of fillrand()

10:26 <bitcoin-git> bitcoin/master b3b382d Pieter Wuille: random: move rand256() and randbytes() to .h file

10:26 <bitcoin-git> bitcoin/master 27cefc7 Pieter Wuille: random: add a few noexcepts to FastRandomContext

10:26 <bitcoin-git> [bitcoin] fanquake merged pull request #29625: Several randomness improvements (master...202403_rand_rework) https://github.com/bitcoin/bitcoin/pull/29625

10:37 BUSY has quit [Ping timeout: 252 seconds]

10:43 kevkevin has joined #bitcoin-core-dev

10:46 _flood has quit [Remote host closed the connection]

10:46 _flood has joined #bitcoin-core-dev

10:48 kevkevin has quit [Ping timeout: 255 seconds]

10:55 BUSY has joined #bitcoin-core-dev

10:59 _flood has quit [Remote host closed the connection]

11:00 _flood has joined #bitcoin-core-dev

11:02 _flood has quit [Remote host closed the connection]

11:03 _flood has joined #bitcoin-core-dev

11:04 <bitcoin-git> [bitcoin] ismaelsadeeq opened pull request #30391: BlockAssembler: return selected packages vsize and feerate (master...07-2024-miner-return-package-sizes-and-fees) https://github.com/bitcoin/bitcoin/pull/30391

11:05 _flood has quit [Remote host closed the connection]

11:06 _flood has joined #bitcoin-core-dev

11:07 _flood has quit [Remote host closed the connection]

11:07 _flood has joined #bitcoin-core-dev

11:30 _flood has quit [Remote host closed the connection]

11:31 _flood has joined #bitcoin-core-dev

11:32 _flood has quit [Remote host closed the connection]

11:33 _flood has joined #bitcoin-core-dev

11:35 _flood has quit [Remote host closed the connection]

11:35 _flood has joined #bitcoin-core-dev

12:07 <bitcoin-git> [bitcoin] maflcko opened pull request #30393: net_processing: use existing RNG object in ProcessGetBlockData (master...2407-rand-fixups) https://github.com/bitcoin/bitcoin/pull/30393

12:12 puchka1101 has joined #bitcoin-core-dev

12:12 puchka has quit [Killed (NickServ (GHOST command used by puchka1101!~puchka@185.203.122.30))]

12:12 puchka1101 is now known as puchka

12:43 kevkevin has joined #bitcoin-core-dev

12:54 kevkevin has quit [Remote host closed the connection]

13:08 jon_atack has quit [Read error: Connection reset by peer]

13:08 <bitcoin-git> [bitcoincore.org] fanquake pushed 2 commits to master: https://github.com/bitcoin-core/bitcoincore.org/compare/958404ba65b9...569541616e85

13:08 <bitcoin-git> bitcoincore.org/master 0ddea14 fanquake: 27.1: fix formatting in release notes

13:08 <bitcoin-git> bitcoincore.org/master 5695416 merge-script: Merge bitcoin-core/bitcoincore.org#1045: 27.1: fix formatting in release n...

13:08 <bitcoin-git> [bitcoincore.org] fanquake merged pull request #1045: 27.1: fix formatting in release notes (master...fix_formatting) https://github.com/bitcoin-core/bitcoincore.org/pull/1045

13:20 andrewtoth has joined #bitcoin-core-dev

13:21 andrewtoth has quit [Client Quit]

13:21 andrewtoth has joined #bitcoin-core-dev

13:24 <bitcoin-git> [bitcoin] glozow pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/5c0cd205a1ab...aa61d4feb041

13:25 <bitcoin-git> bitcoin/master 33c48c1 TheCharlatan: validation: Check if mempool exists before asserting in ActivateSnapshot

13:25 <bitcoin-git> bitcoin/master aa61d4f glozow: Merge bitcoin/bitcoin#30388: validation: Check if mempool exists before si...

13:25 <bitcoin-git> [bitcoin] glozow merged pull request #30388: validation: Check if mempool exists before size check in ActivateSnapshot (master...assumeUtxoMempool) https://github.com/bitcoin/bitcoin/pull/30388

13:28 jonatack has joined #bitcoin-core-dev

13:28 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/aa61d4feb041...bd5d1688b431

13:28 <bitcoin-git> bitcoin/master f59e905 Cory Fields: depends: switch libevent to CMake

13:28 <bitcoin-git> bitcoin/master bd5d168 merge-script: Merge bitcoin/bitcoin#29835: depends: build libevent with CMake

13:28 <bitcoin-git> [bitcoin] fanquake merged pull request #29835: depends: build libevent with CMake (master...libevent_master_cmake) https://github.com/bitcoin/bitcoin/pull/29835

13:41 kevkevin has joined #bitcoin-core-dev

14:00 <achow101> #startmeeting

14:00 <achow101> #bitcoin-core-dev Meeting: achow101 _aj_ amiti ariard aureleoules b10c BlueMatt brunoerg cfields darosior dergoegge dongcarl fanquake fjahr furszy gleb glozow hebasto instagibbs jamesob jarolrod jonatack josibake kallewoof kanzure kouloumos kvaciral laanwj LarryRuane lightlike luke-jr MacroFake Murch phantomcircuit pinheadmz promag provoostenator ryanofsky sdaftuar S3RK stickies-v sipa sr_gi theStack TheCharlatan vasild

14:00 <tdb3> hi

14:00 <brunoerg> hi

14:00 <dergoegge> hi

14:00 <TheCharlatan> hi

14:00 <darosior> LogPrintf("hi");

14:00 <furszy> hi

14:00 <pinheadmz> 🇺🇸

14:00 <achow101> There are no pre-proposed meeting topics this week. Any last minute ones to add?

14:00 <hebasto> hi

14:01 Emc99 has joined #bitcoin-core-dev

14:01 <sdaftuar> hi

14:01 <abubakarsadiq> hi

14:01 <achow101> #topic package relay updates (glozow)

14:02 <glozow> hi

14:02 <glozow> I'm back. TRUC stuff is done! Package RBF still has the followups left, #30295.

14:02 <glozow> On the p2p side, #30111 is still the priority. I updated it yesterday and now waiting for review. Keen to get that done so that we can move on to #30110.

14:02 <gribble> https://github.com/bitcoin/bitcoin/issues/30295 | #28984 package rbf followups by instagibbs · Pull Request #30295 · bitcoin/bitcoin · GitHub

14:02 <gribble> https://github.com/bitcoin/bitcoin/issues/30111 | locks: introduce mutex for tx download, flush rejection filters on UpdatedBlockTip by glozow · Pull Request #30111 · bitcoin/bitcoin · GitHub

14:02 <gribble> https://github.com/bitcoin/bitcoin/issues/30110 | refactor: TxDownloadManager by glozow · Pull Request #30110 · bitcoin/bitcoin · GitHub

14:02 <josie> hi

14:03 <glozow> that's it from me

14:03 <achow101> #topic cluster mempool updates (sdaftuar)

14:03 <sdaftuar> hi. #30126 is still the PR to review (see cluster mempool tracking issue, #30289).

14:03 <gribble> https://github.com/bitcoin/bitcoin/issues/30126 | cluster mempool: cluster linearization algorithm by sipa · Pull Request #30126 · bitcoin/bitcoin · GitHub

14:03 <b10c> hi

14:03 <gribble> https://github.com/bitcoin/bitcoin/issues/30289 | Cluster mempool tracking issue · Issue #30289 · bitcoin/bitcoin · GitHub

14:03 <stickies-v> hi

14:04 <sdaftuar> i've started reviewing sipa's cluster linearization code PR myself, and also trying to keep #28676 up to date with rebases (just noticed i should rebase again)

14:04 <gribble> https://github.com/bitcoin/bitcoin/issues/28676 | [WIP] Cluster mempool implementation by sdaftuar · Pull Request #28676 · bitcoin/bitcoin · GitHub

14:04 <sipa> hi

14:04 <sdaftuar> not sure if sipa is around to provide any other updates, but happy to answer questions

14:05 <sipa> i've been addresses some early review comments on 30126

14:05 <sipa> i've considering changes the serialization format for clusters (which the fuzz tests heavily rely on), as it may be simpler

14:06 <jonatack> hi

14:06 <sipa> other than that, i've been working on a (probably too) long writeup explaining why the algorithms in my PRs are needed and why they work

14:08 <achow101> #topic legacy wallet removal updates (achow101)

14:08 <achow101> #26596 is still the PR to review and it looks like it's close.

14:08 <gribble> https://github.com/bitcoin/bitcoin/issues/26596 | wallet: Migrate legacy wallets to descriptor wallets without requiring BDB by achow101 · Pull Request #26596 · bitcoin/bitcoin · GitHub

14:08 <fjahr> hi

14:09 <achow101> There's also #28574, #30265, and gui#824 to review

14:09 <gribble> https://github.com/bitcoin/bitcoin/issues/28574 | wallet: optimize migration process, batch db transactions by furszy · Pull Request #28574 · bitcoin/bitcoin · GitHub

14:09 <gribble> https://github.com/bitcoin/bitcoin/issues/30265 | wallet: Fix listwalletdir listing of migrated default wallets and generated backup files by achow101 · Pull Request #30265 · bitcoin/bitcoin · GitHub

14:09 <gribble> https://github.com/bitcoin/bitcoin/issues/824 | Use of read_some in bitcoinrpc.cpp · Issue #824 · bitcoin/bitcoin · GitHub

14:09 <achow101> #topic Ad-hoc high priority for review

14:09 <achow101> Anything to add or remove from https://github.com/orgs/bitcoin/projects/1/views/4

14:10 <abubakarsadiq> can i get #29523 it has been acked by furszy already

14:10 <gribble> https://github.com/bitcoin/bitcoin/issues/29523 | Wallet: Add `max_tx_weight` to transaction funding options (take 2) by ismaelsadeeq · Pull Request #29523 · bitcoin/bitcoin · GitHub

14:10 <achow101> abubakarsadiq: added

14:11 <abubakarsadiq> thanks

14:11 <jonatack> Question, would people like to see BIPs merges in this channel?

14:11 <achow101> jonatack: I think bips should have it's own channel

14:11 <jonatack> Noticed the bitcoincore org ones were added here recently

14:12 <achow101> bips are separate from bitcoin core

14:12 <achow101> Any other topics to discuss today?

14:13 <glozow> 26.2 was tagged, please build

14:13 <sipa> disclosures of ancient bitcoin core versions were published: https://bitcoincore.org/en/security-advisories/

14:14 <achow101> #endmeeting

14:15 <fjahr> jonatack: I would be interested in number assignments only but merges of typo fixes etc. sounds too noisy for this channel

14:16 <jonatack> fjahr: achow101: makes sense

14:17 <bitcoin-git> [bitcoin-detached-sigs] achow101 pushed 1 commit to 26.x: https://github.com/bitcoin-core/bitcoin-detached-sigs/compare/788ff1c415b0...6f0226fd43b2

14:17 <bitcoin-git> bitcoin-detached-sigs/26.x 6f0226f Ava Chow: 26.2: win sig for final

14:18 <jonatack> @bitcoinmerges account in https://x0f.org (fediverse) currently toots all core, gui and bips merges

14:19 <jonatack> and Murch[m] tweets about merges of new bips

14:20 kevkevin has quit [Remote host closed the connection]

14:22 Emc99 has quit [Quit: Ping timeout (120 seconds)]

14:28 andrewtoth has quit [Remote host closed the connection]

14:28 andrewtoth has joined #bitcoin-core-dev

14:55 <luke-jr> darosior: in that case, note that a few of them did already have CVEs assigned years ago, which were omitted from the website

14:58 <luke-jr> https://bitcoincore.org/en/2024/07/03/disclose_receive_buffer_oom/ is CVE-2015-3641

14:58 <luke-jr> https://bitcoincore.org/en/2024/07/03/disclose-unbounded-banlist/ is CVE-2020-14198

15:00 <glozow> b10c: willcl-ark: btw the guix.sigs hash matching workflow is really awesome and useful, thanks!!! 👏

15:12 <bitcoin-git> [bitcoin-detached-sigs] fanquake pushed 1 commit to 26.x: https://github.com/bitcoin-core/bitcoin-detached-sigs/compare/6f0226fd43b2...f97d367780cd

15:12 <bitcoin-git> bitcoin-detached-sigs/26.x f97d367 fanquake: 26.2: macOS sig for final

15:13 Guyver2 has left #bitcoin-core-dev [Closing Window]

15:42 bugs_ has joined #bitcoin-core-dev

15:47 mcey has joined #bitcoin-core-dev

16:13 andrewtoth has quit [Remote host closed the connection]

16:13 andrewtoth has joined #bitcoin-core-dev

16:19 zzzzz_ has quit [Ping timeout: 260 seconds]

16:20 zzzzz has joined #bitcoin-core-dev

16:27 mudsip has joined #bitcoin-core-dev

16:29 mudsip has quit [Client Quit]

16:43 abubakarsadiq has quit [Quit: Connection closed for inactivity]

16:44 Torr has joined #bitcoin-core-dev

16:52 andrewtoth has quit [Ping timeout: 260 seconds]

17:12 dzxzg has joined #bitcoin-core-dev

17:14 dzxzg has quit [Client Quit]

17:16 dzxzg has joined #bitcoin-core-dev

17:22 dzxzg has quit [Quit: leaving]

17:43 andrewtoth has joined #bitcoin-core-dev

17:44 BUSY has quit [Ping timeout: 240 seconds]

17:47 Torr has quit [Ping timeout: 260 seconds]

17:49 Torr has joined #bitcoin-core-dev

17:55 ThePlebRoad has joined #bitcoin-core-dev

17:57 BUSY has joined #bitcoin-core-dev

18:00 BUSY has quit [Max SendQ exceeded]

18:01 BUSY has joined #bitcoin-core-dev

18:48 Torr has quit [Ping timeout: 240 seconds]

18:50 Torr has joined #bitcoin-core-dev

19:06 <bitcoin-git> [bitcoin] theStack opened pull request #30394: net: fix race condition in self-connect detection (master...202407-p2p-fix_selfdetection_racecond) https://github.com/bitcoin/bitcoin/pull/30394

19:10 Guest4 has joined #bitcoin-core-dev

19:13 Guest19 has joined #bitcoin-core-dev

19:13 Guest19 has quit [Client Quit]

19:14 Guest4 has quit [Client Quit]

19:16 Talkless has quit [Read error: Connection reset by peer]

19:31 kevkevin has joined #bitcoin-core-dev

19:36 kevkevin has quit [Ping timeout: 256 seconds]

20:19 Guest56 has joined #bitcoin-core-dev

20:25 Guest56 has quit [Quit: Client closed]

21:04 andrewtoth_ has joined #bitcoin-core-dev

21:04 andrewtoth_ has quit [Remote host closed the connection]

22:02 bugs_ has quit [Quit: Leaving]

22:23 zzzzz has quit [Remote host closed the connection]

22:24 zzzzz_ has joined #bitcoin-core-dev

22:25 cm has quit [Quit: Bye.]

22:26 andrewtoth has quit [Ping timeout: 260 seconds]

22:30 andrewtoth has joined #bitcoin-core-dev

22:31 zzzzz_ has quit [Ping timeout: 260 seconds]

22:34 cm has joined #bitcoin-core-dev

22:43 zzzzz_ has joined #bitcoin-core-dev

23:15 kevkevin has joined #bitcoin-core-dev

23:19 zzzzz_ has quit [Ping timeout: 260 seconds]

23:19 kevkevin has quit [Ping timeout: 268 seconds]

23:19 zzzzz_ has joined #bitcoin-core-dev

23:42 andrewtoth has quit [Ping timeout: 260 seconds]