#bitcoin-core-dev on 2024-07-11 — searchable irc log

2023-05-25 14:25 ChanServ changed the topic of #bitcoin-core-dev to: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Weekly Meeting Thursday @ 14:00 UTC | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt

00:05 lbia has quit [Ping timeout: 252 seconds]

00:15 <bitcoin-git> [bitcoincore.org] azuchi opened pull request #1048: Add japanese translation for 26.2 (master...ja-translate-26.2) https://github.com/bitcoin-core/bitcoincore.org/pull/1048

00:22 willcl-ark has quit [Ping timeout: 256 seconds]

00:37 willcl-ark has joined #bitcoin-core-dev

00:46 Guest40 has joined #bitcoin-core-dev

00:46 Guest40 has quit [Client Quit]

01:03 andrewtoth_ has quit [Ping timeout: 260 seconds]

01:31 jon_atack has joined #bitcoin-core-dev

01:32 jonatack has quit [Ping timeout: 256 seconds]

01:42 jon_atack has quit [Ping timeout: 256 seconds]

01:45 zzzzz_ has quit [Remote host closed the connection]

01:50 zzzzz_ has joined #bitcoin-core-dev

02:39 andrewtoth_ has joined #bitcoin-core-dev

03:24 andrewtoth_ has quit [Ping timeout: 260 seconds]

03:27 johnny9dev584508 has quit [Server closed connection]

03:27 johnny9dev584508 has joined #bitcoin-core-dev

03:29 bitdex has joined #bitcoin-core-dev

04:00 achow101 has quit [Server closed connection]

04:00 achow101 has joined #bitcoin-core-dev

04:01 cmirror has quit [Remote host closed the connection]

04:01 cmirror has joined #bitcoin-core-dev

04:15 SpellChecker has quit [Ping timeout: 260 seconds]

04:16 SpellChecker has joined #bitcoin-core-dev

04:16 bitdex has quit [Ping timeout: 260 seconds]

04:18 bitdex has joined #bitcoin-core-dev

04:24 vyHamii has joined #bitcoin-core-dev

04:47 jonatack has joined #bitcoin-core-dev

04:52 jonatack has quit [Ping timeout: 256 seconds]

04:56 Guest44 has joined #bitcoin-core-dev

04:57 Guest44 has quit [Client Quit]

05:01 mcey_ has joined #bitcoin-core-dev

05:01 mcey has quit [Read error: Connection reset by peer]

05:02 Guest44 has joined #bitcoin-core-dev

05:08 cryptapus has quit [Ping timeout: 268 seconds]

05:38 pyth__ has joined #bitcoin-core-dev

05:40 pyth has quit [Ping timeout: 246 seconds]

05:41 diego2 has quit [Quit: WeeChat 4.3.4]

05:41 aleggg has quit [Ping timeout: 264 seconds]

05:41 pyth_ has quit [Ping timeout: 256 seconds]

05:42 aleggg has joined #bitcoin-core-dev

05:43 pyth has joined #bitcoin-core-dev

06:04 kevkevin has quit [Remote host closed the connection]

06:23 lbia has joined #bitcoin-core-dev

06:31 johnzweng has quit [Server closed connection]

06:32 johnzweng has joined #bitcoin-core-dev

06:35 kevkevin has joined #bitcoin-core-dev

06:39 kevkevin has quit [Ping timeout: 240 seconds]

07:06 darosior6 has joined #bitcoin-core-dev

07:06 darosior has quit [Read error: Connection reset by peer]

07:06 darosior6 is now known as darosior

07:10 kevkevin has joined #bitcoin-core-dev

07:16 kevkevin has quit [Ping timeout: 268 seconds]

07:17 kevkevin has joined #bitcoin-core-dev

07:20 Guyver2 has joined #bitcoin-core-dev

07:27 kevkevin has quit [Ping timeout: 256 seconds]

07:43 kevkevin has joined #bitcoin-core-dev

07:56 kevkevin has quit [Ping timeout: 268 seconds]

08:11 kevkevin has joined #bitcoin-core-dev

08:15 kevkevin has quit [Ping timeout: 246 seconds]

08:20 nickler has quit [Remote host closed the connection]

08:30 kevkevin has joined #bitcoin-core-dev

08:35 kevkevin has quit [Ping timeout: 256 seconds]

08:41 cryptapus has joined #bitcoin-core-dev

08:42 flag has joined #bitcoin-core-dev

08:48 kevkevin has joined #bitcoin-core-dev

08:54 kevkevin has quit [Ping timeout: 268 seconds]

09:05 kevkevin has joined #bitcoin-core-dev

09:10 kevkevin has quit [Ping timeout: 260 seconds]

09:17 BlueMatt has quit [Server closed connection]

09:17 jonatack has joined #bitcoin-core-dev

09:17 BlueMatt has joined #bitcoin-core-dev

09:20 nickler has joined #bitcoin-core-dev

09:23 kevkevin has joined #bitcoin-core-dev

09:27 kevkevin has quit [Ping timeout: 260 seconds]

09:41 kevkevin has joined #bitcoin-core-dev

09:46 kevkevin has quit [Ping timeout: 256 seconds]

09:59 kevkevin has joined #bitcoin-core-dev

10:05 kevkevin has quit [Ping timeout: 268 seconds]

10:08 abubakarsadiq has joined #bitcoin-core-dev

10:18 kevkevin has joined #bitcoin-core-dev

10:20 flag has quit [Quit: leaving]

10:20 flag has joined #bitcoin-core-dev

10:23 kevkevin has quit [Ping timeout: 260 seconds]

10:37 kevkevin has joined #bitcoin-core-dev

10:44 kevkevin has quit [Ping timeout: 268 seconds]

10:44 Guest44 has quit [Quit: Guest44]

10:57 <bitcoin-git> [bitcoin] glozow opened pull request #30427: remove truc_policy from libbitcoin_common_a_SOURCES (master...2024-07-truc-common) https://github.com/bitcoin/bitcoin/pull/30427

10:58 kevkevin has joined #bitcoin-core-dev

11:06 kevkevin has quit [Ping timeout: 256 seconds]

11:07 oneeyedalien has joined #bitcoin-core-dev

11:12 mcey_ has quit [Ping timeout: 256 seconds]

11:29 mcey has joined #bitcoin-core-dev

11:29 mcey has quit [Remote host closed the connection]

11:29 mcey has joined #bitcoin-core-dev

11:31 oneeyedalien has quit [Quit: Leaving]

11:31 mekster6694939 has quit [Quit: mekster6694939]

11:32 adil has joined #bitcoin-core-dev

11:34 mekster66949398 has joined #bitcoin-core-dev

11:39 kevkevin has joined #bitcoin-core-dev

11:44 kevkevin has quit [Ping timeout: 256 seconds]

11:45 adil has quit [Quit: adil]

11:46 Guest44 has joined #bitcoin-core-dev

11:55 jonatack has quit [Ping timeout: 246 seconds]

11:57 jonatack has joined #bitcoin-core-dev

12:03 jonatack has quit [Ping timeout: 268 seconds]

12:14 kevkevin has joined #bitcoin-core-dev

12:16 jonatack has joined #bitcoin-core-dev

12:21 kevkevin has quit [Ping timeout: 268 seconds]

12:29 Guyver2 has quit [Quit: Going offline, see ya! (www.adiirc.com)]

12:39 jonatack has quit [Ping timeout: 272 seconds]

12:51 bitdex has quit [Quit: = ""]

12:55 jonatack has joined #bitcoin-core-dev

13:01 jonatack has quit [Ping timeout: 256 seconds]

13:02 jonatack has joined #bitcoin-core-dev

13:03 Guest44 has quit [Quit: Guest44]

13:11 kevkevin has joined #bitcoin-core-dev

13:26 Guest44 has joined #bitcoin-core-dev

13:28 jonatack has quit [Ping timeout: 252 seconds]

13:36 andrewtoth_ has joined #bitcoin-core-dev

13:57 jonatack has joined #bitcoin-core-dev

13:57 Guest65 has joined #bitcoin-core-dev

14:00 <achow101> #startmeeting

14:00 <maxedw> hi

14:00 <achow101> #bitcoin-core-dev Meeting: achow101 _aj_ amiti ariard aureleoules b10c BlueMatt brunoerg cfields darosior dergoegge dongcarl fanquake fjahr furszy gleb glozow hebasto instagibbs jamesob jarolrod jonatack josibake kallewoof kanzure kouloumos kvaciral laanwj LarryRuane lightlike luke-jr MacroFake Murch phantomcircuit pinheadmz promag provoostenator ryanofsky sdaftuar S3RK stickies-v sipa sr_gi theStack TheCharlatan vasild

14:00 <cfields> hi

14:00 <hebasto> hi

14:00 <furszy> hi

14:00 <achow101> There are no pre-proposed meeting topics this week. Any last minute ones to add?

14:00 <stickies-v> hi

14:01 <tdb3> hi

14:01 <willcl-ark> hi

14:01 <sipa> hi

14:01 virtu_ has left #bitcoin-core-dev [#bitcoin-core-dev]

14:01 <abubakarsadiq> hi

14:01 <achow101> #topic package relay updates (glozow)

14:01 virtu has joined #bitcoin-core-dev

14:01 <glozow> The priority is still #30111. We should also get the package RBF followup #30295 merged

14:01 <pinheadmz> hi

14:01 <gribble> https://github.com/bitcoin/bitcoin/issues/30111 | locks: introduce mutex for tx download, flush rejection filters on UpdatedBlockTip by glozow · Pull Request #30111 · bitcoin/bitcoin · GitHub

14:01 <gribble> https://github.com/bitcoin/bitcoin/issues/30295 | #28984 package rbf followups by instagibbs · Pull Request #30295 · bitcoin/bitcoin · GitHub

14:02 <virtu> hi

14:02 <glozow> That's all from me

14:02 <achow101> #topic cluster mempool updates (sdaftuar)

14:02 <sipa> hi

14:03 <sipa> unsure if sdaftuar is here, but my biggest update is that i published https://delvingbitcoin.org/t/introduction-to-cluster-linearization/1032

14:03 <b10c> hi

14:03 <sipa> it's long, but it doesn't assume much background, so if you're interested in reviewing the cluster linearization PRs, this is intended to explain what they're doing, and why that's useful

14:03 <Murch[m]> Hi

14:04 <fjahr> hi

14:04 <sipa> i've also been addressing feedback, and making some changes to the PRs

14:04 <brunoerg> hi

14:04 <ajonas> hi

14:05 <sipa> that's it for me i think

14:05 <achow101> #topic legacy wallet removal updates (achow101)

14:06 <achow101> Priority is still #26596 which I think is close to being merged, has 3 acks

14:06 <gribble> https://github.com/bitcoin/bitcoin/issues/26596 | wallet: Migrate legacy wallets to descriptor wallets without requiring BDB by achow101 · Pull Request #26596 · bitcoin/bitcoin · GitHub

14:07 <achow101> Otherwise, #28574 #30265 and gui#824 are all also ready for review (in no particular order)

14:07 <gribble> https://github.com/bitcoin/bitcoin/issues/28574 | wallet: optimize migration process, batch db transactions by furszy · Pull Request #28574 · bitcoin/bitcoin · GitHub

14:07 <gribble> https://github.com/bitcoin/bitcoin/issues/30265 | wallet: Fix listwalletdir listing of migrated default wallets and generated backup files by achow101 · Pull Request #30265 · bitcoin/bitcoin · GitHub

14:07 <gribble> https://github.com/bitcoin/bitcoin/issues/824 | Use of read_some in bitcoinrpc.cpp · Issue #824 · bitcoin/bitcoin · GitHub

14:07 <achow101> #topic Ad-hoc high priority for review

14:07 <achow101> Anything to add or remove from https://github.com/orgs/bitcoin/projects/1/views/4

14:08 <hebasto> ^^ https://github.com/bitcoin-core/gui/pull/824

14:09 <achow101> sr_gi[m]1: #30116 needs rebase. typically things that need rebasing are removed from this list

14:09 <gribble> https://github.com/bitcoin/bitcoin/issues/30116 | p2p: Fill reconciliation sets (Erlay) attempt 2 by sr-gi · Pull Request #30116 · bitcoin/bitcoin · GitHub

14:09 <achow101> Or any other topics to discuss this week?

14:10 <Murch[m]> Oh yeah

14:10 <Murch[m]> I sent a mail to the mailing list about a bunch of BIPs that are Proposed or Draft which could perhaps be advanced to final

14:10 <sdaftuar> hi

14:11 <Murch[m]> If you are a BIP author and have a BIP that’s in Draft but has actually been adopted for ages, could you please consider opening a PR to update the status?

14:11 Guest65 has quit [Ping timeout: 250 seconds]

14:12 <Murch[m]> There are also some that should probably be updated to "Withdrawn" or "Deferred" ;)

14:12 <achow101> Murch[m]: yes, thanks for the reminder

14:13 <achow101> any other topics?

14:13 <sdaftuar> sorry i'm late, but if there are any additional cluster mempool questions i'm happy to answer (but i don't have any additional updates on that, sipa's PR is the one to review)

14:14 <sipa> that being #30126

14:14 <gribble> https://github.com/bitcoin/bitcoin/issues/30126 | cluster mempool: cluster linearization algorithm by sipa · Pull Request #30126 · bitcoin/bitcoin · GitHub

14:14 <fjahr> fg

14:14 <fjahr> oops

14:15 <achow101> #endmeeting

14:15 kevkevin has quit [Ping timeout: 264 seconds]

14:17 Guest65 has joined #bitcoin-core-dev

14:17 tinta7946 has joined #bitcoin-core-dev

14:18 jonatack has quit [Ping timeout: 268 seconds]

14:18 jonatack has joined #bitcoin-core-dev

14:24 Guest65 has quit [Quit: Client closed]

14:26 kevkevin has joined #bitcoin-core-dev

14:27 tinta7946 has quit [Quit: Client closed]

14:36 Guyver2 has joined #bitcoin-core-dev

14:37 <bitcoin-git> [bitcoin] maflcko opened pull request #30428: log: LogError with FlatFilePos in UndoReadFromDisk (master...2407-log-err-undo) https://github.com/bitcoin/bitcoin/pull/30428

14:53 preimage has joined #bitcoin-core-dev

15:36 <bitcoin-git> [bitcoin] maflcko opened pull request #30429: rpc: Use CHECK_NONFATAL over Assert (master...2407-rpc-no-assert) https://github.com/bitcoin/bitcoin/pull/30429

15:47 <bitcoin-git> [bitcoin] glozow pushed 7 commits to master: https://github.com/bitcoin/bitcoin/compare/9b480f7a25a7...d9aa7b23e438

15:47 <bitcoin-git> bitcoin/master 517e204 Ava Chow: Change MigrateLegacyToDescriptor to reopen wallet as BERKELEY_RO

15:47 <bitcoin-git> bitcoin/master 7461d0c Ava Chow: wallet: Move LegacySPKM data storage and handling to LegacyDataSPKM

15:47 <bitcoin-git> bitcoin/master b231f4d Ava Chow: wallet: Move LegacyScriptPubKeyMan::IsMine to LegacyDataSPKM

15:47 <bitcoin-git> [bitcoin] glozow merged pull request #26596: wallet: Migrate legacy wallets to descriptor wallets without requiring BDB (master...indep-desc-migrate2) https://github.com/bitcoin/bitcoin/pull/26596

16:36 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/d9aa7b23e438...e5a5497d9815

16:36 <bitcoin-git> bitcoin/master e8c3b71 glozow: remove truc_policy.cpp from libbitcoin_common_a_SOURCES

16:36 <bitcoin-git> bitcoin/master e5a5497 merge-script: Merge bitcoin/bitcoin#30427: remove truc_policy from libbitcoin_common_a_S...

16:36 <bitcoin-git> [bitcoin] fanquake merged pull request #30427: remove truc_policy from libbitcoin_common_a_SOURCES (master...2024-07-truc-common) https://github.com/bitcoin/bitcoin/pull/30427

16:37 Guest44 has quit [Quit: Guest44]

16:44 __DuBPiRaTe__ has joined #bitcoin-core-dev

16:51 <bitcoin-git> [bitcoin] fanquake opened pull request #30433: build: add `standard branch-protection` to hardening flags for aarch64-linux (master...standard_branch_fedora) https://github.com/bitcoin/bitcoin/pull/30433

17:08 Talkless has joined #bitcoin-core-dev

17:23 kevkevin has quit [Remote host closed the connection]

17:26 kevkevin has joined #bitcoin-core-dev

17:37 Guest44 has joined #bitcoin-core-dev

17:37 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e5a5497d9815...e51653985cc8

17:37 <bitcoin-git> bitcoin/master e233ec0 Hodlinator: refactor: Use designated initializer

17:37 <bitcoin-git> bitcoin/master e516539 merge-script: Merge bitcoin/bitcoin#30397: refactor: Use designated initializer in test/...

17:37 <bitcoin-git> [bitcoin] fanquake merged pull request #30397: refactor: Use designated initializer in test/util/net.cpp (master...2024-07_net_designated_initializer) https://github.com/bitcoin/bitcoin/pull/30397

17:45 mudsip has joined #bitcoin-core-dev

17:48 mudsip has quit [Client Quit]

17:51 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e51653985cc8...a231cfe96420

17:51 <bitcoin-git> bitcoin/master fa601ab MarcoFalke: util: Catch translation string errors at compile time

17:51 <bitcoin-git> bitcoin/master a231cfe merge-script: Merge bitcoin/bitcoin#30383: util: Catch translation string errors at comp...

17:51 jonatack has quit [Ping timeout: 246 seconds]

17:51 <bitcoin-git> [bitcoin] fanquake merged pull request #30383: util: Catch translation string errors at compile time (master...2407-trans) https://github.com/bitcoin/bitcoin/pull/30383

17:54 <bitcoin-git> [bitcoincore.org] fanquake pushed 2 commits to master: https://github.com/bitcoin-core/bitcoincore.org/compare/b004e179048f...2d6c136f195e

17:54 <bitcoin-git> bitcoincore.org/master 3cc3c05 Pieter Wuille: Make titles/excerpts of disclosures more uniform

17:54 <bitcoin-git> bitcoincore.org/master 2d6c136 merge-script: Merge bitcoin-core/bitcoincore.org#1047: Make titles/excerpts of disclosur...

17:54 <bitcoin-git> [bitcoincore.org] fanquake merged pull request #1047: Make titles/excerpts of disclosures more uniform (master...202407_uniform_cve) https://github.com/bitcoin-core/bitcoincore.org/pull/1047

17:59 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/a231cfe96420...c2c0b4f00299

17:59 <bitcoin-git> bitcoin/master 34c9cee Cory Fields: clang-tidy: add check for non-trivial thread_local vars

17:59 <bitcoin-git> bitcoin/master c2c0b4f merge-script: Merge bitcoin/bitcoin#30146: Add clang-tidy check for thread_local vars

17:59 <bitcoin-git> [bitcoin] fanquake merged pull request #30146: Add clang-tidy check for thread_local vars (master...clang-tidy-thread_local) https://github.com/bitcoin/bitcoin/pull/30146

18:08 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/c2c0b4f00299...01dc38bd01b0

18:08 <bitcoin-git> bitcoin/master 3333bae MarcoFalke: tidy: modernize-use-equals-default

18:08 <bitcoin-git> bitcoin/master 01dc38b merge-script: Merge bitcoin/bitcoin#30406: refactor: modernize-use-equals-default

18:08 <bitcoin-git> [bitcoin] fanquake merged pull request #30406: refactor: modernize-use-equals-default (master...2407-modernize-use-equals-default) https://github.com/bitcoin/bitcoin/pull/30406

18:11 lbia has quit [Ping timeout: 252 seconds]

18:18 <bitcoin-git> [bitcoin] theuni opened pull request #30434: depends: bump boost to 1.85.0 and use new CMake buildsystem (master...cmake-boost-depends) https://github.com/bitcoin/bitcoin/pull/30434

18:19 flag has quit [Ping timeout: 264 seconds]

18:21 <bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/01dc38bd01b0...00feabf6c59c

18:21 <bitcoin-git> bitcoin/master 32b1d13 Cory Fields: refactor: add self-assign checks to classes which violate the clang-tidy c...

18:21 <bitcoin-git> bitcoin/master 26a7f70 Cory Fields: ci: enable self-assignment clang-tidy check

18:21 <bitcoin-git> bitcoin/master 00feabf merge-script: Merge bitcoin/bitcoin#30234: Enable clang-tidy checks for self-assignment

18:21 <bitcoin-git> [bitcoin] fanquake merged pull request #30234: Enable clang-tidy checks for self-assignment (master...clang-tidy-self-assign) https://github.com/bitcoin/bitcoin/pull/30234

18:26 theStack has quit [Server closed connection]

18:33 jonatack has joined #bitcoin-core-dev

18:43 Guest43 has joined #bitcoin-core-dev

18:44 Guest43 has quit [Client Quit]

18:47 mcey_ has joined #bitcoin-core-dev

18:47 mcey has quit [Remote host closed the connection]

19:00 __DuBPiRaTe__ has quit [Quit: Leaving]

19:03 Guest44 has quit [Quit: Guest44]

19:06 Talkless has quit [Read error: Connection reset by peer]

19:07 lbia has joined #bitcoin-core-dev

19:08 <bitcoin-git> [bitcoin] achow101 pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/00feabf6c59c...33af14e31b9f

19:08 <bitcoin-git> bitcoin/master 00b8e26 furszy: test: fix inconsistency in fundrawtransaction weight limits test

19:08 <bitcoin-git> bitcoin/master 33af14e Ava Chow: Merge bitcoin/bitcoin#30353: test: fix inconsistency in fundrawtransaction...

19:08 <bitcoin-git> [bitcoin] achow101 merged pull request #30353: test: fix inconsistency in fundrawtransaction weight limits test (master...2024_test_fix_max_weight_test) https://github.com/bitcoin/bitcoin/pull/30353

19:24 andrewtoth_ has quit [Ping timeout: 260 seconds]

19:38 andrewtoth_ has joined #bitcoin-core-dev

20:01 jonatack has quit [Ping timeout: 256 seconds]

20:03 jonatack has joined #bitcoin-core-dev

20:14 jonatack has quit [Read error: Connection reset by peer]

20:16 Guyver2 has left #bitcoin-core-dev [Closing Window]

20:48 abubakarsadiq has quit [Quit: Connection closed for inactivity]

20:50 andrewtoth_ has quit [Remote host closed the connection]

20:50 andrewtoth_ has joined #bitcoin-core-dev

20:57 jonatack has joined #bitcoin-core-dev

22:30 kevkevin has quit [Remote host closed the connection]

22:52 kevkevin has joined #bitcoin-core-dev

22:52 theStack has joined #bitcoin-core-dev

22:57 kevkevin has quit [Ping timeout: 268 seconds]

22:57 preimage has quit [Quit: WeeChat 4.3.4]

23:15 kevkevin has joined #bitcoin-core-dev

23:20 kevkevin has quit [Ping timeout: 264 seconds]

23:29 emcy__ has joined #bitcoin-core-dev

23:31 kevkevin has joined #bitcoin-core-dev

23:32 mcey_ has quit [Ping timeout: 264 seconds]

23:39 jonatack has quit [Ping timeout: 272 seconds]

23:44 jonatack has joined #bitcoin-core-dev

23:49 kevkevin has quit [Remote host closed the connection]

23:52 kevkevin has joined #bitcoin-core-dev

23:56 jonatack has quit [Read error: Connection reset by peer]

23:57 jonatack has joined #bitcoin-core-dev