ChanServ changed the topic of #bitcoin-core-dev to: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Weekly Meeting Thursday @ 14:00 UTC | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt
zeropoint has quit [Quit: leaving]
<bitcoin-git> [bitcoin] Vick145 opened pull request #30521: Create Wap (master...patch-1) https://github.com/bitcoin/bitcoin/pull/30521
kevkevin has quit [Remote host closed the connection]
mcey_ has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] pinheadmz closed pull request #30521: Create Wap (master...patch-1) https://github.com/bitcoin/bitcoin/pull/30521
mcey has quit [Ping timeout: 265 seconds]
flag has quit [Ping timeout: 255 seconds]
szkl has joined #bitcoin-core-dev
flag has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 248 seconds]
kevkevin has joined #bitcoin-core-dev
lbia has quit [Quit: lbia]
kevkevin has quit [Remote host closed the connection]
bitdex has joined #bitcoin-core-dev
mudsip has joined #bitcoin-core-dev
mudsip has quit [Client Quit]
cmirror has quit [Remote host closed the connection]
cmirror has joined #bitcoin-core-dev
emcy__ has joined #bitcoin-core-dev
mcey_ has quit [Ping timeout: 252 seconds]
luke-jr_ has joined #bitcoin-core-dev
luke-jr has quit [Ping timeout: 264 seconds]
puchka has joined #bitcoin-core-dev
szkl has quit [Quit: Connection closed for inactivity]
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 252 seconds]
luke-jr has joined #bitcoin-core-dev
luke-jr_ has quit [Ping timeout: 265 seconds]
<bitcoin-git> [bitcoin] paplorinc closed pull request #30442: optimization: Precalculate SipHash constant XOR with k0 and k1 in SaltedOutpointHasher (master...paplorinc/siphash) https://github.com/bitcoin/bitcoin/pull/30442
puchka has quit [Ping timeout: 252 seconds]
puchka has joined #bitcoin-core-dev
Sat0Sh1n0b1 has joined #bitcoin-core-dev
BrandonOdiwuor has joined #bitcoin-core-dev
Guyver2 has joined #bitcoin-core-dev
Guyver2 has left #bitcoin-core-dev [Closing Window]
lbia has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/fa0b5d68823b...1ca1df9353b6
<bitcoin-git> bitcoin/master 6e78616 fanquake: refactor: fix missing includes
<bitcoin-git> bitcoin/master e3edacc fanquake: ci: add _LIBCPP_REMOVE_TRANSITIVE_INCLUDES to TSAN job
<bitcoin-git> bitcoin/master 1ca1df9 merge-script: Merge bitcoin/bitcoin#30519: ci: add `_LIBCPP_REMOVE_TRANSITIVE_INCLUDES` ...
<bitcoin-git> [bitcoin] fanquake merged pull request #30519: ci: add `_LIBCPP_REMOVE_TRANSITIVE_INCLUDES` to TSAN (libc++) job (master...tsan_LIBCPP_REMOVE_TRANSITIVE_INCLUDES) https://github.com/bitcoin/bitcoin/pull/30519
jespada has quit [Quit: Textual IRC Client: www.textualapp.com]
BrandonOdiwuor has quit [Quit: Client closed]
cold has quit [Ping timeout: 245 seconds]
<bitcoin-git> [bitcoin] maflcko opened pull request #30522: ci: Add missing qttools5-dev install to Asan task (master...2407-ci-asan-qt) https://github.com/bitcoin/bitcoin/pull/30522
midnight has quit [Ping timeout: 265 seconds]
cold has joined #bitcoin-core-dev
midnight has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/1ca1df9353b6...f7ab3ba404df
<bitcoin-git> bitcoin/master 41a2545 ismaelsadeeq: [fees]: change `estimatesmartfee` default mode to `economical`
<bitcoin-git> bitcoin/master 25bf86a ismaelsadeeq: [test]: ensure `estimatesmartfee` default mode is `economical`
<bitcoin-git> bitcoin/master f7ab3ba merge-script: Merge bitcoin/bitcoin#30275: Fee Estimation: change `estimatesmartfee` def...
<bitcoin-git> [bitcoin] fanquake merged pull request #30275: Fee Estimation: change `estimatesmartfee` default mode to `economical` (master...06-2024-change-estimatesmartfee-default) https://github.com/bitcoin/bitcoin/pull/30275
<bitcoin-git> [bitcoin] hebasto opened pull request #30523: doc: Rename build notes for MinGW-w64 (master...240725-mingw-doc) https://github.com/bitcoin/bitcoin/pull/30523
Guest19 has joined #bitcoin-core-dev
jespada has joined #bitcoin-core-dev
Guest19 has quit [Ping timeout: 256 seconds]
jespada_ has joined #bitcoin-core-dev
jespada_ has quit [Client Quit]
jespada has quit [Remote host closed the connection]
Guest70 has joined #bitcoin-core-dev
andytoshi has quit [Ping timeout: 245 seconds]
andytoshi has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 264 seconds]
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/f7ab3ba404df...955f173b4b97
<bitcoin-git> bitcoin/master faa3598 MarcoFalke: ci: Add missing qttools5-dev install to Asan task
<bitcoin-git> bitcoin/master 955f173 merge-script: Merge bitcoin/bitcoin#30522: ci: Add missing qttools5-dev install to Asan ...
<bitcoin-git> [bitcoin] fanquake merged pull request #30522: ci: Add missing qttools5-dev install to Asan task (master...2407-ci-asan-qt) https://github.com/bitcoin/bitcoin/pull/30522
bitdex has quit [Remote host closed the connection]
bitdex has joined #bitcoin-core-dev
jespada has joined #bitcoin-core-dev
Guest70 has quit [Quit: Client closed]
jespada has quit [Quit: My Mac has gone to sleep. ZZZzzz…]
<bitcoin-git> [bitcoin] maflcko opened pull request #30524: doc: rpc: Use "output script" consistently (2/2) (master...2407-rpc-doc-output-script) https://github.com/bitcoin/bitcoin/pull/30524
<bitcoin-git> [bitcoin] fanquake pushed 8 commits to master: https://github.com/bitcoin/bitcoin/compare/955f173b4b97...30e8a79aefd4
<bitcoin-git> bitcoin/master fafe4b8 MarcoFalke: test: refactor: Replace SetHex with uint256 constructor directly
<bitcoin-git> bitcoin/master fa103db MarcoFalke: scripted-diff: Rename SetHex to SetHexDeprecated
<bitcoin-git> bitcoin/master fad2991 MarcoFalke: refactor: Implement strict uint256::FromHex()
<bitcoin-git> [bitcoin] fanquake merged pull request #30482: rest: Reject truncated hex txid early in getutxos parsing (master...2407-rest-txid) https://github.com/bitcoin/bitcoin/pull/30482
szkl has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/30e8a79aefd4...bee23ce9ec3d
<bitcoin-git> bitcoin/master 9e2a723 TheCharlatan: test: Add arguments for creating a slimmer setup
<bitcoin-git> bitcoin/master f46b220 TheCharlatan: fuzz: Use BasicTestingSetup for coins_view target
<bitcoin-git> bitcoin/master bee23ce merge-script: Merge bitcoin/bitcoin#30399: test: Add arguments for creating a slimmer Te...
<bitcoin-git> [bitcoin] fanquake merged pull request #30399: test: Add arguments for creating a slimmer TestingSetup (master...noNetChainTest) https://github.com/bitcoin/bitcoin/pull/30399
bitdex has quit [Quit: = ""]
<bitcoin-git> [bitcoin] fanquake pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/bee23ce9ec3d...ab8e05eb531f
<bitcoin-git> bitcoin/master 8b41ede fanquake: guix: consolidate back to GCC 12 toolchain for all HOSTS
<bitcoin-git> bitcoin/master b23690e fanquake: guix: use GCC 12.4.0 over 12.3.0
<bitcoin-git> bitcoin/master d1592d2 fanquake: guix: use gcc-12 to compile winpthreads
<bitcoin-git> [bitcoin] fanquake merged pull request #30511: guix: GCC 12 consolidation (master...winpthreads_gcc_12) https://github.com/bitcoin/bitcoin/pull/30511
<bitcoin-git> [bitcoin] fanquake pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/ab8e05eb531f...119a0faf2c33
<bitcoin-git> bitcoin/master 06d4aab Hennadii Stepanov: depends: Cleanup postprocess commands after switching to CMake
<bitcoin-git> bitcoin/master 745bf0f fanquake: depends: cleanup after miniupnpc build
<bitcoin-git> bitcoin/master a0314c1 fanquake: depends: cleanup after qrencode build
<bitcoin-git> [bitcoin] fanquake merged pull request #30506: depends: Cleanup postprocess commands after switching to CMake (master...240723-postprocess) https://github.com/bitcoin/bitcoin/pull/30506
jespada has joined #bitcoin-core-dev
andrewtoth has joined #bitcoin-core-dev
abubakarsadiq has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] fanquake pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/119a0faf2c33...5d280130446d
<bitcoin-git> bitcoin/master 6f49548 glozow: [refactor] combine block vtx loops in BlockConnected
<bitcoin-git> bitcoin/master 7cc5ac5 glozow: [doc] TxOrphanage is no longer thread-safe
<bitcoin-git> bitcoin/master bce5f37 glozow: [refactor] change ActiveTipChange to use CBlockIndex ref instead of ptr
<bitcoin-git> [bitcoin] fanquake merged pull request #30507: m_tx_download_mutex followups (master...2024-07-30111-followups) https://github.com/bitcoin/bitcoin/pull/30507
kevkevin has joined #bitcoin-core-dev
<instagibbs> sipa wen DepGraph->mermaid diagram formatter
<sipa> instagibbs: i've probably written one half a dozen times already, but never included in PRs...
<cfields> proposed meeting topic: CMake update
<bitcoin-git> [bitcoin] theStack closed pull request #30481: test: add creating/spending validity checks for rare output scripts (master...202407-test-rare_output_scripts) https://github.com/bitcoin/bitcoin/pull/30481
BrandonOdiwuor has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
<sdaftuar> hi
<glozow> hi
<b10c> hi
<abubakarsadiq> hi
<glozow> #startmeeting
<pinheadmz> yo
<stickies-v> hi
<hebasto> hi
<glozow> #bitcoin-core-dev Meeting: achow101 _aj_ amiti ariard aureleoules b10c BlueMatt brunoerg cfields darosior dergoegge dongcarl fanquake fjahr furszy gleb glozow hebasto instagibbs jamesob jarolrod jonatack josibake kallewoof kanzure kouloumos kvaciral laanwj LarryRuane lightlike luke-jr MacroFake Murch phantomcircuit pinheadmz promag provoostenator ryanofsky sdaftuar S3RK stickies-v sipa sr_gi theStack TheCharlatan vasild
aleggg has quit [Remote host closed the connection]
<brunoerg> hi
<sr_gi[m]1> Hi
<furszy> hi
<glozow> I see 1 topic from cfields, am I missing any / any last minute ones to add?
<dergoegge> hi
<cfields> hi
<willcl-ark> hi
<glozow> #topic package relay updates
<jon_atack> hi
<glozow> #30111 and its followup were merged (yay), so #30110 is the new priority PR. I just rebased it. Lmk if I can help with review - dimmed zebra will be your friend.
<gribble> https://github.com/bitcoin/bitcoin/issues/30111 | locks: introduce mutex for tx download, flush rejection filters once per tip change by glozow · Pull Request #30111 · bitcoin/bitcoin · GitHub
<gribble> https://github.com/bitcoin/bitcoin/issues/30110 | refactor: TxDownloadManager by glozow · Pull Request #30110 · bitcoin/bitcoin · GitHub
<lightlike> Hi
<sipa> hi
<kevkevin> hi
<glozow> #topic cluster mempool updates (sdaftuar)
<ajonas> hi
<sdaftuar> PR #30126 is nearly ready, I think -- been collecting acks.
<gribble> https://github.com/bitcoin/bitcoin/issues/30126 | cluster mempool: cluster linearization algorithm by sipa · Pull Request #30126 · bitcoin/bitcoin · GitHub
<sdaftuar> sipa - anything to add?
<sipa> I don't think so, most progress is on that PR.
<sdaftuar> i have some things to fix in my PR (i saw your comments instagibbs), which I'll try to get to today or tomorrow
<sdaftuar> nothing else from me...
<glozow> #topic legacy wallet removal updates (achow101)
<glozow> is achow101 here today?
<glozow> Looks like #30328 is still the PR to review
<gribble> https://github.com/bitcoin/bitcoin/issues/30328 | wallet: Remove IsMine from migration code by achow101 · Pull Request #30328 · bitcoin/bitcoin · GitHub
<glozow> #topic CMake update (cfields)
<cfields> Just a quick note and beg for everyone to give #30454 a shot. At this point the CMake branch has undergone a full (years-long) round of review and we believe it's ready for devs to try out. It should have feature parity with the old buildsystem. That branch currently has autotools as well, so it should be possible to build either way and compare. If there are any questions about how to build (how do I do X in CMake compared to autotools), please
<cfields> check the docs. If your question isn't answered, please ask on the PR for the sake of everyone else.
<gribble> https://github.com/bitcoin/bitcoin/issues/30454 | build: Introduce CMake-based build system by hebasto · Pull Request #30454 · bitcoin/bitcoin · GitHub
<cfields> A reminder that if all goes well, the plan is to merge CMake soon after branch-off, at which point autotools will be deleted.
<cfields> Just because it's been reviewed like crazy doesn't mean it won't still be bumpy. We still assume there are plenty of rough edges.
<cfields> Also, there'a a project setup now at github to help track dependencies: https://github.com/orgs/bitcoin/projects/13/views/4
<glozow> nice!
<sipa> great to hear, i'll try to play around with it
<cfields> thanks!
<glozow> #topic Ad-hoc high priority for review
<hebasto> thank you
<glozow> Anything to add or remove from https://github.com/orgs/bitcoin/projects/1/views/4 ?
kashifs has joined #bitcoin-core-dev
<b10c> can I get #25832?
<gribble> https://github.com/bitcoin/bitcoin/issues/25832 | tracing: network connection tracepoints by 0xB10C · Pull Request #25832 · bitcoin/bitcoin · GitHub
puchka has quit [Ping timeout: 244 seconds]
<glozow> b10c: added
<lightlike> could #29519 be added? (assumeutxo p2p fix)
<gribble> https://github.com/bitcoin/bitcoin/issues/29519 | p2p: For assumeutxo, download snapshot chain before background chain by mzumsande · Pull Request #29519 · bitcoin/bitcoin · GitHub
<glozow> lightlike: added
<glozow> I think we are 2-3 weeks from feature freeze
<glozow> Anything else to discuss?
<glozow> #endmeeting
<b10c> glozow: ty!
mcey_ has joined #bitcoin-core-dev
emcy__ has quit [Ping timeout: 265 seconds]
puchka has joined #bitcoin-core-dev
brunoerg has quit [Remote host closed the connection]
<bitcoin-git> [bitcoin] ismaelsadeeq opened pull request #30525: doc, rpc : `#30275` followups (master...07-2024-estimatesmartfee-doc-update) https://github.com/bitcoin/bitcoin/pull/30525
brunoerg has joined #bitcoin-core-dev
puchka has quit [Ping timeout: 245 seconds]
brunoerg has quit [Remote host closed the connection]
preimage has joined #bitcoin-core-dev
aleggg has joined #bitcoin-core-dev
BrandonOdiwuor has quit [Quit: Client closed]
puchka has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] hebasto closed pull request #30523: doc: Rename build notes for MinGW-w64 (master...240725-mingw-doc) https://github.com/bitcoin/bitcoin/pull/30523
kashifs has quit [Quit: Client closed]
zeropoint has joined #bitcoin-core-dev
vasild has quit [Ping timeout: 260 seconds]
bugs_ has joined #bitcoin-core-dev
vasild has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
Talkless has joined #bitcoin-core-dev
bitdex has joined #bitcoin-core-dev
<bitcoin-git> [qa-assets] dergoegge merged pull request #193: New inputs from muttfuzz (main...main) https://github.com/bitcoin-core/qa-assets/pull/193
<bitcoin-git> [qa-assets] dergoegge pushed 2 commits to main: https://github.com/bitcoin-core/qa-assets/compare/60d69a6b6376...87b05f92c39b
<bitcoin-git> qa-assets/main 392d6be Alex Groce: new inputs from muttfuzz
<bitcoin-git> qa-assets/main 87b05f9 Niklas Gögge: Merge pull request #193 from agroce/main
brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
jon_atack has quit [Ping timeout: 252 seconds]
jonatack has joined #bitcoin-core-dev
brunoerg has quit [Remote host closed the connection]
puchka has quit [*.net *.split]
angusp has quit [*.net *.split]
javi404 has quit [*.net *.split]
dermoth has quit [*.net *.split]
TheRec has quit [*.net *.split]
brunoerg_ has joined #bitcoin-core-dev
angusp has joined #bitcoin-core-dev
puchka has joined #bitcoin-core-dev
javi404 has joined #bitcoin-core-dev
dermoth has joined #bitcoin-core-dev
TheRec has joined #bitcoin-core-dev
brunoerg_ has quit [Ping timeout: 339 seconds]
brunoerg has joined #bitcoin-core-dev
<pinheadmz> instagibbs re: PayToAnchor only makes sense for TRUC right? presumably so the *other* party doesnt replace you CPFP with a pinning attack?
jonatack has quit [Read error: Connection reset by peer]
Talkless has quit [Remote host closed the connection]
<bitcoin-git> [bitcoin] hodlinator opened pull request #30526: doc: Correct uint256 hex string endianness (master...2024-07_PR30436_follow_up) https://github.com/bitcoin/bitcoin/pull/30526
andrewtoth has quit [Ping timeout: 260 seconds]
andrewtoth has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] maflcko opened pull request #30527: Bump python minimum supported version to 3.10 (master...2407-py) https://github.com/bitcoin/bitcoin/pull/30527
andrewtoth has quit [Remote host closed the connection]
andrewtoth has joined #bitcoin-core-dev
jonatack has joined #bitcoin-core-dev
jonatack has quit [Read error: Connection reset by peer]
zeropoint has quit [Quit: leaving]
<instagibbs> pinheadmz depends on what your threat model is, but for time-sensitive contracts probably yeah
<instagibbs> generally speaking today you won't be able to propagate more than 1P1C anyways, and truc fits in that paradigm nicely
luke-jr has quit [Read error: Connection reset by peer]
luke-jr has joined #bitcoin-core-dev
luke-jr has quit [Ping timeout: 276 seconds]
mudsip has joined #bitcoin-core-dev
<pinheadmz> why couldnt you propogate more than 1 child? without v3?
mudsip has quit []
preimage has quit [Quit: WeeChat 4.3.5]
<instagibbs> you can if each individual transaction meets dynamic mempool minfee, propagating them one by one over p2p, but typically if you want to use an anchor-like thing, the parent tx will be static/0-fee and you'll need 1P1C relay for that
brunoerg has quit [Remote host closed the connection]
kevkevin has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 248 seconds]
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 260 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
Guest87 has joined #bitcoin-core-dev
Guest66 has joined #bitcoin-core-dev
brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
jonatack has joined #bitcoin-core-dev
Guest66 has quit [Quit: Client closed]
Guest87 has quit [Quit: Client closed]
kevkevin has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 265 seconds]
BrandonOdiwuor has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 264 seconds]
brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Remote host closed the connection]
Guest61 has joined #bitcoin-core-dev
Guest61 has quit [Client Quit]
brunoerg has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 260 seconds]
andrewtoth has quit [Ping timeout: 260 seconds]
bugs_ has quit [Quit: Leaving]
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 248 seconds]
conman has quit [Remote host closed the connection]
jonatack has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
mekster66949398 has quit [Quit: Ping timeout (120 seconds)]
mekster66949398 has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 255 seconds]
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 276 seconds]
brunoerg has quit [Remote host closed the connection]
kevkevin has joined #bitcoin-core-dev
abubakarsadiq has quit [Quit: Connection closed for inactivity]
luke-jr has joined #bitcoin-core-dev