<bitcoin-git>
bitcoin/master a38c960 Cory Fields: contrib: use c++ rather than c for binary tests
<bitcoin-git>
bitcoin/master 261f770 Cory Fields: contrib: rename cc to cxx in binary checking scripts
<bitcoin-git>
bitcoin/master 9010b13 Cory Fields: contrib: c++ify test stubs after switching to c++ compilers
<bitcoin-git>
[bitcoin] fanquake merged pull request #30387: contrib: use c++ compiler rather than c compiler for binary checks (master...cxx-security-check) https://github.com/bitcoin/bitcoin/pull/30387
<_aj_>
glozow: LOCK(m_mutex) doesn't check, it (generally) just deadlocks if it's already held, afaik. (unless you've got DEBUG_LOCKORDER enabled)
puchka has joined #bitcoin-core-dev
<glozow>
_aj_: ah thanks! I should add an explicit `AssertLockNotHeld` then
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 248 seconds]
face has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
<_aj_>
glozow: yeah. i think for mutexes that are private to a class, the MaybeCheckNotHeld stuff will give you compile-time errors if you do a double-lock or don't have sufficient EXCLUSIVE_LOCKS_REQUIRED(!m_mutex) annotations to guarantee no double locks, but better to be extra safe
kevkevin has quit [Ping timeout: 272 seconds]
stratospher[m] has joined #bitcoin-core-dev
<vasild>
I am working on a unit test that is failing in a weird way: just prints *** 1 failure is detected in the test module "Bitcoin Core Test Suite" and exists without printing any failures prior that. I lost some significant amount of time only to figure out that a BOOST_REQUIRE(n > 0) fails without printing anything (!), changing that to assert(n > 0) prints the expected Assertion failed: (n > 0),
<vasild>
...
<vasild>
printouts with std::cout << ... present just before BOOST_REQUIRE(n > 0) were also swallowed/missing. BOOST_TEST_MESSAGE("...") is also executed but missing, in spite std::cout.setf(std::ios::unitbuf); setbuffer(stdout, NULL, 0);
<vasild>
but std::cerr << ... is printed / works
<vasild>
oh, this is my fault, I have accidentally closed stdout
kevkevin has joined #bitcoin-core-dev
SpellChecker has quit [Quit: bye]
SpellChecker has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 248 seconds]
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 272 seconds]
kevkevin has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] fanquake opened pull request #30452: guix: bump time-machine to 3c58b759a51072aabd7eaaca680674a0c2b36c23 (master...guix_mingw64_12_0_1) https://github.com/bitcoin/bitcoin/pull/30452
<bitcoin-git>
[bitcoin] achow101 merged pull request #22729: Make it possible to disable Tor binds and abort startup on bind failure (master...torbind) https://github.com/bitcoin/bitcoin/pull/22729
<bitcoin-git>
bitcoin/master 7e36dca willcl-ark: test: add test for modififed walletprocesspsbt calls
<bitcoin-git>
bitcoin/master 6f9db1e Ava Chow: Merge bitcoin/bitcoin#30357: Fix cases of calls to `FillPSBT` errantly ret...
<bitcoin-git>
[bitcoin] achow101 merged pull request #30357: Fix cases of calls to `FillPSBT` errantly returning `complete=true` (master...walletprocesspsbt-no-finalize) https://github.com/bitcoin/bitcoin/pull/30357
bugs_ has quit [Quit: Leaving]
nanotube has quit [Quit: *poof*]
preimage has quit [Quit: WeeChat 4.3.4]
TracaChang has quit [Quit: Leaving]
TracaChang has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] hebasto opened pull request #30464: test, refactor: Fix MSVC warning C4101 "unreferenced local variable" (master...240716-univalue) https://github.com/bitcoin/bitcoin/pull/30464
nanotube has joined #bitcoin-core-dev
kevkevin has quit [Remote host closed the connection]
<bitcoin-git>
[bitcoin] hebasto opened pull request #30465: depends: Set `CMAKE_SYSTEM_VERSION` for CMake builds (master...240716-deps-cmake) https://github.com/bitcoin/bitcoin/pull/30465
kevkevin has joined #bitcoin-core-dev
b10c has quit [Server closed connection]
b10c has joined #bitcoin-core-dev
kevkevin has quit [Remote host closed the connection]